190720 2018-10-18 09:39:56 -0700 [LFC][IFC] RenderReplaced renderer should create InlineBox 2018-10-19 10:29:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1470559 0 zalan 2018-10-18 09:39:56 -0700 ssia 1470562 1 352700 zalan 2018-10-18 09:41:44 -0700 Created attachment 352700 Patch 1470865 2 352700 koivisto 2018-10-19 08:47:36 -0700 Comment on attachment 352700 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352700&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:91 > + box = new InlineBox( { }, RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline)); Using new is lame. Can we use unique_ptrs and make_unique for safe memory management here? 1470896 3 zalan 2018-10-19 10:00:30 -0700 (In reply to Antti Koivisto from comment #2) > Comment on attachment 352700 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352700&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:91 > > + box = new InlineBox( { }, RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline)); > > Using new is lame. Can we use unique_ptrs and make_unique for safe memory > management here? Absolutely! 1470912 4 zalan 2018-10-19 10:28:19 -0700 Committed r237293: <https://trac.webkit.org/changeset/237293> 1470913 5 webkit-bug-importer 2018-10-19 10:29:26 -0700 <rdar://problem/45409011> 352700 2018-10-18 09:41:44 -0700 2018-10-19 08:47:36 -0700 Patch Patch.txt text/plain 2866 zalan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlYWIyNzMwMmYzNi4uN2U4YTU4OTk4NDQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMC0xOCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgor CisgICAgICAgIFtMRkNdW0lGQ10gUmVuZGVyUmVwbGFjZWQgcmVuZGVyZXIgc2hvdWxkIGNyZWF0 ZSBJbmxpbmVCb3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MDcyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogbGF5b3V0L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpUcmVlQnVpbGRlcjo6Y3JlYXRlU3ViVHJlZSk6CisKIDIwMTgtMTAt MTggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNd IEltcGxlbWVudCBSZXBsYWNlZCBoZWxwZXIgY2xhc3MuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvbGF5b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKaW5kZXggNTg1YTdj NmZhNmUuLjMwNDc0ZTdhZTdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvbGF5 b3V0dHJlZS9MYXlvdXRUcmVlQnVpbGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2xheW91dHRyZWUvTGF5b3V0VHJlZUJ1aWxkZXIuY3BwCkBAIC04Nyw3ICs4NywxMyBAQCB2b2lk IFRyZWVCdWlsZGVyOjpjcmVhdGVTdWJUcmVlKGNvbnN0IFJlbmRlckVsZW1lbnQmIHJvb3RSZW5k ZXJlciwgQ29udGFpbmVyJiBybwogICAgIGZvciAoYXV0byYgY2hpbGQgOiBjaGlsZHJlbk9mVHlw ZTxSZW5kZXJPYmplY3Q+KHJvb3RSZW5kZXJlcikpIHsKICAgICAgICAgQm94KiBib3ggPSBudWxs cHRyOwogCi0gICAgICAgIGlmIChpczxSZW5kZXJFbGVtZW50PihjaGlsZCkpIHsKKyAgICAgICAg aWYgKGlzPFJlbmRlclRleHQ+KGNoaWxkKSkgeworICAgICAgICAgICAgYm94ID0gbmV3IElubGlu ZUJveCggeyB9LCBSZW5kZXJTdHlsZTo6Y3JlYXRlQW5vbnltb3VzU3R5bGVXaXRoRGlzcGxheShy b290UmVuZGVyZXIuc3R5bGUoKSwgRGlzcGxheVR5cGU6OklubGluZSkpOworICAgICAgICAgICAg ZG93bmNhc3Q8SW5saW5lQm94PigqYm94KS5zZXRUZXh0Q29udGVudChkb3duY2FzdDxSZW5kZXJU ZXh0PihjaGlsZCkub3JpZ2luYWxUZXh0KCkpOworICAgICAgICB9IGVsc2UgaWYgKGlzPFJlbmRl clJlcGxhY2VkPihjaGlsZCkpIHsKKyAgICAgICAgICAgIGF1dG8mIHJlbmRlcmVyID0gZG93bmNh c3Q8UmVuZGVyUmVwbGFjZWQ+KGNoaWxkKTsKKyAgICAgICAgICAgIGJveCA9IG5ldyBJbmxpbmVC b3goZWxlbWVudEF0dHJpYnV0ZXMocmVuZGVyZXIpLCBSZW5kZXJTdHlsZTo6Y2xvbmUocmVuZGVy ZXIuc3R5bGUoKSkpOworICAgICAgICB9IGVsc2UgaWYgKGlzPFJlbmRlckVsZW1lbnQ+KGNoaWxk KSkgewogICAgICAgICAgICAgYXV0byYgcmVuZGVyZXIgPSBkb3duY2FzdDxSZW5kZXJFbGVtZW50 PihjaGlsZCk7CiAgICAgICAgICAgICBhdXRvIGRpc3BsYXkgPSByZW5kZXJlci5zdHlsZSgpLmRp c3BsYXkoKTsKICAgICAgICAgICAgIGlmIChkaXNwbGF5ID09IERpc3BsYXlUeXBlOjpCbG9jaykK QEAgLTk4LDEwICsxMDQsNiBAQCB2b2lkIFRyZWVCdWlsZGVyOjpjcmVhdGVTdWJUcmVlKGNvbnN0 IFJlbmRlckVsZW1lbnQmIHJvb3RSZW5kZXJlciwgQ29udGFpbmVyJiBybwogICAgICAgICAgICAg ICAgIEFTU0VSVF9OT1RfSU1QTEVNRU5URURfWUVUKCk7CiAgICAgICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgICAgICB9Ci0KLSAgICAgICAgfSBlbHNlIGlmIChpczxSZW5kZXJUZXh0Pihj aGlsZCkpIHsKLSAgICAgICAgICAgIGJveCA9IG5ldyBJbmxpbmVCb3goIHsgfSwgUmVuZGVyU3R5 bGU6OmNyZWF0ZUFub255bW91c1N0eWxlV2l0aERpc3BsYXkocm9vdFJlbmRlcmVyLnN0eWxlKCks IERpc3BsYXlUeXBlOjpJbmxpbmUpKTsKLSAgICAgICAgICAgIGRvd25jYXN0PElubGluZUJveD4o KmJveCkuc2V0VGV4dENvbnRlbnQoZG93bmNhc3Q8UmVuZGVyVGV4dD4oY2hpbGQpLm9yaWdpbmFs VGV4dCgpKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIEFTU0VSVF9OT1RfSU1QTEVN RU5URURfWUVUKCk7CiAgICAgICAgICAgICBjb250aW51ZTsKQEAgLTEyNSw3ICsxMjcsNyBAQCB2 b2lkIFRyZWVCdWlsZGVyOjpjcmVhdGVTdWJUcmVlKGNvbnN0IFJlbmRlckVsZW1lbnQmIHJvb3RS ZW5kZXJlciwgQ29udGFpbmVyJiBybwogICAgICAgICAgICAgYXV0byYgY29udGFpbmluZ0Jsb2Nr Rm9ybWF0dGluZ0NvbnRleHRSb290ID0gYm94LT5jb250YWluaW5nQmxvY2soKS0+Zm9ybWF0dGlu Z0NvbnRleHRSb290KCk7CiAgICAgICAgICAgICBjb25zdF9jYXN0PENvbnRhaW5lciY+KGNvbnRh aW5pbmdCbG9ja0Zvcm1hdHRpbmdDb250ZXh0Um9vdCkuYWRkT3V0T2ZGbG93RGVzY2VuZGFudCgq Ym94KTsKICAgICAgICAgfQotICAgICAgICBpZiAoaXM8UmVuZGVyRWxlbWVudD4oY2hpbGQpKQor ICAgICAgICBpZiAoaXM8Q29udGFpbmVyPigqYm94KSkKICAgICAgICAgICAgIGNyZWF0ZVN1YlRy ZWUoZG93bmNhc3Q8UmVuZGVyRWxlbWVudD4oY2hpbGQpLCBkb3duY2FzdDxDb250YWluZXI+KCpi b3gpKTsKICAgICB9CiB9Cg==