190712 2018-10-18 08:13:11 -0700 [GTK] fast/css/pseudo-visited-background-color-on-input.html is failing since r237425 - Enable the datalist element by default on iOS and macOS 2018-10-27 18:52:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez wenson_hsieh bugs-noreply commit-queue mcatanzaro pxlcoder thorton wenson_hsieh oldest_to_newest 1470530 0 magomez 2018-10-18 08:13:11 -0700 fast/css/pseudo-visited-background-color-on-input.html [ ImageOnlyFailure ] the images can be seen here: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r237249%20(8526)/fast/css/pseudo-visited-background-color-on-input-diffs.html The diff is just 4 red pixels in the corners of a rounded rectangle that definitely should not be there. 1470569 1 352704 wenson_hsieh 2018-10-18 09:54:20 -0700 Created attachment 352704 Patch 1470632 2 352704 commit-queue 2018-10-18 13:02:56 -0700 Comment on attachment 352704 Patch Clearing flags on attachment: 352704 Committed r237262: <https://trac.webkit.org/changeset/237262> 1470633 3 commit-queue 2018-10-18 13:02:58 -0700 All reviewed patches have been landed. Closing bug. 1472787 4 mcatanzaro 2018-10-27 18:52:16 -0700 Thanks Wenson! I've just removed the failure expectation. 352704 2018-10-18 09:54:20 -0700 2018-10-18 13:02:56 -0700 Patch bug-190712-20181018095419.patch text/plain 6049 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNhNzgyYWRhN2RiNzUw YWNhMThkNGJhNzViYjY1NGQyYWE2ZTI3Ni4uNjljMjdhMjM5NDM3ZjBhZTJhYTcxYWExZDBhNzVk YTNkZmRjYjI0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE4LTEwLTE4ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdIGZhc3Qv Y3NzL3BzZXVkby12aXNpdGVkLWJhY2tncm91bmQtY29sb3Itb24taW5wdXQuaHRtbCBpcyBmYWls aW5nIHNpbmNlIHIyMzc0MjUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MDcxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEVuc3VyZSB0aGF0IGNvbG9yIGlucHV0cyBhcmUgZW5hYmxlZCBieSBkZWZhdWx0 IG9uIEdUSywgYW5kIHRoYXQgY29sb3IgaW5wdXRzIGhhdmUgYSBgLXdlYmtpdC1hcHBlYXJhbmNl YCBvZgorICAgICAgICBgY29sb3Itd2VsbGAgYnkgZGVmYXVsdC4gRml4ZXMgZmFzdC9jc3MvcHNl dWRvLXZpc2l0ZWQtYmFja2dyb3VuZC1jb2xvci1vbi1pbnB1dC5odG1sIG9uIEdUSy4KKworICAg ICAgICAqIHBhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpSdW50aW1lRW5hYmxlZEZlYXR1cmVzKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGhlbWU6OmNvbG9ySW5wdXRTdHlsZVNoZWV0IGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGhlbWUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lOjpwbGF0Zm9ybVVz ZXNDb2xvcldlbGxBcHBlYXJhbmNlIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRo ZW1lOjpwbGF0Zm9ybUNvbG9ySW5wdXRTdHlsZVNoZWV0IGNvbnN0KTogRGVsZXRlZC4KKworICAg ICAgICBSZXBsYWNlIHRoaXMgd2l0aCBhIHBsYXRmb3JtIGhvb2sgdGhhdCBkZXRlcm1pbmVzIHdo ZXRoZXIgd2Ugd2FudCB0byB1c2UgYC13ZWJraXQtYXBwZWFyYW5jZTogY29sb3Itd2VsbDtgIGJ5 CisgICAgICAgIGRlZmF1bHQgZm9yIGlucHV0cyBvZiB0eXBlIGNvbG9yLiBGb3Igbm93LCBvbmx5 IGlPUyBvdmVycmlkZXMgdGhpcyB0byByZXR1cm4gZmFsc2U7IGluIHRoZSBmdXR1cmUsIHdlIHNo b3VsZAorICAgICAgICBzdXBwb3J0IGAtd2Via2l0LWFwcGVhcmFuY2U6IGNvbG9yLXdlbGw7YCBv biBpT1MsIGFuZCByZW1vdmUgdGhpcyBwbGF0Zm9ybSBob29rIGVudGlyZWx5LgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRoZW1lSU9TLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRoZW1lTWFjLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVNYWM6OnBsYXRmb3JtQ29sb3JJbnB1dFN0eWxlU2hl ZXQgY29uc3QpOiBEZWxldGVkLgorCiAyMDE4LTEwLTE4ICBBbGkgSnVtYSAgPGFqdW1hQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbSW50ZXJzZWN0aW9uT2JzZXJ2ZXJdIEZhY3RvciBvdXQgcmVj dCBtYXBwaW5nIGFuZCBjbGlwcGluZyBsb2dpYyBmcm9tIGNvbXB1dGVSZWN0Rm9yUmVwYWludApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAKaW5kZXgg NGJlNDM2YzNhMzgwMjVlNDA1MzViYTdjMDE4ODMxYWQ3NWQ0NzlkYS4uMTU5YTkyYWViZGVhMTEz MTNlNmFiZjhhMDNmNjBlOTNjMTQwYWYyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1J1 bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCkBAIC00Niw2ICs0Niw5IEBAIFJ1bnRpbWVFbmFibGVk RmVhdHVyZXM6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXMoKQogI2lmIFBMQVRGT1JNKFdBVENIT1Mp CiAgICAgbV9pc1dlYlNvY2tldEVuYWJsZWQgPSBmYWxzZTsKICNlbmRpZgorI2lmIFBMQVRGT1JN KEdUSykgJiYgRU5BQkxFKElOUFVUX1RZUEVfQ09MT1IpCisgICAgbV9pc0lucHV0VHlwZUNvbG9y RW5hYmxlZCA9IHRydWU7CisjZW5kaWYKIH0KIAogUnVudGltZUVuYWJsZWRGZWF0dXJlcyYgUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJUaGVtZS5jcHAKaW5kZXggNzcwN2IzNDNjNzgxNmI5OTMyMTMyNGExZTVmNGYx YWIxNDVmMmE0ZS4uMjZkOWRhYjFkMzc4NDk3ODZhNGM4ZDNhZjZmYzdiYTMzMTFkMDlhZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwCkBAIC0xMDM5LDcgKzEwMzks MTAgQEAgYm9vbCBSZW5kZXJUaGVtZTo6cGFpbnRBdHRhY2htZW50KGNvbnN0IFJlbmRlck9iamVj dCYsIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEkKIFN0cmluZyBSZW5kZXJUaGVtZTo6Y29sb3JJ bnB1dFN0eWxlU2hlZXQoKSBjb25zdAogewogICAgIEFTU0VSVChSdW50aW1lRW5hYmxlZEZlYXR1 cmVzOjpzaGFyZWRGZWF0dXJlcygpLmlucHV0VHlwZUNvbG9yRW5hYmxlZCgpKTsKLSAgICByZXR1 cm4gbWFrZVN0cmluZyhwbGF0Zm9ybUNvbG9ySW5wdXRTdHlsZVNoZWV0KCksICIgaW5wdXRbdHlw ZT1cImNvbG9yXCJdIHsgd2lkdGg6IDQ0cHg7IGhlaWdodDogMjNweDsgb3V0bGluZTogbm9uZTsg fSJfcyk7CisgICAgYXV0byBjb2xvcldlbGxBcHBlYXJhbmNlU3R5bGUgPSBlbXB0eVN0cmluZygp OworICAgIGlmIChwbGF0Zm9ybVVzZXNDb2xvcldlbGxBcHBlYXJhbmNlKCkpCisgICAgICAgIGNv bG9yV2VsbEFwcGVhcmFuY2VTdHlsZSA9ICItd2Via2l0LWFwcGVhcmFuY2U6IGNvbG9yLXdlbGw7 ICJfczsKKyAgICByZXR1cm4gbWFrZVN0cmluZygiaW5wdXRbdHlwZT1cImNvbG9yXCJdIHsgIl9z LCBXVEZNb3ZlKGNvbG9yV2VsbEFwcGVhcmFuY2VTdHlsZSksICJ3aWR0aDogNDRweDsgaGVpZ2h0 OiAyM3B4OyBvdXRsaW5lOiBub25lOyB9Il9zKTsKIH0KIAogI2VuZGlmIC8vIEVOQUJMRShJTlBV VF9UWVBFX0NPTE9SKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaAppbmRleCA4 NmZkMjExYjBmY2FhNzJmYTZlZmQwOTI2Zjg0OTc5M2ZlMDgxZjA3Li42ZDUyNDk4MDk0YzgxM2Jl OTZmMGZjYmM5YTY3NDhkNzA4ZDdjMmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGhlbWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGhlbWUuaApAQCAtMzUwLDcgKzM1MCw3IEBAIHByb3RlY3RlZDoKICNlbmRpZgogCiAjaWYgRU5B QkxFKElOUFVUX1RZUEVfQ09MT1IpCi0gICAgdmlydHVhbCBTdHJpbmcgcGxhdGZvcm1Db2xvcklu cHV0U3R5bGVTaGVldCgpIGNvbnN0IHsgcmV0dXJuIHsgfTsgfQorICAgIHZpcnR1YWwgYm9vbCBw bGF0Zm9ybVVzZXNDb2xvcldlbGxBcHBlYXJhbmNlKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQog I2VuZGlmCiAKICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0UHJvZ3Jlc3NCYXJTdHlsZShTdHlsZVJl c29sdmVyJiwgUmVuZGVyU3R5bGUmLCBjb25zdCBFbGVtZW50KikgY29uc3Q7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVJT1MuaCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oCmluZGV4IDBkODg2YmIzYWU2M2NlNTI2ZTgx ZjE2ZWY4NWNmNjlmNDY2YjBkODkuLmNlMzg3OTkzOWM2OTk2YzY5MDUwYjVkZGM1MTE1NjYzOTA4 ODM0MjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlP Uy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUlPUy5oCkBAIC0x NDUsNiArMTQ1LDE0IEBAIHByaXZhdGU6CiAgICAgU3RyaW5nIGV4dHJhRGVmYXVsdFN0eWxlU2hl ZXQoKSBmaW5hbDsKICNlbmRpZgogCisjaWYgRU5BQkxFKElOUFVUX1RZUEVfQ09MT1IpCisgICAg Ym9vbCBwbGF0Zm9ybVVzZXNDb2xvcldlbGxBcHBlYXJhbmNlKCkgY29uc3QgZmluYWwKKyAgICB7 CisgICAgICAgIC8vIEZJWE1FOiBTdXBwb3J0IC13ZWJraXQtYXBwZWFyYW5jZTogY29sb3Itd2Vs bDsgZm9yIGRyYXdpbmcgY29sb3IgaW5wdXRzIG9uIGlPUy4KKyAgICAgICAgcmV0dXJuIGZhbHNl OworICAgIH0KKyNlbmRpZgorCiAgICAgY29uc3QgQ29sb3ImIHNoYWRvd0NvbG9yKCkgY29uc3Q7 CiAgICAgRmxvYXRSZWN0IGFkZFJvdW5kZWRCb3JkZXJDbGlwKGNvbnN0IFJlbmRlck9iamVjdCYg Ym94LCBHcmFwaGljc0NvbnRleHQmLCBjb25zdCBJbnRSZWN0Jik7CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKaW5kZXggY2IyY2M5OWJhYTRhNTRkODllNmExN2Mw NTU5ODc1MTgyMTlkOWYxNi4uZGY0ZDk1MWM1YTU3NWVlNDkxZjBlNmI5Nzc2MjQ0YzdlODRjOTk3 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFjLmgKQEAgLTExOSwx MCArMTE5LDYgQEAgcHJpdmF0ZToKICAgICBTdHJpbmcgaW1hZ2VDb250cm9sc1N0eWxlU2hlZXQo KSBjb25zdCBmaW5hbDsKICNlbmRpZgogCi0jaWYgRU5BQkxFKElOUFVUX1RZUEVfQ09MT1IpCi0g ICAgU3RyaW5nIHBsYXRmb3JtQ29sb3JJbnB1dFN0eWxlU2hlZXQoKSBjb25zdCBmaW5hbDsKLSNl bmRpZgotCiAgICAgYm9vbCBwYWludFRleHRGaWVsZChjb25zdCBSZW5kZXJPYmplY3QmLCBjb25z dCBQYWludEluZm8mLCBjb25zdCBGbG9hdFJlY3QmKSBmaW5hbDsKICAgICB2b2lkIGFkanVzdFRl eHRGaWVsZFN0eWxlKFN0eWxlUmVzb2x2ZXImLCBSZW5kZXJTdHlsZSYsIGNvbnN0IEVsZW1lbnQq KSBjb25zdCBmaW5hbDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lTWFj Lm1tCmluZGV4IDhkMzg4NmM4YTZiNTdiYjUxODE2YTNmMjAzZDY3NGU3YjMzYTFkNTIuLjZiOGRi Y2RiMTJlODU2NjcwOWQ5NzlmMDdhNjZhYzE2MDcwYzZlYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGhlbWVNYWMubW0KQEAgLTM0MCwxMSArMzQwLDYgQEAgdm9pZCBSZW5k ZXJUaGVtZU1hYzo6cHVyZ2VDYWNoZXMoKQogICAgIFJlbmRlclRoZW1lOjpwdXJnZUNhY2hlcygp OwogfQogCi1TdHJpbmcgUmVuZGVyVGhlbWVNYWM6OnBsYXRmb3JtQ29sb3JJbnB1dFN0eWxlU2hl ZXQoKSBjb25zdAotewotICAgIHJldHVybiAiaW5wdXRbdHlwZT1cImNvbG9yXCJdIHsgLXdlYmtp dC1hcHBlYXJhbmNlOiBjb2xvci13ZWxsOyB9Il9zOwotfQotCiBTdHJpbmcgUmVuZGVyVGhlbWVN YWM6Om1lZGlhQ29udHJvbHNTY3JpcHQoKQogewogI2lmIEVOQUJMRShNRURJQV9DT05UUk9MU19T Q1JJUFQpCg==