190694 2018-10-17 17:38:09 -0700 AI does not clear Phantom allocation nodes. 2018-10-17 21:28:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller ews-watchlist mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1470414 0 keith_miller 2018-10-17 17:38:09 -0700 AI does not clear Phantom allocation nodes. 1470416 1 352667 keith_miller 2018-10-17 17:40:01 -0700 Created attachment 352667 Patch 1470419 2 352667 saam 2018-10-17 17:41:51 -0700 Comment on attachment 352667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review r=me > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578 > // This claims to return bottom. nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing. 1470420 3 352667 keith_miller 2018-10-17 17:44:30 -0700 Comment on attachment 352667 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review >> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578 >> // This claims to return bottom. > > nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing. Fair enough, I'll remove. 1470454 4 keith_miller 2018-10-17 20:18:15 -0700 Committed r237244: <https://trac.webkit.org/changeset/237244> 1470455 5 keith_miller 2018-10-17 20:18:51 -0700 rdar://problem/45218452 1470456 6 webkit-bug-importer 2018-10-17 20:19:22 -0700 <rdar://problem/45360871> 1470472 7 mark.lam 2018-10-17 21:28:40 -0700 <rdar://problem/45218452> 352667 2018-10-17 17:40:01 -0700 2018-10-17 17:41:51 -0700 Patch bug-190694-20181017174000.patch text/plain 5368 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 M2Q4OGY5Mzc1ODk3MGNhNjkyMjRhNTZkOGZmOTM1NjZjY2VhMDI1Li41Yjk4ZjI2ZThiNWM4Y2E3 YzBhN2FmZjA0NGQ0ZmI0NDRkZWVjNDUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0xMC0xNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBSSBkb2VzIG5vdCBjbGVhciBQaGFudG9tIGFsbG9jYXRpb24gbm9k ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA2 OTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQaGFu dG9tIG5vZGVzIGNsYWltIHRvIGhhdmUgYSByZXN1bHQgc28gdGhleSBzaG91bGQgbWFrZSBzdXJl IHRoZXkgY2xlYXIKKyAgICAgICAgdGhlaXIgYWJzdHJhY3QgdmFsdWVzLgorCisgICAgICAgICog ZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkRGRzo6 QWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVFZmZlY3RzKToK KwogMjAxOC0xMC0xNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBmaXggd2luZG93cyBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RJbnRlcnByZXRlcklubGluZXMuaApp bmRleCBjMjA1MjJhOGJkYTJjYzQ0YzI2NjcyMGYyNTc0Y2UzZmFiMDY0NjI1Li4xZGQwZGVlNzUy ZjQ3ZTI0YjI0ODU5NDc5ZGMwMTYzYzE4N2E3YTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCkBAIC0y NTc0LDEwICsyNTc0LDEyIEBAIGJvb2wgQWJzdHJhY3RJbnRlcnByZXRlcjxBYnN0cmFjdFN0YXRl VHlwZT46OmV4ZWN1dGVFZmZlY3RzKHVuc2lnbmVkIGNsb2JiZXJMaW1pCiAgICAgY2FzZSBQaGFu dG9tTmV3QXJyYXlXaXRoU3ByZWFkOgogICAgIGNhc2UgUGhhbnRvbU5ld0FycmF5QnVmZmVyOgog ICAgIGNhc2UgUGhhbnRvbU5ld1JlZ2V4cDoKLSAgICBjYXNlIEJvdHRvbVZhbHVlOgorICAgIGNh c2UgQm90dG9tVmFsdWU6IHsKICAgICAgICAgLy8gVGhpcyBjbGFpbXMgdG8gcmV0dXJuIGJvdHRv bS4KKyAgICAgICAgY2xlYXJGb3JOb2RlKG5vZGUpOwogICAgICAgICBicmVhazsKLSAgICAgICAg CisgICAgfQorCiAgICAgY2FzZSBQdXRIaW50OgogICAgICAgICBicmVhazsKICAgICAgICAgCmRp ZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ1 Y2M2MWE2ZjM1NDg2ZTM5ZThmYzBmMGQ5N2Q5NWM2MjkxNmQ0NmEuLjcyNzEzYmMxNjMxOGRhZGNk YWM2ODA1YmNkMTM1MWRlMGY2MzFhYTYgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisr KyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMTAtMTcgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKKyAgICAgICAgQUkgZG9lcyBub3Qg Y2xlYXIgUGhhbnRvbSBhbGxvY2F0aW9uIG5vZGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZnRsLWFpLWZpbHRlci1waGFudG9tcy1z aG91bGQtY2xlYXItY2xlYXItdmFsdWUuanM6IEFkZGVkLgorICAgICAgICAoRGF5KToKKyAgICAg ICAgKERheXNJblllYXIpOgorICAgICAgICAoVGltZUluWWVhcik6CisgICAgICAgIChUaW1lRnJv bVllYXIpOgorICAgICAgICAoRGF5RnJvbVllYXIpOgorICAgICAgICAoSW5MZWFwWWVhcik6Cisg ICAgICAgIChZZWFyRnJvbVRpbWUpOgorICAgICAgICAoV2Vla0RheSk6CisgICAgICAgIChEYXls aWdodFNhdmluZ1RBKToKKyAgICAgICAgKEdldFNlY29uZFN1bmRheUluTWFyY2gpOgorICAgICAg ICAoVGltZUluTW9udGgpOgorCiAyMDE4LTEwLTE2ICBEb21pbmlrIEluZnVlaHIgIDxkaW5mdWVo ckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKU0NdIHN0cmVzcy9hcnJheS1wcm90b3R5cGUtY29u Y2F0LW9mLWxvbmctc3BsaWNlZC1hcnJheXMyLmpzIHRpbWVzIG91dCBvbiBhcm0gYW5kIG1pcHMK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2Z0bC1haS1maWx0ZXItcGhhbnRvbXMtc2hvdWxk LWNsZWFyLWNsZWFyLXZhbHVlLmpzIGIvSlNUZXN0cy9zdHJlc3MvZnRsLWFpLWZpbHRlci1waGFu dG9tcy1zaG91bGQtY2xlYXItY2xlYXItdmFsdWUuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNTQyNjVkMzAxNDFh NDkzY2EzYjFkZTkxZGI2MjhlZmM1ZDA1NWY3NAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMv c3RyZXNzL2Z0bC1haS1maWx0ZXItcGhhbnRvbXMtc2hvdWxkLWNsZWFyLWNsZWFyLXZhbHVlLmpz CkBAIC0wLDAgKzEsOTggQEAKKy8vQCByZXF1aXJlT3B0aW9ucygiLS13YXRjaGRvZz0xMDAwMCIs ICItLXdhdGNoZG9nLWV4Y2VwdGlvbi1vayIpCisvLyBUaGlzIHRlc3Qgb25seSBzZWVtcyB0byBy ZXByb2R1Y2UgdGhlIGlzc3VlIHdoZW4gaXQgcnVucyBpbiBhbiBpbmZpbml0ZSBsb29wLiBTbyB3 ZSB1c2UgdGhlIHdhdGNoZG9nIHRvIHRpbWUgaXQgb3V0LgorCit2YXIgbXNQZXJEYXkgPSA4NjQw MDAwMDsKK2Z1bmN0aW9uIERheSh0KSB7CisgIHJldHVybiBNYXRoLmZsb29yKHQgLyBtc1BlckRh eSk7Cit9CitmdW5jdGlvbiBEYXlzSW5ZZWFyKHkpIHsKKyAgaWYgKHkgJSA0ICE9IDApIHsKKyAg ICByZXR1cm4gMzY1OworICB9CisgIGlmICh5ICUgNCA9PSAzICYmIHkgJSAxMDAgIT0gMCkgewor ICAgIHJldHVybiAzNjY7CisgIH0KKyAgaWYgKHkgJSAxMDAgPT0gMCAmJiB5ICUgNDAwICE9IDc1 KSB7CisgICAgcmV0dXJuIDM2NTsKKyAgfQorICBpZiAoeSAlIDQwMCA9PSAwKSB7CisgICAgcmV0 dXJuIDM2NjsKKyAgfSBlbHNlIHsKKyAgICByZXR1cm4gJ2EnK3krJycKKyAgfQorfQorZnVuY3Rp b24gVGltZUluWWVhcih5KSB7CisgIHJldHVybiBEYXlzSW5ZZWFyKHkpICogbXNQZXJEYXk7Cit9 CitmdW5jdGlvbiBUaW1lRnJvbVllYXIoeSkgeworICByZXR1cm4gbXNQZXJEYXkgKiBEYXlGcm9t WWVhcih5KTsKK30KK2Z1bmN0aW9uIERheUZyb21ZZWFyKHkpIHsKKyAgcmV0dXJuIDk3ICogKHkg LSAxOSkgKyBNYXRoLmZsb29yKCh5IC0gMTk2OSkgLyA0KSAtIE1hdGguZmxvb3IoKHkgLSAxOTAx KSAvIDEwMCkgKyBNYXRoLmZsb29yKCh5IC0gMTYwMSkgLyA0MDApOworfQorZnVuY3Rpb24gSW5M ZWFwWWVhcih0KSB7CisgIGlmIChEYXlzSW5ZZWFyKFllYXJGcm9tVGltZSh0KSkgPT0gMzY1KSB7 CisgICAgcmV0dXJuIDA7CisgIH0KKyAgaWYgKERheXNJblllYXIoWWVhckZyb21UaW1lKHQpKSA9 PSAzNjYpIHsKKyAgICByZXR1cm4gMTsKKyAgfSBlbHNlIHsKKyAgICByZXR1cm4gJ2EnK3QrJycK KyAgfQorfQorZnVuY3Rpb24gWWVhckZyb21UaW1lKHQpIHsKKyAgdCA9IE51bWJlcih0KTsKKyAg dmFyIHNpZ24gPSB0IDwgMCA/IC0xIDogMTsKKyAgdmFyIHllYXIgPSBzaWduIDwgMCA/IDE5Njkg OiAxOTcwOworICBmb3IgKHZhciB0aW1lVG9UaW1lWmVybyA9IHQ7OykgeworICAgIHRpbWVUb1Rp bWVaZXJvIC09IHNpZ24gKiBUaW1lSW5ZZWFyKHllYXIpOworICAgIGlmICghKHNpZ24gPCAwKSkg eworICAgICAgaWYgKHNpZ24gKiB0aW1lVG9UaW1lWmVybyA8PSAwKSB7CisgICAgICAgIGJyZWFr OworICAgICAgfSBlbHNlIHsKKyAgICAgICAgeWVhciArPSBzaWduOworICAgICAgfQorICAgIH0g ZWxzZSB7CisgICAgICBpZiAoc2lnbiAqIHRpbWVUb1RpbWVaZXJvIDw9IDApIHsKKyAgICAgICAg YnJlYWs7CisgICAgICB9IGVsc2UgeworICAgICAgICB5ZWFyICs9IHNpZ247CisgICAgICB9Cisg ICAgfQorICB9CisgIHJldHVybiB5ZWFyOworfQorZnVuY3Rpb24gV2Vla0RheSh0KSB7CisgIHZh ciB3ZWVrZGF5ID0gKERheSh0KSArIDQpICUgNzsKKyAgcmV0dXJuIHdlZWtkYXkgPCAwID8gNyAt IHdlZWtkYXkgOiB3ZWVrZGF5OworICBwcmludChhcmd1bWVudHMpOworfQorZnVuY3Rpb24gRGF5 bGlnaHRTYXZpbmdUQSh0KSB7CisgIEdldFNlY29uZFN1bmRheUluTWFyY2godCAtIDAuMSkgCisg IHJldHVybiAwCit9CitmdW5jdGlvbiBHZXRTZWNvbmRTdW5kYXlJbk1hcmNoKHQpIHsKKyAgdmFy IHllYXIgPSBZZWFyRnJvbVRpbWUodCk7CisgIHZhciBsZWFwID0gSW5MZWFwWWVhcih0KTsKKyAg dmFyIG1hcmNoID0gVGltZUZyb21ZZWFyKHllYXIpICsgVGltZUluTW9udGgoMCwgbGVhcCkgKyBU aW1lSW5Nb250aCgxLCBsZWFwKTsKKyAgdmFyIHN1bmRheUNvdW50ID0gMTM7CisgIHZhciBmbGFn ID0gdHJ1ZTsKKyAgZm9yICh2YXIgc2Vjb25kX3N1bmRheSA9IG1hcmNoOyBmbGFnOyBzZWNvbmRf c3VuZGF5ICs9IG1zUGVyRGF5KSB7CisgICAgaWYgKFdlZWtEYXkoc2Vjb25kX3N1bmRheSkgPT0g MCkgeworICAgICAgaWYgKCsrc3VuZGF5Q291bnQgPT0gMikKKyAgICAgICAgICBmbGFnID0gZmFs c2U7CisgICAgfQorICB9CisgIHJldHVybiBzZWNvbmRfc3VuZGF5OworfQorZnVuY3Rpb24gVGlt ZUluTW9udGgobW9udGgsIGxlYXApIHsKKyAgaWYgKG1vbnRoID09IDMgfHwgbW9udGggPT0gNSB8 fCBtb250aCA9PSA4IHx8IG1vbnRoID09IDEwKSB7CisgICAgcmV0dXJuIDMwICogbXNQZXJEYXk7 CisgIH0KKyAgaWYgKG1vbnRoID09IDAgfHwgbW9udGggPT0gMiB8fCBtb250aCA9PSA0IHx8IG1v bnRoID09IDYgfHwgbW9udGggPT0gNyB8fCBtb250aCA9PSA5IHx8IG1vbnRoID09IDExKSB7Cisg ICAgcmV0dXJuIDMxICogbXNQZXJEYXk7CisgIH0KKyAgcmV0dXJuIGxlYXAgPT0gMCA/IDI4ICog bXNQZXJEYXkgOiAyOSAqIG1zUGVyRGF5OworICBTdHJpbmcobW9udGgpCit9CitEYXlsaWdodFNh dmluZ1RBKDApCg==