190649 2018-10-16 15:55:03 -0700 Web Inspector: Open Quickly dialog doesn't show named scripts that appear in the debugger sidebar 2018-10-22 12:25:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1469920 0 joepeck 2018-10-16 15:55:03 -0700 Open Quickly dialog doesn't show named scripts that appear in the debugger sidebar Test Page: (tst.html) <script>eval(`//# sourceURL=test.js\nconsole.log("test");`)</script> Steps to Reproduce: 1. Inspect test page 2. Show Debugger Tab 3. Reload => Should see "tst.html" resource and "test.js" named script 4. ⌘⇧O to trigger the quickly open dialog 5. Type "t" => Both resources should show up, only "tst.html" does 1469922 1 352511 joepeck 2018-10-16 16:06:30 -0700 Created attachment 352511 [PATCH] Proposed Fix 1469940 2 352511 hi 2018-10-16 16:35:02 -0700 Comment on attachment 352511 [PATCH] Proposed Fix rs=me 1471291 3 352511 commit-queue 2018-10-22 12:24:13 -0700 Comment on attachment 352511 [PATCH] Proposed Fix Clearing flags on attachment: 352511 Committed r237327: <https://trac.webkit.org/changeset/237327> 1471292 4 commit-queue 2018-10-22 12:24:15 -0700 All reviewed patches have been landed. Closing bug. 1471294 5 webkit-bug-importer 2018-10-22 12:25:29 -0700 <rdar://problem/45461980> 352511 2018-10-16 16:06:30 -0700 2018-10-22 12:24:13 -0700 [PATCH] Proposed Fix quickly-1.patch text/plain 2653 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU2NzA0YzgxNzdiLi5iMjk1N2I2NzBjNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMTYgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBPcGVuIFF1aWNrbHkgZGlhbG9nIGRvZXNuJ3Qgc2hvdyBuYW1lZCBzY3JpcHRzIHRoYXQgYXBw ZWFyIGluIHRoZSBkZWJ1Z2dlciBzaWRlYmFyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA2NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvT3BlblJlc291cmNlRGlh bG9nLmpzOgorICAgICAgICAoV0kuT3BlblJlc291cmNlRGlhbG9nLnByb3RvdHlwZS5kaWRQcmVz ZW50RGlhbG9nKToKKyAgICAgICAgKFdJLk9wZW5SZXNvdXJjZURpYWxvZy5wcm90b3R5cGUuX2Fk ZFJlc291cmNlc0ZvclRhcmdldCk6CisgICAgICAgIChXSS5PcGVuUmVzb3VyY2VEaWFsb2cucHJv dG90eXBlLl9hZGRTY3JpcHRzRm9yVGFyZ2V0KToKKyAgICAgICAgSW5jbHVkZSBub24tcmVzb3Vy Y2UgbmFtZWQgc2NyaXB0cyBmcm9tIHRoZSBtYWluIHRhcmdldCBpbgorICAgICAgICB0aGUgb3Bl biBxdWlja2x5IGRpYWxvZy4KKwogMjAxOC0xMC0xNiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FudmFzOiBjYXB0dXJlIHByZXZp b3VzbHkgc2F2ZWQgc3RhdGVzIGFuZCBhZGQgdGhlbSB0byB0aGUgcmVjb3JkaW5nIHBheWxvYWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL09w ZW5SZXNvdXJjZURpYWxvZy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL09wZW5SZXNvdXJjZURpYWxvZy5qcwppbmRleCBkOWI5OGM5MmY0OS4uOTc3OTdiOGIw ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L09wZW5SZXNvdXJjZURpYWxvZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9PcGVuUmVzb3VyY2VEaWFsb2cuanMKQEAgLTE0Nyw2ICsxNDcsOCBAQCBX SS5PcGVuUmVzb3VyY2VEaWFsb2cgPSBjbGFzcyBPcGVuUmVzb3VyY2VEaWFsb2cgZXh0ZW5kcyBX SS5EaWFsb2cKICAgICAgICAgaWYgKFdJLm5ldHdvcmtNYW5hZ2VyLm1haW5GcmFtZSkKICAgICAg ICAgICAgIHRoaXMuX2FkZFJlc291cmNlc0ZvckZyYW1lKFdJLm5ldHdvcmtNYW5hZ2VyLm1haW5G cmFtZSk7CiAKKyAgICAgICAgdGhpcy5fYWRkU2NyaXB0c0ZvclRhcmdldChXSS5tYWluVGFyZ2V0 KTsKKwogICAgICAgICBmb3IgKGxldCB0YXJnZXQgb2YgV0kudGFyZ2V0cykgewogICAgICAgICAg ICAgaWYgKHRhcmdldCAhPT0gV0kubWFpblRhcmdldCkKICAgICAgICAgICAgICAgICB0aGlzLl9h ZGRSZXNvdXJjZXNGb3JUYXJnZXQodGFyZ2V0KTsKQEAgLTMxMSwxMSArMzEzLDIwIEBAIFdJLk9w ZW5SZXNvdXJjZURpYWxvZyA9IGNsYXNzIE9wZW5SZXNvdXJjZURpYWxvZyBleHRlbmRzIFdJLkRp YWxvZwogICAgICAgICBmb3IgKGxldCByZXNvdXJjZSBvZiB0YXJnZXQucmVzb3VyY2VDb2xsZWN0 aW9uKQogICAgICAgICAgICAgdGhpcy5fYWRkUmVzb3VyY2UocmVzb3VyY2UsIHN1cHByZXNzRmls dGVyVXBkYXRlKTsKIAorICAgICAgICB0aGlzLl9hZGRTY3JpcHRzRm9yVGFyZ2V0KHRhcmdldCk7 CisgICAgfQorCisgICAgX2FkZFNjcmlwdHNGb3JUYXJnZXQodGFyZ2V0KQorICAgIHsKKyAgICAg ICAgY29uc3Qgc3VwcHJlc3NGaWx0ZXJVcGRhdGUgPSB0cnVlOworCiAgICAgICAgIGxldCB0YXJn ZXREYXRhID0gV0kuZGVidWdnZXJNYW5hZ2VyLmRhdGFGb3JUYXJnZXQodGFyZ2V0KTsKICAgICAg ICAgZm9yIChsZXQgc2NyaXB0IG9mIHRhcmdldERhdGEuc2NyaXB0cykgewogICAgICAgICAgICAg aWYgKHNjcmlwdC5yZXNvdXJjZSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAg ICAgIGlmIChpc1dlYktpdEludGVybmFsU2NyaXB0KHNjcmlwdC5zb3VyY2VVUkwpIHx8IGlzV2Vi SW5zcGVjdG9yQ29uc29sZUV2YWx1YXRpb25TY3JpcHQoc2NyaXB0LnNvdXJjZVVSTCkpCisgICAg ICAgICAgICBpZiAoc2NyaXB0LmR5bmFtaWNhbGx5QWRkZWRTY3JpcHRFbGVtZW50KQorICAgICAg ICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICAgICAgaWYgKCFzY3JpcHQuc291cmNlVVJMIHx8 IGlzV2ViS2l0SW50ZXJuYWxTY3JpcHQoc2NyaXB0LnNvdXJjZVVSTCkgfHwgaXNXZWJJbnNwZWN0 b3JDb25zb2xlRXZhbHVhdGlvblNjcmlwdChzY3JpcHQuc291cmNlVVJMKSkKICAgICAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgICAgIHRoaXMuX2FkZFJlc291cmNlKHNjcmlwdCwgc3Vw cHJlc3NGaWx0ZXJVcGRhdGUpOwogICAgICAgICB9Cg==