190643 2018-10-16 15:12:56 -0700 Web Inspector: Quickly Open to line/column does should have caret indicating where the position is 2018-10-23 22:20:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=189048 InRadar P2 Normal --- 190862 1 joepeck hi commit-queue hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1469907 0 joepeck 2018-10-16 15:12:56 -0700 Quickly Open to line/column does should have caret indicating where the position is Steps to Reproduce: 1. Inspect <http://bogojoker.com/shell/> 2. Show the "easySlider.min.js" resource in the Debugger tab 3. Unformat the resource so it is not pretty printed 4. ⌘⇧O to trigger the quickly open dialog 5. Type ":5:507" and press return to go to a specific line/column => The editor moves and flashes, but it is unclear where the exact position is, a caret should be showing to indicate it 1470042 1 352552 hi 2018-10-16 23:24:31 -0700 Created attachment 352552 Patch 1470043 2 352553 hi 2018-10-16 23:24:57 -0700 Created attachment 352553 Patch 1470155 3 352553 mattbaker 2018-10-17 10:27:16 -0700 Comment on attachment 352553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352553&action=review This solves the problem, but I'm a little wary of changing revealPosition to force the editor to become focused. We call revealPosition in about a dozen places, are we sure this is the behavior we want? > Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js:-284 > - this.focus(); Why not just move this above the call to revealPosition? See comment below. > Source/WebInspectorUI/UserInterface/Views/TextEditor.js:231 > + this.focus(); Is there ever a time we would want to set the selection, but not focus the editor? 1470234 4 joepeck 2018-10-17 11:50:02 -0700 (In reply to Matt Baker from comment #3) > We call revealPosition in about a dozen places, are we sure this is the behavior we want? This sounds like a good idea to me. We could land it, and live on it, and see if there are any cases that stand out. I imagine the most likely issue I'd come across is that `Escape` in an editable TextEditor might not take me to the QuickConsole due to focus being inside the TextEditor. I think I might be okay with that, and we might even be able to improve that situation if it even happens at all. 1470262 5 352553 mattbaker 2018-10-17 12:22:36 -0700 Comment on attachment 352553 Patch r=me 1470272 6 352553 commit-queue 2018-10-17 12:47:01 -0700 Comment on attachment 352553 Patch Clearing flags on attachment: 352553 Committed r237232: <https://trac.webkit.org/changeset/237232> 1470273 7 commit-queue 2018-10-17 12:47:02 -0700 All reviewed patches have been landed. Closing bug. 1470277 8 webkit-bug-importer 2018-10-17 12:48:49 -0700 <rdar://problem/45347635> 352552 2018-10-16 23:24:31 -0700 2018-10-16 23:24:55 -0700 Patch bug-190643-20181016232431.patch text/plain 3027 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY4NWZlODI1NTFkN2Y4NmQxZDQ0NjQyMzNhN2Rl YTBkMDZjMDJhMGYuLjM1OTdhZTk0YzEzN2NhOThhMjU5NjQ4Yjg3NmQzYjgwNzU3MDI1ZGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBR dWlja2x5IE9wZW4gdG8gbGluZS9jb2x1bW4gZG9lcyBzaG91bGQgaGF2ZSBjYXJldCBpbmRpY2F0 aW5nIHdoZXJlIHRoZSBwb3NpdGlvbiBpcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanM6Cisg ICAgICAgIChXSS5UZXh0RWRpdG9yLnByb3RvdHlwZS5zZXQgc2VsZWN0ZWRUZXh0UmFuZ2UpOgor ICAgICAgICBFbnN1cmUgdGhhdCBDb2RlTWlycm9yIGlzIGZvY3VzZWQgYmVmb3JlIGF0dGVtcHRp bmcgdG8gYHNldFNlbGVjdGlvbmAuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Nv dXJjZUNvZGVUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV0kuU291cmNlQ29kZVRleHRFZGl0b3Iu cHJvdG90eXBlLmRpYWxvZ1dhc0Rpc21pc3NlZFdpdGhSZXByZXNlbnRlZE9iamVjdCk6CisgICAg ICAgIFJlbW92ZSB0aGUgZXh0cmEgYGZvY3VzYCBjYWxsIGFmdGVyIGRpc21pc3NpbmcgdGhlIGBX SS5Hb1RvTGluZURpYWxvZ2Agc2luY2UgaXQgaXMgbm93CisgICAgICAgIGhhbmRsZWQgYnkgYFdJ LlRleHRFZGl0b3JgIHZpYSBgcmV2ZWFsUG9zaXRpb25gLgorCiAyMDE4LTEwLTE2ICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog 4oyDRyB0byBqdW1wIHRvIGxpbmUgaW4gQ1NTIGZpbGUgd2lwZXMgdGhlIGxpbmUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVU ZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U291cmNlQ29kZVRleHRFZGl0b3IuanMKaW5kZXggYzU3YTg5NzJmYjJlNzQ2ZGJjYWQ2YWFjZTc0 OGYzZWU5NDdmMDI1Ny4uMjdlNjRiMmIzYjFmODE5MGYwMDMyZTc0OTA0OGFhZGJmZTVmNmFlMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291 cmNlQ29kZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTI3OSw5ICsyNzksNyBAQCBX SS5Tb3VyY2VDb2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVu ZHMgV0kuVGV4dEVkaXRvcgogICAgIHsKICAgICAgICAgbGV0IHBvc2l0aW9uID0gbmV3IFdJLlNv dXJjZUNvZGVQb3NpdGlvbihsaW5lTnVtYmVyIC0gMSwgMCk7CiAgICAgICAgIGxldCByYW5nZSA9 IG5ldyBXSS5UZXh0UmFuZ2UobGluZU51bWJlciAtIDEsIDAsIGxpbmVOdW1iZXIsIDApOwotCiAg ICAgICAgIHRoaXMucmV2ZWFsUG9zaXRpb24ocG9zaXRpb24sIHJhbmdlLCBmYWxzZSwgdHJ1ZSk7 Ci0gICAgICAgIHRoaXMuZm9jdXMoKTsKICAgICB9CiAKICAgICBjb250ZW50RGlkQ2hhbmdlKHJl cGxhY2VkUmFuZ2VzLCBuZXdSYW5nZXMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwppbmRleCA5MWJjZmZiOGQzMjIy OTJjYmQwNDIyNWY3Y2Q4ZTJmNmZiNDY3MzZkLi45MDE5ZjU1NjExNzFiNzkzZGZhZDc4ZTVmYWYw NDdlY2U4MTY5ZDUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTIyOCw2ICsyMjgsNyBAQCBXSS5UZXh0 RWRpdG9yID0gY2xhc3MgVGV4dEVkaXRvciBleHRlbmRzIFdJLlZpZXcKICAgICBzZXQgc2VsZWN0 ZWRUZXh0UmFuZ2UodGV4dFJhbmdlKQogICAgIHsKICAgICAgICAgdmFyIHBvc2l0aW9uID0gdGhp cy5fY29kZU1pcnJvclBvc2l0aW9uRnJvbVRleHRSYW5nZSh0ZXh0UmFuZ2UpOworICAgICAgICB0 aGlzLmZvY3VzKCk7CiAgICAgICAgIHRoaXMuX2NvZGVNaXJyb3Iuc2V0U2VsZWN0aW9uKHBvc2l0 aW9uLnN0YXJ0LCBwb3NpdGlvbi5lbmQpOwogICAgIH0KIApAQCAtNTIwLDcgKzUyMSw3IEBAIFdJ LlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBs ZXQgbGluZUhhbmRsZSA9IHRoaXMuX2NvZGVNaXJyb3IuZ2V0TGluZUhhbmRsZShsaW5lKTsKIAog ICAgICAgICBpZiAoIXRleHRSYW5nZVRvU2VsZWN0KSB7Ci0gICAgICAgICAgICBsZXQgY29sdW1u ID0gTnVtYmVyLmNvbnN0cmFpbihwb3NpdGlvbi5jb2x1bW5OdW1iZXIsIDAsIHRoaXMuX2NvZGVN aXJyb3IuZ2V0TGluZShsaW5lKS5sZW5ndGggLSAxKTsKKyAgICAgICAgICAgIGxldCBjb2x1bW4g PSBOdW1iZXIuY29uc3RyYWluKHBvc2l0aW9uLmNvbHVtbk51bWJlciwgMCwgdGhpcy5fY29kZU1p cnJvci5nZXRMaW5lKGxpbmUpLmxlbmd0aCk7CiAgICAgICAgICAgICB0ZXh0UmFuZ2VUb1NlbGVj dCA9IG5ldyBXSS5UZXh0UmFuZ2UobGluZSwgY29sdW1uLCBsaW5lLCBjb2x1bW4pOwogICAgICAg ICB9CiAK 352553 2018-10-16 23:24:57 -0700 2018-10-17 12:47:01 -0700 Patch bug-190643-20181016232456.patch text/plain 3174 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY4NWZlODI1NTFkN2Y4NmQxZDQ0NjQyMzNhN2Rl YTBkMDZjMDJhMGYuLmNiZTI1ODQ2ZGU0OGEyMDI3MDg5MGEwYzM1NTZjMDgwMzVkYzNjYzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTEwLTE2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBR dWlja2x5IE9wZW4gdG8gbGluZS9jb2x1bW4gZG9lcyBzaG91bGQgaGF2ZSBjYXJldCBpbmRpY2F0 aW5nIHdoZXJlIHRoZSBwb3NpdGlvbiBpcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNjQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanM6Cisg ICAgICAgIChXSS5UZXh0RWRpdG9yLnByb3RvdHlwZS5zZXQgc2VsZWN0ZWRUZXh0UmFuZ2UpOgor ICAgICAgICAoV0kuVGV4dEVkaXRvci5wcm90b3R5cGUucmV2ZWFsUG9zaXRpb24pOgorICAgICAg ICBFbnN1cmUgdGhhdCBDb2RlTWlycm9yIGlzIGZvY3VzZWQgYmVmb3JlIGF0dGVtcHRpbmcgdG8g YHNldFNlbGVjdGlvbmAuCisgICAgICAgIERyaXZlLWJ5OiBhbGxvdyBzZWxlY3Rpb25zIHBhc3Qg dGhlICJlbmQiIG9mIHRoZSBsaW5lIChzaW5jZSB0aGVyZSBpcyBhIGBcbmAgb3IgYFxyYCkuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzOgor ICAgICAgICAoV0kuU291cmNlQ29kZVRleHRFZGl0b3IucHJvdG90eXBlLmRpYWxvZ1dhc0Rpc21p c3NlZFdpdGhSZXByZXNlbnRlZE9iamVjdCk6CisgICAgICAgIFJlbW92ZSB0aGUgZXh0cmEgYGZv Y3VzYCBjYWxsIGFmdGVyIGRpc21pc3NpbmcgdGhlIGBXSS5Hb1RvTGluZURpYWxvZ2Agc2luY2Ug aXQgaXMgbm93CisgICAgICAgIGhhbmRsZWQgYnkgYFdJLlRleHRFZGl0b3JgIHZpYSBgcmV2ZWFs UG9zaXRpb25gLgorCiAyMDE4LTEwLTE2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog4oyDRyB0byBqdW1wIHRvIGxpbmUgaW4g Q1NTIGZpbGUgd2lwZXMgdGhlIGxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMK aW5kZXggYzU3YTg5NzJmYjJlNzQ2ZGJjYWQ2YWFjZTc0OGYzZWU5NDdmMDI1Ny4uMjdlNjRiMmIz YjFmODE5MGYwMDMyZTc0OTA0OGFhZGJmZTVmNmFlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRl eHRFZGl0b3IuanMKQEAgLTI3OSw5ICsyNzksNyBAQCBXSS5Tb3VyY2VDb2RlVGV4dEVkaXRvciA9 IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV0kuVGV4dEVkaXRvcgogICAgIHsK ICAgICAgICAgbGV0IHBvc2l0aW9uID0gbmV3IFdJLlNvdXJjZUNvZGVQb3NpdGlvbihsaW5lTnVt YmVyIC0gMSwgMCk7CiAgICAgICAgIGxldCByYW5nZSA9IG5ldyBXSS5UZXh0UmFuZ2UobGluZU51 bWJlciAtIDEsIDAsIGxpbmVOdW1iZXIsIDApOwotCiAgICAgICAgIHRoaXMucmV2ZWFsUG9zaXRp b24ocG9zaXRpb24sIHJhbmdlLCBmYWxzZSwgdHJ1ZSk7Ci0gICAgICAgIHRoaXMuZm9jdXMoKTsK ICAgICB9CiAKICAgICBjb250ZW50RGlkQ2hhbmdlKHJlcGxhY2VkUmFuZ2VzLCBuZXdSYW5nZXMp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9U ZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGV4dEVkaXRvci5qcwppbmRleCA5MWJjZmZiOGQzMjIyOTJjYmQwNDIyNWY3Y2Q4ZTJmNmZiNDY3 MzZkLi45MDE5ZjU1NjExNzFiNzkzZGZhZDc4ZTVmYWYwNDdlY2U4MTY5ZDUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0 b3IuanMKQEAgLTIyOCw2ICsyMjgsNyBAQCBXSS5UZXh0RWRpdG9yID0gY2xhc3MgVGV4dEVkaXRv ciBleHRlbmRzIFdJLlZpZXcKICAgICBzZXQgc2VsZWN0ZWRUZXh0UmFuZ2UodGV4dFJhbmdlKQog ICAgIHsKICAgICAgICAgdmFyIHBvc2l0aW9uID0gdGhpcy5fY29kZU1pcnJvclBvc2l0aW9uRnJv bVRleHRSYW5nZSh0ZXh0UmFuZ2UpOworICAgICAgICB0aGlzLmZvY3VzKCk7CiAgICAgICAgIHRo aXMuX2NvZGVNaXJyb3Iuc2V0U2VsZWN0aW9uKHBvc2l0aW9uLnN0YXJ0LCBwb3NpdGlvbi5lbmQp OwogICAgIH0KIApAQCAtNTIwLDcgKzUyMSw3IEBAIFdJLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0 RWRpdG9yIGV4dGVuZHMgV0kuVmlldwogICAgICAgICBsZXQgbGluZUhhbmRsZSA9IHRoaXMuX2Nv ZGVNaXJyb3IuZ2V0TGluZUhhbmRsZShsaW5lKTsKIAogICAgICAgICBpZiAoIXRleHRSYW5nZVRv U2VsZWN0KSB7Ci0gICAgICAgICAgICBsZXQgY29sdW1uID0gTnVtYmVyLmNvbnN0cmFpbihwb3Np dGlvbi5jb2x1bW5OdW1iZXIsIDAsIHRoaXMuX2NvZGVNaXJyb3IuZ2V0TGluZShsaW5lKS5sZW5n dGggLSAxKTsKKyAgICAgICAgICAgIGxldCBjb2x1bW4gPSBOdW1iZXIuY29uc3RyYWluKHBvc2l0 aW9uLmNvbHVtbk51bWJlciwgMCwgdGhpcy5fY29kZU1pcnJvci5nZXRMaW5lKGxpbmUpLmxlbmd0 aCk7CiAgICAgICAgICAgICB0ZXh0UmFuZ2VUb1NlbGVjdCA9IG5ldyBXSS5UZXh0UmFuZ2UobGlu ZSwgY29sdW1uLCBsaW5lLCBjb2x1bW4pOwogICAgICAgICB9CiAK