<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190637</bug_id>
          
          <creation_ts>2018-10-16 13:42:04 -0700</creation_ts>
          <short_desc>delete expression should not throw without a reference</short_desc>
          <delta_ts>2018-10-18 10:32:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Leo Balter">leo</reporter>
          <assigned_to name="Ross Kirsling">ross.kirsling</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>fpizlo</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1469865</commentid>
    <comment_count>0</comment_count>
    <who name="Leo Balter">leo</who>
    <bug_when>2018-10-16 13:42:04 -0700</bug_when>
    <thetext>This test is wrong:

https://github.com/WebKit/webkit/blob/master/LayoutTests/js/script-tests/basic-strict-mode.js#L153

```
&quot;use strict&quot;;
var a = { b: 42 };
delete void a.b;
```

The delete expression should not throw, but it throws a syntax error requiring a reference expression.

The specs says the expression should return true when the right hand expression is not a reference:

https://tc39.github.io/ecma262/#sec-delete-operator-runtime-semantics-evaluation

the void expression will normally return undefined and this value is not a reference.

This bug is only seen on JSC. Other major engines are showing the expected behavior.

```
eshost -x &apos;&quot;use strict&quot;; var a = { b: 42 }; delete void a.b&apos;
#### v8-harmony


#### v8


#### jsc
SyntaxError: The delete operator requires a reference expression.

#### spidermonkey


#### ch


#### node


```

The same happens if the expression is `delete void 0` or `delete typeof 0` but changing the expression from `delete (void 0)` gets the correct behavior.


I&apos;m sending some tests to Test262 to support this and prevent it from other occurrences.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470356</commentid>
    <comment_count>1</comment_count>
      <attachid>352650</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-10-17 15:11:16 -0700</bug_when>
    <thetext>Created attachment 352650
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470361</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-10-17 15:30:34 -0700</bug_when>
    <thetext>This is really interesting -- looks like that SyntaxError has been in JSC&apos;s parser forever, yet even looking through old editions of ECMA-262, it doesn&apos;t seem like it was ever spec-compliant.

I don&apos;t believe there are any test cases to be added here, since we&apos;re just removing a strict-mode check that seemingly ought to have never existed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470480</commentid>
    <comment_count>3</comment_count>
      <attachid>352650</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-10-18 00:02:37 -0700</bug_when>
    <thetext>Comment on attachment 352650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352650&amp;action=review

r=me. Could you update test262 expectations.yaml too?

&gt; LayoutTests/js/script-tests/basic-strict-mode.js:-153
&gt; -shouldBeSyntaxError(&quot;&apos;use strict&apos;; if (0) delete +a.b&quot;);
&gt; -shouldBeSyntaxError(&quot;&apos;use strict&apos;; if (0) delete ++a.b&quot;);
&gt; -shouldBeSyntaxError(&quot;&apos;use strict&apos;; if (0) delete void a.b&quot;);

Lets&apos;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470481</commentid>
    <comment_count>4</comment_count>
      <attachid>352650</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2018-10-18 00:03:22 -0700</bug_when>
    <thetext>Comment on attachment 352650
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352650&amp;action=review

&gt;&gt; LayoutTests/js/script-tests/basic-strict-mode.js:-153
&gt;&gt; -shouldBeSyntaxError(&quot;&apos;use strict&apos;; if (0) delete void a.b&quot;);
&gt; 
&gt; Lets&apos;

Oops.

Let&apos;s keep these tests as follows. `shouldBeXXX(...)`</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470570</commentid>
    <comment_count>5</comment_count>
      <attachid>352705</attachid>
    <who name="Ross Kirsling">ross.kirsling</who>
    <bug_when>2018-10-18 09:55:09 -0700</bug_when>
    <thetext>Created attachment 352705
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470585</commentid>
    <comment_count>6</comment_count>
      <attachid>352705</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-18 10:31:30 -0700</bug_when>
    <thetext>Comment on attachment 352705
Patch for landing

Clearing flags on attachment: 352705

Committed r237259: &lt;https://trac.webkit.org/changeset/237259&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470586</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-18 10:31:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470587</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-18 10:32:41 -0700</bug_when>
    <thetext>&lt;rdar://problem/45375223&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>352650</attachid>
            <date>2018-10-17 15:11:16 -0700</date>
            <delta_ts>2018-10-18 09:55:07 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190637-20181017151115.patch</filename>
            <type>text/plain</type>
            <size>5277</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
YzUyMjRlNDRjOTc0ODRlZGUxZjM2NzkyMTY0NWFmNGJhYTIxM2FmLi4zZTEyMTg4M2FlYTVkZWYx
NzFkNjk4MDhlZGYyNjViYTIzZDZhZDNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOC0xMC0xNyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgZGVsZXRlIGV4cHJlc3Npb24gc2hvdWxkIG5vdCB0aHJvdyB3aXRo
b3V0IGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTA2MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIHBhcnNlci9QYXJzZXIuY3BwOgorICAgICAgICAoSlNDOjpQYXJzZXI8TGV4ZXJU
eXBlPjo6cGFyc2VVbmFyeUV4cHJlc3Npb24pOgorICAgICAgICBFbGltaW5hdGUgbm9uLXNwZWMt
Y29tcGxpYW50IHN3aXRjaCBjYXNlLgorCiAyMDE4LTEwLTE3ICBZdXN1a2UgU3V6dWtpICA8eXVz
dWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CiAKICAgICAgICAgW0pTQ10gVXNlIFdURjo6RnVuY3Rp
b24gaW5zdGVhZCBvZiBzdGQ6OmZ1bmN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvcGFyc2VyL1BhcnNlci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1Bh
cnNlci5jcHAKaW5kZXggNDM5NWRjMmRlYzcwMjg1ZTQ5MzVhNGZkMmVkNjllNWRjNGQ1YWViMC4u
M2YyZmMxZTM4ZjRhNGVkMzE5ZGJhODQ2NWRiZjhlOTkxNDUxOWM1MSAxMDA2NDQKLS0tIGEvU291
cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny
aXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcApAQCAtNDkwNSwxMCArNDkwNSw2IEBAIHRlbXBsYXRl
IDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZUV4cHJlc3Npb24gUGFyc2VyPExleGVyVHlwZT46OnBh
cnNlVW5hcnlFeHByZXNzCiAgICAgICAgICAgICAgICAgbW9kaWZpZXNFeHByID0gdHJ1ZTsKICAg
ICAgICAgICAgICAgICByZXF1aXJlc0xFeHByID0gdHJ1ZTsKICAgICAgICAgICAgICAgICBicmVh
azsKLSAgICAgICAgICAgIGNhc2UgREVMRVRFVE9LRU46Ci0gICAgICAgICAgICAgICAgc2VtYW50
aWNGYWlsSWZUcnVlKHJlcXVpcmVzTEV4cHIsICJUaGUgIiwgb3BlcmF0b3JTdHJpbmcodHJ1ZSwg
bGFzdE9wZXJhdG9yKSwgIiBvcGVyYXRvciByZXF1aXJlcyBhIHJlZmVyZW5jZSBleHByZXNzaW9u
Iik7Ci0gICAgICAgICAgICAgICAgcmVxdWlyZXNMRXhwciA9IHRydWU7Ci0gICAgICAgICAgICAg
ICAgYnJlYWs7CiAgICAgICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgICAgIHNlbWFudGlj
RmFpbElmVHJ1ZShyZXF1aXJlc0xFeHByLCAiVGhlICIsIG9wZXJhdG9yU3RyaW5nKHRydWUsIGxh
c3RPcGVyYXRvciksICIgb3BlcmF0b3IgcmVxdWlyZXMgYSByZWZlcmVuY2UgZXhwcmVzc2lvbiIp
OwogICAgICAgICAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl
TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJhNjFhMzFhNDAxMDQ5MmZhZmMwMWNj
MWVlZjA4ZjgzNjE1NjAyMjkuLjc5ZjhhMGI4YzAwZDI3MGNlMTQ2N2U3NzcwNGEzNDFjY2QyZWU3
OTQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D
aGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0xMC0xNyAgUm9zcyBLaXJzbGluZyAgPHJv
c3Mua2lyc2xpbmdAc29ueS5jb20+CisKKyAgICAgICAgZGVsZXRlIGV4cHJlc3Npb24gc2hvdWxk
IG5vdCB0aHJvdyB3aXRob3V0IGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA2MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzL2Jhc2ljLXN0cmljdC1tb2RlLWV4cGVjdGVkLnR4
dDoKKyAgICAgICAgKiBqcy9zY3JpcHQtdGVzdHMvYmFzaWMtc3RyaWN0LW1vZGUuanM6CisgICAg
ICAgIEVsaW1pbmF0ZSBub24tc3BlYy1jb21wbGlhbnQgdGVzdCBjYXNlcy4KKwogMjAxOC0xMC0x
NyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBD
ZXJ0YWluIHRhZ3Mgc2hvdWxkIGlkZW50aWZ5IHRoZWlyIGNvbnRleHQgdG8gaU9TIEFQSQpkaWZm
IC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvYmFzaWMtc3RyaWN0LW1vZGUtZXhwZWN0ZWQudHh0IGIv
TGF5b3V0VGVzdHMvanMvYmFzaWMtc3RyaWN0LW1vZGUtZXhwZWN0ZWQudHh0CmluZGV4IGQ1ODAy
ZTFhNGVhZTEwYWIyYWI2N2Y5OWM3OTE1MjZmOGVkNzBhMDguLmEwNTcwMGQzYjcxZGU2MTZlOTBl
NGQyNjU2MTQ2M2I0ZjFhODU4OTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL2Jhc2ljLXN0
cmljdC1tb2RlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9qcy9iYXNpYy1zdHJpY3Qt
bW9kZS1leHBlY3RlZC50eHQKQEAgLTE1MywxMiArMTUzLDYgQEAgUEFTUyAndXNlIHN0cmljdCc7
IGZ1bmN0aW9uIGYoKSB7IC0tKDEsIGFyZ3VtZW50cykgfSB0aHJldyBleGNlcHRpb24gU3ludGF4
RXJyb3IKIFBBU1MgKGZ1bmN0aW9uKCl7J3VzZSBzdHJpY3QnOyBmdW5jdGlvbiBmKCkgeyAtLSgx
LCBhcmd1bWVudHMpIH19KSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IENhbm5vdCBtb2Rp
ZnkgJ2FyZ3VtZW50cycgaW4gc3RyaWN0IG1vZGUuLgogUEFTUyAndXNlIHN0cmljdCc7IGZ1bmN0
aW9uIGYoKSB7ICgxLCBhcmd1bWVudHMpLS0gfSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6
ICdhcmd1bWVudHMnIGNhbm5vdCBiZSBtb2RpZmllZCBpbiBzdHJpY3QgbW9kZS4uCiBQQVNTIChm
dW5jdGlvbigpeyd1c2Ugc3RyaWN0JzsgZnVuY3Rpb24gZigpIHsgKDEsIGFyZ3VtZW50cyktLSB9
fSkgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiAnYXJndW1lbnRzJyBjYW5ub3QgYmUgbW9k
aWZpZWQgaW4gc3RyaWN0IG1vZGUuLgotUEFTUyAndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUg
K2EuYiB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFRoZSBkZWxldGUgb3BlcmF0b3IgcmVx
dWlyZXMgYSByZWZlcmVuY2UgZXhwcmVzc2lvbi4uCi1QQVNTIChmdW5jdGlvbigpeyd1c2Ugc3Ry
aWN0JzsgaWYgKDApIGRlbGV0ZSArYS5ifSkgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBU
aGUgZGVsZXRlIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJlbmNlIGV4cHJlc3Npb24uLgotUEFT
UyAndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgKythLmIgdGhyZXcgZXhjZXB0aW9uIFN5bnRh
eEVycm9yOiBUaGUgZGVsZXRlIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJlbmNlIGV4cHJlc3Np
b24uLgotUEFTUyAoZnVuY3Rpb24oKXsndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgKythLmJ9
KSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFRoZSBkZWxldGUgb3BlcmF0b3IgcmVxdWly
ZXMgYSByZWZlcmVuY2UgZXhwcmVzc2lvbi4uCi1QQVNTICd1c2Ugc3RyaWN0JzsgaWYgKDApIGRl
bGV0ZSB2b2lkIGEuYiB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFRoZSBkZWxldGUgb3Bl
cmF0b3IgcmVxdWlyZXMgYSByZWZlcmVuY2UgZXhwcmVzc2lvbi4uCi1QQVNTIChmdW5jdGlvbigp
eyd1c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSB2b2lkIGEuYn0pIHRocmV3IGV4Y2VwdGlvbiBT
eW50YXhFcnJvcjogVGhlIGRlbGV0ZSBvcGVyYXRvciByZXF1aXJlcyBhIHJlZmVyZW5jZSBleHBy
ZXNzaW9uLi4KIFBBU1MgKGZ1bmN0aW9uIChhKXsndXNlIHN0cmljdCc7IGEgPSBmYWxzZTsgcmV0
dXJuIGEgIT09IGFyZ3VtZW50c1swXTsgfSkodHJ1ZSkgaXMgdHJ1ZQogUEFTUyAoZnVuY3Rpb24g
KGEpeyd1c2Ugc3RyaWN0JzsgYXJndW1lbnRzWzBdID0gZmFsc2U7IHJldHVybiBhICE9PSBhcmd1
bWVudHNbMF07IH0pKHRydWUpIGlzIHRydWUKIFBBU1MgKGZ1bmN0aW9uIChhKXsndXNlIHN0cmlj
dCc7IGE9ZmFsc2U7IHJldHVybiBhcmd1bWVudHM7IH0pKHRydWUpWzBdIGlzIHRydWUKZGlmZiAt
LWdpdCBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1zdHJpY3QtbW9kZS5qcyBi
L0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1zdHJpY3QtbW9kZS5qcwppbmRleCA2
YTg0NTI4NjBiNjczZWE2ODNkNzE5ODNkYjllY2RiODgyYzA1Yzc1Li4wMjM1MTY1YzA2ZjNlYjY3
YTdjZGIzZjdkY2NjZjAwOWRiMDM1Njg5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9zY3Jp
cHQtdGVzdHMvYmFzaWMtc3RyaWN0LW1vZGUuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0
LXRlc3RzL2Jhc2ljLXN0cmljdC1tb2RlLmpzCkBAIC0xNDgsOSArMTQ4LDYgQEAgc2hvdWxkQmVT
eW50YXhFcnJvcigiJ3VzZSBzdHJpY3QnOyBmdW5jdGlvbiBmKCkgeyArKygxLCBhcmd1bWVudHMp
IH0iKTsKIHNob3VsZEJlU3ludGF4RXJyb3IoIid1c2Ugc3RyaWN0JzsgZnVuY3Rpb24gZigpIHsg
KDEsIGFyZ3VtZW50cykrKyB9Iik7CiBzaG91bGRCZVN5bnRheEVycm9yKCIndXNlIHN0cmljdCc7
IGZ1bmN0aW9uIGYoKSB7IC0tKDEsIGFyZ3VtZW50cykgfSIpOwogc2hvdWxkQmVTeW50YXhFcnJv
cigiJ3VzZSBzdHJpY3QnOyBmdW5jdGlvbiBmKCkgeyAoMSwgYXJndW1lbnRzKS0tIH0iKTsKLXNo
b3VsZEJlU3ludGF4RXJyb3IoIid1c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSArYS5iIik7Ci1z
aG91bGRCZVN5bnRheEVycm9yKCIndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgKythLmIiKTsK
LXNob3VsZEJlU3ludGF4RXJyb3IoIid1c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSB2b2lkIGEu
YiIpOwogCiBzaG91bGRCZVRydWUoIihmdW5jdGlvbiAoYSl7J3VzZSBzdHJpY3QnOyBhID0gZmFs
c2U7IHJldHVybiBhICE9PSBhcmd1bWVudHNbMF07IH0pKHRydWUpIik7CiBzaG91bGRCZVRydWUo
IihmdW5jdGlvbiAoYSl7J3VzZSBzdHJpY3QnOyBhcmd1bWVudHNbMF0gPSBmYWxzZTsgcmV0dXJu
IGEgIT09IGFyZ3VtZW50c1swXTsgfSkodHJ1ZSkiKTsK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>352705</attachid>
            <date>2018-10-18 09:55:09 -0700</date>
            <delta_ts>2018-10-18 10:31:30 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-190637-20181018095508.patch</filename>
            <type>text/plain</type>
            <size>6182</size>
            <attacher name="Ross Kirsling">ross.kirsling</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw
YzUyMjRlNDRjOTc0ODRlZGUxZjM2NzkyMTY0NWFmNGJhYTIxM2FmLi43ODkzMGUyMjBhZWRlNmVl
MDkxMmQ5NDY1NDg4OWI2NDFlOTFmNWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxOC0xMC0xOCAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u
eS5jb20+CisKKyAgICAgICAgZGVsZXRlIGV4cHJlc3Npb24gc2hvdWxkIG5vdCB0aHJvdyB3aXRo
b3V0IGEgcmVmZXJlbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0xOTA2MzcKKworICAgICAgICBSZXZpZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisg
ICAgICAgICogcGFyc2VyL1BhcnNlci5jcHA6CisgICAgICAgIChKU0M6OlBhcnNlcjxMZXhlclR5
cGU+OjpwYXJzZVVuYXJ5RXhwcmVzc2lvbik6CisgICAgICAgIEVsaW1pbmF0ZSBub24tc3BlYy1j
b21wbGlhbnQgc3dpdGNoIGNhc2UuCisKIDIwMTgtMTAtMTcgIFl1c3VrZSBTdXp1a2kgIDx5dXN1
a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAgICAgICBbSlNDXSBVc2UgV1RGOjpGdW5jdGlv
biBpbnN0ZWFkIG9mIHN0ZDo6ZnVuY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9wYXJzZXIvUGFyc2VyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFy
c2VyLmNwcAppbmRleCA0Mzk1ZGMyZGVjNzAyODVlNDkzNWE0ZmQyZWQ2OWU1ZGM0ZDVhZWIwLi4z
ZjJmYzFlMzhmNGE0ZWQzMTlkYmE4NDY1ZGJmOGU5OTE0NTE5YzUxIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp
cHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCkBAIC00OTA1LDEwICs0OTA1LDYgQEAgdGVtcGxhdGUg
PGNsYXNzIFRyZWVCdWlsZGVyPiBUcmVlRXhwcmVzc2lvbiBQYXJzZXI8TGV4ZXJUeXBlPjo6cGFy
c2VVbmFyeUV4cHJlc3MKICAgICAgICAgICAgICAgICBtb2RpZmllc0V4cHIgPSB0cnVlOwogICAg
ICAgICAgICAgICAgIHJlcXVpcmVzTEV4cHIgPSB0cnVlOwogICAgICAgICAgICAgICAgIGJyZWFr
OwotICAgICAgICAgICAgY2FzZSBERUxFVEVUT0tFTjoKLSAgICAgICAgICAgICAgICBzZW1hbnRp
Y0ZhaWxJZlRydWUocmVxdWlyZXNMRXhwciwgIlRoZSAiLCBvcGVyYXRvclN0cmluZyh0cnVlLCBs
YXN0T3BlcmF0b3IpLCAiIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJlbmNlIGV4cHJlc3Npb24i
KTsKLSAgICAgICAgICAgICAgICByZXF1aXJlc0xFeHByID0gdHJ1ZTsKLSAgICAgICAgICAgICAg
ICBicmVhazsKICAgICAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAgICAgc2VtYW50aWNG
YWlsSWZUcnVlKHJlcXVpcmVzTEV4cHIsICJUaGUgIiwgb3BlcmF0b3JTdHJpbmcodHJ1ZSwgbGFz
dE9wZXJhdG9yKSwgIiBvcGVyYXRvciByZXF1aXJlcyBhIHJlZmVyZW5jZSBleHByZXNzaW9uIik7
CiAgICAgICAgICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmE2MWEzMWE0MDEwNDkyZmFmYzAxY2Mx
ZWVmMDhmODM2MTU2MDIyOS4uZjM2MTk0MTdlNjZkNjNiM2VhMTI5MDI3M2QxMmExM2IxZTllZTA2
NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEwLTE4ICBSb3NzIEtpcnNsaW5nICA8cm9z
cy5raXJzbGluZ0Bzb255LmNvbT4KKworICAgICAgICBkZWxldGUgZXhwcmVzc2lvbiBzaG91bGQg
bm90IHRocm93IHdpdGhvdXQgYSByZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDYzNworCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3Vr
ZSBTdXp1a2kuCisKKyAgICAgICAgKiBqcy9iYXNpYy1zdHJpY3QtbW9kZS1leHBlY3RlZC50eHQ6
CisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL2Jhc2ljLXN0cmljdC1tb2RlLmpzOgorICAgICAg
ICBVcGRhdGUgdGVzdCBjYXNlcy4KKwogMjAxOC0xMC0xNyAgQ2hyaXMgRmxlaXphY2ggIDxjZmxl
aXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBDZXJ0YWluIHRhZ3Mgc2hvdWxkIGlkZW50
aWZ5IHRoZWlyIGNvbnRleHQgdG8gaU9TIEFQSQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMv
YmFzaWMtc3RyaWN0LW1vZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvYmFzaWMtc3Ry
aWN0LW1vZGUtZXhwZWN0ZWQudHh0CmluZGV4IGQ1ODAyZTFhNGVhZTEwYWIyYWI2N2Y5OWM3OTE1
MjZmOGVkNzBhMDguLjczMTZhZDRmOGU3ZTg4OWE0NWQ5NDYzZWE5YzdjMjA4YTcwMTI0YTQgMTAw
NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL2Jhc2ljLXN0cmljdC1tb2RlLWV4cGVjdGVkLnR4dAor
KysgYi9MYXlvdXRUZXN0cy9qcy9iYXNpYy1zdHJpY3QtbW9kZS1leHBlY3RlZC50eHQKQEAgLTE1
MywxMiArMTUzLDEyIEBAIFBBU1MgJ3VzZSBzdHJpY3QnOyBmdW5jdGlvbiBmKCkgeyAtLSgxLCBh
cmd1bWVudHMpIH0gdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yCiBQQVNTIChmdW5jdGlvbigp
eyd1c2Ugc3RyaWN0JzsgZnVuY3Rpb24gZigpIHsgLS0oMSwgYXJndW1lbnRzKSB9fSkgdGhyZXcg
ZXhjZXB0aW9uIFN5bnRheEVycm9yOiBDYW5ub3QgbW9kaWZ5ICdhcmd1bWVudHMnIGluIHN0cmlj
dCBtb2RlLi4KIFBBU1MgJ3VzZSBzdHJpY3QnOyBmdW5jdGlvbiBmKCkgeyAoMSwgYXJndW1lbnRz
KS0tIH0gdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiAnYXJndW1lbnRzJyBjYW5ub3QgYmUg
bW9kaWZpZWQgaW4gc3RyaWN0IG1vZGUuLgogUEFTUyAoZnVuY3Rpb24oKXsndXNlIHN0cmljdCc7
IGZ1bmN0aW9uIGYoKSB7ICgxLCBhcmd1bWVudHMpLS0gfX0pIHRocmV3IGV4Y2VwdGlvbiBTeW50
YXhFcnJvcjogJ2FyZ3VtZW50cycgY2Fubm90IGJlIG1vZGlmaWVkIGluIHN0cmljdCBtb2RlLi4K
LVBBU1MgJ3VzZSBzdHJpY3QnOyBpZiAoMCkgZGVsZXRlICthLmIgdGhyZXcgZXhjZXB0aW9uIFN5
bnRheEVycm9yOiBUaGUgZGVsZXRlIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJlbmNlIGV4cHJl
c3Npb24uLgotUEFTUyAoZnVuY3Rpb24oKXsndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgK2Eu
Yn0pIHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjogVGhlIGRlbGV0ZSBvcGVyYXRvciByZXF1
aXJlcyBhIHJlZmVyZW5jZSBleHByZXNzaW9uLi4KLVBBU1MgJ3VzZSBzdHJpY3QnOyBpZiAoMCkg
ZGVsZXRlICsrYS5iIHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjogVGhlIGRlbGV0ZSBvcGVy
YXRvciByZXF1aXJlcyBhIHJlZmVyZW5jZSBleHByZXNzaW9uLi4KLVBBU1MgKGZ1bmN0aW9uKCl7
J3VzZSBzdHJpY3QnOyBpZiAoMCkgZGVsZXRlICsrYS5ifSkgdGhyZXcgZXhjZXB0aW9uIFN5bnRh
eEVycm9yOiBUaGUgZGVsZXRlIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJlbmNlIGV4cHJlc3Np
b24uLgotUEFTUyAndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgdm9pZCBhLmIgdGhyZXcgZXhj
ZXB0aW9uIFN5bnRheEVycm9yOiBUaGUgZGVsZXRlIG9wZXJhdG9yIHJlcXVpcmVzIGEgcmVmZXJl
bmNlIGV4cHJlc3Npb24uLgotUEFTUyAoZnVuY3Rpb24oKXsndXNlIHN0cmljdCc7IGlmICgwKSBk
ZWxldGUgdm9pZCBhLmJ9KSB0aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFRoZSBkZWxldGUg
b3BlcmF0b3IgcmVxdWlyZXMgYSByZWZlcmVuY2UgZXhwcmVzc2lvbi4uCitQQVNTICd1c2Ugc3Ry
aWN0JzsgaWYgKDApIGRlbGV0ZSArYS5iIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorUEFTUyAo
ZnVuY3Rpb24oKXsndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgK2EuYn0pIGRpZCBub3QgdGhy
b3cgZXhjZXB0aW9uLgorUEFTUyAndXNlIHN0cmljdCc7IGlmICgwKSBkZWxldGUgKythLmIgZGlk
IG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIChmdW5jdGlvbigpeyd1c2Ugc3RyaWN0JzsgaWYg
KDApIGRlbGV0ZSArK2EuYn0pIGRpZCBub3QgdGhyb3cgZXhjZXB0aW9uLgorUEFTUyAndXNlIHN0
cmljdCc7IGlmICgwKSBkZWxldGUgdm9pZCBhLmIgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQ
QVNTIChmdW5jdGlvbigpeyd1c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSB2b2lkIGEuYn0pIGRp
ZCBub3QgdGhyb3cgZXhjZXB0aW9uLgogUEFTUyAoZnVuY3Rpb24gKGEpeyd1c2Ugc3RyaWN0Jzsg
YSA9IGZhbHNlOyByZXR1cm4gYSAhPT0gYXJndW1lbnRzWzBdOyB9KSh0cnVlKSBpcyB0cnVlCiBQ
QVNTIChmdW5jdGlvbiAoYSl7J3VzZSBzdHJpY3QnOyBhcmd1bWVudHNbMF0gPSBmYWxzZTsgcmV0
dXJuIGEgIT09IGFyZ3VtZW50c1swXTsgfSkodHJ1ZSkgaXMgdHJ1ZQogUEFTUyAoZnVuY3Rpb24g
KGEpeyd1c2Ugc3RyaWN0JzsgYT1mYWxzZTsgcmV0dXJuIGFyZ3VtZW50czsgfSkodHJ1ZSlbMF0g
aXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Jhc2ljLXN0
cmljdC1tb2RlLmpzIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL2Jhc2ljLXN0cmljdC1t
b2RlLmpzCmluZGV4IDZhODQ1Mjg2MGI2NzNlYTY4M2Q3MTk4M2RiOWVjZGI4ODJjMDVjNzUuLjlm
NjE3YjJjZTk4Y2ZmZTI4NWIxN2RmYmEyNGE3ZjEzZmJmNjM2YzMgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9iYXNpYy1zdHJpY3QtbW9kZS5qcworKysgYi9MYXlvdXRU
ZXN0cy9qcy9zY3JpcHQtdGVzdHMvYmFzaWMtc3RyaWN0LW1vZGUuanMKQEAgLTIwLDYgKzIwLDEw
IEBAIGZ1bmN0aW9uIHNob3VsZEJlU3ludGF4RXJyb3Ioc3RyKSB7CiAgICAgc2hvdWxkVGhyb3co
c3RyKTsKICAgICBzaG91bGRUaHJvdygiKGZ1bmN0aW9uKCl7IiArIHN0ciArICJ9KSIpOwogfQor
ZnVuY3Rpb24gc2hvdWxkTm90QmVTeW50YXhFcnJvcihzdHIpIHsKKyAgICBzaG91bGROb3RUaHJv
dyhzdHIpOworICAgIHNob3VsZE5vdFRocm93KCIoZnVuY3Rpb24oKXsiICsgc3RyICsgIn0pIik7
Cit9CiBmdW5jdGlvbiB0ZXN0TGluZUNvbnRpbnVhdGlvbigpIHsKICAgICAidXNlIHN0cmljXAog
dCI7CkBAIC0xNDgsOSArMTUyLDkgQEAgc2hvdWxkQmVTeW50YXhFcnJvcigiJ3VzZSBzdHJpY3Qn
OyBmdW5jdGlvbiBmKCkgeyArKygxLCBhcmd1bWVudHMpIH0iKTsKIHNob3VsZEJlU3ludGF4RXJy
b3IoIid1c2Ugc3RyaWN0JzsgZnVuY3Rpb24gZigpIHsgKDEsIGFyZ3VtZW50cykrKyB9Iik7CiBz
aG91bGRCZVN5bnRheEVycm9yKCIndXNlIHN0cmljdCc7IGZ1bmN0aW9uIGYoKSB7IC0tKDEsIGFy
Z3VtZW50cykgfSIpOwogc2hvdWxkQmVTeW50YXhFcnJvcigiJ3VzZSBzdHJpY3QnOyBmdW5jdGlv
biBmKCkgeyAoMSwgYXJndW1lbnRzKS0tIH0iKTsKLXNob3VsZEJlU3ludGF4RXJyb3IoIid1c2Ug
c3RyaWN0JzsgaWYgKDApIGRlbGV0ZSArYS5iIik7Ci1zaG91bGRCZVN5bnRheEVycm9yKCIndXNl
IHN0cmljdCc7IGlmICgwKSBkZWxldGUgKythLmIiKTsKLXNob3VsZEJlU3ludGF4RXJyb3IoIid1
c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSB2b2lkIGEuYiIpOworc2hvdWxkTm90QmVTeW50YXhF
cnJvcigiJ3VzZSBzdHJpY3QnOyBpZiAoMCkgZGVsZXRlICthLmIiKTsKK3Nob3VsZE5vdEJlU3lu
dGF4RXJyb3IoIid1c2Ugc3RyaWN0JzsgaWYgKDApIGRlbGV0ZSArK2EuYiIpOworc2hvdWxkTm90
QmVTeW50YXhFcnJvcigiJ3VzZSBzdHJpY3QnOyBpZiAoMCkgZGVsZXRlIHZvaWQgYS5iIik7CiAK
IHNob3VsZEJlVHJ1ZSgiKGZ1bmN0aW9uIChhKXsndXNlIHN0cmljdCc7IGEgPSBmYWxzZTsgcmV0
dXJuIGEgIT09IGFyZ3VtZW50c1swXTsgfSkodHJ1ZSkiKTsKIHNob3VsZEJlVHJ1ZSgiKGZ1bmN0
aW9uIChhKXsndXNlIHN0cmljdCc7IGFyZ3VtZW50c1swXSA9IGZhbHNlOyByZXR1cm4gYSAhPT0g
YXJndW1lbnRzWzBdOyB9KSh0cnVlKSIpOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>