<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190634</bug_id>
          
          <creation_ts>2018-10-16 12:08:37 -0700</creation_ts>
          <short_desc>isASTErroneous in offlineasm should de-macroify before looking for Errors</short_desc>
          <delta_ts>2018-10-17 21:09:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Keith Miller">keith_miller</reporter>
          <assigned_to name="Keith Miller">keith_miller</assigned_to>
          <cc>ews-watchlist</cc>
    
    <cc>fujii</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1469823</commentid>
    <comment_count>0</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-16 12:08:37 -0700</bug_when>
    <thetext>isASTErroneous in offlineasm should de-macroify before looking for Errors</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469826</commentid>
    <comment_count>1</comment_count>
      <attachid>352486</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-16 12:10:13 -0700</bug_when>
    <thetext>Created attachment 352486
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469828</commentid>
    <comment_count>2</comment_count>
      <attachid>352486</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2018-10-16 12:13:13 -0700</bug_when>
    <thetext>Comment on attachment 352486
Patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469833</commentid>
    <comment_count>3</comment_count>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2018-10-16 12:16:31 -0700</bug_when>
    <thetext>Committed r237197: &lt;https://trac.webkit.org/changeset/237197&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469835</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-16 12:17:29 -0700</bug_when>
    <thetext>&lt;rdar://problem/45314169&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470019</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-10-16 20:02:16 -0700</bug_when>
    <thetext>Reverted r237188, r237189, and r237197 for reason:

It breaks WinCairo Debug builds and Release LayoutTests

Committed r237214: &lt;https://trac.webkit.org/changeset/237214&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1470468</commentid>
    <comment_count>6</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-10-17 21:09:17 -0700</bug_when>
    <thetext>Relanded
https://trac.webkit.org/r237219</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>352486</attachid>
            <date>2018-10-16 12:10:13 -0700</date>
            <delta_ts>2018-10-16 12:13:13 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190634-20181016121011.patch</filename>
            <type>text/plain</type>
            <size>2250</size>
            <attacher name="Keith Miller">keith_miller</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3
ZDFlYjBjY2YwZjgzODAxNThjZTlkMmJkZWU4N2RiYzM1ZDc5N2EzLi5lN2M5ZjhjZmU2OTQwNjRi
MWU0NDkwZDkwMGIxNmU3ZWUxMTI4ODc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxOSBAQAorMjAxOC0xMC0xNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl
LmNvbT4KKworICAgICAgICBpc0FTVEVycm9uZW91cyBpbiBvZmZsaW5lYXNtIHNob3VsZCBkZS1t
YWNyb2lmeSBiZWZvcmUgbG9va2luZyBmb3IgRXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBhIG1hY3JvIGlzbid0IHVzYWJsZSBpbiBhIGNv
bmZpZ3VyYXRpb24gaXQgbWlnaHQgc3RpbGwgY2F1c2UgdXMgdG8KKyAgICAgICAgdGhpbmsgdGhl
IGFzdCBpcyBpbnZhbGlkLiBUaGlzIGNoYW5nZSBydW5zIHRoZSBkZS1tYWNyb2lmaWVyIGJlZm9y
ZQorICAgICAgICBsb29raW5nIGZvciBlcnJvcnMuCisKKyAgICAgICAgQWxzbywgaXQgYWRkcyBh
IG1pc3NpbmcgaW5jbHVkZSB0byBQcmludGVyLmguCisKKyAgICAgICAgKiBhc3NlbWJsZXIvUHJp
bnRlci5oOgorICAgICAgICAqIG9mZmxpbmVhc20vc2V0dGluZ3MucmI6CisKIDIwMTgtMTAtMTYg
IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZp
ZXdlZCwgZm9yZ290IHRvIGFkZCB1bnRyYWNrZWQgZmlsZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL1ByaW50ZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9hc3NlbWJsZXIvUHJpbnRlci5oCmluZGV4IDZkNDZjZDllOWYyNDBlNDIwOGU4OWE0NmNkZTBh
YmMyNWIxZjI5OTUuLjMzMThkZmM4ZGI2MWNjNTdhMzI0Njc5YmRiMWNjMTczOTg5MDAwYWUgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvUHJpbnRlci5oCisrKyBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvUHJpbnRlci5oCkBAIC0yNSw2ICsyNSw4
IEBACiAKICNwcmFnbWEgb25jZQogCisjaW5jbHVkZSAiQ1BVLmgiCisKICNpbmNsdWRlIDx3dGYv
UHJpbnRTdHJlYW0uaD4KICNpbmNsdWRlIDx3dGYvU3RyaW5nUHJpbnRTdHJlYW0uaD4KICNpbmNs
dWRlIDx3dGYvVmVjdG9yLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm
bGluZWFzbS9zZXR0aW5ncy5yYiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3Nl
dHRpbmdzLnJiCmluZGV4IDA2NDdjODJiYWU4ZjUzYzIyZmQxMTVhZTI3YTMxMDczZmJhNTM3NDku
LmVmNTcxNDA4Yzk1MjM3YzZkZGE1ZmMwMmU4M2ZiZWNhMWYyMzA5OWIgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NldHRpbmdzLnJiCisrKyBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3NldHRpbmdzLnJiCkBAIC0xNjUsNyArMTY1LDcgQEAg
ZW5kCiAjCiAKIGRlZiBpc0FTVEVycm9uZW91cyhhc3QpCi0gICAgbm90IGFzdC5maWx0ZXIoRXJy
b3IpLmVtcHR5PworICAgIG5vdCBhc3QuZGVtYWNyb2lmeSh7fSkuZmlsdGVyKEVycm9yKS5lbXB0
eT8KIGVuZAogCiAjCkBAIC0yMDMsNyArMjAzLDcgQEAgZGVmIGVtaXRDb2RlSW5Db25maWd1cmF0
aW9uKGNvbmNyZXRlU2V0dGluZ3MsIGFzdCwgYmFja2VuZCkKICAgICBlbmQKICAgICAKICAgICBp
ZiBpc0FTVEVycm9uZW91cyhhc3QpCi0gICAgICAgICRvdXRwdXQucHV0cyAiI2Vycm9yIFwiSW52
YWxpZCBjb25maWd1cmF0aW9uLlwiIgorICAgICAgICAkb3V0cHV0LnB1dHMgIiNlcnJvciBcIklu
dmFsaWQgY29uZmlndXJhdGlvbi4gRXJyb3IgYXQ6ICN7YXN0LmZpbHRlcihFcnJvcilbMF0uY29k
ZU9yaWdpbn1cIiIKICAgICBlbHNpZiBub3QgV09SS0lOR19CQUNLRU5EUy5pbmNsdWRlPyBiYWNr
ZW5kCiAgICAgICAgICRvdXRwdXQucHV0cyAiI2Vycm9yIFwiVGhpcyBiYWNrZW5kIGlzIG5vdCBz
dXBwb3J0ZWQgeWV0LlwiIgogICAgIGVsc2UK
</data>
<flag name="review"
          id="369772"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>