190631 2018-10-16 11:19:24 -0700 [Media] Use nanoseconds as MaximumTimeScale 2018-10-18 19:49:06 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190691 1 aboya aboya commit-queue jer.noble tsavell webkit-bug-importer oldest_to_newest 1469803 0 aboya 2018-10-16 11:19:24 -0700 The current MediaTime::MaximumTimeScale is 0x7fffffff (2^31-1), which is quite undesirable: it's a prime number, so it does not accomodate *any* other timescale without rounding. I propose to use 1e9 (nanosecond timescale) as maximum timescale: it's very close to 2^31 (a bit under 2^30 actually) and it's already being used by both Matroska (WebM) and GStreamer. 1469819 1 jer.noble 2018-10-16 11:56:49 -0700 LGTM. The initial choice of maximum time scale was relatively arbitrary; it's less than 1/2 of the maximum possible value of a uint32_t. 1469869 2 352499 aboya 2018-10-16 13:52:10 -0700 Created attachment 352499 Patch 1469928 3 352499 commit-queue 2018-10-16 16:18:16 -0700 Comment on attachment 352499 Patch Clearing flags on attachment: 352499 Committed r237208: <https://trac.webkit.org/changeset/237208> 1469929 4 commit-queue 2018-10-16 16:18:17 -0700 All reviewed patches have been landed. Closing bug. 1469930 5 webkit-bug-importer 2018-10-16 16:19:22 -0700 <rdar://problem/45322286> 1470109 6 tsavell 2018-10-17 08:45:54 -0700 The change made in https://trac.webkit.org/changeset/237208/webkit to TestWTF.WTF.MediaTime has caused it to fail constantly on all systems. Log: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/6021/steps/run-api-tests/logs/stdio Build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK1%20(Tests)/builds/6021 1470112 7 tsavell 2018-10-17 08:47:40 -0700 Linked wrong build. Correct build: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/8636 1470123 8 jer.noble 2018-10-17 09:22:42 -0700 Looks like these tests need rebaselining. 1470321 9 tsavell 2018-10-17 13:53:45 -0700 Can this be fixed today? 1470369 10 commit-queue 2018-10-17 15:51:19 -0700 Re-opened since this is blocked by bug 190691 1470404 11 aboya 2018-10-17 17:18:47 -0700 Yes, the tests need a rebaseline indeed. 1470470 12 352683 aboya 2018-10-17 21:26:01 -0700 Created attachment 352683 Patch 1470770 13 352683 commit-queue 2018-10-18 19:49:05 -0700 Comment on attachment 352683 Patch Clearing flags on attachment: 352683 Committed r237278: <https://trac.webkit.org/changeset/237278> 1470771 14 commit-queue 2018-10-18 19:49:06 -0700 All reviewed patches have been landed. Closing bug. 352499 2018-10-16 13:52:10 -0700 2018-10-17 21:26:00 -0700 Patch bug-190631-20181016135209.patch text/plain 1501 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk1M2JhZmU5MmEzM2U2OWU1N2IwZjQ0 ZTY5MWMyZjE2ZWUwMTFjMDIuLmU4YmM4MzY2Y2YzMDBkMGY4ZWJjMzVkNDc2OGQ1MzcxNjJhZDg2 NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTAtMTYgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtNZWRpYV0gVXNlIG5hbm9zZWNvbmRzIGFz IE1heGltdW1UaW1lU2NhbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MDYzMQorCisgICAgICAgIDFlOSBpcyBhIG11Y2ggbW9yZSB1c2VmdWwgdGlt ZXNjYWxlIHRoYW4gdGhlIHByZXZpb3VzIG9uZSAyXjMxLTEuCisgICAgICAgIFVubGlrZSAyXjMx LTEsIHdoaWNoIGlzIGEgcHJpbWUgbnVtYmVyLCBuYW5vc2Vjb25kIHNjYWxlIGlzIHByZXR0eQor ICAgICAgICBjb21tb24gYW1vbmcgc29tZSBmb3JtYXRzIGxpa2UgV2ViTSBhbmQgZnJhbWV3b3Jr cyBsaWtlIEdTdHJlYW1lcgorICAgICAgICB3aGVyZSBiYXNlIDEwIHRpbWVzY2FsZSBpcyBjb21t b24uLi4gYW5kIGl0J3MgdGhvc2UgYmlnIHRpbWVzY2FsZXMgdGhlCisgICAgICAgIG9uZXMgdGhh dCBhcmUgdXN1YWxseSBzY2FsZWQgdXAgdG8gTWF4aW11bVRpbWVTY2FsZS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9NZWRpYVRpbWUuY3Bw OgorCiAyMDE4LTA5LTI1ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIENoYW5nZSBmcm9tIEhBVkUoQ0ZORVRXT1JLX1NUT1JBR0VfUEFSVElUSU9OSU5HKSB0 byBFTkFCTEUoUkVTT1VSQ0VfTE9BRF9TVEFUSVNUSUNTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvTWVkaWFUaW1lLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXgg Y2JhOTY5YWI1ODgxNTMwMGE3NWRkNDE0NjUyN2M0Zjg3Nzg4MDMwMS4uMWZjOGUwNWIzOGQ0NWJj NTQzNzZlNTM4N2E5ODYzMjIyN2Q0OWQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVk aWFUaW1lLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC02MSw3ICs2 MSw3IEBAIHN0YXRpYyBpbnQ2NF90IHNpZ251bShpbnQ2NF90IHZhbCkKICAgICByZXR1cm4gKDAg PCB2YWwpIC0gKHZhbCA8IDApOwogfQogCi1jb25zdCB1aW50MzJfdCBNZWRpYVRpbWU6Ok1heGlt dW1UaW1lU2NhbGUgPSAweDdmZmZmZmZmTDsKK2NvbnN0IHVpbnQzMl90IE1lZGlhVGltZTo6TWF4 aW11bVRpbWVTY2FsZSA9IDEwMDAwMDAwMDA7CiAKIE1lZGlhVGltZTo6TWVkaWFUaW1lKCkKICAg ICA6IG1fdGltZVZhbHVlKDApCg== 352683 2018-10-17 21:26:01 -0700 2018-10-18 19:49:05 -0700 Patch bug-190631-20181017212600.patch text/plain 5112 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk1M2JhZmU5MmEzM2U2OWU1N2IwZjQ0 ZTY5MWMyZjE2ZWUwMTFjMDIuLmU4YmM4MzY2Y2YzMDBkMGY4ZWJjMzVkNDc2OGQ1MzcxNjJhZDg2 NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMTAtMTYgIEFsaWNpYSBCb3lhIEdhcmPDrWEg IDxhYm95YUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtNZWRpYV0gVXNlIG5hbm9zZWNvbmRzIGFz IE1heGltdW1UaW1lU2NhbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MDYzMQorCisgICAgICAgIDFlOSBpcyBhIG11Y2ggbW9yZSB1c2VmdWwgdGlt ZXNjYWxlIHRoYW4gdGhlIHByZXZpb3VzIG9uZSAyXjMxLTEuCisgICAgICAgIFVubGlrZSAyXjMx LTEsIHdoaWNoIGlzIGEgcHJpbWUgbnVtYmVyLCBuYW5vc2Vjb25kIHNjYWxlIGlzIHByZXR0eQor ICAgICAgICBjb21tb24gYW1vbmcgc29tZSBmb3JtYXRzIGxpa2UgV2ViTSBhbmQgZnJhbWV3b3Jr cyBsaWtlIEdTdHJlYW1lcgorICAgICAgICB3aGVyZSBiYXNlIDEwIHRpbWVzY2FsZSBpcyBjb21t b24uLi4gYW5kIGl0J3MgdGhvc2UgYmlnIHRpbWVzY2FsZXMgdGhlCisgICAgICAgIG9uZXMgdGhh dCBhcmUgdXN1YWxseSBzY2FsZWQgdXAgdG8gTWF4aW11bVRpbWVTY2FsZS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9NZWRpYVRpbWUuY3Bw OgorCiAyMDE4LTA5LTI1ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIENoYW5nZSBmcm9tIEhBVkUoQ0ZORVRXT1JLX1NUT1JBR0VfUEFSVElUSU9OSU5HKSB0 byBFTkFCTEUoUkVTT1VSQ0VfTE9BRF9TVEFUSVNUSUNTKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dU Ri93dGYvTWVkaWFUaW1lLmNwcCBiL1NvdXJjZS9XVEYvd3RmL01lZGlhVGltZS5jcHAKaW5kZXgg Y2JhOTY5YWI1ODgxNTMwMGE3NWRkNDE0NjUyN2M0Zjg3Nzg4MDMwMS4uMWZjOGUwNWIzOGQ0NWJj NTQzNzZlNTM4N2E5ODYzMjIyN2Q0OWQ4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVk aWFUaW1lLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9NZWRpYVRpbWUuY3BwCkBAIC02MSw3ICs2 MSw3IEBAIHN0YXRpYyBpbnQ2NF90IHNpZ251bShpbnQ2NF90IHZhbCkKICAgICByZXR1cm4gKDAg PCB2YWwpIC0gKHZhbCA8IDApOwogfQogCi1jb25zdCB1aW50MzJfdCBNZWRpYVRpbWU6Ok1heGlt dW1UaW1lU2NhbGUgPSAweDdmZmZmZmZmTDsKK2NvbnN0IHVpbnQzMl90IE1lZGlhVGltZTo6TWF4 aW11bVRpbWVTY2FsZSA9IDEwMDAwMDAwMDA7CiAKIE1lZGlhVGltZTo6TWVkaWFUaW1lKCkKICAg ICA6IG1fdGltZVZhbHVlKDApCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggMzVkYzFhYjliNWQ1N2VlOGM4YTcwNmZjZjhlNTk2OTA3ZTQ4MGNiZi4u NmRiN2M3M2JkMmFmOTRiMGYzNzZlNTFkMjVjNTFlY2RjNTkzNzk1NyAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4 LTEwLTE3ICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAg ICBbTWVkaWFdIFVzZSBuYW5vc2Vjb25kcyBhcyBNYXhpbXVtVGltZVNjYWxlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA2MzEKKworICAgICAgICBS ZWJhc2VkIE1lZGlhVGltZSB0ZXN0cyBjb3ZlcmluZyB0aW1lc2NhbGVzIG92ZXIgdGhlIG1heGlt dW0uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6VEVTVCk6CisKIDIwMTgtMDktMjUgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbV2ViQXV0aE5dIE1ha2UgQXV0aGVudGljYXRvck1hbmFnZXIKZGlm ZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01lZGlhVGltZS5jcHAgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NZWRpYVRpbWUuY3BwCmluZGV4IGQxZWM4MTNl NjI0YmRhNzMxOTU0YTAxOWUzNGE2YjI3NTRmNTljMWYuLmM1NGIyZjYzMDkzNzM5ZGFlZTNkMmMx ZTc3YmU3ZGE1NmFjMDFiMDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL01lZGlhVGltZS5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWVk aWFUaW1lLmNwcApAQCAtMTEzLDcgKzExMyw3IEBAIFRFU1QoV1RGLCBNZWRpYVRpbWUpCiAgICAg RVhQRUNUX0VRKE1lZGlhVGltZTo6aW5kZWZpbml0ZVRpbWUoKSArIE1lZGlhVGltZSgxLCAxKSwg TWVkaWFUaW1lOjppbmRlZmluaXRlVGltZSgpKTsKICAgICBFWFBFQ1RfRVEoTWVkaWFUaW1lKDEs IDEpICsgTWVkaWFUaW1lKDEsIDEpLCBNZWRpYVRpbWUoMiwgMSkpOwogICAgIEVYUEVDVF9FUShN ZWRpYVRpbWUoMSwgMikgKyBNZWRpYVRpbWUoMSwgMyksIE1lZGlhVGltZSg1LCA2KSk7Ci0gICAg RVhQRUNUX0VRKE1lZGlhVGltZSgxLCBudW1lcmljX2xpbWl0czxpbnQzMl90Pjo6bWF4KCktMSkg KyBNZWRpYVRpbWUoMSwgbnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1heCgpLTIpLCBNZWRpYVRp bWUoMiwgbnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1heCgpKSk7CisgICAgRVhQRUNUX0VRKE1l ZGlhVGltZSgxLCBNZWRpYVRpbWU6Ok1heGltdW1UaW1lU2NhbGUgLSAxKSArIE1lZGlhVGltZSgx LCBNZWRpYVRpbWU6Ok1heGltdW1UaW1lU2NhbGUgLSAyKSwgTWVkaWFUaW1lKDIsIE1lZGlhVGlt ZTo6TWF4aW11bVRpbWVTY2FsZSkpOwogCiAgICAgLy8gU3VidHJhY3Rpb24gT3BlcmF0b3JzCiAg ICAgRVhQRUNUX0VRKE1lZGlhVGltZTo6cG9zaXRpdmVJbmZpbml0ZVRpbWUoKSAtIE1lZGlhVGlt ZTo6cG9zaXRpdmVJbmZpbml0ZVRpbWUoKSwgTWVkaWFUaW1lOjppbnZhbGlkVGltZSgpKTsKQEAg LTEzNCw3ICsxMzQsNyBAQCBURVNUKFdURiwgTWVkaWFUaW1lKQogICAgIEVYUEVDVF9FUShNZWRp YVRpbWU6OmluZGVmaW5pdGVUaW1lKCkgLSBNZWRpYVRpbWUoMSwgMSksIE1lZGlhVGltZTo6aW5k ZWZpbml0ZVRpbWUoKSk7CiAgICAgRVhQRUNUX0VRKE1lZGlhVGltZSgzLCAxKSAtIE1lZGlhVGlt ZSgyLCAxKSwgTWVkaWFUaW1lKDEsIDEpKTsKICAgICBFWFBFQ1RfRVEoTWVkaWFUaW1lKDEsIDIp IC0gTWVkaWFUaW1lKDEsIDMpLCBNZWRpYVRpbWUoMSwgNikpOwotICAgIEVYUEVDVF9FUShNZWRp YVRpbWUoMiwgbnVtZXJpY19saW1pdHM8aW50MzJfdD46Om1heCgpLTEpIC0gTWVkaWFUaW1lKDEs IG51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptYXgoKS0yKSwgTWVkaWFUaW1lKDEsIG51bWVyaWNf bGltaXRzPGludDMyX3Q+OjptYXgoKSkpOworICAgIEVYUEVDVF9FUShNZWRpYVRpbWUoMiwgTWVk aWFUaW1lOjpNYXhpbXVtVGltZVNjYWxlIC0gMSkgLSBNZWRpYVRpbWUoMSwgTWVkaWFUaW1lOjpN YXhpbXVtVGltZVNjYWxlIC0gMiksIE1lZGlhVGltZSgxLCBNZWRpYVRpbWU6Ok1heGltdW1UaW1l U2NhbGUpKTsKIAogICAgIC8vIE11bHRpcGxpY2F0aW9uIE9wZXJhdG9ycwogICAgIEVYUEVDVF9F UShNZWRpYVRpbWU6OnBvc2l0aXZlSW5maW5pdGVUaW1lKCksIE1lZGlhVGltZTo6cG9zaXRpdmVJ bmZpbml0ZVRpbWUoKSAqIDIpOwpAQCAtMjk5LDkgKzI5OSw5IEBAIFRFU1QoV1RGLCBNZWRpYVRp bWUpCiAgICAgaW50NjRfdCBtYXhJbnQzMiA9IG51bWVyaWNfbGltaXRzPGludDMyX3Q+OjptYXgo KTsKICAgICBFWFBFQ1RfRVEoTWVkaWFUaW1lKG1heEludDMyICogMiwgMSkudG9UaW1lU2NhbGUo MikudGltZVZhbHVlKCksIG1heEludDMyICogNCk7CiAgICAgaW50NjRfdCBiaWdJbnQgPSAxTEwg PDwgNjI7Ci0gICAgRVhQRUNUX0VRKE1lZGlhVGltZShiaWdJbnQsIDFVIDw8IDMxKS50b1RpbWVT Y2FsZSgxVSA8PCAzMCkudGltZVZhbHVlKCksIGJpZ0ludCAvIDIpOwotICAgIEVYUEVDVF9FUShN ZWRpYVRpbWUoYmlnSW50ICsgMSwgMVUgPDwgMzEpLnRvVGltZVNjYWxlKDFVIDw8IDMwLCBNZWRp YVRpbWU6OlJvdW5kaW5nRmxhZ3M6OlRvd2FyZFplcm8pLnRpbWVWYWx1ZSgpLCBiaWdJbnQgLyAy KTsKLSAgICBFWFBFQ1RfRVEoTWVkaWFUaW1lKGJpZ0ludCArIDEsIDFVIDw8IDMxKS50b1RpbWVT Y2FsZSgxVSA8PCAzMCkuaGFzQmVlblJvdW5kZWQoKSwgdHJ1ZSk7CisgICAgRVhQRUNUX0VRKE1l ZGlhVGltZShiaWdJbnQsIDFVIDw8IDMxKS50b1RpbWVTY2FsZSgxVSA8PCAyOSkudGltZVZhbHVl KCksIGJpZ0ludCAvIDQpOworICAgIEVYUEVDVF9FUShNZWRpYVRpbWUoYmlnSW50ICsgMSwgMVUg PDwgMzEpLnRvVGltZVNjYWxlKDFVIDw8IDI5LCBNZWRpYVRpbWU6OlJvdW5kaW5nRmxhZ3M6OlRv d2FyZFplcm8pLnRpbWVWYWx1ZSgpLCBiaWdJbnQgLyA0KTsKKyAgICBFWFBFQ1RfRVEoTWVkaWFU aW1lKGJpZ0ludCArIDEsIDFVIDw8IDMxKS50b1RpbWVTY2FsZSgxVSA8PCAyOSkuaGFzQmVlblJv dW5kZWQoKSwgdHJ1ZSk7CiAgICAgRVhQRUNUX0VRKE1lZGlhVGltZShiaWdJbnQgLSAyLCBNZWRp YVRpbWU6Ok1heGltdW1UaW1lU2NhbGUpLnRvVGltZVNjYWxlKE1lZGlhVGltZTo6TWF4aW11bVRp bWVTY2FsZSAtIDEpLmhhc0JlZW5Sb3VuZGVkKCksIHRydWUpOwogICAgIEVYUEVDVF9FUShNZWRp YVRpbWUoYmlnSW50LCAxKS50b1RpbWVTY2FsZShNZWRpYVRpbWU6Ok1heGltdW1UaW1lU2NhbGUp LCBNZWRpYVRpbWU6OnBvc2l0aXZlSW5maW5pdGVUaW1lKCkpOwogICAgIEVYUEVDVF9FUShNZWRp YVRpbWUoLWJpZ0ludCwgMSkudG9UaW1lU2NhbGUoTWVkaWFUaW1lOjpNYXhpbXVtVGltZVNjYWxl KSwgTWVkaWFUaW1lOjpuZWdhdGl2ZUluZmluaXRlVGltZSgpKTsK