190623 2018-10-16 09:49:40 -0700 [GLib] Build error with RemoteInspector disabled 2018-10-16 10:54:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand berto bugs-noreply cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1469753 0 pnormand 2018-10-16 09:49:40 -0700 build-webkit --gtk --cmakeargs="-DENABLE_REMOTE_INSPECTOR=OFF" In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35: ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:115: error: ‘RemoteInspector’ in namespace ‘Inspector’ does not name a type WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~~~~~~~~~~~~~~ In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35: ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected unqualified-id before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~ ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected ‘)’ before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ~ ^~ ) ../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected initializer before ‘::’ token WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&); ^~ [1562/1986] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource30.cpp.o 1469759 1 352468 pnormand 2018-10-16 10:03:48 -0700 Created attachment 352468 Patch 1469760 2 ews-watchlist 2018-10-16 10:05:41 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1469790 3 pnormand 2018-10-16 10:54:27 -0700 Committed r237191: <https://trac.webkit.org/changeset/237191> 352468 2018-10-16 10:03:48 -0700 2018-10-16 10:18:31 -0700 Patch bug-190623-20181016180347.patch text/plain 3969 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFkN2UxOTIwM2YxMDA5YWFm ZTg0MmVkYjZmN2FkMTg1ZjMxNGY5M2UuLjEyMzk0M2MwOGZkY2EwZWUyZjM3NWY0NWUxZmI2ODY0 MjNmODEzODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMTYgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHTGliXSBCdWlsZCBl cnJvciB3aXRoIFJlbW90ZUluc3BlY3RvciBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tcGlsYXRpb24gZ3VhcmRzIGFkZGVkIHRvIGVu c3VyZSB0aGUgYnVpbGQgc3RpbGwgd29ya3Mgd2hlbiB0aGUKKyAgICAgICAgUmVtb3RlIFdlYklu c3BlY3RvciBoYXMgYmVlbiBkaXNhYmxlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xp Yi9XZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbi5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdEF1dG9tYXRpb25TZXNzaW9uUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHA6CisKIDIwMTgtMTAtMTYgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXBsYWNlIEhpc3Rv cnlJdGVtKiB3aXRoIEhpc3RvcnlJdGVtJiB3aGVyZSBwb3NzaWJsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0QXV0b21hdGlvblNlc3Npb24uY3Bw IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0QXV0b21hdGlvblNlc3Np b24uY3BwCmluZGV4IDdlYjk1ZTkyOThmOTA4ODUxN2E3ZmQwOTExMDAxYjQ2MDM4ZDZiN2QuLjI5 ODMzOWVlNTMyNTMxYmUwOTc3ZTY0OWVjMTI5NzY3NjQ1N2E4OWIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdEF1dG9tYXRpb25TZXNzaW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRBdXRvbWF0aW9uU2Vz c2lvbi5jcHAKQEAgLTg0LDcgKzg0LDkgQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgZGlkRGlzY29u bmVjdEZyb21SZW1vdGUoV2ViQXV0b21hdGlvblNlc3Npb24mKSBvdmVycmlkZQogICAgIHsKKyNp ZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKICAgICAgICAgd2Via2l0V2ViQ29udGV4dFdpbGxD bG9zZUF1dG9tYXRpb25TZXNzaW9uKG1fc2Vzc2lvbi0+cHJpdi0+d2ViQ29udGV4dCk7CisjZW5k aWYKICAgICB9CiAKICAgICB2b2lkIHJlcXVlc3ROZXdQYWdlV2l0aE9wdGlvbnMoV2ViQXV0b21h dGlvblNlc3Npb24mLCBBUEk6OkF1dG9tYXRpb25TZXNzaW9uQnJvd3NpbmdDb250ZXh0T3B0aW9u cywgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChXZWJQYWdlUHJveHkqKT4mJiBjb21wbGV0aW9uSGFu ZGxlcikgb3ZlcnJpZGUKQEAgLTI4OCw2ICsyOTAsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfYXV0 b21hdGlvbl9zZXNzaW9uX2NsYXNzX2luaXQoV2ViS2l0QXV0b21hdGlvblNlc3Npb25DbGFzcyog cwogICAgICAgICBHX1RZUEVfTk9ORSk7CiB9CiAKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RP UikKIFdlYktpdEF1dG9tYXRpb25TZXNzaW9uKiB3ZWJraXRBdXRvbWF0aW9uU2Vzc2lvbkNyZWF0 ZShXZWJLaXRXZWJDb250ZXh0KiB3ZWJDb250ZXh0LCBjb25zdCBjaGFyKiBzZXNzaW9uSUQsIGNv bnN0IEluc3BlY3Rvcjo6UmVtb3RlSW5zcGVjdG9yOjpDbGllbnQ6OlNlc3Npb25DYXBhYmlsaXRp ZXMmIGNhcGFiaWxpdGllcykKIHsKICAgICBhdXRvKiBzZXNzaW9uID0gV0VCS0lUX0FVVE9NQVRJ T05fU0VTU0lPTihnX29iamVjdF9uZXcoV0VCS0lUX1RZUEVfQVVUT01BVElPTl9TRVNTSU9OLCAi aWQiLCBzZXNzaW9uSUQsIG51bGxwdHIpKTsKQEAgLTMwMSw2ICszMDQsNyBAQCBXZWJLaXRBdXRv bWF0aW9uU2Vzc2lvbiogd2Via2l0QXV0b21hdGlvblNlc3Npb25DcmVhdGUoV2ViS2l0V2ViQ29u dGV4dCogd2ViQ29udAogICAgIH0KICAgICByZXR1cm4gc2Vzc2lvbjsKIH0KKyNlbmRpZgogCiBX ZWJBdXRvbWF0aW9uU2Vzc2lvbiYgd2Via2l0QXV0b21hdGlvblNlc3Npb25HZXRTZXNzaW9uKFdl YktpdEF1dG9tYXRpb25TZXNzaW9uKiBzZXNzaW9uKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0QXV0b21hdGlvblNlc3Npb25Qcml2YXRlLmgg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRBdXRvbWF0aW9uU2Vzc2lv blByaXZhdGUuaAppbmRleCBiNDhjZjcwNGI1ZmJmYWRlODhlN2VhOTg4NTFhZDQ3N2VhNGZlZDg1 Li44OGMzMjE1MGMyZmM4YmJjMmY4NmYxYjZiMjRjZWU1OTc3MjhlMDQxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRBdXRvbWF0aW9uU2Vzc2lvblBy aXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRBdXRv bWF0aW9uU2Vzc2lvblByaXZhdGUuaApAQCAtMjQsNyArMjQsMTAgQEAKICNpbmNsdWRlICJXZWJL aXRXZWJDb250ZXh0LmgiCiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvUmVtb3RlSW5zcGVjdG9y Lmg+CiAKKyNpZiBFTkFCTEUoUkVNT1RFX0lOU1BFQ1RPUikKIFdlYktpdEF1dG9tYXRpb25TZXNz aW9uKiB3ZWJraXRBdXRvbWF0aW9uU2Vzc2lvbkNyZWF0ZShXZWJLaXRXZWJDb250ZXh0KiwgY29u c3QgY2hhciogc2Vzc2lvbklELCBjb25zdCBJbnNwZWN0b3I6OlJlbW90ZUluc3BlY3Rvcjo6Q2xp ZW50OjpTZXNzaW9uQ2FwYWJpbGl0aWVzJik7CisjZW5kaWYKKwogV2ViS2l0OjpXZWJBdXRvbWF0 aW9uU2Vzc2lvbiYgd2Via2l0QXV0b21hdGlvblNlc3Npb25HZXRTZXNzaW9uKFdlYktpdEF1dG9t YXRpb25TZXNzaW9uKik7CiBTdHJpbmcgd2Via2l0QXV0b21hdGlvblNlc3Npb25HZXRCcm93c2Vy TmFtZShXZWJLaXRBdXRvbWF0aW9uU2Vzc2lvbiopOwogU3RyaW5nIHdlYmtpdEF1dG9tYXRpb25T ZXNzaW9uR2V0QnJvd3NlclZlcnNpb24oV2ViS2l0QXV0b21hdGlvblNlc3Npb24qKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1JlbW90ZVdlYkluc3BlY3RvclByb3h5LmNwcApp bmRleCBkODJlNTgyZTFjYjdmOTA1NjFlMjNmOGJiNjg1MzA1NTgxZWRjZjAyLi42ZjFlNDA3MTBh YWJjZDA1YjI4MTBhOWQ3N2U2MDlmM2NhZmI4NWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHkuY3BwCkBAIC0xNDgsNyArMTQ4LDcg QEAgdm9pZCBSZW1vdGVXZWJJbnNwZWN0b3JQcm94eTo6Y2xvc2VGcm9udGVuZFBhZ2VBbmRXaW5k b3coKQogICAgIHBsYXRmb3JtQ2xvc2VGcm9udGVuZFBhZ2VBbmRXaW5kb3coKTsKIH0KIAotI2lm ICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShHVEspCisjaWYgIUVOQUJMRShSRU1PVEVfSU5T UEVDVE9SKSB8fCAoIVBMQVRGT1JNKE1BQykgJiYgIVBMQVRGT1JNKEdUSykpCiBXZWJQYWdlUHJv eHkqIFJlbW90ZVdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUNyZWF0ZUZyb250ZW5kUGFnZUFu ZFdpbmRvdygpCiB7CiAgICAgbm90SW1wbGVtZW50ZWQoKTsK