190585 2018-10-15 09:11:02 -0700 Share some code to dirty z-order and normal flow lists when child layers are added or removed 2018-10-15 10:52:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1469263 0 simon.fraser 2018-10-15 09:11:02 -0700 Share some code to dirty z-order and normal flow lists when child layers are added or removed 1469264 1 352329 simon.fraser 2018-10-15 09:12:07 -0700 Created attachment 352329 Patch 1469276 2 352329 zalan 2018-10-15 09:26:39 -0700 Comment on attachment 352329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352329&action=review > Source/WebCore/rendering/RenderLayer.cpp:454 > + if (!child.isNormalFlowOnly() || child.firstChild()) { child.isNormalFlowOnly is always false here. 1469326 3 simon.fraser 2018-10-15 10:51:22 -0700 https://trac.webkit.org/changeset/237123/webkit 1469330 4 webkit-bug-importer 2018-10-15 10:52:39 -0700 <rdar://problem/45276600> 352329 2018-10-15 09:12:07 -0700 2018-10-15 09:26:39 -0700 Patch bug-190585-20181015091206.patch text/plain 4513 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTcwZTUzOWEzMmRjMzA3 MDdiNzE2NDgwZTU2Njk3NGI1NGY5MDRiZC4uMmIzZjFhM2IzMjhkMWMwNjg3MDgyNzM5M2RjZDVi ODE5YmVjYzAxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNoYXJlIHNvbWUg Y29kZSB0byBkaXJ0eSB6LW9yZGVyIGFuZCBub3JtYWwgZmxvdyBsaXN0cyB3aGVuIGNoaWxkIGxh eWVycyBhcmUgYWRkZWQgb3IgcmVtb3ZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNTg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRmFjdG9yIGNvZGUgd2hpY2ggZGlydGllcyB0aGUgbm9ybWFsIGZs b3cgbGlzdCBhbmQgY2hpbGQgc3RhY2tpbmcgY29udGV4dCB6LW9yZGVyIGxpc3RzCisgICAgICAg IHdoZW4gYSBsYXllciBpcyBhZGRlZCBvciByZW1vdmVkLgorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjphZGRDaGls ZCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cmVtb3ZlQ2hpbGQpOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmRpcnR5UGFpbnRPcmRlckxpc3RzT25DaGlsZENoYW5n ZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisKIDIwMTgtMTAtMTUgIFNp bW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBhIGhl bHBlciBmdW5jdGlvbiB0byBjaGVjayBmb3IgcmVmbGVjdGlvbiBsYXllcnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDhhZmEyZTU1YjlhNGZlYzAyOWJmMDU1 NmI4ZGQxMDY0Njc3NTZmMjUuLjEzMTY2ZWFjMzQ3NzJhYmNlOTgzNDVkYTE4MmYxZjNhZTQ5YmM1 ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMzk0LDE1 ICszOTQsNyBAQCB2b2lkIFJlbmRlckxheWVyOjphZGRDaGlsZChSZW5kZXJMYXllciYgY2hpbGQs IFJlbmRlckxheWVyKiBiZWZvcmVDaGlsZCkKIAogICAgIGNoaWxkLnNldFBhcmVudCh0aGlzKTsK IAotICAgIGlmIChjaGlsZC5pc05vcm1hbEZsb3dPbmx5KCkpCi0gICAgICAgIGRpcnR5Tm9ybWFs Rmxvd0xpc3QoKTsKLQotICAgIGlmICghY2hpbGQuaXNOb3JtYWxGbG93T25seSgpIHx8IGNoaWxk LmZpcnN0Q2hpbGQoKSkgewotICAgICAgICAvLyBEaXJ0eSB0aGUgei1vcmRlciBsaXN0IGluIHdo aWNoIHdlIGFyZSBjb250YWluZWQuIFRoZSBzdGFja2luZ0NvbnRleHQoKSBjYW4gYmUgbnVsbCBp biB0aGUKLSAgICAgICAgLy8gY2FzZSB3aGVyZSB3ZSdyZSBidWlsZGluZyB1cCBnZW5lcmF0ZWQg Y29udGVudCBsYXllcnMuIFRoaXMgaXMgb2ssIHNpbmNlIHRoZSBsaXN0cyB3aWxsIHN0YXJ0Ci0g ICAgICAgIC8vIG9mZiBkaXJ0eSBpbiB0aGF0IGNhc2UgYW55d2F5LgotICAgICAgICBjaGlsZC5k aXJ0eVN0YWNraW5nQ29udGV4dFpPcmRlckxpc3RzKCk7Ci0gICAgfQorICAgIGRpcnR5UGFpbnRP cmRlckxpc3RzT25DaGlsZENoYW5nZShjaGlsZCk7CiAKICAgICBjaGlsZC51cGRhdGVEZXNjZW5k YW50RGVwZW5kZW50RmxhZ3MoKTsKICAgICBpZiAoY2hpbGQubV9oYXNWaXNpYmxlQ29udGVudCB8 fCBjaGlsZC5tX2hhc1Zpc2libGVEZXNjZW5kYW50KQpAQCAtNDEzLDcgKzQwNSw3IEBAIHZvaWQg UmVuZGVyTGF5ZXI6OmFkZENoaWxkKFJlbmRlckxheWVyJiBjaGlsZCwgUmVuZGVyTGF5ZXIqIGJl Zm9yZUNoaWxkKQogCiAjaWYgRU5BQkxFKENTU19DT01QT1NJVElORykKICAgICBpZiAoY2hpbGQu aGFzQmxlbmRNb2RlKCkgfHwgKGNoaWxkLmhhc05vdElzb2xhdGVkQmxlbmRpbmdEZXNjZW5kYW50 cygpICYmICFjaGlsZC5pc29sYXRlc0JsZW5kaW5nKCkpKQotICAgICAgICB1cGRhdGVBbmNlc3Rv ckNoYWluSGFzQmxlbmRpbmdEZXNjZW5kYW50cygpOworICAgICAgICB1cGRhdGVBbmNlc3RvckNo YWluSGFzQmxlbmRpbmdEZXNjZW5kYW50cygpOyAvLyBXaHkgbm90IGp1c3QgZGlydHk/CiAjZW5k aWYKIAogICAgIGNvbXBvc2l0b3IoKS5sYXllcldhc0FkZGVkKCp0aGlzLCBjaGlsZCk7CkBAIC00 MzUsMTQgKzQyNyw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnJlbW92ZUNoaWxkKFJlbmRlckxheWVy JiBvbGRDaGlsZCkKICAgICBpZiAobV9sYXN0ID09ICZvbGRDaGlsZCkKICAgICAgICAgbV9sYXN0 ID0gb2xkQ2hpbGQucHJldmlvdXNTaWJsaW5nKCk7CiAKLSAgICBpZiAob2xkQ2hpbGQuaXNOb3Jt YWxGbG93T25seSgpKQotICAgICAgICBkaXJ0eU5vcm1hbEZsb3dMaXN0KCk7Ci0gICAgaWYgKCFv bGRDaGlsZC5pc05vcm1hbEZsb3dPbmx5KCkgfHwgb2xkQ2hpbGQuZmlyc3RDaGlsZCgpKSB7Ci0g ICAgICAgIC8vIERpcnR5IHRoZSB6LW9yZGVyIGxpc3QgaW4gd2hpY2ggd2UgYXJlIGNvbnRhaW5l ZC4gV2hlbiBjYWxsZWQgdmlhIHRoZQotICAgICAgICAvLyByZWF0dGFjaG1lbnQgcHJvY2VzcyBp biByZW1vdmVPbmx5VGhpc0xheWVyLCB0aGUgbGF5ZXIgbWF5IGFscmVhZHkgYmUgZGlzY29ubmVj dGVkCi0gICAgICAgIC8vIGZyb20gdGhlIG1haW4gbGF5ZXIgdHJlZSwgc28gd2UgbmVlZCB0byBu dWxsLWNoZWNrIHRoZSB8c3RhY2tpbmdDb250ZXh0fCB2YWx1ZS4KLSAgICAgICAgb2xkQ2hpbGQu ZGlydHlTdGFja2luZ0NvbnRleHRaT3JkZXJMaXN0cygpOwotICAgIH0KKyAgICBkaXJ0eVBhaW50 T3JkZXJMaXN0c09uQ2hpbGRDaGFuZ2Uob2xkQ2hpbGQpOwogCiAgICAgb2xkQ2hpbGQuc2V0UHJl dmlvdXNTaWJsaW5nKG51bGxwdHIpOwogICAgIG9sZENoaWxkLnNldE5leHRTaWJsaW5nKG51bGxw dHIpOwpAQCAtNDYxLDYgKzQ0NiwxOSBAQCB2b2lkIFJlbmRlckxheWVyOjpyZW1vdmVDaGlsZChS ZW5kZXJMYXllciYgb2xkQ2hpbGQpCiAjZW5kaWYKIH0KIAordm9pZCBSZW5kZXJMYXllcjo6ZGly dHlQYWludE9yZGVyTGlzdHNPbkNoaWxkQ2hhbmdlKFJlbmRlckxheWVyJiBjaGlsZCkKK3sKKyAg ICBpZiAoY2hpbGQuaXNOb3JtYWxGbG93T25seSgpKQorICAgICAgICBkaXJ0eU5vcm1hbEZsb3dM aXN0KCk7CisKKyAgICBpZiAoIWNoaWxkLmlzTm9ybWFsRmxvd09ubHkoKSB8fCBjaGlsZC5maXJz dENoaWxkKCkpIHsKKyAgICAgICAgLy8gRGlydHkgdGhlIHotb3JkZXIgbGlzdCBpbiB3aGljaCB3 ZSBhcmUgY29udGFpbmVkLiBUaGUgc3RhY2tpbmdDb250ZXh0KCkgY2FuIGJlIG51bGwgaW4gdGhl CisgICAgICAgIC8vIGNhc2Ugd2hlcmUgd2UncmUgYnVpbGRpbmcgdXAgZ2VuZXJhdGVkIGNvbnRl bnQgbGF5ZXJzLiBUaGlzIGlzIG9rLCBzaW5jZSB0aGUgbGlzdHMgd2lsbCBzdGFydAorICAgICAg ICAvLyBvZmYgZGlydHkgaW4gdGhhdCBjYXNlIGFueXdheS4KKyAgICAgICAgY2hpbGQuZGlydHlT dGFja2luZ0NvbnRleHRaT3JkZXJMaXN0cygpOworICAgIH0KK30KKwogdm9pZCBSZW5kZXJMYXll cjo6aW5zZXJ0T25seVRoaXNMYXllcigpCiB7CiAgICAgaWYgKCFtX3BhcmVudCAmJiByZW5kZXJl cigpLnBhcmVudCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4 IDkwODNhZmFjMzc4ZDhkMTFlMmQ4YTVlYTg4YjkyMTUwNmRhOTdiNTQuLmRhYTU1OGQzYjJjOWU5 NDZmZGE1ZWE4ODAwYjlkZTM3ZTRkZTAxYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllci5oCkBAIC03NDUsNiArNzQ1LDggQEAgcHJpdmF0ZToKICAgICB2b2lkIHNldFBhcmVu dChSZW5kZXJMYXllciopOwogICAgIHZvaWQgc2V0Rmlyc3RDaGlsZChSZW5kZXJMYXllciogZmly c3QpIHsgbV9maXJzdCA9IGZpcnN0OyB9CiAgICAgdm9pZCBzZXRMYXN0Q2hpbGQoUmVuZGVyTGF5 ZXIqIGxhc3QpIHsgbV9sYXN0ID0gbGFzdDsgfQorICAgIAorICAgIHZvaWQgZGlydHlQYWludE9y ZGVyTGlzdHNPbkNoaWxkQ2hhbmdlKFJlbmRlckxheWVyJik7CiAKICAgICBib29sIHNob3VsZEJl Tm9ybWFsRmxvd09ubHkoKSBjb25zdDsKICAgICBib29sIHNob3VsZEJlU3RhY2tpbmdDb250ZXh0 KCkgY29uc3Q7Cg==