190584 2018-10-15 09:00:20 -0700 Make a helper function to check for reflection layers 2018-10-15 10:51:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1469258 0 simon.fraser 2018-10-15 09:00:20 -0700 Make a helper function to check for reflection layers 1469259 1 352328 simon.fraser 2018-10-15 09:01:16 -0700 Created attachment 352328 Patch 1469274 2 352328 zalan 2018-10-15 09:25:04 -0700 Comment on attachment 352328 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352328&action=review > Source/WebCore/rendering/RenderLayer.cpp:6425 > +bool RenderLayer::isReflectionLayer(RenderLayer& layer) const const RenderLayer&? 1469323 3 simon.fraser 2018-10-15 10:50:47 -0700 https://trac.webkit.org/r237122 1469329 4 webkit-bug-importer 2018-10-15 10:51:53 -0700 <rdar://problem/45276561> 352328 2018-10-15 09:01:16 -0700 2018-10-15 09:25:04 -0700 Patch bug-190584-20181015090115.patch text/plain 4594 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjRiYTllZWIxNjdmMGQ3 MzU1ZmUxZWMyZDRiN2FjZDViZTUyMTBkNy4uYTcwZTUzOWEzMmRjMzA3MDdiNzE2NDgwZTU2Njk3 NGI1NGY5MDRiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTEwLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgYSBoZWxw ZXIgZnVuY3Rpb24gdG8gY2hlY2sgZm9yIHJlZmxlY3Rpb24gbGF5ZXJzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA1ODQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgUmVuZGVyTGF5ZXI6OmlzUmVm bGVjdGlvbkxheWVyKCkgd2hpY2ggcmV0dXJucyB0cnVlIGlmIHRoZSBwYXNzZWQgbGF5ZXIKKyAg ICAgICAgaXMgdGhlIGxheWVyIG9mIHRoaXMgbGF5ZXIncyByZWZsZWN0aW9uLiBJdCdzIHVzZWQg aW4gei1vcmRlciBsaXN0IGJ1aWxkaW5nLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxh eWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVOb3JtYWxGbG93 TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllcjo6cmVidWlsZFpPcmRlckxpc3Rz KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjb2xsZWN0TGF5ZXJzKToKKyAgICAg ICAgKFdlYkNvcmU6OmV4cGFuZENsaXBSZWN0Rm9yRGVzY2VuZGFudHNBbmRSZWZsZWN0aW9uKToK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpjYWxjdWxhdGVDbGlwUmVjdHMgY29uc3Qp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5oOgorCiAyMDE4LTEwLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmRlckxheWVy OjphZGRDaGlsZCgpIGFuZCByZW1vdmVDaGlsZCgpIHNob3VsZCB0YWtlIHJlZmVyZW5jZXMKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IGQwZGYzNjVmNTJjZjg1 NzdmNzRkMDc2NTc0OWE1MDhlY2JlZTNjOTMuLjhhZmEyZTU1YjlhNGZlYzAyOWJmMDU1NmI4ZGQx MDY0Njc3NTZmMjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJM YXllci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApA QCAtNjQzLDcgKzY0Myw3IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVwZGF0ZU5vcm1hbEZsb3dMaXN0 KCkKIAogICAgIGZvciAoUmVuZGVyTGF5ZXIqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBjaGlsZDsg Y2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgewogICAgICAgICAvLyBJZ25vcmUgbm9uLW92 ZXJmbG93IGxheWVycyBhbmQgcmVmbGVjdGlvbnMuCi0gICAgICAgIGlmIChjaGlsZC0+aXNOb3Jt YWxGbG93T25seSgpICYmICghbV9yZWZsZWN0aW9uIHx8IHJlZmxlY3Rpb25MYXllcigpICE9IGNo aWxkKSkgeworICAgICAgICBpZiAoY2hpbGQtPmlzTm9ybWFsRmxvd09ubHkoKSAmJiAhaXNSZWZs ZWN0aW9uTGF5ZXIoKmNoaWxkKSkgewogICAgICAgICAgICAgaWYgKCFtX25vcm1hbEZsb3dMaXN0 KQogICAgICAgICAgICAgICAgIG1fbm9ybWFsRmxvd0xpc3QgPSBzdGQ6Om1ha2VfdW5pcXVlPFZl Y3RvcjxSZW5kZXJMYXllcio+PigpOwogICAgICAgICAgICAgbV9ub3JtYWxGbG93TGlzdC0+YXBw ZW5kKGNoaWxkKTsKQEAgLTY2NSw3ICs2NjUsNyBAQCB2b2lkIFJlbmRlckxheWVyOjpyZWJ1aWxk Wk9yZGVyTGlzdHMoc3RkOjp1bmlxdWVfcHRyPFZlY3RvcjxSZW5kZXJMYXllcio+PiYgcG9zWgog ewogICAgIGJvb2wgaW5jbHVkZUhpZGRlbkxheWVycyA9IGNvbXBvc2l0b3IoKS5pbkNvbXBvc2l0 aW5nTW9kZSgpOwogICAgIGZvciAoUmVuZGVyTGF5ZXIqIGNoaWxkID0gZmlyc3RDaGlsZCgpOyBj aGlsZDsgY2hpbGQgPSBjaGlsZC0+bmV4dFNpYmxpbmcoKSkgewotICAgICAgICBpZiAoIW1fcmVm bGVjdGlvbiB8fCByZWZsZWN0aW9uTGF5ZXIoKSAhPSBjaGlsZCkKKyAgICAgICAgaWYgKCFpc1Jl ZmxlY3Rpb25MYXllcigqY2hpbGQpKQogICAgICAgICAgICAgY2hpbGQtPmNvbGxlY3RMYXllcnMo aW5jbHVkZUhpZGRlbkxheWVycywgcG9zWk9yZGVyTGlzdCwgbmVnWk9yZGVyTGlzdCk7CiAgICAg fQogCkBAIC03MDAsNyArNzAwLDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6Y29sbGVjdExheWVycyhi b29sIGluY2x1ZGVIaWRkZW5MYXllcnMsIHN0ZDo6dW5pcXVlX3B0cjxWZWN0b3IKICAgICBpZiAo KGluY2x1ZGVIaWRkZW5MYXllcnMgfHwgbV9oYXNWaXNpYmxlRGVzY2VuZGFudCkgJiYgIWlzU3Rh Y2tpbmcpIHsKICAgICAgICAgZm9yIChSZW5kZXJMYXllciogY2hpbGQgPSBmaXJzdENoaWxkKCk7 IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgICAgICAvLyBJ Z25vcmUgcmVmbGVjdGlvbnMuCi0gICAgICAgICAgICBpZiAoIW1fcmVmbGVjdGlvbiB8fCByZWZs ZWN0aW9uTGF5ZXIoKSAhPSBjaGlsZCkKKyAgICAgICAgICAgIGlmICghaXNSZWZsZWN0aW9uTGF5 ZXIoKmNoaWxkKSkKICAgICAgICAgICAgICAgICBjaGlsZC0+Y29sbGVjdExheWVycyhpbmNsdWRl SGlkZGVuTGF5ZXJzLCBwb3NpdGl2ZVpPcmRlckxpc3QsIG5lZ2F0aXZlWk9yZGVyTGlzdCk7CiAg ICAgICAgIH0KICAgICB9CkBAIC0xODUwLDcgKzE4NTAsNyBAQCBzdGF0aWMgdm9pZCBleHBhbmRD bGlwUmVjdEZvckRlc2NlbmRhbnRzQW5kUmVmbGVjdGlvbihMYXlvdXRSZWN0JiBjbGlwUmVjdCwg Y29ucwogICAgICAgICAvLyBOb3RlOiB3ZSBkb24ndCBoYXZlIHRvIHdhbGsgei1vcmRlciBsaXN0 cyBzaW5jZSB0cmFuc3BhcmVudCBlbGVtZW50cyBhbHdheXMgZXN0YWJsaXNoCiAgICAgICAgIC8v IGEgc3RhY2tpbmcgY29udGFpbmVyLiBUaGlzIG1lYW5zIHdlIGNhbiBqdXN0IHdhbGsgdGhlIGxh eWVyIHRyZWUgZGlyZWN0bHkuCiAgICAgICAgIGZvciAoUmVuZGVyTGF5ZXIqIGN1cnIgPSBsYXll ci5maXJzdENoaWxkKCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5uZXh0U2libGluZygpKSB7Ci0gICAg ICAgICAgICBpZiAoIWxheWVyLnJlZmxlY3Rpb24oKSB8fCBsYXllci5yZWZsZWN0aW9uTGF5ZXIo KSAhPSBjdXJyKQorICAgICAgICAgICAgaWYgKCFsYXllci5pc1JlZmxlY3Rpb25MYXllcigqY3Vy cikpCiAgICAgICAgICAgICAgICAgY2xpcFJlY3QudW5pdGUodHJhbnNwYXJlbmN5Q2xpcEJveCgq Y3Vyciwgcm9vdExheWVyLCB0cmFuc3BhcmVuY3lCZWhhdmlvciwgRGVzY2VuZGFudHNPZlRyYW5z cGFyZW5jeUNsaXBCb3gsIHBhaW50QmVoYXZpb3IpKTsKICAgICAgICAgfQogICAgIH0KQEAgLTY0 MjIsNiArNjQyMiwxMSBAQCBSZW5kZXJMYXllciogUmVuZGVyTGF5ZXI6OnJlZmxlY3Rpb25MYXll cigpIGNvbnN0CiAgICAgcmV0dXJuIG1fcmVmbGVjdGlvbiA/IG1fcmVmbGVjdGlvbi0+bGF5ZXIo KSA6IG51bGxwdHI7CiB9CiAKK2Jvb2wgUmVuZGVyTGF5ZXI6OmlzUmVmbGVjdGlvbkxheWVyKFJl bmRlckxheWVyJiBsYXllcikgY29uc3QKK3sKKyAgICByZXR1cm4gbV9yZWZsZWN0aW9uID8gJmxh eWVyID09IG1fcmVmbGVjdGlvbi0+bGF5ZXIoKSA6IGZhbHNlOworfQorCiB2b2lkIFJlbmRlckxh eWVyOjpjcmVhdGVSZWZsZWN0aW9uKCkKIHsKICAgICBBU1NFUlQoIW1fcmVmbGVjdGlvbik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4IDc2MjFkMTE2YTc5ODRlNmM0 YmVkZTFmNjkyZWZjNWE2OGI5NmRhMDAuLjkwODNhZmFjMzc4ZDhkMTFlMmQ4YTVlYTg4YjkyMTUw NmRhOTdiNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCkBAIC0yNjUs NiArMjY1LDcgQEAgcHVibGljOgogICAgIGJvb2wgaXNSZWZsZWN0aW9uKCkgY29uc3QgeyByZXR1 cm4gcmVuZGVyZXIoKS5pc1JlcGxpY2EoKTsgfQogICAgIFJlbmRlclJlcGxpY2EqIHJlZmxlY3Rp b24oKSBjb25zdCB7IHJldHVybiBtX3JlZmxlY3Rpb24uZ2V0KCk7IH0KICAgICBSZW5kZXJMYXll ciogcmVmbGVjdGlvbkxheWVyKCkgY29uc3Q7CisgICAgYm9vbCBpc1JlZmxlY3Rpb25MYXllcihS ZW5kZXJMYXllciYpIGNvbnN0OwogCiAgICAgY29uc3QgTGF5b3V0UG9pbnQmIGxvY2F0aW9uKCkg Y29uc3QgeyByZXR1cm4gbV90b3BMZWZ0OyB9CiAgICAgdm9pZCBzZXRMb2NhdGlvbihjb25zdCBM YXlvdXRQb2ludCYgcCkgeyBtX3RvcExlZnQgPSBwOyB9Cg==