190558 2018-10-13 23:10:53 -0700 [Payment Request] PaymentResponse should be a ContextDestructionObserver 2018-10-15 12:38:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes achristensen andersca cdumez commit-queue ews-watchlist sam thorton webkit-bug-importer youennf oldest_to_newest 1469033 0 aestes 2018-10-13 23:10:53 -0700 [Payment Request] PaymentResponse should be a ContextDestructionObserver 1469034 1 352266 aestes 2018-10-13 23:14:45 -0700 Created attachment 352266 Patch 1469035 2 ews-watchlist 2018-10-13 23:16:03 -0700 Attachment 352266 did not pass style-queue: ERROR: Source/WebCore/Modules/paymentrequest/PaymentResponse.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1469391 3 352266 commit-queue 2018-10-15 12:37:26 -0700 Comment on attachment 352266 Patch Clearing flags on attachment: 352266 Committed r237133: <https://trac.webkit.org/changeset/237133> 1469392 4 commit-queue 2018-10-15 12:37:28 -0700 All reviewed patches have been landed. Closing bug. 1469393 5 webkit-bug-importer 2018-10-15 12:38:32 -0700 <rdar://problem/45280768> 352266 2018-10-13 23:14:45 -0700 2018-10-15 12:37:26 -0700 Patch bug-190558-20181013231442.patch text/plain 5292 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZjY2M1ZDc5YmQ2N2Nl NGMzNmZmN2MzNGE2MWEzODM5YmNlMTM4Mi4uOGEwN2QzNDgzNjI1MmE5NTRjZDBjZGQ4MTM4NGU5 N2NmMTBmYzlkMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTEwLTEzICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbUGF5bWVudCBSZXF1ZXN0XSBQ YXltZW50UmVzcG9uc2Ugc2hvdWxkIGJlIGEgQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDU1OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgUGF5bWVu dFJlc3BvbnNlIGEgQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXIgc28gaXQgaGFzIGEgU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCB0bworICAgICAgICByZXR1cm4gZm9yIGl0cyBvdmVycmlkZSBvZiBF dmVudFRhcmdldDo6c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpLiBEbyB0aGlzIGluc3RlYWQgb2YK KyAgICAgICAgZG93bmNhc3RpbmcgbV9yZXF1ZXN0IHRvIGFuIEFjdGl2ZURPTU9iamVjdCB0byBh c2sgZm9yIGl0cyBjb250ZXh0LgorCisgICAgICAgICogTW9kdWxlcy9wYXltZW50cmVxdWVzdC9Q YXltZW50UmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXltZW50UmVxdWVzdDo6YWNj ZXB0KToKKyAgICAgICAgKiBNb2R1bGVzL3BheW1lbnRyZXF1ZXN0L1BheW1lbnRSZXNwb25zZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQYXltZW50UmVzcG9uc2U6OlBheW1lbnRSZXNwb25zZSk6 CisgICAgICAgIChXZWJDb3JlOjpQYXltZW50UmVzcG9uc2U6OnNjcmlwdEV4ZWN1dGlvbkNvbnRl eHQgY29uc3QpOiBEZWxldGVkLgorICAgICAgICAqIE1vZHVsZXMvcGF5bWVudHJlcXVlc3QvUGF5 bWVudFJlc3BvbnNlLmg6CisKIDIwMTgtMTAtMTIgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2ll aEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQWxsb3cgU1BJIGNsaWVudHMgdG8gbGF5IG91 dCBhdCBhcmJpdHJhcmlseSBzY2FsZWQgc2l6ZXMgYW5kIHNjYWxlIHRvIGZpdCB0aGUgdmlldwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9wYXltZW50cmVxdWVzdC9QYXltZW50 UmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BheW1lbnRyZXF1ZXN0L1BheW1l bnRSZXF1ZXN0LmNwcAppbmRleCBkOGI1OTA4Njc1ZjhhZGJlMDVlN2E4M2MzMTkwOGEyMTk1OWNj NWRmLi5hM2VmYzY5MWUzYzc5NmE1OWQ4NmYwMjc4YThjNTQzNTU2OWQ0ZGY1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BheW1lbnRyZXF1ZXN0L1BheW1lbnRSZXF1ZXN0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BheW1lbnRyZXF1ZXN0L1BheW1lbnRSZXF1 ZXN0LmNwcApAQCAtNjkwLDcgKzY5MCw3IEBAIHZvaWQgUGF5bWVudFJlcXVlc3Q6OmFjY2VwdChj b25zdCBTdHJpbmcmIG1ldGhvZE5hbWUsIFBheW1lbnRSZXNwb25zZTo6RGV0YWlsc0Z1CiB7CiAg ICAgQVNTRVJUKG1fc3RhdGUgPT0gU3RhdGU6OkludGVyYWN0aXZlKTsKIAotICAgIGF1dG8gcmVz cG9uc2UgPSBQYXltZW50UmVzcG9uc2U6OmNyZWF0ZSgqdGhpcywgV1RGTW92ZShkZXRhaWxzRnVu Y3Rpb24pKTsKKyAgICBhdXRvIHJlc3BvbnNlID0gUGF5bWVudFJlc3BvbnNlOjpjcmVhdGUoc2Ny aXB0RXhlY3V0aW9uQ29udGV4dCgpLCAqdGhpcywgV1RGTW92ZShkZXRhaWxzRnVuY3Rpb24pKTsK ICAgICByZXNwb25zZS0+c2V0UmVxdWVzdElkKG1fZGV0YWlscy5pZCk7CiAgICAgcmVzcG9uc2Ut PnNldE1ldGhvZE5hbWUobWV0aG9kTmFtZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L01vZHVsZXMvcGF5bWVudHJlcXVlc3QvUGF5bWVudFJlc3BvbnNlLmNwcCBiL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvcGF5bWVudHJlcXVlc3QvUGF5bWVudFJlc3BvbnNlLmNwcAppbmRleCA4Mjg3 ZDdiYjI5NDAyNTViZDJjNjczNjk2MDU5MWZlYTFiY2NiNWU5Li5jZjBhYzRmOTQ0ZjEwMDI2NzUx MTA5YzNjYTA5OWNhMzliNDJmN2UwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3BheW1lbnRyZXF1ZXN0L1BheW1lbnRSZXNwb25zZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9wYXltZW50cmVxdWVzdC9QYXltZW50UmVzcG9uc2UuY3BwCkBAIC0zNCw4ICszNCw5 IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUGF5bWVudFJlc3BvbnNlOjpQYXltZW50UmVz cG9uc2UoUGF5bWVudFJlcXVlc3QmIHJlcXVlc3QsIERldGFpbHNGdW5jdGlvbiYmIGRldGFpbHNG dW5jdGlvbikKLSAgICA6IG1fcmVxdWVzdCB7IHJlcXVlc3QgfQorUGF5bWVudFJlc3BvbnNlOjpQ YXltZW50UmVzcG9uc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgUGF5bWVudFJl cXVlc3QmIHJlcXVlc3QsIERldGFpbHNGdW5jdGlvbiYmIGRldGFpbHNGdW5jdGlvbikKKyAgICA6 IENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyIHsgY29udGV4dCB9CisgICAgLCBtX3JlcXVlc3Qg eyByZXF1ZXN0IH0KICAgICAsIG1fZGV0YWlsc0Z1bmN0aW9uIHsgV1RGTW92ZShkZXRhaWxzRnVu Y3Rpb24pIH0KIHsKICAgICBBU1NFUlQobV9kZXRhaWxzRnVuY3Rpb24pOwpAQCAtNjEsMTEgKzYy LDYgQEAgdm9pZCBQYXltZW50UmVzcG9uc2U6OnJldHJ5KFBheW1lbnRWYWxpZGF0aW9uRXJyb3Jz JiYsIERPTVByb21pc2VEZWZlcnJlZDx2b2lkPiYKICAgICBwcm9taXNlLnJlamVjdChFeGNlcHRp b24geyBOb3RTdXBwb3J0ZWRFcnJvciB9KTsKIH0KIAotU2NyaXB0RXhlY3V0aW9uQ29udGV4dCog UGF5bWVudFJlc3BvbnNlOjpzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkgY29uc3QKLXsKLSAgICBy ZXR1cm4gc3RhdGljX2Nhc3Q8QWN0aXZlRE9NT2JqZWN0Jj4obV9yZXF1ZXN0LmdldCgpKS5zY3Jp cHRFeGVjdXRpb25Db250ZXh0KCk7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2Vu ZGlmIC8vIEVOQUJMRShQQVlNRU5UX1JFUVVFU1QpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3BheW1lbnRyZXF1ZXN0L1BheW1lbnRSZXNwb25zZS5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9wYXltZW50cmVxdWVzdC9QYXltZW50UmVzcG9uc2UuaAppbmRleCA0NDllZmYw YTUyMDJmMmRhOTVhYjNmMzU5NGUxMzQzODhlMTE4YWIzLi5jMzY1ZGZhMzkyZGQ5MDhlOGEwZmIy ZWI0NDY3YTc0NTcyNDIwYjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3Bh eW1lbnRyZXF1ZXN0L1BheW1lbnRSZXNwb25zZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvcGF5bWVudHJlcXVlc3QvUGF5bWVudFJlc3BvbnNlLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAog I2lmIEVOQUJMRShQQVlNRU5UX1JFUVVFU1QpCiAKKyNpbmNsdWRlICJDb250ZXh0RGVzdHJ1Y3Rp b25PYnNlcnZlci5oIgogI2luY2x1ZGUgIkV2ZW50VGFyZ2V0LmgiCiAjaW5jbHVkZSAiSlNET01Q cm9taXNlRGVmZXJyZWQuaCIKICNpbmNsdWRlICJKU1ZhbHVlSW5XcmFwcGVkT2JqZWN0LmgiCkBA IC0zOSwxMyArNDAsMTMgQEAgY2xhc3MgRG9jdW1lbnQ7CiBjbGFzcyBQYXltZW50UmVxdWVzdDsK IHN0cnVjdCBQYXltZW50VmFsaWRhdGlvbkVycm9yczsKIAotY2xhc3MgUGF5bWVudFJlc3BvbnNl IGZpbmFsIDogcHVibGljIFJlZkNvdW50ZWQ8UGF5bWVudFJlc3BvbnNlPiwgcHVibGljIEV2ZW50 VGFyZ2V0V2l0aElubGluZURhdGEgeworY2xhc3MgUGF5bWVudFJlc3BvbnNlIGZpbmFsIDogcHVi bGljIENvbnRleHREZXN0cnVjdGlvbk9ic2VydmVyLCBwdWJsaWMgRXZlbnRUYXJnZXRXaXRoSW5s aW5lRGF0YSwgcHVibGljIFJlZkNvdW50ZWQ8UGF5bWVudFJlc3BvbnNlPiB7CiBwdWJsaWM6CiAg ICAgdXNpbmcgRGV0YWlsc0Z1bmN0aW9uID0gRnVuY3Rpb248SlNDOjpTdHJvbmc8SlNDOjpKU09i amVjdD4oSlNDOjpFeGVjU3RhdGUmKT47CiAKLSAgICBzdGF0aWMgUmVmPFBheW1lbnRSZXNwb25z ZT4gY3JlYXRlKFBheW1lbnRSZXF1ZXN0JiByZXF1ZXN0LCBEZXRhaWxzRnVuY3Rpb24mJiBkZXRh aWxzRnVuY3Rpb24pCisgICAgc3RhdGljIFJlZjxQYXltZW50UmVzcG9uc2U+IGNyZWF0ZShTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBQYXltZW50UmVxdWVzdCYgcmVxdWVzdCwgRGV0 YWlsc0Z1bmN0aW9uJiYgZGV0YWlsc0Z1bmN0aW9uKQogICAgIHsKLSAgICAgICAgcmV0dXJuIGFk b3B0UmVmKCpuZXcgUGF5bWVudFJlc3BvbnNlKHJlcXVlc3QsIFdURk1vdmUoZGV0YWlsc0Z1bmN0 aW9uKSkpOworICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBQYXltZW50UmVzcG9uc2UoY29u dGV4dCwgcmVxdWVzdCwgV1RGTW92ZShkZXRhaWxzRnVuY3Rpb24pKSk7CiAgICAgfQogCiAgICAg flBheW1lbnRSZXNwb25zZSgpOwpAQCAtODEsMTEgKzgyLDExIEBAIHB1YmxpYzoKICAgICB1c2lu ZyBSZWZDb3VudGVkPFBheW1lbnRSZXNwb25zZT46OmRlcmVmOwogCiBwcml2YXRlOgotICAgIFBh eW1lbnRSZXNwb25zZShQYXltZW50UmVxdWVzdCYsIERldGFpbHNGdW5jdGlvbiYmKTsKKyAgICBQ YXltZW50UmVzcG9uc2UoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIFBheW1lbnRSZXF1ZXN0Jiwg RGV0YWlsc0Z1bmN0aW9uJiYpOwogCiAgICAgLy8gRXZlbnRUYXJnZXQKICAgICBFdmVudFRhcmdl dEludGVyZmFjZSBldmVudFRhcmdldEludGVyZmFjZSgpIGNvbnN0IGZpbmFsIHsgcmV0dXJuIFBh eW1lbnRSZXNwb25zZUV2ZW50VGFyZ2V0SW50ZXJmYWNlVHlwZTsgfQotICAgIFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdCBmaW5hbDsKKyAgICBT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkgY29uc3QgZmlu YWwgeyByZXR1cm4gQ29udGV4dERlc3RydWN0aW9uT2JzZXJ2ZXI6OnNjcmlwdEV4ZWN1dGlvbkNv bnRleHQoKTsgfQogICAgIHZvaWQgcmVmRXZlbnRUYXJnZXQoKSBmaW5hbCB7IHJlZigpOyB9CiAg ICAgdm9pZCBkZXJlZkV2ZW50VGFyZ2V0KCkgZmluYWwgeyBkZXJlZigpOyB9CiAK