<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190522</bug_id>
          
          <creation_ts>2018-10-12 09:17:53 -0700</creation_ts>
          <short_desc>Add a temporarily off by default preference for doing safe browsing checks</short_desc>
          <delta_ts>2018-10-15 15:35:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alex Christensen">achristensen</reporter>
          <assigned_to name="Alex Christensen">achristensen</assigned_to>
          <cc>cdumez</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1468445</commentid>
    <comment_count>0</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-10-12 09:17:53 -0700</bug_when>
    <thetext>Add a temporarily off by default preference for doing safe browsing checks</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1468446</commentid>
    <comment_count>1</comment_count>
      <attachid>352172</attachid>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-10-12 09:19:08 -0700</bug_when>
    <thetext>Created attachment 352172
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469224</commentid>
    <comment_count>2</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-10-15 08:24:51 -0700</bug_when>
    <thetext>https://trac.webkit.org/changeset/237104/webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469233</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-15 08:25:46 -0700</bug_when>
    <thetext>&lt;rdar://problem/45271675&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469501</commentid>
    <comment_count>4</comment_count>
    <who name="Alex Christensen">achristensen</who>
    <bug_when>2018-10-15 15:35:51 -0700</bug_when>
    <thetext>http://trac.webkit.org/r237149</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>352172</attachid>
            <date>2018-10-12 09:19:08 -0700</date>
            <delta_ts>2018-10-12 17:03:41 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190522-20181012091908.patch</filename>
            <type>text/plain</type>
            <size>4514</size>
            <attacher name="Alex Christensen">achristensen</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzcwNjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTEyICBBbGV4IENocmlz
dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIGEgdGVtcG9y
YXJpbHkgb2ZmIGJ5IGRlZmF1bHQgcHJlZmVyZW5jZSBmb3IgZG9pbmcgc2FmZSBicm93c2luZyBj
aGVja3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5
MDUyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNh
ZmUgYnJvd3NpbmcgZGV2ZWxvcG1lbnQgaGFzIHRha2VuIGxvbmdlciB0aGFuIGFudGljaXBhdGVk
LgorICAgICAgICBUbyBwcmV2ZW50IHRoZSB1bnVzZWQgcG9zc2libGUgY29udGFjdGluZyB0aGUg
c2FmZSBicm93c2luZyBwcm92aWRlciBmb3Igbm8gYmVuZWZpdCwgbWFrZSB0aGlzIG9mZiBieSBk
ZWZhdWx0IGZvciBub3cuCisgICAgICAgIEknbGwgbWFrZSBpdCBvbiBieSBkZWZhdWx0IHdoZW4g
aXQncyBhY3R1YWxseSB1c2VkLgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzLnlh
bWw6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tOgorICAg
ICAgICAoLVtXS1ByZWZlcmVuY2VzIF9zZXRTYWZlQnJvd3NpbmdFbmFibGVkOl0pOgorICAgICAg
ICAoLVtXS1ByZWZlcmVuY2VzIF9zYWZlQnJvd3NpbmdFbmFibGVkXSk6CisgICAgICAgICogVUlQ
cm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJv
Y2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmRl
Y2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pOgorCiAyMDE4LTEwLTExICBZb3Vlbm4gRmFi
bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBJT1MgMTIgLSBTZXJ2aWNlIHdvcmtl
ciBjYWNoZSBub3Qgc2hhcmVkIHdoZW4gYWRkZWQgdG8gaG9tZXNjcmVlbgpJbmRleDogU291cmNl
L1dlYktpdC9TaGFyZWQvV2ViUHJlZmVyZW5jZXMueWFtbAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv
V2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCShyZXZpc2lvbiAyMzcwMzMpCisrKyBT
b3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNlcy55YW1sCSh3b3JraW5nIGNvcHkpCkBA
IC00Niw2ICs0NiwxMSBAQCBYU1NBdWRpdG9yRW5hYmxlZDoKICAgdHlwZTogYm9vbAogICBkZWZh
dWx0VmFsdWU6IHRydWUKIAorU2FmZUJyb3dzaW5nRW5hYmxlZDoKKyAgdHlwZTogYm9vbAorICBk
ZWZhdWx0VmFsdWU6IGZhbHNlCisgIHdlYmNvcmVCaW5kaW5nOiBub25lCisKIFByaXZhdGVCcm93
c2luZ0VuYWJsZWQ6CiAgIHR5cGU6IGJvb2wKICAgZGVmYXVsdFZhbHVlOiBmYWxzZQpJbmRleDog
U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiAyMzcwMzMp
CisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNv
cHkpCkBAIC00MTEzLDYgKzQxMTMsOSBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5
Rm9yTmF2aWdhCiAgICAgVU5VU0VEX1BBUkFNKG5ld05hdmlnYXRpb25JRCk7CiAjZW5kaWYKIAor
ICAgIGlmICghbV9wcmVmZXJlbmNlcy0+c2FmZUJyb3dzaW5nRW5hYmxlZCgpKQorICAgICAgICBz
aG91bGRTa2lwU2FmZUJyb3dzaW5nQ2hlY2sgPSBTaG91bGRTa2lwU2FmZUJyb3dzaW5nQ2hlY2s6
OlllczsKKwogICAgIGF1dG8gbGlzdGVuZXIgPSBtYWtlUmVmKGZyYW1lLnNldFVwUG9saWN5TGlz
dGVuZXJQcm94eShbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBmcmFtZSA9
IG1ha2VSZWYoZnJhbWUpLCBzZW5kZXIgPSBXVEZNb3ZlKHNlbmRlciksIG5hdmlnYXRpb25dIChX
ZWJDb3JlOjpQb2xpY3lBY3Rpb24gcG9saWN5QWN0aW9uLCBBUEk6OldlYnNpdGVQb2xpY2llcyog
cG9saWNpZXMsIFByb2Nlc3NTd2FwUmVxdWVzdGVkQnlDbGllbnQgcHJvY2Vzc1N3YXBSZXF1ZXN0
ZWRCeUNsaWVudCwgVmVjdG9yPFJlZjxTYWZlQnJvd3NpbmdSZXN1bHQ+PiYmKSBtdXRhYmxlIHsK
ICAgICAgICAgLy8gRklYTUU6IGRvIHNvbWV0aGluZyB3aXRoIHRoZSBTYWZlQnJvd3NpbmdSZXN1
bHRzLgogICAgICAgICByZWNlaXZlZE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lvbihwb2xpY3lBY3Rp
b24sIG5hdmlnYXRpb24uZ2V0KCksIHByb2Nlc3NTd2FwUmVxdWVzdGVkQnlDbGllbnQsIGZyYW1l
LCBwb2xpY2llcywgV1RGTW92ZShzZW5kZXIpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9j
ZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tCShyZXZpc2lvbiAyMzcwMzMp
CisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQko
d29ya2luZyBjb3B5KQpAQCAtNjk3LDYgKzY5NywxNiBAQCAtICh2b2lkKV9zZXRJQ0VDYW5kaWRh
dGVGaWx0ZXJpbmdFbmFibGVkCiAgICAgX3ByZWZlcmVuY2VzLT5zZXRJQ0VDYW5kaWRhdGVGaWx0
ZXJpbmdFbmFibGVkKGVuYWJsZWQpOwogfQogCistICh2b2lkKV9zZXRTYWZlQnJvd3NpbmdFbmFi
bGVkOihCT09MKWVuYWJsZWQKK3sKKyAgICBfcHJlZmVyZW5jZXMtPnNldFNhZmVCcm93c2luZ0Vu
YWJsZWQoZW5hYmxlZCk7Cit9CisKKy0gKEJPT0wpX3NhZmVCcm93c2luZ0VuYWJsZWQKK3sKKyAg
ICByZXR1cm4gX3ByZWZlcmVuY2VzLT5zYWZlQnJvd3NpbmdFbmFibGVkKCk7Cit9CisKIC0gKEJP
T0wpX3dlYlJUQ0xlZ2FjeUFQSUVuYWJsZWQKIHsKICAgICByZXR1cm4gTk87CkluZGV4OiBTb3Vy
Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaAo9PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNl
c1ByaXZhdGUuaAkocmV2aXNpb24gMjM3MDMzKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv
QVBJL0NvY29hL1dLUHJlZmVyZW5jZXNQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMSw2
ICsxMjEsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFZGl0YWJsZUxpCiBAcHJv
cGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRJQ0VDYW5kaWRhdGVGaWx0ZXJpbmdFbmFibGVk
OikgQk9PTCBfaWNlQ2FuZGlkYXRlRmlsdGVyaW5nRW5hYmxlZCBXS19BUElfQVZBSUxBQkxFKG1h
Y29zeCgxMC4xMy40KSwgaW9zKDExLjMpKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9
X3NldFdlYlJUQ0xlZ2FjeUFQSUVuYWJsZWQ6KSBCT09MIF93ZWJSVENMZWdhY3lBUElFbmFibGVk
IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwgaW9zKDExLjApKTsKIEBwcm9wZXJ0eSAo
bm9uYXRvbWljLCBzZXR0ZXI9X3NldEluYWN0aXZlTWVkaWFDYXB0dXJlU3RlYW1SZXByb21wdElu
dGVydmFsSW5NaW51dGVzOikgZG91YmxlIF9pbmFjdGl2ZU1lZGlhQ2FwdHVyZVN0ZWFtUmVwcm9t
cHRJbnRlcnZhbEluTWludXRlcyBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMy40KSwgaW9z
KDExLjMpKTsKK0Bwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldFNhZmVCcm93c2luZ0Vu
YWJsZWQ6KSBCT09MIF9zYWZlQnJvd3NpbmdFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4
KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogCiBAcHJvcGVydHkgKG5vbmF0b21pYywg
c2V0dGVyPV9zZXRKYXZhU2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkOikgQk9PTCBfamF2YVNjcmlw
dENhbkFjY2Vzc0NsaXBib2FyZCBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMyksIGlvcygx
MS4wKSk7CiBAcHJvcGVydHkgKG5vbmF0b21pYywgc2V0dGVyPV9zZXRET01QYXN0ZUFsbG93ZWQ6
KSBCT09MIF9kb21QYXN0ZUFsbG93ZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTMpLCBp
b3MoMTEuMCkpOwo=
</data>
<flag name="review"
          id="369475"
          type_id="1"
          status="+"
          setter="cdumez"
    />
          </attachment>
      

    </bug>

</bugzilla>