190510 2018-10-11 20:14:15 -0700 Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark 2018-10-12 16:01:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck nvasilyev webkit-bug-importer oldest_to_newest 1468338 0 joepeck 2018-10-11 20:14:15 -0700 Web Inspector: Dark Mode: Highlight text in Network Headers search is too dark Steps to Reproduce: •. Use Dark Mode 1. Inspect this page 2. Show Network Tab 3. Select a Resource 4. Show Headers Pane 5. ⌘F to search for a string => Highlights look bad 1468339 1 352129 joepeck 2018-10-11 20:15:05 -0700 Created attachment 352129 [PATCH] Proposed Fix 1468356 2 352129 hi 2018-10-11 22:27:38 -0700 Comment on attachment 352129 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=352129&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ResourceHeadersContentView.css:82 > + color: var(--text-color); It seems weird to me that we'd color the header keys too (instead of using the existing current color) , but I suppose that blue-on-yellow isn't much better :| If we did, you could drop this `color` altogether, since the `.value` already uses `--text-color`. 1468520 3 nvasilyev 2018-10-12 12:05:51 -0700 I don't think I even knew that there's search in the headers pane. This fix is fine. Eventually, I'd like to unify highlight styles. Search highlights are used in DOM tree outline, styles sidebar, resource content view, console, search tab, and a few other places. We should make them look the same and, possibly, even use the same CSS rule everywhere. 1468663 4 352129 commit-queue 2018-10-12 15:59:55 -0700 Comment on attachment 352129 [PATCH] Proposed Fix Clearing flags on attachment: 352129 Committed r237085: <https://trac.webkit.org/changeset/237085> 1468664 5 commit-queue 2018-10-12 15:59:57 -0700 All reviewed patches have been landed. Closing bug. 1468665 6 webkit-bug-importer 2018-10-12 16:01:03 -0700 <rdar://problem/45240487> 352129 2018-10-11 20:15:05 -0700 2018-10-12 15:59:55 -0700 [PATCH] Proposed Fix highlight-1.patch text/plain 1406 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhhMjhjOWVhOGU5Li5lZTVhZTdlNDM0MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBEYXJrIE1vZGU6IEhpZ2hsaWdodCB0ZXh0IGluIE5ldHdvcmsgSGVhZGVycyBzZWFyY2ggaXMg dG9vIGRhcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MDUxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZUhlYWRlcnNDb250ZW50Vmlldy5jc3M6Cisg ICAgICAgICgucmVzb3VyY2UtaGVhZGVycy5zaG93aW5nLWZpbmQtYmFubmVyIC5zZWFyY2gtaGln aGxpZ2h0KToKKyAgICAgICAgVXNlIGFkYXB0aXZlIHRleHQtY29sb3IuCisKIDIwMTgtMTAtMDQg IE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJFR1JFU1NJT04gKHIyMzY3NjYpOiBTdG9yYWdlIHRhYiBubyBsb25nZXIgdXBkYXRlcyBh ZnRlciBtYWluIGZyYW1lIG5hdmlnYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlSGVhZGVyc0NvbnRlbnRWaWV3LmNzcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlSGVhZGVy c0NvbnRlbnRWaWV3LmNzcwppbmRleCAxM2JiNTEyYTNiZC4uMTI1MWZhYzY3MDYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlSGVh ZGVyc0NvbnRlbnRWaWV3LmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9SZXNvdXJjZUhlYWRlcnNDb250ZW50Vmlldy5jc3MKQEAgLTc5LDcgKzc5LDcg QEAgYm9keVtkaXI9cnRsXSAucmVzb3VyY2UtaGVhZGVycyAuZGV0YWlscyAucGFpciB7CiB9CiAK IC5yZXNvdXJjZS1oZWFkZXJzLnNob3dpbmctZmluZC1iYW5uZXIgLnNlYXJjaC1oaWdobGlnaHQg ewotICAgIGNvbG9yOiBibGFjazsKKyAgICBjb2xvcjogdmFyKC0tdGV4dC1jb2xvcik7CiAgICAg YmFja2dyb3VuZC1jb2xvcjogaHNsYSg1MywgODMlLCA1MyUsIDAuMik7CiAgICAgYm9yZGVyLWJv dHRvbTogMXB4IHNvbGlkIGhzbCg0NywgODIlLCA2MCUpOwogfQo=