190503 2018-10-11 18:03:44 -0700 Use currentStackPointer more 2018-10-11 18:50:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo dbates ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1468279 0 ysuzuki 2018-10-11 18:03:44 -0700 Use currentStackPointer more 1468280 1 352115 ysuzuki 2018-10-11 18:04:24 -0700 Created attachment 352115 Patch 1468282 2 352115 saam 2018-10-11 18:19:03 -0700 Comment on attachment 352115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352115&action=review > Source/WTF/wtf/StackBounds.cpp:55 > + volatile uint8_t* stackValue = bitwise_cast<uint8_t*>(currentStackPointer()); Does this work on debug builds where this is an actual function call? 1468287 3 ysuzuki 2018-10-11 18:31:58 -0700 (In reply to Saam Barati from comment #2) > Comment on attachment 352115 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352115&action=review > > > Source/WTF/wtf/StackBounds.cpp:55 > > + volatile uint8_t* stackValue = bitwise_cast<uint8_t*>(currentStackPointer()); > > Does this work on debug builds where this is an actual function call? Yeah, at least in x64, it works :) 1468290 4 ysuzuki 2018-10-11 18:33:40 -0700 Landed in https://trac.webkit.org/r237059 1468291 5 webkit-bug-importer 2018-10-11 18:34:26 -0700 <rdar://problem/45213815> 1468296 6 mark.lam 2018-10-11 18:50:53 -0700 (In reply to Yusuke Suzuki from comment #3) > (In reply to Saam Barati from comment #2) > > Comment on attachment 352115 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=352115&action=review > > > > > Source/WTF/wtf/StackBounds.cpp:55 > > > + volatile uint8_t* stackValue = bitwise_cast<uint8_t*>(currentStackPointer()); > > > > Does this work on debug builds where this is an actual function call? > > Yeah, at least in x64, it works :) Yes, currentStackPointer() is designed to work on both release and debug builds. They work differently though: the release build version relies on it being inlined, while the debug build version relies on it not being inlined. 352115 2018-10-11 18:04:24 -0700 2018-10-11 18:19:03 -0700 Patch bug-190503-20181012100423.patch text/plain 5347 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy N2UwOWMzNDdiNzE1MjU5ODY5OTZhNGU1MGFkNTY0ZTIwNTg4YmI4Li5jOGVmYzk2MTA3OGEyNTg1 ZWMyNGMxNmVmMjI2NGM1OGI0MzQ0NDVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0xMC0xMSAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFVzZSBjdXJyZW50U3RhY2tQb2ludGVyIG1vcmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDUwMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9WTS5j cHA6CisgICAgICAgIChKU0M6OlZNOjpjb21taXR0ZWRTdGFja0J5dGVDb3VudCk6CisKIDIwMTgt MTAtMDggIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9yZz4KIAogICAg ICAgICBbSlNDXSBKU0Mgc2hvdWxkIGhhdmUgInBhcnNlRnVuY3Rpb24iIHRvIG9wdGltaXplIEZ1 bmN0aW9uIGNvbnN0cnVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1ZTA4NWI2OTA0ZTkwY2E5OTVhZTQwZjE3Nzk3YjI1 Y2E0YTg0YTkuLjE2NzVjOTk1ODAyM2ZjMjUwMjkxZGZhYTVhNTE3YjkyNGUwMjhhYmEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTgtMTAtMTEgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lA c2xvd3N0YXJ0Lm9yZz4KKworICAgICAgICBVc2UgY3VycmVudFN0YWNrUG9pbnRlciBtb3JlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA1MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgV1RGOjpj dXJyZW50U3RhY2tQb2ludGVyIG1vcmUgaW4gV2ViS2l0IHRvIGFkb3B0IEFTQU4gZGV0ZWN0X3N0 YWNrX3VzZV9hZnRlcl9yZXR1cm4gb3B0aW9uLgorCisgICAgICAgICogd3RmL1N0YWNrQm91bmRz LmNwcDoKKyAgICAgICAgKFdURjo6dGVzdFN0YWNrRGlyZWN0aW9uMik6CisgICAgICAgIChXVEY6 OnRlc3RTdGFja0RpcmVjdGlvbik6CisgICAgICAgICogd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNw cDoKKyAgICAgICAgKFdURjo6VGhyZWFkOjpzaWduYWxIYW5kbGVyU3VzcGVuZFJlc3VtZSk6Cisg ICAgICAgIChXVEY6OmdldEFwcHJveGltYXRlU3RhY2tQb2ludGVyKTogRGVsZXRlZC4KKwogMjAx OC0xMC0xMSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAg ICAgW1dURl0gU2VtYXBob3JlLmggY29uZmxpY3RzIHdpdGggUE9TSVggaGVhZGVyCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggNDdlNjFiODNhMzk3MzA1Nzc0YTZmMjNkYzQz ZTMwZGJkNzA2Y2Q2MC4uMTg2ZjdhZWIyOWNiY2FjZGE2Y2M1YjFmYzliNjQwYWQ2ZDY3ODY2NyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtMTE1Nyw4ICsxMTU3LDggQEAg c2l6ZV90IFZNOjpjb21taXR0ZWRTdGFja0J5dGVDb3VudCgpCiAgICAgLy8gV2hlbiB1c2luZyB0 aGUgQyBzdGFjaywgd2UgZG9uJ3Qga25vdyBob3cgbWFueSBzdGFjayBwYWdlcyBhcmUgYWN0dWFs bHkKICAgICAvLyBjb21taXR0ZWQuIFNvLCB3ZSB1c2UgdGhlIGN1cnJlbnQgc3RhY2sgdXNhZ2Ug YXMgYW4gZXN0aW1hdGUuCiAgICAgQVNTRVJUKFRocmVhZDo6Y3VycmVudCgpLnN0YWNrKCkuaXNH cm93aW5nRG93bndhcmQoKSk7Ci0gICAgaW50OF90KiBjdXJyZW50ID0gcmVpbnRlcnByZXRfY2Fz dDxpbnQ4X3QqPigmY3VycmVudCk7Ci0gICAgaW50OF90KiBoaWdoID0gcmVpbnRlcnByZXRfY2Fz dDxpbnQ4X3QqPihUaHJlYWQ6OmN1cnJlbnQoKS5zdGFjaygpLm9yaWdpbigpKTsKKyAgICB1aW50 OF90KiBjdXJyZW50ID0gYml0d2lzZV9jYXN0PHVpbnQ4X3QqPihjdXJyZW50U3RhY2tQb2ludGVy KCkpOworICAgIHVpbnQ4X3QqIGhpZ2ggPSBiaXR3aXNlX2Nhc3Q8dWludDhfdCo+KFRocmVhZDo6 Y3VycmVudCgpLnN0YWNrKCkub3JpZ2luKCkpOwogICAgIHJldHVybiBoaWdoIC0gY3VycmVudDsK ICNlbHNlCiAgICAgcmV0dXJuIENMb29wU3RhY2s6OmNvbW1pdHRlZEJ5dGVDb3VudCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwIGIvU291cmNlL1dURi93dGYv U3RhY2tCb3VuZHMuY3BwCmluZGV4IDg1Mzc0OTNiM2UyZjEwOTA2MWNkOTIyNmI0NGJmOTBlY2E0 ZTg3M2MuLmJhN2Y3NDU0ZDcyNDE5MzgwNDM3ODI3YWNkYWI0MjU2YmQ0M2Y3ZjkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9T dGFja0JvdW5kcy5jcHAKQEAgLTUwLDE3ICs1MCwxNyBAQCBBTFdBWVNfSU5MSU5FIFN0YWNrQm91 bmRzOjpTdGFja0RpcmVjdGlvbiBTdGFja0JvdW5kczo6c3RhY2tEaXJlY3Rpb24oKQogICAgIHJl dHVybiBTdGFja0RpcmVjdGlvbjo6RG93bndhcmQ7CiB9CiAjZWxzZQotc3RhdGljIE5FVkVSX0lO TElORSBOT1RfVEFJTF9DQUxMRUQgU3RhY2tCb3VuZHM6OlN0YWNrRGlyZWN0aW9uIHRlc3RTdGFj a0RpcmVjdGlvbjIodm9sYXRpbGUgY29uc3QgaW50KiBwb2ludGVyKQorc3RhdGljIE5FVkVSX0lO TElORSBOT1RfVEFJTF9DQUxMRUQgU3RhY2tCb3VuZHM6OlN0YWNrRGlyZWN0aW9uIHRlc3RTdGFj a0RpcmVjdGlvbjIodm9sYXRpbGUgY29uc3QgdWludDhfdCogcG9pbnRlcikKIHsKLSAgICB2b2xh dGlsZSBpbnQgc3RhY2tWYWx1ZSA9IDQyOwotICAgIHJldHVybiAocG9pbnRlciA8ICZzdGFja1Zh bHVlKSA/IFN0YWNrQm91bmRzOjpTdGFja0RpcmVjdGlvbjo6VXB3YXJkIDogU3RhY2tCb3VuZHM6 OlN0YWNrRGlyZWN0aW9uOjpEb3dud2FyZDsKKyAgICB2b2xhdGlsZSB1aW50OF90KiBzdGFja1Zh bHVlID0gYml0d2lzZV9jYXN0PHVpbnQ4X3QqPihjdXJyZW50U3RhY2tQb2ludGVyKCkpOworICAg IHJldHVybiAocG9pbnRlciA8IHN0YWNrVmFsdWUpID8gU3RhY2tCb3VuZHM6OlN0YWNrRGlyZWN0 aW9uOjpVcHdhcmQgOiBTdGFja0JvdW5kczo6U3RhY2tEaXJlY3Rpb246OkRvd253YXJkOwogfQog CiBzdGF0aWMgTkVWRVJfSU5MSU5FIE5PVF9UQUlMX0NBTExFRCBTdGFja0JvdW5kczo6U3RhY2tE aXJlY3Rpb24gdGVzdFN0YWNrRGlyZWN0aW9uKCkKIHsKICAgICBOT19UQUlMX0NBTExTKCk7Ci0g ICAgdm9sYXRpbGUgaW50IHN0YWNrVmFsdWUgPSA0MjsKLSAgICByZXR1cm4gdGVzdFN0YWNrRGly ZWN0aW9uMigmc3RhY2tWYWx1ZSk7CisgICAgdm9sYXRpbGUgdWludDhfdCogc3RhY2tWYWx1ZSA9 IGJpdHdpc2VfY2FzdDx1aW50OF90Kj4oY3VycmVudFN0YWNrUG9pbnRlcigpKTsKKyAgICByZXR1 cm4gdGVzdFN0YWNrRGlyZWN0aW9uMihzdGFja1ZhbHVlKTsKIH0KIAogTkVWRVJfSU5MSU5FIFN0 YWNrQm91bmRzOjpTdGFja0RpcmVjdGlvbiBTdGFja0JvdW5kczo6c3RhY2tEaXJlY3Rpb24oKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwIGIvU291cmNl L1dURi93dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCmluZGV4IDEwNTBjM2I0Y2ZhZjU2YjNkOWFj ZWU0ZGQ0MmZiMzI5MzA0MjkxNTMuLjY0MDRiNDIxNDcwN2M4MWI4MDc0NzFmYjdlZDQyOTlkMWIz ZTU3NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNwcAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHAKQEAgLTEwOSwxOSArMTA5 LDYgQEAgc3RhdGljIExhenlOZXZlckRlc3Ryb3llZDxTZW1hcGhvcmU+IGdsb2JhbFNlbWFwaG9y ZUZvclN1c3BlbmRSZXN1bWU7CiBzdGF0aWMgY29uc3RleHByIGNvbnN0IGludCBTaWdUaHJlYWRT dXNwZW5kUmVzdW1lID0gU0lHVVNSMTsKIHN0YXRpYyBzdGQ6OmF0b21pYzxUaHJlYWQqPiB0YXJn ZXRUaHJlYWQgeyBudWxscHRyIH07CiAKLUlHTk9SRV9HQ0NfV0FSTklOR1NfQkVHSU4oInJldHVy bi1sb2NhbC1hZGRyIikKLUlHTk9SRV9DTEFOR19XQVJOSU5HU19CRUdJTigicmV0dXJuLXN0YWNr LWFkZHJlc3MiKQotCi1zdGF0aWMgTkVWRVJfSU5MSU5FIHZvaWQqIGdldEFwcHJveGltYXRlU3Rh Y2tQb2ludGVyKCkKLXsKLSAgICB2b2xhdGlsZSB1aW50cHRyX3Qgc3RhY2tMb2NhdGlvbjsKLSAg ICBzdGFja0xvY2F0aW9uID0gYml0d2lzZV9jYXN0PHVpbnRwdHJfdD4oJnN0YWNrTG9jYXRpb24p OwotICAgIHJldHVybiBiaXR3aXNlX2Nhc3Q8dm9pZCo+KHN0YWNrTG9jYXRpb24pOwotfQotCi1J R05PUkVfQ0xBTkdfV0FSTklOR1NfRU5ECi1JR05PUkVfR0NDX1dBUk5JTkdTX0VORAotCiB2b2lk IFRocmVhZDo6c2lnbmFsSGFuZGxlclN1c3BlbmRSZXN1bWUoaW50LCBzaWdpbmZvX3QqLCB2b2lk KiB1Y29udGV4dCkKIHsKICAgICAvLyBUb3VjaGluZyBhIGdsb2JhbCB2YXJpYWJsZSBhdG9taWMg dHlwZXMgZnJvbSBzaWduYWwgaGFuZGxlcnMgaXMgYWxsb3dlZC4KQEAgLTEzNyw3ICsxMjQsNyBA QCB2b2lkIFRocmVhZDo6c2lnbmFsSGFuZGxlclN1c3BlbmRSZXN1bWUoaW50LCBzaWdpbmZvX3Qq LCB2b2lkKiB1Y29udGV4dCkKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIHZvaWQqIGFw cHJveGltYXRlU3RhY2tQb2ludGVyID0gZ2V0QXBwcm94aW1hdGVTdGFja1BvaW50ZXIoKTsKKyAg ICB2b2lkKiBhcHByb3hpbWF0ZVN0YWNrUG9pbnRlciA9IGN1cnJlbnRTdGFja1BvaW50ZXIoKTsK ICAgICBpZiAoIXRocmVhZC0+bV9zdGFjay5jb250YWlucyhhcHByb3hpbWF0ZVN0YWNrUG9pbnRl cikpIHsKICAgICAgICAgLy8gVGhpcyBoYXBwZW5zIGlmIHdlIHVzZSBhbiBhbHRlcm5hdGl2ZSBz aWduYWwgc3RhY2suCiAgICAgICAgIC8vIDEuIEEgdXNlci1kZWZpbmVkIHNpZ25hbCBoYW5kbGVy IGlzIGludm9rZWQgd2l0aCBhbiBhbHRlcm5hdGl2ZSBzaWduYWwgc3RhY2suCg==