190477 2018-10-11 13:08:51 -0700 Add PLATFORM(IOS_FAMILY) and OS(IOS_FAMILY) 2018-10-12 09:59:21 -0700 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aestes bdakin benjamin cdumez cmarcelo dbates ews-watchlist mitz simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1468119 0 ap 2018-10-11 13:08:51 -0700 Currently, PLATFORM(IOS) and OS(IOS) are true when building for any TARGET_OS_IPHONE target, which is quite confusing. Add a better named alternative, as a first step towards mass replacing PLATFORM(IOS). Can't so it all at once because of dependencies in other source repositories. 1468122 1 352068 ap 2018-10-11 13:12:26 -0700 Created attachment 352068 proposed patch 1468123 2 thorton 2018-10-11 13:13:06 -0700 Earlier suggestion was PLATFORM(COCOA_TOUCH). Technically that does include all UIKitty platforms even if they don't have touch proper. 1468134 3 ap 2018-10-11 13:29:08 -0700 Do you like that earlier suggestion more? I do not. 1468216 4 352068 thorton 2018-10-11 15:47:27 -0700 Comment on attachment 352068 proposed patch I'd like to hear more r+ of the name first, but the approach is fine 1468230 5 mitz 2018-10-11 16:15:33 -0700 Of the names proposed so far, I prefer the one in the patch. 1468461 6 ap 2018-10-12 09:58:40 -0700 Committed http://trac.webkit.org/r237069 1468462 7 webkit-bug-importer 2018-10-12 09:59:21 -0700 <rdar://problem/45228899> 352068 2018-10-11 13:12:26 -0700 2018-10-11 15:47:27 -0700 proposed patch AddFamily.txt text/plain 6038 ap SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzcwNDQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTExICBBbGV4ZXkgUHJvc2t1cnlha292 ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBQTEFURk9STShJT1NfRkFNSUxZKSBhbmQg T1MoSU9TX0ZBTUlMWSkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5MDQ3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEN1cnJlbnRseSwgUExBVEZPUk0oSU9TKSBhbmQgT1MoSU9TKSBhcmUgdHJ1ZSB3aGVu IGJ1aWxkaW5nIGZvciBhbnkKKyAgICAgICAgVEFSR0VUX09TX0lQSE9ORSB0YXJnZXQsIHdoaWNo IGlzIHF1aXRlIGNvbmZ1c2luZy4gQWRkIGEgYmV0dGVyIG5hbWVkIGFsdGVybmF0aXZlLAorICAg ICAgICBhcyBhIGZpcnN0IHN0ZXAgdG93YXJkcyBtYXNzIHJlcGxhY2luZyBQTEFURk9STShJT1Mp LiBDYW4ndCBzbyBpdCBhbGwgYXQgb25jZQorICAgICAgICBiZWNhdXNlIG9mIGRlcGVuZGVuY2ll cyBpbiBvdGhlciBzb3VyY2UgcmVwb3NpdG9yaWVzLgorCisgICAgICAgICogd3RmL1BsYXRmb3Jt Lmg6IENoYW5nZWQgdG8gdGhlIG5ldyBuYW1lIGluIHRoaXMgZmlsZSB0aG91Z2guIEtlcHQgYSBm ZXcKKyAgICAgICAgaW5zdGFuY2VzIHRoYXQgYWN0dWFsbHkgdGFyZ2V0IGlPUyBvbmx5LCBoYXZp bmcgYSB2ZXJzaW9uIGNoZWNrLgorCiAyMDE4LTEwLTEwICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2VzIHRvd2FyZHMgYWxsb3dpbmcgdXNlIG9mIHRoZSBB U0FOIGRldGVjdF9zdGFja191c2VfYWZ0ZXJfcmV0dXJuIG9wdGlvbi4KSW5kZXg6IFNvdXJjZS9X VEYvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0u aAkocmV2aXNpb24gMjM2OTE0KQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2lu ZyBjb3B5KQpAQCAtMzcwLDExICszNzAsMTIgQEAKICNpbmNsdWRlIDxUYXJnZXRDb25kaXRpb25h bHMuaD4KICNlbmRpZgogCi0vKiBPUyhJT1MpIC0gaU9TICovCi0vKiBPUyhNQUNfT1NfWCkgLSBN YWMgT1MgWCAobm90IGluY2x1ZGluZyBpT1MpICovCisvKiBPUyhJT1NfRkFNSUxZKSAtIGlPUyBm YW1pbHksIGluY2x1ZGluZyBpT1NNYWMgKi8KKy8qIE9TKE1BQ19PU19YKSAtIG1hY09TIChub3Qg aW5jbHVkaW5nIGlPUyBmYW1pbHkpICovCiAjaWYgT1MoREFSV0lOKQogI2lmIFRBUkdFVF9PU19J UEhPTkUKICNkZWZpbmUgV1RGX09TX0lPUyAxCisjZGVmaW5lIFdURl9PU19JT1NfRkFNSUxZIDEK ICNlbGlmIFRBUkdFVF9PU19NQUMKICNkZWZpbmUgV1RGX09TX01BQ19PU19YIDEKICNlbmRpZgpA QCAtNTEwLDcgKzUxMSw5IEBACiAvKiBQTEFURk9STShHVEspICovCiAvKiBQTEFURk9STShNQUMp ICovCiAvKiBQTEFURk9STShJT1MpICovCisvKiBQTEFURk9STShJT1NfRkFNSUxZKSAqLwogLyog UExBVEZPUk0oSU9TX1NJTVVMQVRPUikgKi8KKy8qIFBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxB VE9SKSAqLwogLyogUExBVEZPUk0oV0lOKSAqLwogI2lmIGRlZmluZWQoQlVJTERJTkdfR1RLX18p CiAjZGVmaW5lIFdURl9QTEFURk9STV9HVEsgMQpAQCAtNTIyLDggKzUyNSwxMCBAQAogI2RlZmlu ZSBXVEZfUExBVEZPUk1fTUFDIDEKICNlbGlmIE9TKElPUykKICNkZWZpbmUgV1RGX1BMQVRGT1JN X0lPUyAxCisjZGVmaW5lIFdURl9QTEFURk9STV9JT1NfRkFNSUxZIDEKICNpZiBUQVJHRVRfT1Nf U0lNVUxBVE9SCiAjZGVmaW5lIFdURl9QTEFURk9STV9JT1NfU0lNVUxBVE9SIDEKKyNkZWZpbmUg V1RGX1BMQVRGT1JNX0lPU19GQU1JTFlfU0lNVUxBVE9SIDEKICNlbmRpZgogI2lmIGRlZmluZWQo VEFSR0VUX09TX0lPU01BQykgJiYgVEFSR0VUX09TX0lPU01BQwogI2RlZmluZSBXVEZfUExBVEZP Uk1fSU9TTUFDIDEKQEAgLTUzMyw3ICs1MzgsNyBAQAogI2VuZGlmCiAKIC8qIFBMQVRGT1JNKENP Q09BKSAqLwotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oSU9TKQorI2lmIFBMQVRGT1JN KE1BQykgfHwgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0NPQ09B IDEKICNlbmRpZgogCkBAIC02MTUsNyArNjIwLDcgQEAKICNlbmRpZgogI2VuZGlmIC8qIFBMQVRG T1JNKE1BQykgKi8KIAotI2lmIFBMQVRGT1JNKElPUykKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZ KQogCiAjZGVmaW5lIEhBVkVfTkVUV09SS19FWFRFTlNJT04gMQogI2RlZmluZSBIQVZFX1JFQURM SU5FIDEKQEAgLTYzMSw3ICs2MzYsNyBAQAogI2RlZmluZSBIQVZFX0FSTV9ORU9OX0lOVFJJTlNJ Q1MgMAogI2VuZGlmCiAKLSNlbmRpZiAvKiBQTEFURk9STShJT1MpICovCisjZW5kaWYgLyogUExB VEZPUk0oSU9TX0ZBTUlMWSkgKi8KIAogI2lmICFkZWZpbmVkKEhBVkVfQUNDRVNTSUJJTElUWSkK ICNpZiBQTEFURk9STShDT0NPQSkgfHwgUExBVEZPUk0oV0lOKSB8fCBQTEFURk9STShHVEspIHx8 IFBMQVRGT1JNKFdQRSkKQEAgLTY4OCw3ICs2OTMsNyBAQAogI2lmICFQTEFURk9STShHVEspCiAj ZGVmaW5lIFVTRV9BQ0NFTEVSQVRFIDEKICNlbmRpZgotI2lmICFQTEFURk9STShJT1MpCisjaWYg IVBMQVRGT1JNKElPU19GQU1JTFkpCiAjZGVmaW5lIEhBVkVfSE9TVEVEX0NPUkVfQU5JTUFUSU9O IDEKICNlbmRpZgogCkBAIC03NzQsNyArNzc5LDcgQEAKICNlbmRpZgogCiAvKiBUaGUgRlRMIGlz IGRpc2FibGVkIG9uIHRoZSBpT1Mgc2ltdWxhdG9yLCBtb3N0bHkgZm9yIHNpbXBsaWNpdHkuICov Ci0jaWYgUExBVEZPUk0oSU9TX1NJTVVMQVRPUikKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZX1NJ TVVMQVRPUikKICN1bmRlZiBFTkFCTEVfRlRMX0pJVAogI2RlZmluZSBFTkFCTEVfRlRMX0pJVCAw CiAjZW5kaWYKQEAgLTgwMCw3ICs4MDUsNyBAQAogI2RlZmluZSBFTkFCTEVfREZHX0pJVCAxCiAj ZW5kaWYKIC8qIEVuYWJsZSB0aGUgREZHIEpJVCBvbiBBUk12Ny4gIE9ubHkgdGVzdGVkIG9uIGlP UywgTGludXgsIGFuZCBGcmVlQlNELiAqLwotI2lmIChDUFUoQVJNX1RIVU1CMikgfHwgQ1BVKEFS TTY0KSkgJiYgKFBMQVRGT1JNKElPUykgfHwgT1MoTElOVVgpIHx8IE9TKEZSRUVCU0QpKQorI2lm IChDUFUoQVJNX1RIVU1CMikgfHwgQ1BVKEFSTTY0KSkgJiYgKFBMQVRGT1JNKElPU19GQU1JTFkp IHx8IE9TKExJTlVYKSB8fCBPUyhGUkVFQlNEKSkKICNkZWZpbmUgRU5BQkxFX0RGR19KSVQgMQog I2VuZGlmCiAvKiBFbmFibGUgdGhlIERGRyBKSVQgb24gQVJNLiAqLwpAQCAtMTAzMSwxNCArMTAz NiwxNCBAQAogCiAvKiBDU1MgU2VsZWN0b3IgSklUIENvbXBpbGVyICovCiAjaWYgIWRlZmluZWQo RU5BQkxFX0NTU19TRUxFQ1RPUl9KSVQpCi0jaWYgKENQVShYODZfNjQpIHx8IENQVShBUk02NCkg fHwgKENQVShBUk1fVEhVTUIyKSAmJiBQTEFURk9STShJT1MpKSkgJiYgRU5BQkxFKEpJVCkgJiYg KE9TKERBUldJTikgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXUEUpKQorI2lmIChDUFUo WDg2XzY0KSB8fCBDUFUoQVJNNjQpIHx8IChDUFUoQVJNX1RIVU1CMikgJiYgUExBVEZPUk0oSU9T X0ZBTUlMWSkpKSAmJiBFTkFCTEUoSklUKSAmJiAoT1MoREFSV0lOKSB8fCBQTEFURk9STShHVEsp IHx8IFBMQVRGT1JNKFdQRSkpCiAjZGVmaW5lIEVOQUJMRV9DU1NfU0VMRUNUT1JfSklUIDEKICNl bHNlCiAjZGVmaW5lIEVOQUJMRV9DU1NfU0VMRUNUT1JfSklUIDAKICNlbmRpZgogI2VuZGlmCiAK LSNpZiBQTEFURk9STShJT1MpCisjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICNpZiAhUExBVEZP Uk0oV0FUQ0hPUykgJiYgIVBMQVRGT1JNKEFQUExFVFYpICYmICFQTEFURk9STShJT1NNQUMpCiAj ZGVmaW5lIFVTRV9RVUlDS19MT09LIDEKICNkZWZpbmUgSEFWRV9BUFBfTElOS1MgMQpAQCAtMTE0 OCw3ICsxMTUzLDcgQEAKICNlbmRpZgogI2VuZGlmCiAKLSNpZiBQTEFURk9STShJT1MpIHx8IFBM QVRGT1JNKE1BQykKKyNpZiBQTEFURk9STShJT1NfRkFNSUxZKSB8fCBQTEFURk9STShNQUMpCiAj ZGVmaW5lIFVTRV9DT1JFTUVESUEgMQogI2RlZmluZSBVU0VfVklERU9UT09MQk9YIDEKIApAQCAt MTE1OSwxNiArMTE2NCwxNiBAQAogI2VuZGlmCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKElPUykg fHwgUExBVEZPUk0oTUFDKQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpIHx8IFBMQVRGT1JNKE1B QykKICNkZWZpbmUgSEFWRV9BVkZPVU5EQVRJT05fTUVESUFfU0VMRUNUSU9OX0dST1VQIDEKICNl bmRpZgogCi0jaWYgUExBVEZPUk0oSU9TKSB8fCBQTEFURk9STShNQUMpCisjaWYgUExBVEZPUk0o SU9TX0ZBTUlMWSkgfHwgUExBVEZPUk0oTUFDKQogI2RlZmluZSBIQVZFX0FWRk9VTkRBVElPTl9M RUdJQkxFX09VVFBVVF9TVVBQT1JUIDEKICNkZWZpbmUgSEFWRV9NRURJQV9BQ0NFU1NJQklMSVRZ X0ZSQU1FV09SSyAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0oTUFD KQorI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpIHx8IFBMQVRGT1JNKE1BQykKICNkZWZpbmUgSEFW RV9BVkZPVU5EQVRJT05fTE9BREVSX0RFTEVHQVRFIDEKICNlbmRpZgogCkBAIC0xMjIwLDcgKzEy MjUsNyBAQAogI2RlZmluZSBVU0VfSU5TRVJUSU9OX1VORE9fR1JPVVBJTkcgMQogI2VuZGlmCiAK LSNpZiBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykKKyNpZiBQTEFURk9STShNQUMpIHx8 IFBMQVRGT1JNKElPU19GQU1JTFkpCiAjZGVmaW5lIEhBVkVfQVZBU1NFVFJFQURFUiAxCiAjZW5k aWYKIApAQCAtMTIzMiwxMSArMTIzNywxMSBAQAogI2RlZmluZSBVU0VfQVVESU9fU0VTU0lPTiAx CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKENPQ09BKSAmJiAhUExBVEZPUk0oSU9TX1NJTVVMQVRP UikKKyNpZiBQTEFURk9STShDT0NPQSkgJiYgIVBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9S KQogI2RlZmluZSBIQVZFX0lPU1VSRkFDRSAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKElPUykg JiYgIVBMQVRGT1JNKElPU19TSU1VTEFUT1IpICYmICFQTEFURk9STShJT1NNQUMpCisjaWYgUExB VEZPUk0oSU9TX0ZBTUlMWSkgJiYgIVBMQVRGT1JNKElPU19GQU1JTFlfU0lNVUxBVE9SKSAmJiAh UExBVEZPUk0oSU9TTUFDKQogI2RlZmluZSBIQVZFX0lPU1VSRkFDRV9BQ0NFTEVSQVRPUiAxCiAj ZW5kaWYKIApAQCAtMTI4Myw3ICsxMjg4LDcgQEAKICNkZWZpbmUgVVNFX01FRElBVE9PTEJPWCAx CiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oSU9TKQorI2lmIFBMQVRG T1JNKE1BQykgfHwgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICNkZWZpbmUgVVNFX09TX0xPRyAxCiAj aWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykKICNkZWZpbmUgVVNFX09TX1NUQVRFIDEKQEAgLTEz MTgsNyArMTMyMyw3IEBACiAjZW5kaWYKICNlbmRpZgogCi0jaWYgUExBVEZPUk0oTUFDKSB8fCBQ TEFURk9STShJT1MpCisjaWYgUExBVEZPUk0oTUFDKSB8fCBQTEFURk9STShJT1NfRkFNSUxZKQog I2RlZmluZSBVU0VfTUVESUFSRU1PVEUgMQogI2VuZGlmCiAKQEAgLTEzNjIsNyArMTM2Nyw3IEBA CiAjZGVmaW5lIEhBVkVfU0VDX0tFWV9QUk9YWSAxCiAjZW5kaWYKIAotI2lmIFBMQVRGT1JNKENP Q09BKSAmJiBVU0UoQ0EpICYmICFQTEFURk9STShJT1NfU0lNVUxBVE9SKQorI2lmIFBMQVRGT1JN KENPQ09BKSAmJiBVU0UoQ0EpICYmICFQTEFURk9STShJT1NfRkFNSUxZX1NJTVVMQVRPUikKICNk ZWZpbmUgVVNFX0lPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRSAxCiAjZW5kaWYKIAo=