190474 2018-10-11 09:09:24 -0700 Regression(PSON): Deal with the drawing area potentially being null under WebChromeClient::contentsSizeChanged() 2018-10-11 10:26:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren koivisto webkit-bug-importer oldest_to_newest 1468043 0 cdumez 2018-10-11 09:09:24 -0700 Deal with the drawing area potentially being null under WebChromeClient::contentsSizeChanged(): Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x0000000106858c6d WebKit::WebChromeClient::contentsSizeChanged(WebCore::Frame&, WebCore::IntSize const&) const + 333 (WebChromeClient.cpp:600) 1 com.apple.WebCore 0x0000000117de28c9 WebCore::Chrome::contentsSizeChanged(WebCore::Frame&, WebCore::IntSize const&) const + 73 (Chrome.cpp:136) 2 com.apple.WebCore 0x0000000117e68d6c WebCore::FrameView::setContentsSize(WebCore::IntSize const&) + 204 (FrameView.cpp:628) 3 com.apple.WebCore 0x0000000117e6058f WebCore::FrameView::adjustViewSize() + 687 (FrameView.cpp:650) 4 com.apple.WebCore 0x0000000117e63468 WebCore::FrameViewLayoutContext::layout() + 2392 (FrameViewLayoutContext.cpp:228) 5 com.apple.WebCore 0x0000000117e5b66c WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() + 300 (FrameView.cpp:4295) 6 com.apple.WebCore 0x0000000117e279da WebCore::EventHandler::hitTestResultAtPoint(WebCore::LayoutPoint const&, unsigned int, WebCore::LayoutSize const&) const + 906 7 com.apple.WebKit 0x000000010690eb68 WebKit::WebFrame::hitTest(WebCore::IntPoint) const + 168 (WebFrame.cpp:639) 8 com.apple.WebKit 0x000000010674f1b1 WKBundleFrameCreateHitTestResult + 65 (WKBundleFrame.cpp:273) 9 com.apple.Safari.framework 0x000000012944072b Safari::WK::BundleFrame::hitTest(CGPoint) const + 155 (BundleFrame.mm:236) 1468044 1 352048 cdumez 2018-10-11 09:10:10 -0700 Created attachment 352048 Patch 1468065 2 352048 ggaren 2018-10-11 09:59:16 -0700 Comment on attachment 352048 Patch r=me 1468074 3 352048 commit-queue 2018-10-11 10:25:26 -0700 Comment on attachment 352048 Patch Clearing flags on attachment: 352048 Committed r237035: <https://trac.webkit.org/changeset/237035> 1468075 4 commit-queue 2018-10-11 10:25:27 -0700 All reviewed patches have been landed. Closing bug. 1468076 5 webkit-bug-importer 2018-10-11 10:26:32 -0700 <rdar://problem/45197158> 352048 2018-10-11 09:10:10 -0700 2018-10-11 10:25:26 -0700 Patch bug-190474-20181011091010.patch text/plain 1611 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM0ZjM4MjJlMzk0YTcwMzI5 YTI3NjQ5YTNiZjhhOTNhZjBjZTdlYmEuLmMzNWJlNDcxYzUxODE4ZWM2OTJjY2NlZDkzNTI1NzJm MTk5Y2I2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMTAtMTEgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKFBTT04pOiBEZWFs IHdpdGggdGhlIGRyYXdpbmcgYXJlYSBwb3RlbnRpYWxseSBiZWluZyBudWxsIHVuZGVyIFdlYkNo cm9tZUNsaWVudDo6Y29udGVudHNTaXplQ2hhbmdlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTA0NzQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2Vi Q2hyb21lQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ2hyb21lQ2xpZW50Ojpjb250 ZW50c1NpemVDaGFuZ2VkIGNvbnN0KToKKwogMjAxOC0xMC0xMSAgQWxlamFuZHJvIEcuIENhc3Ry byAgPGFsZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIEFkZCBtZWRpYURldmlj ZXMuZW51bWVyYXRlRGV2aWNlcyBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCmluZGV4IGY5 MzY2N2FlNDhlOWQ3ODFmMzJmMjZhMTBhM2E1MmY3Y2ZhOGMzMTYuLmY4ZjAzMGMyM2ExN2Q0MTJl YWZlNWZmMTY1OWI3YjU1NDEwZDEyZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCkBAIC01OTcs NyArNTk3LDggQEAgdm9pZCBXZWJDaHJvbWVDbGllbnQ6OmNvbnRlbnRzU2l6ZUNoYW5nZWQoRnJh bWUmIGZyYW1lLCBjb25zdCBJbnRTaXplJiBzaXplKSBjb24KIAogICAgIG1fcGFnZS5zZW5kKE1l c3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZENoYW5nZUNvbnRlbnRTaXplKHNpemUpKTsKIAotICAg IG1fcGFnZS5kcmF3aW5nQXJlYSgpLT5tYWluRnJhbWVDb250ZW50U2l6ZUNoYW5nZWQoc2l6ZSk7 CisgICAgaWYgKGF1dG8qIGRyYXdpbmdBcmVhID0gbV9wYWdlLmRyYXdpbmdBcmVhKCkpCisgICAg ICAgIGRyYXdpbmdBcmVhLT5tYWluRnJhbWVDb250ZW50U2l6ZUNoYW5nZWQoc2l6ZSk7CiAKICAg ICBpZiAoZnJhbWVWaWV3ICYmICFmcmFtZVZpZXctPmRlbGVnYXRlc1Njcm9sbGluZygpKSAgewog ICAgICAgICBib29sIGhhc0hvcml6b250YWxTY3JvbGxiYXIgPSBmcmFtZVZpZXctPmhvcml6b250 YWxTY3JvbGxiYXIoKTsK