190464 2018-10-11 03:02:39 -0700 [GStreamer][MSE] Fix height calculation for streams with source aspect ratio 2018-10-11 05:26:59 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha bandou.yacine calvaris commit-queue webkit-bug-importer oldest_to_newest 1467990 0 eocanha 2018-10-11 03:02:39 -0700 (At least) MPEG-DASH videos with Screen Aspect Ration (SAR) different than 1:1 are wrongly displayed when played with dash.js 2.9.0. The code that computes width/height on MSE is applying the SAR correction inversely. The actual result is a back and forth aspect switch between what dash.js (properly) computes as video resolution and what MSE (wrongly) computes as video resolution. For instance, in a video hacked to have SAR 2:1 (so it should have twice its normal width) the video is displayed with double-width, then half-width, then double, etc. Note that the video has double-width when the MPEG-DASH URL is played using a standalone gst-play-1.0 player. 1467991 1 352032 eocanha 2018-10-11 03:10:18 -0700 Created attachment 352032 Patch 1468005 2 352032 commit-queue 2018-10-11 04:10:21 -0700 Comment on attachment 352032 Patch Clearing flags on attachment: 352032 Committed r237033: <https://trac.webkit.org/changeset/237033> 1468006 3 commit-queue 2018-10-11 04:10:23 -0700 All reviewed patches have been landed. Closing bug. 1468007 4 webkit-bug-importer 2018-10-11 04:11:31 -0700 <rdar://problem/45189891> 1468009 5 pnormand 2018-10-11 04:44:59 -0700 *** Bug 183591 has been marked as a duplicate of this bug. *** 1468010 6 bandou.yacine 2018-10-11 05:26:59 -0700 (In reply to Philippe Normand from comment #5) > *** Bug 183591 has been marked as a duplicate of this bug. *** I think that should be the opposite ;) 352032 2018-10-11 03:10:18 -0700 2018-10-11 04:10:21 -0700 Patch bug-190464-20181011101017.patch text/plain 1865 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzBhZjg3NDFhYTFjZmRj MTU5MGI4MTczODNiMGI2YTU0N2Q5MTYwYi4uYTU3OTM3YTI5NjA4NTE4YTdmMzAxZGJmYmNhZmEx OGE1OTg0ZWU1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTExICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bTVNFXSBGaXggaGVpZ2h0IGNhbGN1bGF0aW9uIGZvciBzdHJlYW1zIHdpdGggc291 cmNlIGFzcGVjdCByYXRpbworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTkwNDY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBwYXRjaCBpcyBhdXRob3JlZCBieSBOaWtvbGEgVmVsamtvdmljIDxOaWtv bGEuVmVsamtvdmljQHplbnRlcmlvLmNvbT4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0Vmlk ZW9SZXNvbHV0aW9uRnJvbUNhcHMpOiBSZXZlcnNlIHRoZSBTQVIgYWRqdXN0bWVudCB0byAidW5k byIgaXQKKyAgICAgICAgaW5zdGVhZCBvZiBhcHBseWluZyBpdCB0d2ljZS4KKwogMjAxOC0wOS0y NyAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29ueS5jb20+CiAKICAgICAgICAgW0N1 cmxdIEZpeCBwcmlvcml0eSBpc3N1ZSB3aXRoIG11bHRpcGxlIGNvb2tpZXMgd2l0aCBkaWZmZXJl bnQgbGV2ZWwgb2YgcGF0aC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9HU3RyZWFtZXJDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKaW5kZXggNjA1ZDY3 MjcyMTQ0OTI5MDRiMzJlMzdhN2MxM2M5NDUyMTk5OThhNy4uYmUyOTRlYjljN2M3NGY0MjMyMjZk MTQ0ZjdkYWVjZmU0ZWEzYzc2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKQEAgLTEy MSw3ICsxMjEsNyBAQCBzdGQ6Om9wdGlvbmFsPEZsb2F0U2l6ZT4gZ2V0VmlkZW9SZXNvbHV0aW9u RnJvbUNhcHMoY29uc3QgR3N0Q2FwcyogY2FwcykKICAgICAgICAgcGl4ZWxBc3BlY3RSYXRpb0Rl bm9taW5hdG9yID0gR1NUX1ZJREVPX0lORk9fUEFSX0QoJmluZm8pOwogICAgIH0KIAotICAgIHJl dHVybiBzdGQ6Om1ha2Vfb3B0aW9uYWwoRmxvYXRTaXplKHdpZHRoLCBoZWlnaHQgKiAoc3RhdGlj X2Nhc3Q8ZmxvYXQ+KHBpeGVsQXNwZWN0UmF0aW9OdW1lcmF0b3IpIC8gc3RhdGljX2Nhc3Q8Zmxv YXQ+KHBpeGVsQXNwZWN0UmF0aW9EZW5vbWluYXRvcikpKSk7CisgICAgcmV0dXJuIHN0ZDo6bWFr ZV9vcHRpb25hbChGbG9hdFNpemUod2lkdGgsIGhlaWdodCAqIChzdGF0aWNfY2FzdDxmbG9hdD4o cGl4ZWxBc3BlY3RSYXRpb0Rlbm9taW5hdG9yKSAvIHN0YXRpY19jYXN0PGZsb2F0PihwaXhlbEFz cGVjdFJhdGlvTnVtZXJhdG9yKSkpKTsKIH0KIAogYm9vbCBnZXRTYW1wbGVWaWRlb0luZm8oR3N0 U2FtcGxlKiBzYW1wbGUsIEdzdFZpZGVvSW5mbyYgdmlkZW9JbmZvKQo=