190450 2018-10-10 15:35:25 -0700 WebPageProxy should always have a HistoryClient 2018-10-15 08:26:32 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez webkit-bug-importer oldest_to_newest 1467858 0 achristensen 2018-10-10 15:35:25 -0700 WebPageProxy should always have a HistoryClient 1467859 1 351994 achristensen 2018-10-10 15:38:54 -0700 Created attachment 351994 Patch 1469227 2 achristensen 2018-10-15 08:25:18 -0700 https://trac.webkit.org/changeset/237101/webkit 1469236 3 webkit-bug-importer 2018-10-15 08:26:32 -0700 <rdar://problem/45271690> 351994 2018-10-10 15:38:54 -0700 2018-10-12 17:18:35 -0700 Patch bug-190450-20181010153853.patch text/plain 7242 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzcwMTgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI2IEBACisyMDE4LTEwLTEwICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV2ViUGFnZVByb3h5 IHNob3VsZCBhbHdheXMgaGF2ZSBhIEhpc3RvcnlDbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQ1MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgd2lsbCBtYWtlIGl0IHNvIHdlIGRvbid0 IGZvcmdldCB0byBudWxsIGNoZWNrIGl0LgorICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3Ig YmVjYXVzZSB0aGUgZGVmYXVsdCBIaXN0b3J5Q2xpZW50IGRvZXMgbm90aGluZy4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvQVBJSGlzdG9yeUNsaWVudC5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvTmF2 aWdhdGlvblN0YXRlLm1tOgorICAgICAgICAoV2ViS2l0OjpOYXZpZ2F0aW9uU3RhdGU6OmNyZWF0 ZUhpc3RvcnlDbGllbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94eSk6CisgICAgICAgIChX ZWJLaXQ6OldlYlBhZ2VQcm94eTo6c2V0SGlzdG9yeUNsaWVudCk6CisgICAgICAgIChXZWJLaXQ6 OldlYlBhZ2VQcm94eTo6ZGlkTmF2aWdhdGVXaXRoTmF2aWdhdGlvbkRhdGEpOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OmRpZFBlcmZvcm1DbGllbnRSZWRpcmVjdCk6CisgICAgICAg IChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkUGVyZm9ybVNlcnZlclJlZGlyZWN0KToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRVcGRhdGVIaXN0b3J5VGl0bGUpOgorICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKwogMjAxOC0xMC0xMCAgVGltIEhvcnRvbiAg PHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBTaGFyZSBtb3JlIFdLU2hhcmVT aGVldCBjb2RlIGJldHdlZW4gbWFjT1MgYW5kIGlPUywgYW5kIGZpeCBhIGZldyBidWdzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDIzNjk3 MCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTM4Myw2ICszODMsNyBAQCBXZWJQYWdlUHJveHk6OldlYlBhZ2VQcm94eShQYWdl Q2xpZW50JiBwCiAgICAgOiBtX3BhZ2VDbGllbnQobWFrZVdlYWtQdHIocGFnZUNsaWVudCkpCiAg ICAgLCBtX2NvbmZpZ3VyYXRpb24oV1RGTW92ZShjb25maWd1cmF0aW9uKSkKICAgICAsIG1fbmF2 aWdhdGlvbkNsaWVudChtYWtlVW5pcXVlUmVmPEFQSTo6TmF2aWdhdGlvbkNsaWVudD4oKSkKKyAg ICAsIG1faGlzdG9yeUNsaWVudChtYWtlVW5pcXVlUmVmPEFQSTo6SGlzdG9yeUNsaWVudD4oKSkK ICAgICAsIG1faWNvbkxvYWRpbmdDbGllbnQoc3RkOjptYWtlX3VuaXF1ZTxBUEk6Okljb25Mb2Fk aW5nQ2xpZW50PigpKQogICAgICwgbV9mb3JtQ2xpZW50KHN0ZDo6bWFrZV91bmlxdWU8QVBJOjpG b3JtQ2xpZW50PigpKQogICAgICwgbV91aUNsaWVudChzdGQ6Om1ha2VfdW5pcXVlPEFQSTo6VUlD bGllbnQ+KCkpCkBAIC01NjMsNyArNTY0LDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNldFByZWZl cmVuY2VzKFdlYlByZQogICAgIHByZWZlcmVuY2VzRGlkQ2hhbmdlKCk7CiB9CiAgICAgCi12b2lk IFdlYlBhZ2VQcm94eTo6c2V0SGlzdG9yeUNsaWVudChzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpIaXN0 b3J5Q2xpZW50PiYmIGhpc3RvcnlDbGllbnQpCit2b2lkIFdlYlBhZ2VQcm94eTo6c2V0SGlzdG9y eUNsaWVudChVbmlxdWVSZWY8QVBJOjpIaXN0b3J5Q2xpZW50PiYmIGhpc3RvcnlDbGllbnQpCiB7 CiAgICAgbV9oaXN0b3J5Q2xpZW50ID0gV1RGTW92ZShoaXN0b3J5Q2xpZW50KTsKIH0KQEAgLTQy NzMsNyArNDI3NCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkaWROYXZpZ2F0ZVdpdGhOYXZpZ2EK ICAgICBNRVNTQUdFX0NIRUNLKGZyYW1lKTsKICAgICBNRVNTQUdFX0NIRUNLKGZyYW1lLT5wYWdl KCkgPT0gdGhpcyk7CiAKLSAgICBpZiAobV9oaXN0b3J5Q2xpZW50ICYmIGZyYW1lLT5pc01haW5G cmFtZSgpKQorICAgIGlmIChmcmFtZS0+aXNNYWluRnJhbWUoKSkKICAgICAgICAgbV9oaXN0b3J5 Q2xpZW50LT5kaWROYXZpZ2F0ZVdpdGhOYXZpZ2F0aW9uRGF0YSgqdGhpcywgc3RvcmUpOwogICAg IHByb2Nlc3MoKS5wcm9jZXNzUG9vbCgpLmhpc3RvcnlDbGllbnQoKS5kaWROYXZpZ2F0ZVdpdGhO YXZpZ2F0aW9uRGF0YShwcm9jZXNzKCkucHJvY2Vzc1Bvb2woKSwgKnRoaXMsIHN0b3JlLCAqZnJh bWUpOwogfQpAQCAtNDI5Miw3ICs0MjkzLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRpZFBlcmZv cm1DbGllbnRSZWRpcgogICAgIE1FU1NBR0VfQ0hFQ0tfVVJMKHNvdXJjZVVSTFN0cmluZyk7CiAg ICAgTUVTU0FHRV9DSEVDS19VUkwoZGVzdGluYXRpb25VUkxTdHJpbmcpOwogCi0gICAgaWYgKG1f aGlzdG9yeUNsaWVudCAmJiBmcmFtZS0+aXNNYWluRnJhbWUoKSkKKyAgICBpZiAoZnJhbWUtPmlz TWFpbkZyYW1lKCkpCiAgICAgICAgIG1faGlzdG9yeUNsaWVudC0+ZGlkUGVyZm9ybUNsaWVudFJl ZGlyZWN0KCp0aGlzLCBzb3VyY2VVUkxTdHJpbmcsIGRlc3RpbmF0aW9uVVJMU3RyaW5nKTsKICAg ICBwcm9jZXNzKCkucHJvY2Vzc1Bvb2woKS5oaXN0b3J5Q2xpZW50KCkuZGlkUGVyZm9ybUNsaWVu dFJlZGlyZWN0KHByb2Nlc3MoKS5wcm9jZXNzUG9vbCgpLCAqdGhpcywgc291cmNlVVJMU3RyaW5n LCBkZXN0aW5hdGlvblVSTFN0cmluZywgKmZyYW1lKTsKIH0KQEAgLTQzMTEsNyArNDMxMiw3IEBA IHZvaWQgV2ViUGFnZVByb3h5OjpkaWRQZXJmb3JtU2VydmVyUmVkaXIKICAgICBNRVNTQUdFX0NI RUNLX1VSTChzb3VyY2VVUkxTdHJpbmcpOwogICAgIE1FU1NBR0VfQ0hFQ0tfVVJMKGRlc3RpbmF0 aW9uVVJMU3RyaW5nKTsKIAotICAgIGlmIChtX2hpc3RvcnlDbGllbnQgJiYgZnJhbWUtPmlzTWFp bkZyYW1lKCkpCisgICAgaWYgKGZyYW1lLT5pc01haW5GcmFtZSgpKQogICAgICAgICBtX2hpc3Rv cnlDbGllbnQtPmRpZFBlcmZvcm1TZXJ2ZXJSZWRpcmVjdCgqdGhpcywgc291cmNlVVJMU3RyaW5n LCBkZXN0aW5hdGlvblVSTFN0cmluZyk7CiAgICAgcHJvY2VzcygpLnByb2Nlc3NQb29sKCkuaGlz dG9yeUNsaWVudCgpLmRpZFBlcmZvcm1TZXJ2ZXJSZWRpcmVjdChwcm9jZXNzKCkucHJvY2Vzc1Bv b2woKSwgKnRoaXMsIHNvdXJjZVVSTFN0cmluZywgZGVzdGluYXRpb25VUkxTdHJpbmcsICpmcmFt ZSk7CiB9CkBAIC00MzI2LDcgKzQzMjcsNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkVXBkYXRl SGlzdG9yeVRpdGxlCiAKICAgICBNRVNTQUdFX0NIRUNLX1VSTCh1cmwpOwogCi0gICAgaWYgKG1f aGlzdG9yeUNsaWVudCAmJiBmcmFtZS0+aXNNYWluRnJhbWUoKSkKKyAgICBpZiAoZnJhbWUtPmlz TWFpbkZyYW1lKCkpCiAgICAgICAgIG1faGlzdG9yeUNsaWVudC0+ZGlkVXBkYXRlSGlzdG9yeVRp dGxlKCp0aGlzLCB0aXRsZSwgdXJsKTsKICAgICBwcm9jZXNzKCkucHJvY2Vzc1Bvb2woKS5oaXN0 b3J5Q2xpZW50KCkuZGlkVXBkYXRlSGlzdG9yeVRpdGxlKHByb2Nlc3MoKS5wcm9jZXNzUG9vbCgp LCAqdGhpcywgdGl0bGUsIHVybCwgKmZyYW1lKTsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5oCShyZXZpc2lvbiAyMzY5NzApCisrKyBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuaAkod29ya2luZyBjb3B5KQpAQCAtNDI4LDcgKzQyOCw3IEBA IHB1YmxpYzoKICAgICB2b2lkIHNldERpYWdub3N0aWNMb2dnaW5nQ2xpZW50KHN0ZDo6dW5pcXVl X3B0cjxBUEk6OkRpYWdub3N0aWNMb2dnaW5nQ2xpZW50PiYmKTsKICAgICB2b2lkIHNldEZvcm1D bGllbnQoc3RkOjp1bmlxdWVfcHRyPEFQSTo6Rm9ybUNsaWVudD4mJik7CiAgICAgdm9pZCBzZXRO YXZpZ2F0aW9uQ2xpZW50KFVuaXF1ZVJlZjxBUEk6Ok5hdmlnYXRpb25DbGllbnQ+JiYpOwotICAg IHZvaWQgc2V0SGlzdG9yeUNsaWVudChzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpIaXN0b3J5Q2xpZW50 PiYmKTsKKyAgICB2b2lkIHNldEhpc3RvcnlDbGllbnQoVW5pcXVlUmVmPEFQSTo6SGlzdG9yeUNs aWVudD4mJik7CiAgICAgdm9pZCBzZXRMb2FkZXJDbGllbnQoc3RkOjp1bmlxdWVfcHRyPEFQSTo6 TG9hZGVyQ2xpZW50PiYmKTsKICAgICB2b2lkIHNldFBvbGljeUNsaWVudChzdGQ6OnVuaXF1ZV9w dHI8QVBJOjpQb2xpY3lDbGllbnQ+JiYpOwogICAgIHZvaWQgc2V0SW5qZWN0ZWRCdW5kbGVDbGll bnQoY29uc3QgV0tQYWdlSW5qZWN0ZWRCdW5kbGVDbGllbnRCYXNlKik7CkBAIC0xODYwLDcgKzE4 NjAsNyBAQCBwcml2YXRlOgogICAgIHN0ZDo6dW5pcXVlX3B0cjxBUEk6OkxvYWRlckNsaWVudD4g bV9sb2FkZXJDbGllbnQ7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEFQSTo6UG9saWN5Q2xpZW50PiBt X3BvbGljeUNsaWVudDsKICAgICBVbmlxdWVSZWY8QVBJOjpOYXZpZ2F0aW9uQ2xpZW50PiBtX25h dmlnYXRpb25DbGllbnQ7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPEFQSTo6SGlzdG9yeUNsaWVudD4g bV9oaXN0b3J5Q2xpZW50OworICAgIFVuaXF1ZVJlZjxBUEk6Okhpc3RvcnlDbGllbnQ+IG1faGlz dG9yeUNsaWVudDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpJY29uTG9hZGluZ0NsaWVudD4g bV9pY29uTG9hZGluZ0NsaWVudDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpGb3JtQ2xpZW50 PiBtX2Zvcm1DbGllbnQ7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEFQSTo6VUlDbGllbnQ+IG1fdWlD bGllbnQ7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJSGlzdG9yeUNsaWVu dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElIaXN0b3J5 Q2xpZW50LmgJKHJldmlzaW9uIDIzNjk3MCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQ SS9BUElIaXN0b3J5Q2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTIzLDggKzIzLDcgQEAKICAq IFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCi0jaWZuZGVmIEFQSUhpc3Rv cnlDbGllbnRfaAotI2RlZmluZSBBUElIaXN0b3J5Q2xpZW50X2gKKyNwcmFnbWEgb25jZQogCiAj aW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KIApAQCAtNDYsNSArNDUsMyBAQCBwdWJsaWM6CiB9Owog CiB9IC8vIG5hbWVzcGFjZSBBUEkKLQotI2VuZGlmIC8vIEFQSUhpc3RvcnlDbGllbnRfaApJbmRl eDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvTmF2aWdhdGlvblN0YXRlLmgJ KHJldmlzaW9uIDIzNjk3MCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL05hdmln YXRpb25TdGF0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw3ICs2Myw3IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgTmF2aWdhdGlvblN0YXRlJiBmcm9tV2ViUGFnZShXZWJQYWdlUHJveHkmKTsKIAog ICAgIFVuaXF1ZVJlZjxBUEk6Ok5hdmlnYXRpb25DbGllbnQ+IGNyZWF0ZU5hdmlnYXRpb25DbGll bnQoKTsKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8QVBJOjpIaXN0b3J5Q2xpZW50PiBjcmVhdGVIaXN0 b3J5Q2xpZW50KCk7CisgICAgVW5pcXVlUmVmPEFQSTo6SGlzdG9yeUNsaWVudD4gY3JlYXRlSGlz dG9yeUNsaWVudCgpOwogCiAgICAgUmV0YWluUHRyPGlkIDxXS05hdmlnYXRpb25EZWxlZ2F0ZT4g PiBuYXZpZ2F0aW9uRGVsZWdhdGUoKTsKICAgICB2b2lkIHNldE5hdmlnYXRpb25EZWxlZ2F0ZShp ZCA8V0tOYXZpZ2F0aW9uRGVsZWdhdGU+KTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9OYXZpZ2F0aW9uU3RhdGUubW0JKHJldmlzaW9uIDIzNjk4OSkKKysrIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL05hdmlnYXRpb25TdGF0ZS5tbQkod29ya2luZyBj b3B5KQpAQCAtMTI3LDkgKzEyNyw5IEBAIFVuaXF1ZVJlZjxBUEk6Ok5hdmlnYXRpb25DbGllbnQ+ IE5hdmlnYXQKICAgICByZXR1cm4gbWFrZVVuaXF1ZVJlZjxOYXZpZ2F0aW9uQ2xpZW50PigqdGhp cyk7CiB9CiAgICAgCi1zdGQ6OnVuaXF1ZV9wdHI8QVBJOjpIaXN0b3J5Q2xpZW50PiBOYXZpZ2F0 aW9uU3RhdGU6OmNyZWF0ZUhpc3RvcnlDbGllbnQoKQorVW5pcXVlUmVmPEFQSTo6SGlzdG9yeUNs aWVudD4gTmF2aWdhdGlvblN0YXRlOjpjcmVhdGVIaXN0b3J5Q2xpZW50KCkKIHsKLSAgICByZXR1 cm4gc3RkOjptYWtlX3VuaXF1ZTxIaXN0b3J5Q2xpZW50PigqdGhpcyk7CisgICAgcmV0dXJuIG1h a2VVbmlxdWVSZWY8SGlzdG9yeUNsaWVudD4oKnRoaXMpOwogfQogCiBSZXRhaW5QdHI8aWQgPFdL TmF2aWdhdGlvbkRlbGVnYXRlPiA+IE5hdmlnYXRpb25TdGF0ZTo6bmF2aWdhdGlvbkRlbGVnYXRl KCkK