190443 2018-10-10 14:30:36 -0700 Web Inspector: Network: detail view reverts to "Response" when new requests are added 2018-10-11 19:31:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1467831 0 hi 2018-10-10 14:30:36 -0700 * STEPS TO REPRODUCE: 1. Open WebInspector on any page 2. Go to the Network tab 3. Select a resource that has a request payload (e.g. JSON sent with the request) 4. Show the "Request" content under "Preview" 5. Fire another request on the page => "Response" content is suddenly shown Example request: fetch("data.json?" + Math.random(), { method: "POST", // headers: {"Content-Type": "application/json"}, body: `{"a":1,"b":2,"c":3,"d":4,"e":5,"f":6}`, }); 1467833 1 351986 hi 2018-10-10 14:38:11 -0700 Created attachment 351986 Patch This patch relies on changes from <https://webkit.org/b/189773>. I will upload a different version if that bug takes a while to land. 1467965 2 352017 hi 2018-10-10 22:31:24 -0700 Created attachment 352017 Patch Rebase 1468200 3 352017 joepeck 2018-10-11 15:14:45 -0700 Comment on attachment 352017 Patch Interesting! Does this fix when switching between resources? Currently when switching between resources it keeps popping back to "Response" instead of keeping it "Requests". That is probably separate though. 1468303 4 hi 2018-10-11 19:02:53 -0700 (In reply to Joseph Pecoraro from comment #3) > Interesting! Does this fix when switching between resources? Currently when > switching between resources it keeps popping back to "Response" instead of > keeping it "Requests". That is probably separate though. Nope :( Filed another bug: <https://webkit.org/b/190505> 1468312 5 352017 commit-queue 2018-10-11 19:30:25 -0700 Comment on attachment 352017 Patch Clearing flags on attachment: 352017 Committed r237061: <https://trac.webkit.org/changeset/237061> 1468313 6 commit-queue 2018-10-11 19:30:27 -0700 All reviewed patches have been landed. Closing bug. 1468315 7 webkit-bug-importer 2018-10-11 19:31:37 -0700 <rdar://problem/45214836> 351986 2018-10-10 14:38:11 -0700 2018-10-10 22:31:22 -0700 Patch 190443.diff text/plain 1589 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlZDQwM2Q5Yzc3Li5mODQyNzM3NDlkNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMTAgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5l dHdvcms6IGRldGFpbCB2aWV3IHJldmVydHMgdG8gIlJlc3BvbnNlIiB3aGVuIG5ldyByZXF1ZXN0 cyBhcmUgYWRkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5MDQ0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qczoKKyAg ICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fc2hvd0RldGFpbFZp ZXcpOgorICAgICAgICBSZXR1cm4gZWFybHkgaWYgd2UgYXJlIGFscmVhZHkgc2hvd2luZyBhIGRl dGFpbCB2aWV3IGZvciB0aGUgc2VsZWN0ZWQgb2JqZWN0LgorCiAyMDE4LTEwLTEwICBEZXZpbiBS b3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBkZXRh aWwgdmlldyBpcyBub3QgcmUtc2hvd24gYWZ0ZXIgc29ydGluZyB0aGUgTmV0d29yayB0YWJsZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0 d29ya1RhYmxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCA0ZDRlMmI0MTljYi4u ZDkwYzc3ZDYzNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCkBA IC0xMjY0LDYgKzEyNjQsOSBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5l dHdvcmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAgICAgICBsZXQg b2xkRGV0YWlsVmlldyA9IHRoaXMuX2RldGFpbFZpZXc7CiAKICAgICAgICAgdGhpcy5fZGV0YWls VmlldyA9IHRoaXMuX2RldGFpbFZpZXdNYXAuZ2V0KG9iamVjdCk7CisgICAgICAgIGlmICh0aGlz Ll9kZXRhaWxWaWV3ID09PSBvbGREZXRhaWxWaWV3KQorICAgICAgICAgICAgcmV0dXJuOworCiAg ICAgICAgIGlmICghdGhpcy5fZGV0YWlsVmlldykgewogICAgICAgICAgICAgaWYgKG9iamVjdCBp bnN0YW5jZW9mIFdJLlJlc291cmNlKQogICAgICAgICAgICAgICAgIHRoaXMuX2RldGFpbFZpZXcg PSBuZXcgV0kuTmV0d29ya1Jlc291cmNlRGV0YWlsVmlldyhvYmplY3QsIHRoaXMpOwo= 352017 2018-10-10 22:31:24 -0700 2018-10-11 19:30:25 -0700 Patch bug-190443-20181010223123.patch text/plain 1695 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM2NzE4YTdmNDgxZjRhM2NmNTQ5MjNhOTNlYzJh YmFiNzViY2QzOTcuLjY5MTRlZTA2NDQxNjFhNzI1OWM2ZjE3NjQyMTgzYTU1N2M3MDVmMTkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEwLTEwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXR3b3JrOiBkZXRhaWwgdmlldyByZXZlcnRzIHRvICJSZXNwb25zZSIgd2hlbiBuZXcgcmVxdWVz dHMgYXJlIGFkZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTA0NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanM6Cisg ICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUuX3Nob3dEZXRhaWxW aWV3KToKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlmIHdlIGFyZSBhbHJlYWR5IHNob3dpbmcgYSBk ZXRhaWwgdmlldyBmb3IgdGhlIHNlbGVjdGVkIG9iamVjdC4KKwogMjAxOC0xMC0xMCAgRGV2aW4g Um91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogY3Jl YXRlIHNwZWNpYWwgTmV0d29yayB3YXRlcmZhbGwgZm9yIG1lZGlhIGV2ZW50cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxl Q29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCAwODcwM2NhN2I4MDA5MTA0NmYyYTYy YTRiNmQ4YWYwNTJhMWQ4MWRmLi5iNGNmYzMzMTBhODI5ZWVmZTU5ODI3Y2IxOGZjMjg0MGZmNWIx YzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAtMTI0MCw2 ICsxMjQwLDkgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBOZXR3b3JrVGFi bGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAgbGV0IG9sZERldGFp bFZpZXcgPSB0aGlzLl9kZXRhaWxWaWV3OwogCiAgICAgICAgIHRoaXMuX2RldGFpbFZpZXcgPSB0 aGlzLl9kZXRhaWxWaWV3TWFwLmdldChvYmplY3QpOworICAgICAgICBpZiAodGhpcy5fZGV0YWls VmlldyA9PT0gb2xkRGV0YWlsVmlldykKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBp ZiAoIXRoaXMuX2RldGFpbFZpZXcpIHsKICAgICAgICAgICAgIGlmIChvYmplY3QgaW5zdGFuY2Vv ZiBXSS5SZXNvdXJjZSkKICAgICAgICAgICAgICAgICB0aGlzLl9kZXRhaWxWaWV3ID0gbmV3IFdJ Lk5ldHdvcmtSZXNvdXJjZURldGFpbFZpZXcob2JqZWN0LCB0aGlzKTsK