190441 2018-10-10 14:07:46 -0700 DOMCache should dereference itself as soon as stopped 2018-10-12 10:15:32 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue ggaren webkit-bug-importer oldest_to_newest 1467824 0 youennf 2018-10-10 14:07:46 -0700 Once stopped, it is no longer needed to keep a ref as the DOMCache is becoming a no-op. 1467825 1 351983 youennf 2018-10-10 14:10:23 -0700 Created attachment 351983 Patch 1467942 2 351983 ggaren 2018-10-10 20:19:08 -0700 Comment on attachment 351983 Patch What prevents stop() from being called multiple times? 1468091 3 352059 youennf 2018-10-11 11:14:35 -0700 Created attachment 352059 Patch 1468472 4 352059 commit-queue 2018-10-12 10:14:21 -0700 Comment on attachment 352059 Patch Clearing flags on attachment: 352059 Committed r237070: <https://trac.webkit.org/changeset/237070> 1468473 5 commit-queue 2018-10-12 10:14:22 -0700 All reviewed patches have been landed. Closing bug. 1468474 6 webkit-bug-importer 2018-10-12 10:15:32 -0700 <rdar://problem/45229381> 351983 2018-10-10 14:10:23 -0700 2018-10-11 11:14:34 -0700 Patch bug-190441-20181010141022.patch text/plain 1889 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWU1Y2Q4MDE3YWFkY2Zm YzI3MzAxNDg5OTYzYWY2OTYzNjg3Zjk0NS4uMTIwYWNmZDYyYjY5N2Q0ZTI0M2FjYTMyYTc5MmQ1 NjI5MzI1ZWMyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTEwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBET01DYWNoZSBzaG91bGQg ZGVyZWZlcmVuY2UgaXRzZWxmIGFzIHNvb24gYXMgc3RvcHBlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNDQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVyZWZlcmVuY2UgdGhlIERPTUNhY2hlIGFz IHNvb24gYXMgaXRzIGNvbnRleHQgaXMgc3RvcHBlZCBpbnN0ZWFkIG9mIHdhaXRpbmcgZm9yIGdh cmJhZ2UgY29sbGVjdGlvbi4KKyAgICAgICAgVGhpcyBhbGxvd3MgZnJlZWluZyByZXNvdXJjZXMg c29vbmVyIGluIHRoZSBuZXR3b3JrIHByb2Nlc3MuCisgICAgICAgIE5vIG9ic2VydmFibGUgY2hh bmdlIG9mIGJlaGF2aW9yIHNpbmNlIHRoZSBET01DYWNoZSBiZWNvbWVzIG5vLW9wIHdoZW4gaXRz IGNvbnRleHQgaXMgc3RvcHBlZC4KKworICAgICAgICAqIE1vZHVsZXMvY2FjaGUvRE9NQ2FjaGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NQ2FjaGU6On5ET01DYWNoZSk6CisgICAgICAgIChX ZWJDb3JlOjpET01DYWNoZTo6c3RvcCk6CisKIDIwMTgtMTAtMTAgIFRpbSBIb3J0b24gIDx0aW1v dGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2hhcmUgbW9yZSBXS1NoYXJlU2hlZXQg Y29kZSBiZXR3ZWVuIG1hY09TIGFuZCBpT1MsIGFuZCBmaXggYSBmZXcgYnVncwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9jYWNoZS9ET01DYWNoZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlLmNwcAppbmRleCBmNzkyZjVhMTAxMDQ2ZWYxMTAw MGE3MTFiNjE0MTkxMzFjMjg1ZjQzLi4xMmFjYzMxZmVmYzRkOTlkZmRlNDQ3ZjA5OWE1M2RmNmQ1 ZTdjNzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hl LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlLmNwcApAQCAt NTEsNyArNTEsOCBAQCBET01DYWNoZTo6RE9NQ2FjaGUoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYg Y29udGV4dCwgU3RyaW5nJiYgbmFtZSwgdWludDY0X3QgaWRlbgogCiBET01DYWNoZTo6fkRPTUNh Y2hlKCkKIHsKLSAgICBtX2Nvbm5lY3Rpb24tPmRlcmVmZXJlbmNlKG1faWRlbnRpZmllcik7Cisg ICAgaWYgKCFtX2lzU3RvcHBlZCkKKyAgICAgICAgbV9jb25uZWN0aW9uLT5kZXJlZmVyZW5jZSht X2lkZW50aWZpZXIpOwogfQogCiB2b2lkIERPTUNhY2hlOjptYXRjaChSZXF1ZXN0SW5mbyYmIGlu Zm8sIENhY2hlUXVlcnlPcHRpb25zJiYgb3B0aW9ucywgUmVmPERlZmVycmVkUHJvbWlzZT4mJiBw cm9taXNlKQpAQCAtNTcxLDYgKzU3Miw3IEBAIHZvaWQgRE9NQ2FjaGU6OnVwZGF0ZVJlY29yZHMo VmVjdG9yPFJlY29yZD4mJiByZWNvcmRzKQogdm9pZCBET01DYWNoZTo6c3RvcCgpCiB7CiAgICAg bV9pc1N0b3BwZWQgPSB0cnVlOworICAgIG1fY29ubmVjdGlvbi0+ZGVyZWZlcmVuY2UobV9pZGVu dGlmaWVyKTsKIH0KIAogY29uc3QgY2hhciogRE9NQ2FjaGU6OmFjdGl2ZURPTU9iamVjdE5hbWUo KSBjb25zdAo= 352059 2018-10-11 11:14:35 -0700 2018-10-12 10:14:21 -0700 Patch bug-190441-20181011111435.patch text/plain 1921 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVhNDYzZDlmZWQyNWUy NzRjNmJjMWVmYzNmMmIwYzQxMGU0ZDgxNS4uNTQ4OTgxMDYxOTU2ZmZmNjdmYmFjMzMyZjllYTY3 YmJhYjZkNjI1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTExICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBET01DYWNoZSBzaG91bGQg ZGVyZWZlcmVuY2UgaXRzZWxmIGFzIHNvb24gYXMgc3RvcHBlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNDQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVyZWZlcmVuY2UgdGhlIERPTUNhY2hlIGFz IHNvb24gYXMgaXRzIGNvbnRleHQgaXMgc3RvcHBlZCBpbnN0ZWFkIG9mIHdhaXRpbmcgZm9yIGdh cmJhZ2UgY29sbGVjdGlvbi4KKyAgICAgICAgVGhpcyBhbGxvd3MgZnJlZWluZyByZXNvdXJjZXMg c29vbmVyIGluIHRoZSBuZXR3b3JrIHByb2Nlc3MuCisgICAgICAgIE5vIG9ic2VydmFibGUgY2hh bmdlIG9mIGJlaGF2aW9yIHNpbmNlIHRoZSBET01DYWNoZSBiZWNvbWVzIG5vLW9wIHdoZW4gaXRz IGNvbnRleHQgaXMgc3RvcHBlZC4KKworICAgICAgICAqIE1vZHVsZXMvY2FjaGUvRE9NQ2FjaGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NQ2FjaGU6On5ET01DYWNoZSk6CisgICAgICAgIChX ZWJDb3JlOjpET01DYWNoZTo6c3RvcCk6CisKIDIwMTgtMTAtMTEgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIElPUyAxMiAtIFNlcnZpY2Ugd29ya2VyIGNhY2hl IG5vdCBzaGFyZWQgd2hlbiBhZGRlZCB0byBob21lc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2NhY2hlL0RPTUNhY2hlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvY2FjaGUvRE9NQ2FjaGUuY3BwCmluZGV4IGY3OTJmNWExMDEwNDZlZjExMDAwYTcxMWI2MTQx OTEzMWMyODVmNDMuLmQyYWE3YTJlZTdmNmZiZGExOWM4YWZiOGU5NTRlYWQ1MWFiZjZiZjIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGUuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvY2FjaGUvRE9NQ2FjaGUuY3BwCkBAIC01MSw3ICs1MSw4 IEBAIERPTUNhY2hlOjpET01DYWNoZShTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBT dHJpbmcmJiBuYW1lLCB1aW50NjRfdCBpZGVuCiAKIERPTUNhY2hlOjp+RE9NQ2FjaGUoKQogewot ICAgIG1fY29ubmVjdGlvbi0+ZGVyZWZlcmVuY2UobV9pZGVudGlmaWVyKTsKKyAgICBpZiAoIW1f aXNTdG9wcGVkKQorICAgICAgICBtX2Nvbm5lY3Rpb24tPmRlcmVmZXJlbmNlKG1faWRlbnRpZmll cik7CiB9CiAKIHZvaWQgRE9NQ2FjaGU6Om1hdGNoKFJlcXVlc3RJbmZvJiYgaW5mbywgQ2FjaGVR dWVyeU9wdGlvbnMmJiBvcHRpb25zLCBSZWY8RGVmZXJyZWRQcm9taXNlPiYmIHByb21pc2UpCkBA IC01NzAsNyArNTcxLDEwIEBAIHZvaWQgRE9NQ2FjaGU6OnVwZGF0ZVJlY29yZHMoVmVjdG9yPFJl Y29yZD4mJiByZWNvcmRzKQogCiB2b2lkIERPTUNhY2hlOjpzdG9wKCkKIHsKKyAgICBpZiAobV9p c1N0b3BwZWQpCisgICAgICAgIHJldHVybjsKICAgICBtX2lzU3RvcHBlZCA9IHRydWU7CisgICAg bV9jb25uZWN0aW9uLT5kZXJlZmVyZW5jZShtX2lkZW50aWZpZXIpOwogfQogCiBjb25zdCBjaGFy KiBET01DYWNoZTo6YWN0aXZlRE9NT2JqZWN0TmFtZSgpIGNvbnN0Cg==