190439 2018-10-10 13:42:03 -0700 Web Inspector: Network: more aggressively snap timing blocks together 2018-10-25 15:58:26 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes mattbaker timothy webkit-bug-importer oldest_to_newest 1467815 0 hi 2018-10-10 13:42:03 -0700 Right now, we don't do any snapping of timing phases, such that if one is close enough to the other we just join them. We currently "rely" on pixel rounding to do this for us. We should more aggressively snap these phase blocks together (e.g. if the difference is less than 2px just merge them). 1467817 1 mattbaker 2018-10-10 13:48:10 -0700 (In reply to Devin Rousso from comment #0) > Right now, we don't do any snapping of timing phases, such that if one is > close enough to the other we just join them. We currently "rely" on pixel > rounding to do this for us. We should more aggressively snap these phase > blocks together (e.g. if the difference is less than 2px just merge them). Nice. We do something similar when computing segments for rendering frame "bars". 1467844 2 351990 hi 2018-10-10 15:04:26 -0700 Created attachment 351990 Patch This patch relies on changes from <https://webkit.org/b/189773>. I will upload a different version if that bug takes a while to land. 1467966 3 352018 hi 2018-10-10 22:33:23 -0700 Created attachment 352018 Patch Rebase 1472217 4 352018 commit-queue 2018-10-25 15:57:52 -0700 Comment on attachment 352018 Patch Clearing flags on attachment: 352018 Committed r237430: <https://trac.webkit.org/changeset/237430> 1472218 5 commit-queue 2018-10-25 15:57:54 -0700 All reviewed patches have been landed. Closing bug. 1472219 6 webkit-bug-importer 2018-10-25 15:58:26 -0700 <rdar://problem/45570193> 351990 2018-10-10 15:04:26 -0700 2018-10-10 22:33:22 -0700 Patch 190439.diff text/plain 2119 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNhYzQwMTA0MDQxLi42YjNhZTA4ZTExNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMTAtMTAgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5l dHdvcms6IG1vcmUgYWdncmVzc2l2ZWx5IHNuYXAgdGltaW5nIGJsb2NrcyB0b2dldGhlcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNDM5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuTmV0d29y a1RhYmxlQ29udGVudFZpZXcucHJvdG90eXBlLl9wb3B1bGF0ZVdhdGVyZmFsbEdyYXBoLmFwcGVu ZEJsb2NrKToKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5f cG9wdWxhdGVXYXRlcmZhbGxHcmFwaCk6CisgICAgICAgIElmIHRoZSB0aW1lIGRpZmZlcmVuY2Ug YmV0d2VlbiB0aGUgZW5kIG9mIHRoZSBwcmV2aW91cyBibG9jayBhbmQgdGhlIHN0YXJ0IG9mIHRo aXMgYmxvY2sKKyAgICAgICAgd291bGQgcmVzdWx0IGluIGxlc3MgdGhhbiAycHggb2Ygc3BhY2Us IGV4dGVuZCB0aGUgbmV4dCBibG9jayBiYWNrIHRvIHRoZSBwcmV2aW91cyBibG9jay4KKwogMjAx OC0xMC0xMCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjM2ODUzKTogVW5jYXVnaHQgRXhjZXB0aW9uOiB1bmRl ZmluZWQgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAnZW50cnkucmVzb3VyY2UnKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29y a1RhYmxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwppbmRleCAwM2NiMmE0ZTY0Ni4uMjY3 OWUwMzcxZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCkBAIC03 NjcsMTAgKzc2NywxNSBAQCBXSS5OZXR3b3JrVGFibGVDb250ZW50VmlldyA9IGNsYXNzIE5ldHdv cmtUYWJsZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZQogICAgICAgICAgICAgcmV0 dXJuOwogICAgICAgICB9CiAKKyAgICAgICAgbGV0IGxhc3RFbmRUaW1lc3RhbXAgPSBOYU47CiAg ICAgICAgIGZ1bmN0aW9uIGFwcGVuZEJsb2NrKHN0YXJ0VGltZXN0YW1wLCBlbmRUaW1lc3RhbXAs IGNsYXNzTmFtZSkgewogICAgICAgICAgICAgaWYgKGlzTmFOKHN0YXJ0VGltZXN0YW1wKSB8fCBp c05hTihlbmRUaW1lc3RhbXApIHx8IGVuZFRpbWVzdGFtcCAtIHN0YXJ0VGltZXN0YW1wIDw9IDAp CiAgICAgICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAKKyAgICAgICAgICAgIGlmIChNYXRoLmFi cyhzdGFydFRpbWVzdGFtcCAtIGxhc3RFbmRUaW1lc3RhbXApIDwgc2Vjb25kc1BlclBpeGVsICog MikKKyAgICAgICAgICAgICAgICBzdGFydFRpbWVzdGFtcCA9IGxhc3RFbmRUaW1lc3RhbXA7Cisg ICAgICAgICAgICBsYXN0RW5kVGltZXN0YW1wID0gZW5kVGltZXN0YW1wOworCiAgICAgICAgICAg ICBsZXQgYmxvY2sgPSBjb250YWluZXIuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiZGl2IikpOwogICAgICAgICAgICAgYmxvY2suY2xhc3NMaXN0LmFkZCgiYmxvY2siLCBjbGFz c05hbWUpOwogICAgICAgICAgICAgcG9zaXRpb25CeVN0YXJ0T2Zmc2V0KGJsb2NrLCBzdGFydFRp bWVzdGFtcCk7Cg== 352018 2018-10-10 22:33:23 -0700 2018-10-25 15:57:52 -0700 Patch bug-190439-20181010223323.patch text/plain 2187 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM2NzE4YTdmNDgxZjRhM2NmNTQ5MjNhOTNlYzJh YmFiNzViY2QzOTcuLjIyNmQ3OTRiNTJmZGJlZjU4OTk2YWEyNTI4ZjkxNzgzYjRjZWVjZDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTEwICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBO ZXR3b3JrOiBtb3JlIGFnZ3Jlc3NpdmVseSBzbmFwIHRpbWluZyBibG9ja3MgdG9nZXRoZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQzOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdv cmtUYWJsZUNvbnRlbnRWaWV3LnByb3RvdHlwZS5fcG9wdWxhdGVXYXRlcmZhbGxHcmFwaC5hcHBl bmRCbG9jayk6CisgICAgICAgIChXSS5OZXR3b3JrVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUu X3BvcHVsYXRlV2F0ZXJmYWxsR3JhcGgpOgorICAgICAgICBJZiB0aGUgdGltZSBkaWZmZXJlbmNl IGJldHdlZW4gdGhlIGVuZCBvZiB0aGUgcHJldmlvdXMgYmxvY2sgYW5kIHRoZSBzdGFydCBvZiB0 aGlzIGJsb2NrCisgICAgICAgIHdvdWxkIHJlc3VsdCBpbiBsZXNzIHRoYW4gMnB4IG9mIHNwYWNl LCBleHRlbmQgdGhlIG5leHQgYmxvY2sgYmFjayB0byB0aGUgcHJldmlvdXMgYmxvY2suCisKIDIw MTgtMTAtMTAgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IGNyZWF0ZSBzcGVjaWFsIE5ldHdvcmsgd2F0ZXJmYWxsIGZvciBtZWRpYSBl dmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggMDg3MDNj YTdiODAwOTEwNDZmMmE2MmE0YjZkOGFmMDUyYTFkODFkZi4uZjhiYjY4Yjc4ODc0MTUxMzE4OGEy NWI0Yjg2YTk2NTEzYzMxYmFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZp ZXcuanMKQEAgLTc0NCwxMCArNzQ0LDE1IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0g Y2xhc3MgTmV0d29ya1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICBsZXQgbGFzdEVuZFRpbWVzdGFt cCA9IE5hTjsKICAgICAgICAgZnVuY3Rpb24gYXBwZW5kQmxvY2soc3RhcnRUaW1lc3RhbXAsIGVu ZFRpbWVzdGFtcCwgY2xhc3NOYW1lKSB7CiAgICAgICAgICAgICBpZiAoaXNOYU4oc3RhcnRUaW1l c3RhbXApIHx8IGlzTmFOKGVuZFRpbWVzdGFtcCkgfHwgZW5kVGltZXN0YW1wIC0gc3RhcnRUaW1l c3RhbXAgPD0gMCkKICAgICAgICAgICAgICAgICByZXR1cm4gbnVsbDsKIAorICAgICAgICAgICAg aWYgKE1hdGguYWJzKHN0YXJ0VGltZXN0YW1wIC0gbGFzdEVuZFRpbWVzdGFtcCkgPCBzZWNvbmRz UGVyUGl4ZWwgKiAyKQorICAgICAgICAgICAgICAgIHN0YXJ0VGltZXN0YW1wID0gbGFzdEVuZFRp bWVzdGFtcDsKKyAgICAgICAgICAgIGxhc3RFbmRUaW1lc3RhbXAgPSBlbmRUaW1lc3RhbXA7CisK ICAgICAgICAgICAgIGxldCBibG9jayA9IGNvbnRhaW5lci5hcHBlbmRDaGlsZChkb2N1bWVudC5j cmVhdGVFbGVtZW50KCJkaXYiKSk7CiAgICAgICAgICAgICBibG9jay5jbGFzc0xpc3QuYWRkKCJi bG9jayIsIGNsYXNzTmFtZSk7CiAgICAgICAgICAgICBwb3NpdGlvbkJ5U3RhcnRPZmZzZXQoYmxv Y2ssIHN0YXJ0VGltZXN0YW1wKTsK