190433 2018-10-10 11:17:18 -0700 REGRESSION (r236678): Keyboard scrolling with arrow keys doesn't work on iOS 2018-10-10 15:47:08 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue simon.fraser wenson_hsieh oldest_to_newest 1467759 0 thorton 2018-10-10 11:17:18 -0700 REGRESSION (r236678): Keyboard scrolling with arrow keys doesn't work on iOS 1467760 1 351972 thorton 2018-10-10 11:17:41 -0700 Created attachment 351972 Patch 1467762 2 thorton 2018-10-10 11:18:59 -0700 <rdar://problem/45111986> 1467772 3 351972 simon.fraser 2018-10-10 11:28:16 -0700 Comment on attachment 351972 Patch Can we test this? 1467773 4 thorton 2018-10-10 11:29:15 -0700 Soon! See rdar://problem/45110698 1467784 5 351972 thorton 2018-10-10 11:42:07 -0700 Comment on attachment 351972 Patch Err, somehow the #import got left behind from the index. 1467785 6 thorton 2018-10-10 11:43:39 -0700 https://trac.webkit.org/changeset/237011/webkit 351972 2018-10-10 11:17:41 -0700 2018-10-10 11:42:07 -0700 Patch bug-190433-20181010111740.patch text/plain 2952 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAxNWYxOWJkNDNhMzM2Yzk2 ZTFhZjkxNGY4MzM3MzgwMGQzZDMyYzkuLmY1YTlmZjRlMDIzNWU5NmVjMTBlODg5ZTBkZGFjNzIw ZjRiMjAyMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMTAgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIz NjY3OCk6IEtleWJvYXJkIHNjcm9sbGluZyB3aXRoIGFycm93IGtleXMgZG9lc24ndCB3b3JrIG9u IGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkw NDMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbToKKyAgICAgICAgKC1b V0tLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yIGtleWJvYXJkU2Nyb2xsRm9yRXZlbnQ6XSk6Cisg ICAgICAgICgtW1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvciBiZWdpbldpdGhFdmVudDpdKTog RGVsZXRlZC4KKyAgICAgICAgKC1bV0tLZXlib2FyZFNjcm9sbFZpZXdBbmltYXRvciBiZWdpbldp dGhFdmVudDpdKTogRGVsZXRlZC4KKyAgICAgICAgcjIzNjY3OCBjaGFuZ2VzIHRoZSBjaGFyYWN0 ZXJzIGluIGNoYXJhY3RlcnNJZ25vcmluZ01vZGlmaWVycyB0byBtYXRjaCBBcHBLaXQuCisgICAg ICAgIFdlIHNpbWlsYXJseSBuZWVkIHRvIHVwZGF0ZSBXS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0 b3IncyBjb21wYXJpc29uLgorCiAyMDE4LTEwLTA4ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhp QGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIDxpbnB1dCB0eXBlPWNvbG9yPiBhIHJ1bnRpbWUg ZW5hYmxlZCAob24tYnktZGVmYXVsdCkgZmVhdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbSBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0tleWJvYXJkU2Nyb2xsaW5nQW5pbWF0b3IubW0KaW5kZXgg ZGQ1ZDQwODM4OTFmMjczZmVmZWRjZTE5MmIxNzliMzFhZGUyODlmZS4uZmQyMzA1NzFjY2EzYjI5 MGZiZGU1OWU4MDdkYjdmNTc0YTM0ZWU4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1dLS2V5Ym9hcmRTY3JvbGxpbmdBbmltYXRvci5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tLZXlib2FyZFNjcm9sbGluZ0FuaW1hdG9yLm1tCkBAIC0xOTAs MjEgKzE5MCwyNSBAQCAtIChzdGQ6Om9wdGlvbmFsPFdlYktpdDo6S2V5Ym9hcmRTY3JvbGw+KWtl eWJvYXJkU2Nyb2xsRm9yRXZlbnQ6KDo6V2ViRXZlbnQgKilldgogICAgIGVudW0gY2xhc3MgS2V5 IDogdWludDhfdCB7IE90aGVyLCBMZWZ0QXJyb3csIFJpZ2h0QXJyb3csIFVwQXJyb3csIERvd25B cnJvdywgUGFnZVVwLCBQYWdlRG93biwgU3BhY2UgfTsKICAgICAKICAgICBhdXRvIGtleSA9IF57 Ci0gICAgICAgIGlmIChbY2hhcmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJzIGlzRXF1YWxUb1N0cmlu ZzpVSUtleUlucHV0TGVmdEFycm93XSkKKyAgICAgICAgYXV0byBmaXJzdENoYXJhY3RlciA9IFtj aGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgY2hhcmFjdGVyQXRJbmRleDowXTsKKyAgICAgICAg c3dpdGNoIChmaXJzdENoYXJhY3RlcikgeworICAgICAgICBjYXNlIE5TTGVmdEFycm93RnVuY3Rp b25LZXk6CiAgICAgICAgICAgICByZXR1cm4gS2V5OjpMZWZ0QXJyb3c7Ci0gICAgICAgIGlmIChb Y2hhcmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJzIGlzRXF1YWxUb1N0cmluZzpVSUtleUlucHV0Umln aHRBcnJvd10pCisgICAgICAgIGNhc2UgTlNSaWdodEFycm93RnVuY3Rpb25LZXk6CiAgICAgICAg ICAgICByZXR1cm4gS2V5OjpSaWdodEFycm93OwotICAgICAgICBpZiAoW2NoYXJhY3RlcnNJZ25v cmluZ01vZGlmaWVycyBpc0VxdWFsVG9TdHJpbmc6VUlLZXlJbnB1dFVwQXJyb3ddKQorICAgICAg ICBjYXNlIE5TVXBBcnJvd0Z1bmN0aW9uS2V5OgogICAgICAgICAgICAgcmV0dXJuIEtleTo6VXBB cnJvdzsKLSAgICAgICAgaWYgKFtjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgaXNFcXVhbFRv U3RyaW5nOlVJS2V5SW5wdXREb3duQXJyb3ddKQorICAgICAgICBjYXNlIE5TRG93bkFycm93RnVu Y3Rpb25LZXk6CiAgICAgICAgICAgICByZXR1cm4gS2V5OjpEb3duQXJyb3c7Ci0gICAgICAgIGlm IChbY2hhcmFjdGVyc0lnbm9yaW5nTW9kaWZpZXJzIGlzRXF1YWxUb1N0cmluZzpVSUtleUlucHV0 UGFnZURvd25dKQorICAgICAgICBjYXNlIE5TUGFnZURvd25GdW5jdGlvbktleToKICAgICAgICAg ICAgIHJldHVybiBLZXk6OlBhZ2VEb3duOwotICAgICAgICBpZiAoW2NoYXJhY3RlcnNJZ25vcmlu Z01vZGlmaWVycyBpc0VxdWFsVG9TdHJpbmc6VUlLZXlJbnB1dFBhZ2VVcF0pCisgICAgICAgIGNh c2UgTlNQYWdlVXBGdW5jdGlvbktleToKICAgICAgICAgICAgIHJldHVybiBLZXk6OlBhZ2VVcDsK LSAgICAgICAgaWYgKFtjaGFyYWN0ZXJzSWdub3JpbmdNb2RpZmllcnMgY2hhcmFjdGVyQXRJbmRl eDowXSA9PSBrV2ViU3BhY2VLZXkpCisgICAgICAgIGNhc2Uga1dlYlNwYWNlS2V5OgogICAgICAg ICAgICAgcmV0dXJuIEtleTo6U3BhY2U7Ci0gICAgICAgIHJldHVybiBLZXk6Ok90aGVyOworICAg ICAgICBkZWZhdWx0OgorICAgICAgICAgICAgcmV0dXJuIEtleTo6T3RoZXI7CisgICAgICAgIH07 CiAgICAgfSgpOwogICAgIAogICAgIGlmIChrZXkgPT0gS2V5OjpPdGhlcikK