190430 2018-10-10 10:47:30 -0700 build-webkit --inspector-frontend shouldn't have a nonzero exit code 2018-10-10 13:30:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling bburg commit-queue dbates ews-watchlist webkit-bug-importer oldest_to_newest 1467743 0 ross.kirsling 2018-10-10 10:47:30 -0700 build-webkit --inspector-frontend shouldn't have a nonzero exit code 1467745 1 351970 ross.kirsling 2018-10-10 10:49:54 -0700 Created attachment 351970 Patch 1467746 2 ross.kirsling 2018-10-10 10:52:27 -0700 This has been busted forever, but I never took the time to investigate the cause until now. :P Success output before patch: > ** BUILD SUCCEEDED ** > > xcodebuild: error: invalid option '--inspector-frontend' Success output after patch: > ** BUILD SUCCEEDED ** > > > ==================================================================== > WebKit is now built (00m:05s). > To run Safari with this newly-built code, use the > "Tools/Scripts/run-safari" script. > ==================================================================== 1467748 3 351970 bburg 2018-10-10 11:01:01 -0700 Comment on attachment 351970 Patch rs=me 1467809 4 351970 commit-queue 2018-10-10 13:29:08 -0700 Comment on attachment 351970 Patch Clearing flags on attachment: 351970 Committed r237015: <https://trac.webkit.org/changeset/237015> 1467810 5 commit-queue 2018-10-10 13:29:10 -0700 All reviewed patches have been landed. Closing bug. 1467812 6 webkit-bug-importer 2018-10-10 13:30:27 -0700 <rdar://problem/45170865> 351970 2018-10-10 10:49:54 -0700 2018-10-10 13:29:08 -0700 Patch bug-190430-20181010104953.patch text/plain 1341 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjE0Y2Y0MDRhZjM5YjY0ZDYxZTVlMjZjNjM0MDczNTIy NTdmMjg2Ny4uOWJiM2JhZTJkODYxNjRlZjBkMDkwNzAyNzBlNTk4MDUyNDU5YTExYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTEwLTEwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBidWlsZC13ZWJraXQgLS1pbnNwZWN0b3ItZnJvbnRlbmQgc2hvdWxkbid0IGhh dmUgYSBub256ZXJvIGV4aXQgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTkwNDMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChhcmd1bWVu dHNGb3JDb25maWd1cmF0aW9uKToKKyAgICAgICAgLS1pbnNwZWN0b3ItZnJvbnRlbmQgc2hvdWxk IG9ubHkgYmUgcG9wcGVkIG9mZiBvZiBhcmd2IGJ5IGRldGVybWluZUlzSW5zcGVjdG9yRnJvbnRl bmQ7CisgICAgICAgIGl0IHNob3VsZG4ndCBiZSByZS1pbnNlcnRlZCBhcyBhIENMSSBvcHRpb24g YnkgYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbi4KKwogMjAxOC0xMC0xMCAgR3VpbGxhdW1lIEVt b250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ09ubHkgQWRkIGFuIGFy bXY3IEpTQ09ubHkgRVdTIHRoYXQgcnVucyB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGJlZWJi YzMzOGNkZjVmODViMjEyMDY3MTIxZTFiN2ZkYzI0ZjQwMjguLjBiNWNmMWVjZDVlYjg5NmZjYjUw MWExN2ViOWI0YzFmM2RkNmZkYTcgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTQ5NCw3ICs0OTQsNiBA QCBzdWIgYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbigpCiAgICAgcHVzaChAYXJncywgJy0td3Bl JykgaWYgaXNXUEUoKTsKICAgICBwdXNoKEBhcmdzLCAnLS1qc2Mtb25seScpIGlmIGlzSlNDT25s eSgpOwogICAgIHB1c2goQGFyZ3MsICctLXdpbmNhaXJvJykgaWYgaXNXaW5DYWlybygpOwotICAg IHB1c2goQGFyZ3MsICctLWluc3BlY3Rvci1mcm9udGVuZCcpIGlmIGlzSW5zcGVjdG9yRnJvbnRl bmQoKTsKICAgICByZXR1cm4gQGFyZ3M7CiB9CiAK