19043 2008-05-14 00:48:05 -0700 New window event for wxWebKit 2009-04-15 15:47:05 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) All All RESOLVED FIXED Wx P2 Normal --- 1 robin webkit-unassigned kevino oldest_to_newest 80332 0 robin 2008-05-14 00:48:05 -0700 This patch adds sending of the new window event for wxWebKit 80333 1 21120 robin 2008-05-14 00:48:57 -0700 Created attachment 21120 patch for new window event 80334 2 21121 robin 2008-05-14 00:49:08 -0700 Created attachment 21121 patch for new window event 81781 3 21121 kevino 2008-05-28 13:43:09 -0700 Comment on attachment 21121 patch for new window event This looks good except for one important detail. When we implement DecidePolicy events, we need to handle the case in which they are ignored. In this case, if possible, I think we should restructure the code so that if the wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow the app to block certain URLs and let WebCore know that they were blocked. Thanks for all your help! :) 117669 4 29516 robin 2009-04-15 14:38:17 -0700 Created attachment 29516 Updated patch 117686 5 kevino 2009-04-15 15:47:05 -0700 Landed in r42562, thanks! 21120 2008-05-14 00:48:57 -0700 2008-05-14 00:49:36 -0700 patch for new window event webkit-newwindowevent.patch text/plain 1941 robin SW5kZXg6IC9wcm9qZWN0cy93ay9XZWJLaXQvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRXeC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gL3Byb2plY3RzL3drL1dlYktpdC9XZWJL aXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcAkocmV2aXNpb24gMzMw MzcpCisrKyAvcHJvamVjdHMvd2svV2ViS2l0L1dlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50V3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDYsMTIgKzcwNiwxOSBAQAog ICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQogCi12b2lk IEZyYW1lTG9hZGVyQ2xpZW50V3g6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0 aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24m LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBTdHJpbmcmKQordm9pZCBGcmFtZUxvYWRl ckNsaWVudFd4OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbihGcmFtZVBv bGljeUZ1bmN0aW9uIGZ1bmN0aW9uLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uJiwgY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBTdHJpbmcmIHRhcmdldE5hbWUpCiB7CiAgICAg aWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBub3RJbXBsZW1lbnRlZCgpOwor ICAgIHd4V2luZG93KiB0YXJnZXQgPSBtX2ZyYW1lLT52aWV3KCktPm5hdGl2ZVdpbmRvdygpOwor ICAgIGlmICh0YXJnZXQpIHsKKyAgICAgICAgd3hXZWJWaWV3TmV3V2luZG93RXZlbnQgd2tFdmVu dCh0YXJnZXQpOworICAgICAgICB3a0V2ZW50LlNldFVSTChyZXF1ZXN0LnVybCgpLnN0cmluZygp KTsKKyAgICAgICAgd2tFdmVudC5TZXRUYXJnZXROYW1lKHRhcmdldE5hbWUpOworICAgICAgICB0 YXJnZXQtPkdldEV2ZW50SGFuZGxlcigpLT5Qcm9jZXNzRXZlbnQod2tFdmVudCk7CisgICAgfQor ICAgIAogICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQog CkluZGV4OiAvcHJvamVjdHMvd2svV2ViS2l0L1dlYktpdC93eC9XZWJWaWV3LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gL3Byb2plY3RzL3drL1dlYktpdC9XZWJLaXQvd3gvV2ViVmlldy5oCShyZXZpc2lvbiAz MzAzNykKKysrIC9wcm9qZWN0cy93ay9XZWJLaXQvV2ViS2l0L3d4L1dlYlZpZXcuaAkod29ya2lu ZyBjb3B5KQpAQCAtMjQ3LDEyICsyNjYsMTUgQEAKIHB1YmxpYzoKICAgICB3eFN0cmluZyBHZXRV UkwoKSBjb25zdCB7IHJldHVybiBtX3VybDsgfQogICAgIHZvaWQgU2V0VVJMKGNvbnN0IHd4U3Ry aW5nJiB1cmwpIHsgbV91cmwgPSB1cmw7IH0KKyAgICB3eFN0cmluZyBHZXRUYXJnZXROYW1lKCkg Y29uc3QgeyByZXR1cm4gbV90YXJnZXROYW1lOyB9CisgICAgdm9pZCBTZXRUYXJnZXROYW1lKGNv bnN0IHd4U3RyaW5nJiBuYW1lKSB7IG1fdGFyZ2V0TmFtZSA9IG5hbWU7IH0KIAogICAgIHd4V2Vi Vmlld05ld1dpbmRvd0V2ZW50KCB3eFdpbmRvdyogd2luID0gc3RhdGljX2Nhc3Q8d3hXaW5kb3cq PihOVUxMKSk7CiAgICAgd3hFdmVudCAqQ2xvbmUodm9pZCkgY29uc3QgeyByZXR1cm4gbmV3IHd4 V2ViVmlld05ld1dpbmRvd0V2ZW50KCp0aGlzKTsgfQogCiBwcml2YXRlOgogICAgIHd4U3RyaW5n IG1fdXJsOworICAgIHd4U3RyaW5nIG1fdGFyZ2V0TmFtZTsKIH07CiAKIGNsYXNzIFdYRExMSU1Q RVhQX1dFQktJVCB3eFdlYlZpZXdSaWdodENsaWNrRXZlbnQgOiBwdWJsaWMgd3hDb21tYW5kRXZl bnQK 21121 2008-05-14 00:49:08 -0700 2009-04-15 14:38:17 -0700 patch for new window event webkit-newwindowevent.patch text/plain 1941 robin SW5kZXg6IC9wcm9qZWN0cy93ay9XZWJLaXQvV2ViS2l0L3d4L1dlYktpdFN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRXeC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gL3Byb2plY3RzL3drL1dlYktpdC9XZWJL aXQvd3gvV2ViS2l0U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFd4LmNwcAkocmV2aXNpb24gMzMw MzcpCisrKyAvcHJvamVjdHMvd2svV2ViS2l0L1dlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50V3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDYsMTIgKzcwNiwxOSBAQAog ICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQogCi12b2lk IEZyYW1lTG9hZGVyQ2xpZW50V3g6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0 aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24m LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmLCBjb25zdCBTdHJpbmcmKQordm9pZCBGcmFtZUxvYWRl ckNsaWVudFd4OjpkaXNwYXRjaERlY2lkZVBvbGljeUZvck5ld1dpbmRvd0FjdGlvbihGcmFtZVBv bGljeUZ1bmN0aW9uIGZ1bmN0aW9uLCBjb25zdCBOYXZpZ2F0aW9uQWN0aW9uJiwgY29uc3QgUmVz b3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBTdHJpbmcmIHRhcmdldE5hbWUpCiB7CiAgICAg aWYgKCFtX2ZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBub3RJbXBsZW1lbnRlZCgpOwor ICAgIHd4V2luZG93KiB0YXJnZXQgPSBtX2ZyYW1lLT52aWV3KCktPm5hdGl2ZVdpbmRvdygpOwor ICAgIGlmICh0YXJnZXQpIHsKKyAgICAgICAgd3hXZWJWaWV3TmV3V2luZG93RXZlbnQgd2tFdmVu dCh0YXJnZXQpOworICAgICAgICB3a0V2ZW50LlNldFVSTChyZXF1ZXN0LnVybCgpLnN0cmluZygp KTsKKyAgICAgICAgd2tFdmVudC5TZXRUYXJnZXROYW1lKHRhcmdldE5hbWUpOworICAgICAgICB0 YXJnZXQtPkdldEV2ZW50SGFuZGxlcigpLT5Qcm9jZXNzRXZlbnQod2tFdmVudCk7CisgICAgfQor ICAgIAogICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQog CkluZGV4OiAvcHJvamVjdHMvd2svV2ViS2l0L1dlYktpdC93eC9XZWJWaWV3LmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gL3Byb2plY3RzL3drL1dlYktpdC9XZWJLaXQvd3gvV2ViVmlldy5oCShyZXZpc2lvbiAz MzAzNykKKysrIC9wcm9qZWN0cy93ay9XZWJLaXQvV2ViS2l0L3d4L1dlYlZpZXcuaAkod29ya2lu ZyBjb3B5KQpAQCAtMjQ3LDEyICsyNjYsMTUgQEAKIHB1YmxpYzoKICAgICB3eFN0cmluZyBHZXRV UkwoKSBjb25zdCB7IHJldHVybiBtX3VybDsgfQogICAgIHZvaWQgU2V0VVJMKGNvbnN0IHd4U3Ry aW5nJiB1cmwpIHsgbV91cmwgPSB1cmw7IH0KKyAgICB3eFN0cmluZyBHZXRUYXJnZXROYW1lKCkg Y29uc3QgeyByZXR1cm4gbV90YXJnZXROYW1lOyB9CisgICAgdm9pZCBTZXRUYXJnZXROYW1lKGNv bnN0IHd4U3RyaW5nJiBuYW1lKSB7IG1fdGFyZ2V0TmFtZSA9IG5hbWU7IH0KIAogICAgIHd4V2Vi Vmlld05ld1dpbmRvd0V2ZW50KCB3eFdpbmRvdyogd2luID0gc3RhdGljX2Nhc3Q8d3hXaW5kb3cq PihOVUxMKSk7CiAgICAgd3hFdmVudCAqQ2xvbmUodm9pZCkgY29uc3QgeyByZXR1cm4gbmV3IHd4 V2ViVmlld05ld1dpbmRvd0V2ZW50KCp0aGlzKTsgfQogCiBwcml2YXRlOgogICAgIHd4U3RyaW5n IG1fdXJsOworICAgIHd4U3RyaW5nIG1fdGFyZ2V0TmFtZTsKIH07CiAKIGNsYXNzIFdYRExMSU1Q RVhQX1dFQktJVCB3eFdlYlZpZXdSaWdodENsaWNrRXZlbnQgOiBwdWJsaWMgd3hDb21tYW5kRXZl bnQK 29516 2009-04-15 14:38:17 -0700 2009-04-15 15:02:28 -0700 Updated patch newwindow.patch text/plain 1884 robin SW5kZXg6IFdlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3gu Y3BwCShyZXZpc2lvbiA0MjU0MykKKysrIFdlYktpdC93eC9XZWJLaXRTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50V3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OTAsMTIgKzY5MCwyMyBAQAogICAg IChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQogCi12b2lkIEZy YW1lTG9hZGVyQ2xpZW50V3g6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3V2luZG93QWN0aW9u KEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRpb25BY3Rpb24mLCBj b25zdCBSZXNvdXJjZVJlcXVlc3QmLCBQYXNzUmVmUHRyPEZvcm1TdGF0ZT4sIGNvbnN0IFN0cmlu ZyYpCit2b2lkIEZyYW1lTG9hZGVyQ2xpZW50V3g6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9yTmV3 V2luZG93QWN0aW9uKEZyYW1lUG9saWN5RnVuY3Rpb24gZnVuY3Rpb24sIGNvbnN0IE5hdmlnYXRp b25BY3Rpb24mLCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIFBhc3NSZWZQdHI8Rm9y bVN0YXRlPiwgY29uc3QgU3RyaW5nJiB0YXJnZXROYW1lKQogewogICAgIGlmICghbV9mcmFtZSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAobV93ZWJW aWV3KSB7CisgICAgICAgIHd4V2ViVmlld05ld1dpbmRvd0V2ZW50IHdrRXZlbnQobV93ZWJWaWV3 KTsKKyAgICAgICAgd2tFdmVudC5TZXRVUkwocmVxdWVzdC51cmwoKS5zdHJpbmcoKSk7CisgICAg ICAgIHdrRXZlbnQuU2V0VGFyZ2V0TmFtZSh0YXJnZXROYW1lKTsKKyAgICAgICAgaWYgKG1fd2Vi Vmlldy0+R2V0RXZlbnRIYW5kbGVyKCktPlByb2Nlc3NFdmVudCh3a0V2ZW50KSkgeworICAgICAg ICAgICAgLy8gaWYgdGhlIGFwcCBoYW5kbGVzIGFuZCBkb2Vzbid0IHNraXAgdGhlIGV2ZW50LCAK KyAgICAgICAgICAgIC8vIGZyb20gV2ViS2l0J3MgcGVyc3BlY3RpdmUgdHJlYXQgaXQgYXMgYmxv Y2tlZCAvIGlnbm9yZWQKKyAgICAgICAgICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9u KShQb2xpY3lJZ25vcmUpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgfQor ICAgIAogICAgIChtX2ZyYW1lLT5sb2FkZXIoKS0+KmZ1bmN0aW9uKShQb2xpY3lVc2UpOwogfQog CkluZGV4OiBXZWJLaXQvd3gvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93eC9DaGFu Z2VMb2cJKHJldmlzaW9uIDQyNTU3KQorKysgV2ViS2l0L3d4L0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA0LTE1ICBSb2JpbiBEdW5uICA8cm9iaW5AYWxs ZHVubi5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBJbXBsZW1lbnQgc3VwcG9ydCBmb3Igd3hXZWJWaWV3TmV3V2luZG93RXZlbnQu CisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50V3guY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRXeDo6ZGlzcGF0Y2hEZWNpZGVQb2xpY3lG b3JOZXdXaW5kb3dBY3Rpb24pOgorCiAyMDA5LTA0LTA0ICBLZXZpbiBPbGxpdmllciAgPGtldmlu b0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeGVzIGZvciB3eE1hYy9UaWdl ci4K