190426 2018-10-10 04:18:56 -0700 [JSC] [Armv7] stress/sampling-profiler-richards.js crashes 2018-11-02 04:44:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 guijemont webkit-unassigned tzagallo webkit-bug-importer oldest_to_newest 1467685 0 guijemont 2018-10-10 04:18:56 -0700 The test crashes on linux/armv7. When running the test manually, it only seems to crash with the sampling-profiler enabled. 1467688 1 guijemont 2018-10-10 04:39:32 -0700 Committed r237000: <https://trac.webkit.org/changeset/237000> 1467689 2 guijemont 2018-10-10 04:40:09 -0700 Reopening as the commit was only to skip the test. 1467690 3 webkit-bug-importer 2018-10-10 04:40:24 -0700 <rdar://problem/45157301> 1467691 4 webkit-bug-importer 2018-10-10 04:40:25 -0700 <rdar://problem/45157300> 1474438 5 tzagallo 2018-11-02 03:26:12 -0700 FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184 to convert these to `skip if no $jitTests`, since they were also timing out on x86. I've removed the FIXME comments, since it should no longer be necessary to change the tests, only the runner. Let me know if you want me to keep the comments and I'll revert the changes. 1474450 6 guijemont 2018-11-02 04:42:52 -0700 (In reply to Tadeu Zagallo from comment #5) > FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184 > to convert these to `skip if no $jitTests`, since they were also timing out > on x86. I've removed the FIXME comments, since it should no longer be > necessary to change the tests, only the runner. Let me know if you want me > to keep the comments and I'll revert the changes. I think we still need an explicit '@skip if $architecture == "arm"' for this test since I expect this crash to still be there once we reenable the JIT on arm (unless the bytecode changes accidentally fixed it). 1474451 7 guijemont 2018-11-02 04:44:59 -0700 (In reply to Guillaume Emont from comment #6) > (In reply to Tadeu Zagallo from comment #5) > > FYI, I've put a patch up in https://bugs.webkit.org/show_bug.cgi?id=191184 > > to convert these to `skip if no $jitTests`, since they were also timing out > > on x86. I've removed the FIXME comments, since it should no longer be > > necessary to change the tests, only the runner. Let me know if you want me > > to keep the comments and I'll revert the changes. > > I think we still need an explicit '@skip if $architecture == "arm"' for this > test since I expect this crash to still be there once we reenable the JIT on > arm (unless the bytecode changes accidentally fixed it). FWIW your patch on Bug 191184 already does the right thing for this test.