190419 2018-10-09 17:33:59 -0700 Performance dashboard should show added iterations due failed build requests. 2018-10-14 20:16:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu webkit-unassigned dewei_zhu lforschler rniwa oldest_to_newest 1467621 0 dewei_zhu 2018-10-09 17:33:59 -0700 Performance dashboard should show added iterations due failed build requests. 1467624 1 351929 dewei_zhu 2018-10-09 17:38:56 -0700 Created attachment 351929 Patch 1467637 2 351929 rniwa 2018-10-09 20:08:30 -0700 Comment on attachment 351929 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351929&action=review > Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js:374 > + this.content('status-summary').innerHTML = `${currentGroup.initialRepetitionCount()} requested, ${currentGroup.repetitionCount() - currentGroup.initialRepetitionCount()} added due to failures.`; Let's store values in local variables first so that the template literal looks nicer. 1468777 3 rniwa 2018-10-13 12:17:48 -0700 Have you landed this change?? 1468778 4 rniwa 2018-10-13 12:18:28 -0700 Landed in https://trac.webkit.org/changeset/236997. Please don't forget to close bugs. You can use webkit-patch land to do that automatically. 1468962 5 dewei_zhu 2018-10-13 17:45:48 -0700 Thanks! I will use that script. 1469105 6 webkit-bug-importer 2018-10-14 20:16:26 -0700 <rdar://problem/45261523> 351929 2018-10-09 17:38:56 -0700 2018-10-09 20:08:30 -0700 Patch bug-190419-20181009173855.patch text/plain 3737 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTg2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA5ZjY3OGU2ZDczOWNmM2MxZTI4ZmNjYzMxMjIwMWI2NTEyNDI3ODMzLi5kMzU2N2JjNDNi YmFmOWEyNDY3YWZjYTU2NWNlODQ0MzM4NjYxZWU5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxOC0xMC0wOSAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBQZXJmb3JtYW5jZSBkYXNoYm9hcmQgc2hvdWxkIHNob3cg YWRkZWQgaXRlcmF0aW9ucyBkdWUgZmFpbGVkIGJ1aWxkIHJlcXVlc3RzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwNDE5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgVUkgdG8gc2hvdyBhZGRl ZCBidWlsZCByZXF1ZXN0cyBkdWUgdG8gcHJldmlvdXMgZmFpbGVkIGJ1aWxkIHJlcXVlc3RzLgor ICAgICAgICBVcGRhdGVkIHRoZSByZXRyeS9iaXNlY3QgYnV0dG9uIHRvIGRlZmF1bHQgdG8gaW5p dGlhbCByZXBldGl0aW9uIGNvdW50IHdoZW4gdGVzdCBncm91cCBpcyBjcmVhdGVkLgorCisgICAg ICAgICogcHVibGljL3YzL3BhZ2VzL2FuYWx5c2lzLXRhc2stcGFnZS5qczogQWRkZWQgYSBkaXYg dG8gc2hvdyBhZGRlZCBidWlsZCByZXF1ZXN0cy4KKyAgICAgICAgUmV0cnkgYW5kIGJpc2VjdCBi dXR0b24gc2hvdWxkIGRlZmF1bHQgdG8gaW5pdGlhbCByZXBldGlvbiBjb3VudC4KKyAgICAgICAg KEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUucHJvdG90eXBlLl9yZW5kZXJDdXJyZW50VGVzdEdy b3VwKToKKyAgICAgICAgKEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUuY3NzVGVtcGxhdGUpOgor CiAyMDE4LTEwLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IC9hcGkvcmVwb3J0IHRha2VzIDE1KyBtaW51dGVzIHN1Ym1pdHRpbmcgc29tZSB0ZXN0IHJlc3Vs dHMKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMv YW5hbHlzaXMtdGFzay1wYWdlLmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92 My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKaW5kZXggMGY3MDg5ZjI4NGMxMzhkODNiNDUy ZjhmNjIyMWU5YTRiNTAwNzdiNS4uNDlkNmI4YTA0MTE5YTkxZTk3NmIyZWJkMzUyODhlODczMmQ3 YWY0NSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdl cy9hbmFseXNpcy10YXNrLXBhZ2UuanMKKysrIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy92My9wYWdlcy9hbmFseXNpcy10YXNrLXBhZ2UuanMKQEAgLTM2OSwxMSArMzY5LDEzIEBA IGNsYXNzIEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUgZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsK ICAgICAgICAgICAgIHRoaXMuX3Rlc3RHcm91cE1hcC5nZXQoY3VycmVudEdyb3VwKS5saXN0SXRl bS5jbGFzc0xpc3QuYWRkKCdzZWxlY3RlZCcpOwogCiAgICAgICAgIGlmIChjdXJyZW50R3JvdXAp IHsKLSAgICAgICAgICAgIHRoaXMucGFydCgncmV0cnktZm9ybScpLnNldFJlcGV0aXRpb25Db3Vu dChjdXJyZW50R3JvdXAucmVwZXRpdGlvbkNvdW50KCkpOwotICAgICAgICAgICAgdGhpcy5wYXJ0 KCdiaXNlY3QtZm9ybScpLnNldFJlcGV0aXRpb25Db3VudChjdXJyZW50R3JvdXAucmVwZXRpdGlv bkNvdW50KCkpOworICAgICAgICAgICAgdGhpcy5wYXJ0KCdyZXRyeS1mb3JtJykuc2V0UmVwZXRp dGlvbkNvdW50KGN1cnJlbnRHcm91cC5pbml0aWFsUmVwZXRpdGlvbkNvdW50KCkpOworICAgICAg ICAgICAgdGhpcy5wYXJ0KCdiaXNlY3QtZm9ybScpLnNldFJlcGV0aXRpb25Db3VudChjdXJyZW50 R3JvdXAuaW5pdGlhbFJlcGV0aXRpb25Db3VudCgpKTsKKyAgICAgICAgICAgIHRoaXMuY29udGVu dCgnc3RhdHVzLXN1bW1hcnknKS5pbm5lckhUTUwgPSBgJHtjdXJyZW50R3JvdXAuaW5pdGlhbFJl cGV0aXRpb25Db3VudCgpfSByZXF1ZXN0ZWQsICR7Y3VycmVudEdyb3VwLnJlcGV0aXRpb25Db3Vu dCgpIC0gY3VycmVudEdyb3VwLmluaXRpYWxSZXBldGl0aW9uQ291bnQoKX0gYWRkZWQgZHVlIHRv IGZhaWx1cmVzLmA7CiAgICAgICAgIH0KICAgICAgICAgdGhpcy5jb250ZW50KCdyZXRyeS1mb3Jt Jykuc3R5bGUuZGlzcGxheSA9IGN1cnJlbnRHcm91cCA/IG51bGwgOiAnbm9uZSc7CiAgICAgICAg IHRoaXMuY29udGVudCgnYmlzZWN0LWZvcm0nKS5zdHlsZS5kaXNwbGF5ID0gY3VycmVudEdyb3Vw ICYmIHRoaXMuX2Jpc2VjdGluZ0NvbW1pdFNldEJ5VGVzdEdyb3VwLmdldChjdXJyZW50R3JvdXAp ID8gbnVsbCA6ICdub25lJzsKKyAgICAgICAgdGhpcy5jb250ZW50KCdzdGF0dXMtc3VtbWFyeScp LnN0eWxlLmRpc3BsYXkgPSBjdXJyZW50R3JvdXAgJiYgY3VycmVudEdyb3VwLnJlcGV0aXRpb25D b3VudCgpID4gY3VycmVudEdyb3VwLmluaXRpYWxSZXBldGl0aW9uQ291bnQoKSA/IG51bGwgOiAn bm9uZSc7CiAKICAgICAgICAgY29uc3QgaGlkZUJ1dHRvbiA9IHRoaXMuY29udGVudCgnaGlkZS1i dXR0b24nKTsKICAgICAgICAgaGlkZUJ1dHRvbi50ZXh0Q29udGVudCA9IGN1cnJlbnRHcm91cCAm JiBjdXJyZW50R3JvdXAuaXNIaWRkZW4oKSA/ICdVbmhpZGUnIDogJ0hpZGUnOwpAQCAtMzg5LDYg KzM5MSw3IEBAIGNsYXNzIEFuYWx5c2lzVGFza1Rlc3RHcm91cFBhbmUgZXh0ZW5kcyBDb21wb25l bnRCYXNlIHsKICAgICAgICAgICAgIDxkaXYgaWQ9InRlc3QtZ3JvdXAtZGV0YWlscyI+CiAgICAg ICAgICAgICAgICAgPHRlc3QtZ3JvdXAtcmVzdWx0cy12aWV3ZXIgaWQ9InJlc3VsdHMtdmlld2Vy Ij48L3Rlc3QtZ3JvdXAtcmVzdWx0cy12aWV3ZXI+CiAgICAgICAgICAgICAgICAgPHRlc3QtZ3Jv dXAtcmV2aXNpb24tdGFibGUgaWQ9InJldmlzaW9uLXRhYmxlIj48L3Rlc3QtZ3JvdXAtcmV2aXNp b24tdGFibGU+CisgICAgICAgICAgICAgICAgPGRpdiBpZD0ic3RhdHVzLXN1bW1hcnkiIGNsYXNz PSJzdW1tYXJ5Ij48L2Rpdj4KICAgICAgICAgICAgICAgICA8dGVzdC1ncm91cC1mb3JtIGlkPSJy ZXRyeS1mb3JtIj5SZXRyeTwvdGVzdC1ncm91cC1mb3JtPgogICAgICAgICAgICAgICAgIDx0ZXN0 LWdyb3VwLWZvcm0gaWQ9ImJpc2VjdC1mb3JtIj5CaXNlY3Q8L3Rlc3QtZ3JvdXAtZm9ybT4KICAg ICAgICAgICAgICAgICA8YnV0dG9uIGlkPSJoaWRlLWJ1dHRvbiI+SGlkZTwvYnV0dG9uPgpAQCAt NDUxLDYgKzQ1NCwxMCBAQCBjbGFzcyBBbmFseXNpc1Rhc2tUZXN0R3JvdXBQYW5lIGV4dGVuZHMg Q29tcG9uZW50QmFzZSB7CiAgICAgICAgICAgICAgICAgYmFja2dyb3VuZDogI2VlZTsKICAgICAg ICAgICAgIH0KIAorICAgICAgICAgICAgZGl2LnN1bW1hcnkgeworICAgICAgICAgICAgICAgIHBh ZGRpbmctbGVmdDogMXJlbTsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgI3Rlc3QtZ3Jv dXAtZGV0YWlscyB7CiAgICAgICAgICAgICAgICAgZGlzcGxheTogdGFibGUtY2VsbDsKICAgICAg ICAgICAgICAgICBtYXJnaW4tYm90dG9tOiAxcmVtOwo=