190409 2018-10-09 13:24:15 -0700 [WPE][GTK] Complex text crashes with harfbuzz 1.8.8 2018-10-09 14:59:21 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro zan oldest_to_newest 1467528 0 mcatanzaro 2018-10-09 13:24:15 -0700 From https://gitlab.gnome.org/GNOME/evolution/issues/157 We discovered that harfbuzz 1.8.8 breaks WebKit by changing the ownership semantics of hb_icu_get_unicode_funcs() from (transfer full) to (transfer none). Our code was actually expecting (transfer none), so it's not immediately clear to me why it's crashing now, but doesn't matter as per Behdad: "Please just remove that line of code. hb-buffer comes up prepared with unicode-funcs these days (has had, for at least five years). Just removing that line completely results in better output." This should be covered by all our complex text tests if the bots were upgraded to the newer harfbuzz. 1467530 1 351905 mcatanzaro 2018-10-09 13:27:56 -0700 Created attachment 351905 Patch 1467567 2 351905 commit-queue 2018-10-09 14:59:20 -0700 Comment on attachment 351905 Patch Clearing flags on attachment: 351905 Committed r236985: <https://trac.webkit.org/changeset/236985> 1467568 3 commit-queue 2018-10-09 14:59:21 -0700 All reviewed patches have been landed. Closing bug. 351905 2018-10-09 13:27:56 -0700 2018-10-09 14:59:20 -0700 Patch bug-190409-20181009152755.patch text/plain 2234 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjJiNTdjZTNjMTI4MDg5 MTJmMGVjOGY2OGZiNjAwMTU4NTY3MjQwNC4uYjJjOWU0NjU5YzIyNTUxYzI3MWUyNjk2NmQ0YzA3 YmRhNjg1MjcxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTA5ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtH VEtdIENvbXBsZXggdGV4dCBjcmFzaGVzIHdpdGggaGFyZmJ1enogMS44LjgKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDQwOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRpc2NvdmVyZWQgdGhhdCBo YXJmYnV6eiAxLjguOCBicmVha3MgV2ViS2l0IGJ5IGNoYW5naW5nIHRoZSBvd25lcnNoaXAgc2Vt YW50aWNzIG9mCisgICAgICAgIGhiX2ljdV9nZXRfdW5pY29kZV9mdW5jcygpIGZyb20gKHRyYW5z ZmVyIGZ1bGwpIHRvICh0cmFuc2ZlciBub25lKS4gT3VyIGNvZGUgd2FzIGFjdHVhbGx5CisgICAg ICAgIGV4cGVjdGluZyAodHJhbnNmZXIgbm9uZSksIHNvIGl0J3Mgbm90IGltbWVkaWF0ZWx5IGNs ZWFyIHRvIG1lIHdoeSBpdCdzIGNyYXNoaW5nIG5vdywgYnV0CisgICAgICAgIGRvZXNuJ3QgbWF0 dGVyIGFzIEJlaGRhZCByZWNvbW1lbmRzIHJlbW92aW5nIHRoaXMgbGluZSBvZiBjb2RlIGJlY2F1 c2UgaXQgaGFzbid0IGJlZW4KKyAgICAgICAgYmVlbiBuZWVkZWQgZm9yIG1hbnkgeWVhcnMuCisK KyAgICAgICAgVGhpcyBzaG91bGQgYmUgY292ZXJlZCBieSBhbGwgb3VyIGNvbXBsZXggdGV4dCB0 ZXN0cyBpZiB0aGUgYm90cyB3ZXJlIHVwZ3JhZGVkIHRvIHRoZSBuZXdlcgorICAgICAgICBoYXJm YnV6ei4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2hhcmZidXp6L0NvbXBsZXhUZXh0 Q29udHJvbGxlckhhcmZCdXp6LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBsZXhUZXh0Q29u dHJvbGxlcjo6Y29sbGVjdENvbXBsZXhUZXh0UnVuc0ZvckNoYXJhY3RlcnMpOgorCiAyMDE4LTEw LTA5ICBPcmlvbCBCcnVmYXUgIDxvYnJ1ZmF1QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVzb2x2 ZSBpbnNldCBwcm9wZXJ0aWVzIHRvIGNvbXB1dGVkIHN0eWxlIHdoZW4gdGhlcmUgaXMgb3ZlcmNv bnN0cmFpbnRtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJmQnV6ei5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9oYXJmYnV6ei9Db21wbGV4VGV4dENvbnRyb2xsZXJIYXJm QnV6ei5jcHAKaW5kZXggYzljMWY3MTAxZWMxMTljMmRlNjJjZTFjNjU5YTNhNjQxNmEwMzJmNC4u MjcxMjNkM2I2ODBlNDdjMTA5YmMzN2Y1Y2FmNGFiZDVmOTgzNDkzNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovQ29tcGxleFRleHRDb250cm9s bGVySGFyZkJ1enouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2hh cmZidXp6L0NvbXBsZXhUZXh0Q29udHJvbGxlckhhcmZCdXp6LmNwcApAQCAtMTkzLDcgKzE5Myw2 IEBAIHZvaWQgQ29tcGxleFRleHRDb250cm9sbGVyOjpjb2xsZWN0Q29tcGxleFRleHRSdW5zRm9y Q2hhcmFjdGVycyhjb25zdCBVQ2hhciogY2hhCiAgICAgY29uc3QgYXV0byYgZm9udFBsYXRmb3Jt RGF0YSA9IGZvbnQtPnBsYXRmb3JtRGF0YSgpOwogICAgIGF1dG8gZmVhdHVyZXMgPSBmb250RmVh dHVyZXMobV9mb250LCBmb250UGxhdGZvcm1EYXRhLm9yaWVudGF0aW9uKCkpOwogICAgIEhiVW5p cXVlUHRyPGhiX2J1ZmZlcl90PiBidWZmZXIoaGJfYnVmZmVyX2NyZWF0ZSgpKTsKLSAgICBoYl9i dWZmZXJfc2V0X3VuaWNvZGVfZnVuY3MoYnVmZmVyLmdldCgpLCBoYl9pY3VfZ2V0X3VuaWNvZGVf ZnVuY3MoKSk7CiAKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcnVuQ291bnQ7ICsraSkg ewogICAgICAgICBhdXRvJiBydW4gPSBydW5MaXN0W21fcnVuLnJ0bCgpID8gcnVuQ291bnQgLSBp IC0gMSA6IGldOwo=