<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190402</bug_id>
          
          <creation_ts>2018-10-09 09:56:16 -0700</creation_ts>
          <short_desc>[iOS] Cleanup -[WAKView _selfHandleEvent:] and -[WAKWindow sendEventSynchronously:]</short_desc>
          <delta_ts>2018-10-14 22:02:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>iOS 12</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>190571</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>aestes</cc>
    
    <cc>andersca</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1467429</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 09:56:16 -0700</bug_when>
    <thetext>Cleanup code style in -[WAKView _selfHandleEvent:] and -[WAKWindow sendEventSynchronously:] and remove default case statements with body ASSERT_NOT_REACHED() so as make a missing enumerator a compile-time error instead of a runtime error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467430</commentid>
    <comment_count>1</comment_count>
      <attachid>351884</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 09:59:11 -0700</bug_when>
    <thetext>Created attachment 351884
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467437</commentid>
    <comment_count>2</comment_count>
      <attachid>351885</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 10:07:18 -0700</bug_when>
    <thetext>Created attachment 351885
Patch

More clean up of -[WAKView _selfHandleEvent:]. Inline a local variable into the swithc condition, change break statements to return statements and remove the return statement at the end of the function as the compiler is capable of verifing that the switch block handles all enumerators.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467439</commentid>
    <comment_count>3</comment_count>
      <attachid>351886</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 10:13:26 -0700</bug_when>
    <thetext>Created attachment 351886
Patch

Tighten up -[WAKView _selfHandleEvent:] some more by removing unncessary braces.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467440</commentid>
    <comment_count>4</comment_count>
      <attachid>351886</attachid>
    <who name="Anders Carlsson">andersca</who>
    <bug_when>2018-10-09 10:14:15 -0700</bug_when>
    <thetext>Comment on attachment 351886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351886&amp;action=review

&gt; Source/WebCore/platform/ios/wak/WAKView.mm:132
&gt;  - (BOOL)_selfHandleEvent:(WebEvent *)event
&gt;  {

Does _selfHandleEvent ever return NO? I&apos;m guessing there are WAKView subclasses that can return NO.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467467</commentid>
    <comment_count>5</comment_count>
      <attachid>351894</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 10:46:06 -0700</bug_when>
    <thetext>Created attachment 351894
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467554</commentid>
    <comment_count>6</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-09 14:22:36 -0700</bug_when>
    <thetext>(In reply to Anders Carlsson from comment #4)
&gt; Comment on attachment 351886 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=351886&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/ios/wak/WAKView.mm:132
&gt; &gt;  - (BOOL)_selfHandleEvent:(WebEvent *)event
&gt; &gt;  {
&gt; 
&gt; Does _selfHandleEvent ever return NO? I&apos;m guessing there are WAKView
&gt; subclasses that can return NO.

Your intuition is correct. -[WAKScrollView _selfHandleEvent] can return NO: &lt;https://trac.webkit.org/browser/trunk/Source/WebCore/platform/ios/wak/WAKScrollView.mm?rev=236938#L88&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467936</commentid>
    <comment_count>7</comment_count>
      <attachid>351894</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-10 20:08:39 -0700</bug_when>
    <thetext>Comment on attachment 351894
Patch

Clearing flags on attachment: 351894

Committed r237027: &lt;https://trac.webkit.org/changeset/237027&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467937</commentid>
    <comment_count>8</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-10-10 20:08:41 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1467938</commentid>
    <comment_count>9</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-10 20:09:28 -0700</bug_when>
    <thetext>&lt;rdar://problem/45182678&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351884</attachid>
            <date>2018-10-09 09:59:11 -0700</date>
            <delta_ts>2018-10-09 10:07:17 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190402-20181009095910.patch</filename>
            <type>text/plain</type>
            <size>5157</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyOGU0NmYwMzYyYzMy
NDVlMzQ4MzUzYWQ4NzEwYTliYjRmMWY3MC4uNzYyY2UwZTc1NzUwZTNiNGM1ZTI5YzQyZmZiNzU1
NDBkOGZiZTJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTA5ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDbGVhbnVwIC1b
V0FLVmlldyBfc2VsZkhhbmRsZUV2ZW50Ol0gYW5kIC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNo
cm9ub3VzbHk6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkwNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVW5pbmRlbnQgY2FzZSBzdGF0ZW1lbnRzLiBSZW1vdmUgdXNlIG9mIGRlZmF1bHQgY2FzZSBz
dGF0ZW1lbnRzIHdpdGggYm9keSBBU1NFUlRfTk9UX1JFQUNIRUQoKQorICAgICAgICB0byBjYXRj
aCB0aGUgY2FzZXMgb2YgYSBtaXNzaW5nIGVudW1lcmF0b3IuIEJ5IG9taXR0aW5nIHRoZSBkZWZh
dWx0IGNhc2Ugc3RhdGVtZW50IHdlIHR1cm4KKyAgICAgICAgc3VjaCBhIHNjZW5hcmlvIGludG8g
YSBjb21waWxlLXRpbWUgZXJyb3IgaW5zdGVhZCBvZiBoYW5kbGluZyBpdCBhcyBhIHJ1bnRpbWUg
ZXJyb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW06CisgICAgICAg
ICgtW1dBS1ZpZXcgX3NlbGZIYW5kbGVFdmVudDpdKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv
d2FrL1dBS1dpbmRvdy5tbToKKyAgICAgICAgKC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNocm9u
b3VzbHk6XSk6CisKIDIwMTgtMTAtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t
PgogCiAgICAgICAgIENsZWFudXAgV2ViRXZlbnQubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLVmlldy5tbQppbmRleCBiYjNhNzUxZTA1OTJlMDU1MzlmNTc0N2E4ZmZiMDBj
ZWFjZTgwNWFkLi43ZDM5NGZjMWEwOTNmMDI0YTkyNTg3MDgyMDliMzU0MjIzMTkxYTUzIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW0KKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtWaWV3Lm1tCkBAIC0xMzMsNDIgKzEz
MywzOSBAQCAtIChCT09MKV9zZWxmSGFuZGxlRXZlbnQ6KFdlYkV2ZW50ICopZXZlbnQKICAgICBX
ZWJFdmVudFR5cGUgdHlwZSA9IGV2ZW50LnR5cGU7CiAgICAgCiAgICAgc3dpdGNoICh0eXBlKSB7
Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246IHsKLSAgICAgICAgICAgIFtzZWxmIG1v
dXNlRG93bjpldmVudF07Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAgICAgICBj
YXNlIFdlYkV2ZW50TW91c2VVcDogewotICAgICAgICAgICAgW3NlbGYgbW91c2VVcDpldmVudF07
Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQotICAgICAgICBjYXNlIFdlYkV2ZW50TW91
c2VNb3ZlZDogewotICAgICAgICAgICAgW3NlbGYgbW91c2VNb3ZlZDpldmVudF07Ci0gICAgICAg
ICAgICBicmVhazsKLSAgICAgICAgfQotICAgICAgICBjYXNlIFdlYkV2ZW50S2V5RG93bjogewot
ICAgICAgICAgICAgW3NlbGYga2V5RG93bjpldmVudF07Ci0gICAgICAgICAgICBicmVhazsKLSAg
ICAgICAgfQotICAgICAgICBjYXNlIFdlYkV2ZW50S2V5VXA6IHsKLSAgICAgICAgICAgIFtzZWxm
IGtleVVwOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNh
c2UgV2ViRXZlbnRTY3JvbGxXaGVlbDogewotICAgICAgICAgICAgW3NlbGYgc2Nyb2xsV2hlZWw6
ZXZlbnRdOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KKyAgICBjYXNlIFdlYkV2ZW50
TW91c2VEb3duOiB7CisgICAgICAgIFtzZWxmIG1vdXNlRG93bjpldmVudF07CisgICAgICAgIGJy
ZWFrOworICAgIH0KKyAgICBjYXNlIFdlYkV2ZW50TW91c2VVcDogeworICAgICAgICBbc2VsZiBt
b3VzZVVwOmV2ZW50XTsKKyAgICAgICAgYnJlYWs7CisgICAgfQorICAgIGNhc2UgV2ViRXZlbnRN
b3VzZU1vdmVkOiB7CisgICAgICAgIFtzZWxmIG1vdXNlTW92ZWQ6ZXZlbnRdOworICAgICAgICBi
cmVhazsKKyAgICB9CisgICAgY2FzZSBXZWJFdmVudEtleURvd246IHsKKyAgICAgICAgW3NlbGYg
a2V5RG93bjpldmVudF07CisgICAgICAgIGJyZWFrOworICAgIH0KKyAgICBjYXNlIFdlYkV2ZW50
S2V5VXA6IHsKKyAgICAgICAgW3NlbGYga2V5VXA6ZXZlbnRdOworICAgICAgICBicmVhazsKKyAg
ICB9CisgICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOiB7CisgICAgICAgIFtzZWxmIHNjcm9s
bFdoZWVsOmV2ZW50XTsKKyAgICAgICAgYnJlYWs7CisgICAgfQogI2lmIEVOQUJMRShUT1VDSF9F
VkVOVFMpCi0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaEJlZ2luOgotICAgICAgICBjYXNlIFdl
YkV2ZW50VG91Y2hDaGFuZ2U6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVuZDoKLSAgICAg
ICAgY2FzZSBXZWJFdmVudFRvdWNoQ2FuY2VsOiB7Ci0gICAgICAgICAgICBbc2VsZiB0b3VjaDpl
dmVudF07Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAgIGNhc2UgV2ViRXZlbnRU
b3VjaEJlZ2luOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaENoYW5nZToKKyAgICBjYXNlIFdlYkV2
ZW50VG91Y2hFbmQ6CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQ2FuY2VsOiB7CisgICAgICAgIFtz
ZWxmIHRvdWNoOmV2ZW50XTsKKyAgICAgICAgYnJlYWs7CisgICAgfQogI2VuZGlmCi0gICAgICAg
IGRlZmF1bHQ6Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgICAg
IGJyZWFrOwogICAgIH0KICAgICByZXR1cm4gWUVTOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtXaW5kb3cubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5tbQppbmRleCBhY2VmZmJjOWYwNGU2MGRkZjdmZTA0Y2Fi
NjQ1MGFiY2EyNmIwNzc5Li43ZTMyOTY2OGExNTMxZDRhZjkwNTY0ZTY2NmQ4NjhmM2EyYTZiOTky
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5t
bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5tbQpAQCAt
MzI4LDMyICszMjgsMjggQEAgLSAodm9pZClzZW5kRXZlbnRTeW5jaHJvbm91c2x5OihXZWJFdmVu
dCAqKWFuRXZlbnQKICAgICBjdXJyZW50RXZlbnQgPSBbYW5FdmVudCByZXRhaW5dOwogCiAgICAg
c3dpdGNoIChhbkV2ZW50LnR5cGUpIHsKLSAgICAgICAgY2FzZSBXZWJFdmVudE1vdXNlTW92ZWQ6
Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRTY3JvbGxXaGVlbDoKLSAgICAgICAgICAgIGlmIChXQUtW
aWV3ICpoaXRWaWV3ID0gW19jb250ZW50VmlldyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9uSW5X
aW5kb3cpXSkKLSAgICAgICAgICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsK
LSAgICAgICAgICAgIGJyZWFrOwotCi0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZVVwOgotICAg
ICAgICBjYXNlIFdlYkV2ZW50S2V5RG93bjoKLSAgICAgICAgY2FzZSBXZWJFdmVudEtleVVwOgot
ICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hDaGFuZ2U6Ci0gICAgICAgICAgICBbX3Jlc3BvbmRl
clZpZXcgaGFuZGxlRXZlbnQ6YW5FdmVudF07Ci0gICAgICAgICAgICBicmVhazsKLQotICAgICAg
ICBjYXNlIFdlYkV2ZW50TW91c2VEb3duOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hCZWdp
bjoKLSAgICAgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5kOgotICAgICAgICBjYXNlIFdlYkV2ZW50
VG91Y2hDYW5jZWw6Ci0gICAgICAgICAgICBpZiAoV0FLVmlldyAqaGl0VmlldyA9IFtfY29udGVu
dFZpZXcgaGl0VGVzdDooYW5FdmVudC5sb2NhdGlvbkluV2luZG93KV0pIHsKLSAgICAgICAgICAg
ICAgICBbc2VsZiBtYWtlRmlyc3RSZXNwb25kZXI6aGl0Vmlld107Ci0gICAgICAgICAgICAgICAg
W2hpdFZpZXcgaGFuZGxlRXZlbnQ6YW5FdmVudF07Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAg
ICBicmVhazsKLQotICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFD
SEVEKCk7Ci0gICAgICAgICAgICBicmVhazsKKyAgICBjYXNlIFdlYkV2ZW50TW91c2VNb3ZlZDoK
KyAgICBjYXNlIFdlYkV2ZW50U2Nyb2xsV2hlZWw6CisgICAgICAgIGlmIChXQUtWaWV3ICpoaXRW
aWV3ID0gW19jb250ZW50VmlldyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9uSW5XaW5kb3cpXSkK
KyAgICAgICAgICAgIFtoaXRWaWV3IGhhbmRsZUV2ZW50OmFuRXZlbnRdOworICAgICAgICBicmVh
azsKKworICAgIGNhc2UgV2ViRXZlbnRNb3VzZVVwOgorICAgIGNhc2UgV2ViRXZlbnRLZXlEb3du
OgorICAgIGNhc2UgV2ViRXZlbnRLZXlVcDoKKyAgICBjYXNlIFdlYkV2ZW50VG91Y2hDaGFuZ2U6
CisgICAgICAgIFtfcmVzcG9uZGVyVmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKKyAgICAgICAg
YnJlYWs7CisKKyAgICBjYXNlIFdlYkV2ZW50TW91c2VEb3duOgorICAgIGNhc2UgV2ViRXZlbnRU
b3VjaEJlZ2luOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVuZDoKKyAgICBjYXNlIFdlYkV2ZW50
VG91Y2hDYW5jZWw6CisgICAgICAgIGlmIChXQUtWaWV3ICpoaXRWaWV3ID0gW19jb250ZW50Vmll
dyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9uSW5XaW5kb3cpXSkgeworICAgICAgICAgICAgW3Nl
bGYgbWFrZUZpcnN0UmVzcG9uZGVyOmhpdFZpZXddOworICAgICAgICAgICAgW2hpdFZpZXcgaGFu
ZGxlRXZlbnQ6YW5FdmVudF07CisgICAgICAgIH0KKyAgICAgICAgYnJlYWs7CiAgICAgfQogCiAg
ICAgW2N1cnJlbnRFdmVudCByZWxlYXNlXTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351885</attachid>
            <date>2018-10-09 10:07:18 -0700</date>
            <delta_ts>2018-10-09 10:13:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190402-20181009100717.patch</filename>
            <type>text/plain</type>
            <size>5297</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyOGU0NmYwMzYyYzMy
NDVlMzQ4MzUzYWQ4NzEwYTliYjRmMWY3MC4uNzYyY2UwZTc1NzUwZTNiNGM1ZTI5YzQyZmZiNzU1
NDBkOGZiZTJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTA5ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDbGVhbnVwIC1b
V0FLVmlldyBfc2VsZkhhbmRsZUV2ZW50Ol0gYW5kIC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNo
cm9ub3VzbHk6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkwNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVW5pbmRlbnQgY2FzZSBzdGF0ZW1lbnRzLiBSZW1vdmUgdXNlIG9mIGRlZmF1bHQgY2FzZSBz
dGF0ZW1lbnRzIHdpdGggYm9keSBBU1NFUlRfTk9UX1JFQUNIRUQoKQorICAgICAgICB0byBjYXRj
aCB0aGUgY2FzZXMgb2YgYSBtaXNzaW5nIGVudW1lcmF0b3IuIEJ5IG9taXR0aW5nIHRoZSBkZWZh
dWx0IGNhc2Ugc3RhdGVtZW50IHdlIHR1cm4KKyAgICAgICAgc3VjaCBhIHNjZW5hcmlvIGludG8g
YSBjb21waWxlLXRpbWUgZXJyb3IgaW5zdGVhZCBvZiBoYW5kbGluZyBpdCBhcyBhIHJ1bnRpbWUg
ZXJyb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW06CisgICAgICAg
ICgtW1dBS1ZpZXcgX3NlbGZIYW5kbGVFdmVudDpdKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv
d2FrL1dBS1dpbmRvdy5tbToKKyAgICAgICAgKC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNocm9u
b3VzbHk6XSk6CisKIDIwMTgtMTAtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t
PgogCiAgICAgICAgIENsZWFudXAgV2ViRXZlbnQubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLVmlldy5tbQppbmRleCBiYjNhNzUxZTA1OTJlMDU1MzlmNTc0N2E4ZmZiMDBj
ZWFjZTgwNWFkLi4zNjYwODU5ZjE3NmM1NmNkOGQ5ODE3NTY1MGFlNWZmYjc2YzA2ZDBiIDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW0KKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtWaWV3Lm1tCkBAIC0xMzAsNDcgKzEz
MCw0MSBAQCAtICh2b2lkKWhhbmRsZUV2ZW50OihXZWJFdmVudCAqKWV2ZW50CiAKIC0gKEJPT0wp
X3NlbGZIYW5kbGVFdmVudDooV2ViRXZlbnQgKilldmVudAogewotICAgIFdlYkV2ZW50VHlwZSB0
eXBlID0gZXZlbnQudHlwZTsKLSAgICAKLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICAgICAgY2Fz
ZSBXZWJFdmVudE1vdXNlRG93bjogewotICAgICAgICAgICAgW3NlbGYgbW91c2VEb3duOmV2ZW50
XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRN
b3VzZVVwOiB7Ci0gICAgICAgICAgICBbc2VsZiBtb3VzZVVwOmV2ZW50XTsKLSAgICAgICAgICAg
IGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZU1vdmVkOiB7Ci0g
ICAgICAgICAgICBbc2VsZiBtb3VzZU1vdmVkOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwot
ICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOiB7Ci0gICAgICAgICAgICBb
c2VsZiBrZXlEb3duOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAg
ICAgIGNhc2UgV2ViRXZlbnRLZXlVcDogewotICAgICAgICAgICAgW3NlbGYga2V5VXA6ZXZlbnRd
OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgY2FzZSBXZWJFdmVudFNj
cm9sbFdoZWVsOiB7Ci0gICAgICAgICAgICBbc2VsZiBzY3JvbGxXaGVlbDpldmVudF07Ci0gICAg
ICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAgIHN3aXRjaCAoZXZlbnQudHlwZSkgeworICAg
IGNhc2UgV2ViRXZlbnRNb3VzZURvd246IHsKKyAgICAgICAgW3NlbGYgbW91c2VEb3duOmV2ZW50
XTsKKyAgICAgICAgcmV0dXJuIFlFUzsKKyAgICB9CisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6
IHsKKyAgICAgICAgW3NlbGYgbW91c2VVcDpldmVudF07CisgICAgICAgIHJldHVybiBZRVM7Cisg
ICAgfQorICAgIGNhc2UgV2ViRXZlbnRNb3VzZU1vdmVkOiB7CisgICAgICAgIFtzZWxmIG1vdXNl
TW92ZWQ6ZXZlbnRdOworICAgICAgICByZXR1cm4gWUVTOworICAgIH0KKyAgICBjYXNlIFdlYkV2
ZW50S2V5RG93bjogeworICAgICAgICBbc2VsZiBrZXlEb3duOmV2ZW50XTsKKyAgICAgICAgcmV0
dXJuIFlFUzsKKyAgICB9CisgICAgY2FzZSBXZWJFdmVudEtleVVwOiB7CisgICAgICAgIFtzZWxm
IGtleVVwOmV2ZW50XTsKKyAgICAgICAgcmV0dXJuIFlFUzsKKyAgICB9CisgICAgY2FzZSBXZWJF
dmVudFNjcm9sbFdoZWVsOiB7CisgICAgICAgIFtzZWxmIHNjcm9sbFdoZWVsOmV2ZW50XTsKKyAg
ICAgICAgcmV0dXJuIFlFUzsKKyAgICB9CiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKLSAgICAg
ICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENo
YW5nZToKLSAgICAgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5kOgotICAgICAgICBjYXNlIFdlYkV2
ZW50VG91Y2hDYW5jZWw6IHsKLSAgICAgICAgICAgIFtzZWxmIHRvdWNoOmV2ZW50XTsKLSAgICAg
ICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46Cisg
ICAgY2FzZSBXZWJFdmVudFRvdWNoQ2hhbmdlOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVuZDoK
KyAgICBjYXNlIFdlYkV2ZW50VG91Y2hDYW5jZWw6IHsKKyAgICAgICAgW3NlbGYgdG91Y2g6ZXZl
bnRdOworICAgICAgICByZXR1cm4gWUVTOworICAgIH0KICNlbmRpZgotICAgICAgICBkZWZhdWx0
OgotICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICBicmVhazsK
ICAgICB9Ci0gICAgcmV0dXJuIFlFUzsKIH0KIAogLSAoTlNSZXNwb25kZXIgKiluZXh0UmVzcG9u
ZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRv
dy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tCmluZGV4
IGFjZWZmYmM5ZjA0ZTYwZGRmN2ZlMDRjYWI2NDUwYWJjYTI2YjA3NzkuLjdlMzI5NjY4YTE1MzFk
NGFmOTA1NjRlNjY2ZDg2OGYzYTJhNmI5OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLV2luZG93Lm1tCkBAIC0zMjgsMzIgKzMyOCwyOCBAQCAtICh2b2lkKXNlbmRF
dmVudFN5bmNocm9ub3VzbHk6KFdlYkV2ZW50ICopYW5FdmVudAogICAgIGN1cnJlbnRFdmVudCA9
IFthbkV2ZW50IHJldGFpbl07CiAKICAgICBzd2l0Y2ggKGFuRXZlbnQudHlwZSkgewotICAgICAg
ICBjYXNlIFdlYkV2ZW50TW91c2VNb3ZlZDoKLSAgICAgICAgY2FzZSBXZWJFdmVudFNjcm9sbFdo
ZWVsOgotICAgICAgICAgICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhp
dFRlc3Q6KGFuRXZlbnQubG9jYXRpb25JbldpbmRvdyldKQotICAgICAgICAgICAgICAgIFtoaXRW
aWV3IGhhbmRsZUV2ZW50OmFuRXZlbnRdOwotICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAg
Y2FzZSBXZWJFdmVudE1vdXNlVXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOgotICAg
ICAgICBjYXNlIFdlYkV2ZW50S2V5VXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENoYW5n
ZToKLSAgICAgICAgICAgIFtfcmVzcG9uZGVyVmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKLSAg
ICAgICAgICAgIGJyZWFrOwotCi0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246Ci0gICAg
ICAgIGNhc2UgV2ViRXZlbnRUb3VjaEJlZ2luOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hF
bmQ6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKLSAgICAgICAgICAgIGlmIChX
QUtWaWV3ICpoaXRWaWV3ID0gW19jb250ZW50VmlldyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9u
SW5XaW5kb3cpXSkgewotICAgICAgICAgICAgICAgIFtzZWxmIG1ha2VGaXJzdFJlc3BvbmRlcjpo
aXRWaWV3XTsKLSAgICAgICAgICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsK
LSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIGJyZWFrOwotCi0gICAgICAgIGRlZmF1bHQ6Ci0g
ICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgICAgIGJyZWFrOworICAg
IGNhc2UgV2ViRXZlbnRNb3VzZU1vdmVkOgorICAgIGNhc2UgV2ViRXZlbnRTY3JvbGxXaGVlbDoK
KyAgICAgICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFu
RXZlbnQubG9jYXRpb25JbldpbmRvdyldKQorICAgICAgICAgICAgW2hpdFZpZXcgaGFuZGxlRXZl
bnQ6YW5FdmVudF07CisgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6
CisgICAgY2FzZSBXZWJFdmVudEtleURvd246CisgICAgY2FzZSBXZWJFdmVudEtleVVwOgorICAg
IGNhc2UgV2ViRXZlbnRUb3VjaENoYW5nZToKKyAgICAgICAgW19yZXNwb25kZXJWaWV3IGhhbmRs
ZUV2ZW50OmFuRXZlbnRdOworICAgICAgICBicmVhazsKKworICAgIGNhc2UgV2ViRXZlbnRNb3Vz
ZURvd246CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46CisgICAgY2FzZSBXZWJFdmVudFRv
dWNoRW5kOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKKyAgICAgICAgaWYgKFdBS1Zp
ZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFuRXZlbnQubG9jYXRpb25Jbldp
bmRvdyldKSB7CisgICAgICAgICAgICBbc2VsZiBtYWtlRmlyc3RSZXNwb25kZXI6aGl0Vmlld107
CisgICAgICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKKyAgICAgICAgfQor
ICAgICAgICBicmVhazsKICAgICB9CiAKICAgICBbY3VycmVudEV2ZW50IHJlbGVhc2VdOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351886</attachid>
            <date>2018-10-09 10:13:26 -0700</date>
            <delta_ts>2018-10-09 10:46:05 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190402-20181009101325.patch</filename>
            <type>text/plain</type>
            <size>5234</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyOGU0NmYwMzYyYzMy
NDVlMzQ4MzUzYWQ4NzEwYTliYjRmMWY3MC4uNzYyY2UwZTc1NzUwZTNiNGM1ZTI5YzQyZmZiNzU1
NDBkOGZiZTJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTA5ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDbGVhbnVwIC1b
V0FLVmlldyBfc2VsZkhhbmRsZUV2ZW50Ol0gYW5kIC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNo
cm9ub3VzbHk6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkwNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVW5pbmRlbnQgY2FzZSBzdGF0ZW1lbnRzLiBSZW1vdmUgdXNlIG9mIGRlZmF1bHQgY2FzZSBz
dGF0ZW1lbnRzIHdpdGggYm9keSBBU1NFUlRfTk9UX1JFQUNIRUQoKQorICAgICAgICB0byBjYXRj
aCB0aGUgY2FzZXMgb2YgYSBtaXNzaW5nIGVudW1lcmF0b3IuIEJ5IG9taXR0aW5nIHRoZSBkZWZh
dWx0IGNhc2Ugc3RhdGVtZW50IHdlIHR1cm4KKyAgICAgICAgc3VjaCBhIHNjZW5hcmlvIGludG8g
YSBjb21waWxlLXRpbWUgZXJyb3IgaW5zdGVhZCBvZiBoYW5kbGluZyBpdCBhcyBhIHJ1bnRpbWUg
ZXJyb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW06CisgICAgICAg
ICgtW1dBS1ZpZXcgX3NlbGZIYW5kbGVFdmVudDpdKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv
d2FrL1dBS1dpbmRvdy5tbToKKyAgICAgICAgKC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNocm9u
b3VzbHk6XSk6CisKIDIwMTgtMTAtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t
PgogCiAgICAgICAgIENsZWFudXAgV2ViRXZlbnQubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLVmlldy5tbQppbmRleCBiYjNhNzUxZTA1OTJlMDU1MzlmNTc0N2E4ZmZiMDBj
ZWFjZTgwNWFkLi4zOTg0N2JhODQ5Njk4ZDYxMjIwZmJlZTAyMzBhMmVmNjVmNjA2MGQ4IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW0KKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtWaWV3Lm1tCkBAIC0xMzAsNDcgKzEz
MCwzNCBAQCAtICh2b2lkKWhhbmRsZUV2ZW50OihXZWJFdmVudCAqKWV2ZW50CiAKIC0gKEJPT0wp
X3NlbGZIYW5kbGVFdmVudDooV2ViRXZlbnQgKilldmVudAogewotICAgIFdlYkV2ZW50VHlwZSB0
eXBlID0gZXZlbnQudHlwZTsKLSAgICAKLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICAgICAgY2Fz
ZSBXZWJFdmVudE1vdXNlRG93bjogewotICAgICAgICAgICAgW3NlbGYgbW91c2VEb3duOmV2ZW50
XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRN
b3VzZVVwOiB7Ci0gICAgICAgICAgICBbc2VsZiBtb3VzZVVwOmV2ZW50XTsKLSAgICAgICAgICAg
IGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZU1vdmVkOiB7Ci0g
ICAgICAgICAgICBbc2VsZiBtb3VzZU1vdmVkOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwot
ICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOiB7Ci0gICAgICAgICAgICBb
c2VsZiBrZXlEb3duOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAg
ICAgIGNhc2UgV2ViRXZlbnRLZXlVcDogewotICAgICAgICAgICAgW3NlbGYga2V5VXA6ZXZlbnRd
OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgY2FzZSBXZWJFdmVudFNj
cm9sbFdoZWVsOiB7Ci0gICAgICAgICAgICBbc2VsZiBzY3JvbGxXaGVlbDpldmVudF07Ci0gICAg
ICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAgIHN3aXRjaCAoZXZlbnQudHlwZSkgeworICAg
IGNhc2UgV2ViRXZlbnRNb3VzZURvd246CisgICAgICAgIFtzZWxmIG1vdXNlRG93bjpldmVudF07
CisgICAgICAgIHJldHVybiBZRVM7CisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6CisgICAgICAg
IFtzZWxmIG1vdXNlVXA6ZXZlbnRdOworICAgICAgICByZXR1cm4gWUVTOworICAgIGNhc2UgV2Vi
RXZlbnRNb3VzZU1vdmVkOgorICAgICAgICBbc2VsZiBtb3VzZU1vdmVkOmV2ZW50XTsKKyAgICAg
ICAgcmV0dXJuIFlFUzsKKyAgICBjYXNlIFdlYkV2ZW50S2V5RG93bjoKKyAgICAgICAgW3NlbGYg
a2V5RG93bjpldmVudF07CisgICAgICAgIHJldHVybiBZRVM7CisgICAgY2FzZSBXZWJFdmVudEtl
eVVwOgorICAgICAgICBbc2VsZiBrZXlVcDpldmVudF07CisgICAgICAgIHJldHVybiBZRVM7Cisg
ICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOgorICAgICAgICBbc2VsZiBzY3JvbGxXaGVlbDpl
dmVudF07CisgICAgICAgIHJldHVybiBZRVM7CiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKLSAg
ICAgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3Vj
aENoYW5nZToKLSAgICAgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5kOgotICAgICAgICBjYXNlIFdl
YkV2ZW50VG91Y2hDYW5jZWw6IHsKLSAgICAgICAgICAgIFtzZWxmIHRvdWNoOmV2ZW50XTsKLSAg
ICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46
CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQ2hhbmdlOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVu
ZDoKKyAgICBjYXNlIFdlYkV2ZW50VG91Y2hDYW5jZWw6CisgICAgICAgIFtzZWxmIHRvdWNoOmV2
ZW50XTsKKyAgICAgICAgcmV0dXJuIFlFUzsKICNlbmRpZgotICAgICAgICBkZWZhdWx0OgotICAg
ICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgICAgICBicmVhazsKICAgICB9
Ci0gICAgcmV0dXJuIFlFUzsKIH0KIAogLSAoTlNSZXNwb25kZXIgKiluZXh0UmVzcG9uZGVyCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5tbSBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tCmluZGV4IGFjZWZm
YmM5ZjA0ZTYwZGRmN2ZlMDRjYWI2NDUwYWJjYTI2YjA3NzkuLjdlMzI5NjY4YTE1MzFkNGFmOTA1
NjRlNjY2ZDg2OGYzYTJhNmI5OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93
YWsvV0FLV2luZG93Lm1tCkBAIC0zMjgsMzIgKzMyOCwyOCBAQCAtICh2b2lkKXNlbmRFdmVudFN5
bmNocm9ub3VzbHk6KFdlYkV2ZW50ICopYW5FdmVudAogICAgIGN1cnJlbnRFdmVudCA9IFthbkV2
ZW50IHJldGFpbl07CiAKICAgICBzd2l0Y2ggKGFuRXZlbnQudHlwZSkgewotICAgICAgICBjYXNl
IFdlYkV2ZW50TW91c2VNb3ZlZDoKLSAgICAgICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOgot
ICAgICAgICAgICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6
KGFuRXZlbnQubG9jYXRpb25JbldpbmRvdyldKQotICAgICAgICAgICAgICAgIFtoaXRWaWV3IGhh
bmRsZUV2ZW50OmFuRXZlbnRdOwotICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAgY2FzZSBX
ZWJFdmVudE1vdXNlVXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOgotICAgICAgICBj
YXNlIFdlYkV2ZW50S2V5VXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENoYW5nZToKLSAg
ICAgICAgICAgIFtfcmVzcG9uZGVyVmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKLSAgICAgICAg
ICAgIGJyZWFrOwotCi0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246Ci0gICAgICAgIGNh
c2UgV2ViRXZlbnRUb3VjaEJlZ2luOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hFbmQ6Ci0g
ICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKLSAgICAgICAgICAgIGlmIChXQUtWaWV3
ICpoaXRWaWV3ID0gW19jb250ZW50VmlldyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9uSW5XaW5k
b3cpXSkgewotICAgICAgICAgICAgICAgIFtzZWxmIG1ha2VGaXJzdFJlc3BvbmRlcjpoaXRWaWV3
XTsKLSAgICAgICAgICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKLSAgICAg
ICAgICAgIH0KLSAgICAgICAgICAgIGJyZWFrOwotCi0gICAgICAgIGRlZmF1bHQ6Ci0gICAgICAg
ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgICAgIGJyZWFrOworICAgIGNhc2Ug
V2ViRXZlbnRNb3VzZU1vdmVkOgorICAgIGNhc2UgV2ViRXZlbnRTY3JvbGxXaGVlbDoKKyAgICAg
ICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFuRXZlbnQu
bG9jYXRpb25JbldpbmRvdyldKQorICAgICAgICAgICAgW2hpdFZpZXcgaGFuZGxlRXZlbnQ6YW5F
dmVudF07CisgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6CisgICAg
Y2FzZSBXZWJFdmVudEtleURvd246CisgICAgY2FzZSBXZWJFdmVudEtleVVwOgorICAgIGNhc2Ug
V2ViRXZlbnRUb3VjaENoYW5nZToKKyAgICAgICAgW19yZXNwb25kZXJWaWV3IGhhbmRsZUV2ZW50
OmFuRXZlbnRdOworICAgICAgICBicmVhazsKKworICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246
CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46CisgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5k
OgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKKyAgICAgICAgaWYgKFdBS1ZpZXcgKmhp
dFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFuRXZlbnQubG9jYXRpb25JbldpbmRvdyld
KSB7CisgICAgICAgICAgICBbc2VsZiBtYWtlRmlyc3RSZXNwb25kZXI6aGl0Vmlld107CisgICAg
ICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKKyAgICAgICAgfQorICAgICAg
ICBicmVhazsKICAgICB9CiAKICAgICBbY3VycmVudEV2ZW50IHJlbGVhc2VdOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351894</attachid>
            <date>2018-10-09 10:46:06 -0700</date>
            <delta_ts>2018-10-10 20:08:39 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190402-20181009104606.patch</filename>
            <type>text/plain</type>
            <size>5234</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQyOGU0NmYwMzYyYzMy
NDVlMzQ4MzUzYWQ4NzEwYTliYjRmMWY3MC4uNzYyY2UwZTc1NzUwZTNiNGM1ZTI5YzQyZmZiNzU1
NDBkOGZiZTJiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTA5ICBEYW5p
ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDbGVhbnVwIC1b
V0FLVmlldyBfc2VsZkhhbmRsZUV2ZW50Ol0gYW5kIC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNo
cm9ub3VzbHk6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9MTkwNDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVW5pbmRlbnQgY2FzZSBzdGF0ZW1lbnRzLiBSZW1vdmUgdXNlIG9mIGRlZmF1bHQgY2FzZSBz
dGF0ZW1lbnRzIHdpdGggYm9keSBBU1NFUlRfTk9UX1JFQUNIRUQoKQorICAgICAgICB0byBjYXRj
aCB0aGUgY2FzZXMgb2YgYSBtaXNzaW5nIGVudW1lcmF0b3IuIEJ5IG9taXR0aW5nIHRoZSBkZWZh
dWx0IGNhc2Ugc3RhdGVtZW50IHdlIHR1cm4KKyAgICAgICAgc3VjaCBhIHNjZW5hcmlvIGludG8g
YSBjb21waWxlLXRpbWUgZXJyb3IgaW5zdGVhZCBvZiBoYW5kbGluZyBpdCBhcyBhIHJ1bnRpbWUg
ZXJyb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW06CisgICAgICAg
ICgtW1dBS1ZpZXcgX3NlbGZIYW5kbGVFdmVudDpdKToKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mv
d2FrL1dBS1dpbmRvdy5tbToKKyAgICAgICAgKC1bV0FLV2luZG93IHNlbmRFdmVudFN5bmNocm9u
b3VzbHk6XSk6CisKIDIwMTgtMTAtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29t
PgogCiAgICAgICAgIENsZWFudXAgV2ViRXZlbnQubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLVmlldy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLVmlldy5tbQppbmRleCBiYjNhNzUxZTA1OTJlMDU1MzlmNTc0N2E4ZmZiMDBj
ZWFjZTgwNWFkLi5kZWVlMzhiNTgwNTQxODI5NzM2YjFhOGNjMGE4MmM1MjhjMTYxODE1IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1ZpZXcubW0KKysrIGIv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL3dhay9XQUtWaWV3Lm1tCkBAIC0xMzAsNDcgKzEz
MCwzNCBAQCAtICh2b2lkKWhhbmRsZUV2ZW50OihXZWJFdmVudCAqKWV2ZW50CiAKIC0gKEJPT0wp
X3NlbGZIYW5kbGVFdmVudDooV2ViRXZlbnQgKilldmVudAogewotICAgIFdlYkV2ZW50VHlwZSB0
eXBlID0gZXZlbnQudHlwZTsKLSAgICAKLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICAgICAgY2Fz
ZSBXZWJFdmVudE1vdXNlRG93bjogewotICAgICAgICAgICAgW3NlbGYgbW91c2VEb3duOmV2ZW50
XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRN
b3VzZVVwOiB7Ci0gICAgICAgICAgICBbc2VsZiBtb3VzZVVwOmV2ZW50XTsKLSAgICAgICAgICAg
IGJyZWFrOwotICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZU1vdmVkOiB7Ci0g
ICAgICAgICAgICBbc2VsZiBtb3VzZU1vdmVkOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwot
ICAgICAgICB9Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOiB7Ci0gICAgICAgICAgICBb
c2VsZiBrZXlEb3duOmV2ZW50XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9Ci0gICAg
ICAgIGNhc2UgV2ViRXZlbnRLZXlVcDogewotICAgICAgICAgICAgW3NlbGYga2V5VXA6ZXZlbnRd
OwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAgY2FzZSBXZWJFdmVudFNj
cm9sbFdoZWVsOiB7Ci0gICAgICAgICAgICBbc2VsZiBzY3JvbGxXaGVlbDpldmVudF07Ci0gICAg
ICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAgIHN3aXRjaCAoZXZlbnQudHlwZSkgeworICAg
IGNhc2UgV2ViRXZlbnRNb3VzZURvd246CisgICAgICAgIFtzZWxmIG1vdXNlRG93bjpldmVudF07
CisgICAgICAgIHJldHVybiBZRVM7CisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6CisgICAgICAg
IFtzZWxmIG1vdXNlVXA6ZXZlbnRdOworICAgICAgICByZXR1cm4gWUVTOworICAgIGNhc2UgV2Vi
RXZlbnRNb3VzZU1vdmVkOgorICAgICAgICBbc2VsZiBtb3VzZU1vdmVkOmV2ZW50XTsKKyAgICAg
ICAgcmV0dXJuIFlFUzsKKyAgICBjYXNlIFdlYkV2ZW50S2V5RG93bjoKKyAgICAgICAgW3NlbGYg
a2V5RG93bjpldmVudF07CisgICAgICAgIHJldHVybiBZRVM7CisgICAgY2FzZSBXZWJFdmVudEtl
eVVwOgorICAgICAgICBbc2VsZiBrZXlVcDpldmVudF07CisgICAgICAgIHJldHVybiBZRVM7Cisg
ICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOgorICAgICAgICBbc2VsZiBzY3JvbGxXaGVlbDpl
dmVudF07CisgICAgICAgIHJldHVybiBZRVM7CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46
CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQ2hhbmdlOgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaEVu
ZDoKKyAgICBjYXNlIFdlYkV2ZW50VG91Y2hDYW5jZWw6CiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5U
UykKLSAgICAgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46Ci0gICAgICAgIGNhc2UgV2ViRXZl
bnRUb3VjaENoYW5nZToKLSAgICAgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5kOgotICAgICAgICBj
YXNlIFdlYkV2ZW50VG91Y2hDYW5jZWw6IHsKLSAgICAgICAgICAgIFtzZWxmIHRvdWNoOmV2ZW50
XTsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgICAgIFtzZWxmIHRvdWNoOmV2
ZW50XTsKICNlbmRpZgotICAgICAgICBkZWZhdWx0OgotICAgICAgICAgICAgQVNTRVJUX05PVF9S
RUFDSEVEKCk7Ci0gICAgICAgICAgICBicmVhazsKKyAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9
Ci0gICAgcmV0dXJuIFlFUzsKIH0KIAogLSAoTlNSZXNwb25kZXIgKiluZXh0UmVzcG9uZGVyCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3Mvd2FrL1dBS1dpbmRvdy5tbSBi
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93YWsvV0FLV2luZG93Lm1tCmluZGV4IGFjZWZm
YmM5ZjA0ZTYwZGRmN2ZlMDRjYWI2NDUwYWJjYTI2YjA3NzkuLjdlMzI5NjY4YTE1MzFkNGFmOTA1
NjRlNjY2ZDg2OGYzYTJhNmI5OTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L2lvcy93YWsvV0FLV2luZG93Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy93
YWsvV0FLV2luZG93Lm1tCkBAIC0zMjgsMzIgKzMyOCwyOCBAQCAtICh2b2lkKXNlbmRFdmVudFN5
bmNocm9ub3VzbHk6KFdlYkV2ZW50ICopYW5FdmVudAogICAgIGN1cnJlbnRFdmVudCA9IFthbkV2
ZW50IHJldGFpbl07CiAKICAgICBzd2l0Y2ggKGFuRXZlbnQudHlwZSkgewotICAgICAgICBjYXNl
IFdlYkV2ZW50TW91c2VNb3ZlZDoKLSAgICAgICAgY2FzZSBXZWJFdmVudFNjcm9sbFdoZWVsOgot
ICAgICAgICAgICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6
KGFuRXZlbnQubG9jYXRpb25JbldpbmRvdyldKQotICAgICAgICAgICAgICAgIFtoaXRWaWV3IGhh
bmRsZUV2ZW50OmFuRXZlbnRdOwotICAgICAgICAgICAgYnJlYWs7Ci0KLSAgICAgICAgY2FzZSBX
ZWJFdmVudE1vdXNlVXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRLZXlEb3duOgotICAgICAgICBj
YXNlIFdlYkV2ZW50S2V5VXA6Ci0gICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENoYW5nZToKLSAg
ICAgICAgICAgIFtfcmVzcG9uZGVyVmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKLSAgICAgICAg
ICAgIGJyZWFrOwotCi0gICAgICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246Ci0gICAgICAgIGNh
c2UgV2ViRXZlbnRUb3VjaEJlZ2luOgotICAgICAgICBjYXNlIFdlYkV2ZW50VG91Y2hFbmQ6Ci0g
ICAgICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKLSAgICAgICAgICAgIGlmIChXQUtWaWV3
ICpoaXRWaWV3ID0gW19jb250ZW50VmlldyBoaXRUZXN0OihhbkV2ZW50LmxvY2F0aW9uSW5XaW5k
b3cpXSkgewotICAgICAgICAgICAgICAgIFtzZWxmIG1ha2VGaXJzdFJlc3BvbmRlcjpoaXRWaWV3
XTsKLSAgICAgICAgICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKLSAgICAg
ICAgICAgIH0KLSAgICAgICAgICAgIGJyZWFrOwotCi0gICAgICAgIGRlZmF1bHQ6Ci0gICAgICAg
ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgICAgIGJyZWFrOworICAgIGNhc2Ug
V2ViRXZlbnRNb3VzZU1vdmVkOgorICAgIGNhc2UgV2ViRXZlbnRTY3JvbGxXaGVlbDoKKyAgICAg
ICAgaWYgKFdBS1ZpZXcgKmhpdFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFuRXZlbnQu
bG9jYXRpb25JbldpbmRvdyldKQorICAgICAgICAgICAgW2hpdFZpZXcgaGFuZGxlRXZlbnQ6YW5F
dmVudF07CisgICAgICAgIGJyZWFrOworCisgICAgY2FzZSBXZWJFdmVudE1vdXNlVXA6CisgICAg
Y2FzZSBXZWJFdmVudEtleURvd246CisgICAgY2FzZSBXZWJFdmVudEtleVVwOgorICAgIGNhc2Ug
V2ViRXZlbnRUb3VjaENoYW5nZToKKyAgICAgICAgW19yZXNwb25kZXJWaWV3IGhhbmRsZUV2ZW50
OmFuRXZlbnRdOworICAgICAgICBicmVhazsKKworICAgIGNhc2UgV2ViRXZlbnRNb3VzZURvd246
CisgICAgY2FzZSBXZWJFdmVudFRvdWNoQmVnaW46CisgICAgY2FzZSBXZWJFdmVudFRvdWNoRW5k
OgorICAgIGNhc2UgV2ViRXZlbnRUb3VjaENhbmNlbDoKKyAgICAgICAgaWYgKFdBS1ZpZXcgKmhp
dFZpZXcgPSBbX2NvbnRlbnRWaWV3IGhpdFRlc3Q6KGFuRXZlbnQubG9jYXRpb25JbldpbmRvdyld
KSB7CisgICAgICAgICAgICBbc2VsZiBtYWtlRmlyc3RSZXNwb25kZXI6aGl0Vmlld107CisgICAg
ICAgICAgICBbaGl0VmlldyBoYW5kbGVFdmVudDphbkV2ZW50XTsKKyAgICAgICAgfQorICAgICAg
ICBicmVhazsKICAgICB9CiAKICAgICBbY3VycmVudEV2ZW50IHJlbGVhc2VdOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>