190398 2018-10-09 08:16:07 -0700 [WPE] Explicitly link against gmodule where used 2018-10-09 12:25:26 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 csaavedra csaavedra aperez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1467397 0 csaavedra 2018-10-09 08:16:07 -0700 [WPE] Explicitly link against gmodule where used 1467398 1 351879 csaavedra 2018-10-09 08:16:54 -0700 Created attachment 351879 Patch 1467399 2 csaavedra 2018-10-09 08:18:01 -0700 I ran into linking issues downstream because gmodule was not being pulled in, so let's add this. Not sure if it's needed for GTK+, but maybe yes. 1467438 3 aperez 2018-10-09 10:13:00 -0700 (In reply to Claudio Saavedra from comment #2) > I ran into linking issues downstream because gmodule was not being pulled > in, so let's add this. Not sure if it's needed for GTK+, but maybe yes. I think the linking error is noticeable more easily in the WPE port because GModule is used in JSC to load “libWPEInspectorResources.so”, which gets built first, but then it's used also in WebKit's “ModuleGlib.cpp” and “InjectedBundleGlib.cpp” so both ports en up using it. It could be that in the case of the GTK+ port some of the additional libraries used by the sources in the “WebKit/” subdir also use GModule, and that's why we don't see linker errors there. At any rate, the correct thing to do is explicitly adding the GModule flags obtained from pkg-config to the targets which use them, so let's land this (informal r+ here!) 1467441 4 aperez 2018-10-09 10:14:22 -0700 FWIW, the GTK+ port already has GModule in “Source/WebCore/PlatformGTK.cmake”, so no changes should be needed for the GTK+ port. 1467515 5 351879 commit-queue 2018-10-09 12:25:25 -0700 Comment on attachment 351879 Patch Clearing flags on attachment: 351879 Committed r236975: <https://trac.webkit.org/changeset/236975> 1467516 6 commit-queue 2018-10-09 12:25:26 -0700 All reviewed patches have been landed. Closing bug. 351879 2018-10-09 08:16:54 -0700 2018-10-09 12:25:25 -0700 Patch bug-190398-20181009181653.patch text/plain 2207 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm OWU0MDEzYzgwOTEzZjMyYWM1ZDY4ZTdkZmU0NTg1ODNiMDRjMWRiLi41YTcxNTg0YWYyYTJhZTRi ZDFlNjY3ZjhkMjQxNWY4NmQzMGZjOGEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0xMC0wOSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdIEV4cGxpY2l0bHkgbGluayBhZ2FpbnN0IGdtb2R1bGUg d2hlcmUgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTkwMzk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBQbGF0Zm9ybVdQRS5jbWFrZToKKwogMjAxOC0xMC0wOCAgSnVzdGluIEZhbiAgPGp1c3Rp bl9mYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkdQVTogUmVuYW1lIG9sZCBXZWJHUFUgcHJv dG90eXBlIHRvIFdlYk1ldGFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVmZWMyOTk2ODVkYmRhZTQ2MzBkMDgyMGMw ZGVlNTY2ODc3MDJhMGYuLjM3YzMzNzhlOTdmZDM5ZTIwNzhmYWM0YjIzMWI2Nzk3YTcyMzMyOGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMTAtMDkgIENsYXVkaW8gU2FhdmVkcmEg IDxjc2FhdmVkcmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBFeHBsaWNpdGx5IGxpbmsg YWdhaW5zdCBnbW9kdWxlIHdoZXJlIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MDM5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6CisKIDIwMTgtMTAtMDkgIEFu dHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFByZXdhcm0gRm9udERh dGFiYXNlIG9uIHByb2Nlc3Mgc3dhcApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtV1BFLmNt YWtlCmluZGV4IDY5ZTliZWM0ODY4N2YwNzhmMjQ2OWUyNzk2ZmRlNDEzOWJjNDUyOTcuLjQ1M2I1 NGJlOGViZDE1YjE3MWExNTIzYThlOGZjYTU0YzU2ZjY4NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9QbGF0Zm9ybVdQRS5jbWFrZQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvUGxhdGZvcm1XUEUuY21ha2UKQEAgLTIsNiArMiw3IEBAIGluY2x1ZGUoR0xpYi5jbWFrZSkK IAogbGlzdChBUFBFTkQgSmF2YVNjcmlwdENvcmVfTElCUkFSSUVTCiAgICAgJHtHTElCX0xJQlJB UklFU30KKyAgICAke0dMSUJfR01PRFVMRV9MSUJSQVJJRVN9CiApCiAKIGxpc3QoQVBQRU5EIEph dmFTY3JpcHRDb3JlX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5j bWFrZQppbmRleCBiOTBlOGMwZTljZjFmMGMzMTY4YTNiNDM4ZThmMWQ0YzY2NGUxZjkyLi5jY2Zh YmFiYTU2MDhmYmRkMmJlYjI5Y2Q4OTYzNDJmMTk2Zjc4NzgwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUu Y21ha2UKQEAgLTI4Miw2ICsyODIsNyBAQCBsaXN0KEFQUEVORCBXZWJLaXRfTElCUkFSSUVTCiAg ICAgICAgICR7Q0FJUk9fTElCUkFSSUVTfQogICAgICAgICAke0ZSRUVUWVBFX0xJQlJBUklFU30K ICAgICAgICAgJHtHTElCX0xJQlJBUklFU30KKyAgICAgICAgJHtHTElCX0dNT0RVTEVfTElCUkFS SUVTfQogICAgICAgICAke0dTVFJFQU1FUl9MSUJSQVJJRVN9CiAgICAgICAgICR7SEFSRkJVWlpf TElCUkFSSUVTfQogICAgICAgICAke0xJQlNPVVBfTElCUkFSSUVTfQo=