190396 2018-10-09 07:36:56 -0700 Revert temporary asserts for debugging a mysterious ASAN bot crash. 2018-10-09 08:33:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue dbates ews-watchlist pnormand webkit-bug-importer ysuzuki oldest_to_newest 1467390 0 mark.lam 2018-10-09 07:36:56 -0700 Patch coming. 1467392 1 351877 mark.lam 2018-10-09 07:44:23 -0700 Created attachment 351877 proposed patch. 1467393 2 351877 ysuzuki 2018-10-09 07:52:30 -0700 Comment on attachment 351877 proposed patch. r=me 1467402 3 351877 commit-queue 2018-10-09 08:31:40 -0700 Comment on attachment 351877 proposed patch. Clearing flags on attachment: 351877 Committed r236962: <https://trac.webkit.org/changeset/236962> 1467403 4 commit-queue 2018-10-09 08:31:42 -0700 All reviewed patches have been landed. Closing bug. 1467404 5 webkit-bug-importer 2018-10-09 08:33:30 -0700 <rdar://problem/45126808> 351877 2018-10-09 07:44:23 -0700 2018-10-09 08:31:40 -0700 proposed patch. bug-190396.patch text/plain 3151 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzY5NjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTEwLTA5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZlcnQgdGVtcG9yYXJ5IGFzc2VydHMgZm9yIGRlYnVn Z2luZyBhIG15c3RlcmlvdXMgQVNBTiBib3QgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAzOTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5jcHA6CisgICAgICAg IChXVEY6OlN0YWNrQm91bmRzOjpuZXdUaHJlYWRTdGFja0JvdW5kcyk6CisgICAgICAgICogd3Rm L1N0YWNrQm91bmRzLmg6CisgICAgICAgIChXVEY6OlN0YWNrQm91bmRzOjpjaGVja0NvbnNpc3Rl bmN5IGNvbnN0KToKKwogMjAxOC0xMC0wOCAgQWRpdHlhIEtlZXJ0aGkgIDxha2VlcnRoaUBhcHBs ZS5jb20+CiAKICAgICAgICAgTWFrZSA8aW5wdXQgdHlwZT1jb2xvcj4gYSBydW50aW1lIGVuYWJs ZWQgKG9uLWJ5LWRlZmF1bHQpIGZlYXR1cmUKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1N0YWNrQm91 bmRzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAJKHJl dmlzaW9uIDIzNjk1NykKKysrIFNvdXJjZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTQ1LDE4ICsxNDUsNiBAQCBTdGFja0JvdW5kcyBTdGFja0JvdW5kczo6bmV3 VGhyZWFkU3RhY2tCCiAgICAgaWYgKHN0YWNrRGlyZWN0aW9uKCkgPT0gU3RhY2tEaXJlY3Rpb246 OlVwd2FyZCkKICAgICAgICAgc3RkOjpzd2FwKG9yaWdpbiwgYm91bmQpOwogCi0gICAgLy8gVGhl IGZvbGxvd2luZyBzZXQgb2YgYXNzZXJ0aW9ucyBhcmUgb25seSBuZWVkZWQgZm9yIGRlYnVnZ2lu ZyBhCi0gICAgLy8gbXlzdGVyaW91cyBjcmFzaCBvbiBhbiBBU0FOIGJvdCB0aGF0IGlzIG5vdCBy ZXByb2R1Y2libGUgb3RoZXJ3aXNlLgotICAgIC8vIFdpbGwgcmVtb3ZlIGFmdGVyIHRoZSBuZWVk ZWQgZGF0YSBoYXMgYmVlbiBjb2xsZWN0ZWQuCi0jaWYgT1MoTElOVVgpCi0gICAgZWxzZSB7Ci0g ICAgICAgIEFTU0VSVChzdGFja0RpcmVjdGlvbigpID09IFN0YWNrRGlyZWN0aW9uOjpEb3dud2Fy ZCk7Ci0gICAgICAgIHZvaWQqIGN1cnJlbnRQb3NpdGlvbiA9ICZjdXJyZW50UG9zaXRpb247Ci0g ICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0VfVU5VU0VEKGN1cnJlbnRQb3NpdGlvbiwgKGN1cnJl bnRQb3NpdGlvbiA8IG9yaWdpbiAmJiBjdXJyZW50UG9zaXRpb24gPiBib3VuZCksICJuZXdUaHJl YWRTdGFja0JvdW5kczogY3VycmVudFBvc2l0aW9uICVwIG9yaWdpbiAlcCBib3VuZCAlcCBzdGFj a1NpemUgJXp1IiwgY3VycmVudFBvc2l0aW9uLCBvcmlnaW4sIGJvdW5kLCBzdGFja1NpemUpOwot ICAgIH0KLSNlbmRpZgotICAgIC8vIEVuZCBvZiBBU0FOIGJvdCBkZWJ1Z2dpbmcgYXNzZXJ0aW9u cy4KLQogICAgIHJldHVybiBTdGFja0JvdW5kcyB7IG9yaWdpbiwgYm91bmQgfTsKIH0KIApJbmRl eDogU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L3d0Zi9TdGFja0JvdW5kcy5oCShyZXZpc2lvbiAyMzY5NTcpCisrKyBTb3VyY2UvV1RGL3d0Zi9T dGFja0JvdW5kcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsMTggKzE0Nyw2IEBAIHByaXZhdGU6 CiAgICAgewogI2lmICFBU1NFUlRfRElTQUJMRUQKICAgICAgICAgdm9pZCogY3VycmVudFBvc2l0 aW9uID0gJmN1cnJlbnRQb3NpdGlvbjsKLQotICAgICAgICAvLyBUaGUgZm9sbG93aW5nIHNldCBv ZiBhc3NlcnRpb25zIGFyZSBvbmx5IG5lZWRlZCBmb3IgZGVidWdnaW5nIGEKLSAgICAgICAgLy8g bXlzdGVyaW91cyBjcmFzaCBvbiBhbiBBU0FOIGJvdCB0aGF0IGlzIG5vdCByZXByb2R1Y2libGUg b3RoZXJ3aXNlLgotICAgICAgICAvLyBXaWxsIHJlbW92ZSBhZnRlciB0aGUgbmVlZGVkIGRhdGEg aGFzIGJlZW4gY29sbGVjdGVkLgotI2lmIE9TKExJTlVYKQotICAgICAgICBpZiAoaXNHcm93aW5n RG93bndhcmQoKSkKLSAgICAgICAgICAgIEFTU0VSVF9XSVRIX01FU1NBR0UoKGN1cnJlbnRQb3Np dGlvbiA8IG1fb3JpZ2luICYmIGN1cnJlbnRQb3NpdGlvbiA+IG1fYm91bmQpLCAiY2hlY2tDb25z aXN0ZW5jeTogY3VycmVudFBvc2l0aW9uICVwIG1fb3JpZ2luICVwIG1fYm91bmQgJXAgc3RhY2tT aXplICV6dSIsIGN1cnJlbnRQb3NpdGlvbiwgbV9vcmlnaW4sIG1fYm91bmQsIChyZWludGVycHJl dF9jYXN0PHVpbnQ4X3QqPihtX29yaWdpbikgLSByZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPiht X2JvdW5kKSkpOwotICAgICAgICBlbHNlCi0gICAgICAgICAgICBBU1NFUlRfV0lUSF9NRVNTQUdF KChjdXJyZW50UG9zaXRpb24gPiBtX29yaWdpbiAmJiBjdXJyZW50UG9zaXRpb24gPCBtX2JvdW5k KSwgImNoZWNrQ29uc2lzdGVuY3k6IGN1cnJlbnRQb3NpdGlvbiAlcCBtX29yaWdpbiAlcCBtX2Jv dW5kICVwIHN0YWNrU2l6ZSAlenUiLCBjdXJyZW50UG9zaXRpb24sIG1fb3JpZ2luLCBtX2JvdW5k LCAocmVpbnRlcnByZXRfY2FzdDx1aW50OF90Kj4obV9ib3VuZCkgLSByZWludGVycHJldF9jYXN0 PHVpbnQ4X3QqPihtX29yaWdpbikpKTsKLSNlbmRpZiAvLyBPUyhMSU5VWCkKLSAgICAgICAgLy8g RW5kIG9mIEFTQU4gYm90IGRlYnVnZ2luZyBhc3NlcnRpb25zLgotCiAgICAgICAgIEFTU0VSVCht X29yaWdpbiAhPSBtX2JvdW5kKTsKICAgICAgICAgQVNTRVJUKGlzR3Jvd2luZ0Rvd253YXJkKCkK ICAgICAgICAgICAgID8gKGN1cnJlbnRQb3NpdGlvbiA8IG1fb3JpZ2luICYmIGN1cnJlbnRQb3Np dGlvbiA+IG1fYm91bmQpCg==