190394 2018-10-08 23:33:16 -0700 r236735 has some dead ASSERTs that need to be moved 2018-10-09 10:41:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190143 1 calvaris aboya aboya bugs-noreply calvaris commit-queue pnormand webkit-bug-importer oldest_to_newest 1467351 0 calvaris 2018-10-08 23:33:16 -0700 +++ This bug was initially created as a clone of Bug #190143 +++ The MP4 file used in this URL does not contain a stss (Sync Sample Box). In consequence, in acordance with the ISO BMFF spec, all samples are assumed to be sync frames... But in this case that is not true, it's just that the file is wrong (e.g. created with a buggy muxer). http://orange-opensource.github.io/hasplayer.js/1.2.0/player.html?url=http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism/Manifest The way it works in other browsers is because instead of trusting the MP4 stss table, they rely on parsing the h264 frames. We can do that too, using h264parse. 1467357 1 351867 aboya 2018-10-09 00:08:27 -0700 Created attachment 351867 Patch 1467455 2 351867 commit-queue 2018-10-09 10:40:10 -0700 Comment on attachment 351867 Patch Clearing flags on attachment: 351867 Committed r236967: <https://trac.webkit.org/changeset/236967> 1467456 3 commit-queue 2018-10-09 10:40:11 -0700 All reviewed patches have been landed. Closing bug. 1467459 4 webkit-bug-importer 2018-10-09 10:41:26 -0700 <rdar://problem/45130773> 351867 2018-10-09 00:08:27 -0700 2018-10-09 10:40:10 -0700 Patch bug-190394-20181009090826.patch text/plain 2186 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmZlZTQ5MDE2MzhlYjVj ZDUwN2RlMzdiYWM5ZDU0Yzg2OTE1YzNmOS4uNzcwOTQ3YzVkZjEzY2IxZGViYTNkNjQwODY2MGEy NWM1ODFmYWVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTA5ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIHIyMzY3MzUgaGFzIHNvbWUgZGVhZCBBU1NFUlRzIHRoYXQgbmVlZCB0byBiZSBtb3Zl ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMzk0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OmNyZWF0ZU9wdGlvbmFsUGFyc2VyRm9yRm9ybWF0KToKKwogMjAxOC0xMC0wMSAg QWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW01TRV1b R1N0cmVhbWVyXSBNYWtlIHNhbWUgdGhyZWFkIGFzc2VydCBub24tcmVsZWFzZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQ aXBlbGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv bXNlL0FwcGVuZFBpcGVsaW5lLmNwcAppbmRleCA0YzNiOWM4M2FiMWQ4Nzg2N2ZkMzAxODkwNDI3 ZjU2MzNkY2UwZGZhLi44MzlkYTYyZDc3MTEwZGU3YTM0ZWMyOTM2YjJlOGNmNTUwODExNTNiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNl L0FwcGVuZFBpcGVsaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNwcApAQCAtODU5LDIwICs4NTksMjAgQEAg Y3JlYXRlT3B0aW9uYWxQYXJzZXJGb3JGb3JtYXQoR3N0UGFkKiBkZW11eGVyU3JjUGFkKQogCiAg ICAgaWYgKCFnX3N0cmNtcDAobWVkaWFUeXBlLCAiYXVkaW8veC1vcHVzIikpIHsKICAgICAgICAg R3N0RWxlbWVudCogb3B1c3BhcnNlID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJvcHVzcGFy c2UiLCBwYXJzZXJOYW1lLmdldCgpKTsKLSAgICAgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwob3B1 c3BhcnNlLCBudWxscHRyKTsKICAgICAgICAgQVNTRVJUKG9wdXNwYXJzZSk7CisgICAgICAgIGdf cmV0dXJuX3ZhbF9pZl9mYWlsKG9wdXNwYXJzZSwgbnVsbHB0cik7CiAgICAgICAgIHJldHVybiBH UmVmUHRyPEdzdEVsZW1lbnQ+KG9wdXNwYXJzZSk7CiAgICAgfQogICAgIGlmICghZ19zdHJjbXAw KG1lZGlhVHlwZSwgImF1ZGlvL3gtdm9yYmlzIikpIHsKICAgICAgICAgR3N0RWxlbWVudCogdm9y YmlzcGFyc2UgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoInZvcmJpc3BhcnNlIiwgcGFyc2Vy TmFtZS5nZXQoKSk7Ci0gICAgICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKHZvcmJpc3BhcnNlLCBu dWxscHRyKTsKICAgICAgICAgQVNTRVJUKHZvcmJpc3BhcnNlKTsKKyAgICAgICAgZ19yZXR1cm5f dmFsX2lmX2ZhaWwodm9yYmlzcGFyc2UsIG51bGxwdHIpOwogICAgICAgICByZXR1cm4gR1JlZlB0 cjxHc3RFbGVtZW50Pih2b3JiaXNwYXJzZSk7CiAgICAgfQogICAgIGlmICghZ19zdHJjbXAwKG1l ZGlhVHlwZSwgInZpZGVvL3gtaDI2NCIpKSB7CiAgICAgICAgIEdzdEVsZW1lbnQqIGgyNjRwYXJz ZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiaDI2NHBhcnNlIiwgcGFyc2VyTmFtZS5nZXQo KSk7Ci0gICAgICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKGgyNjRwYXJzZSwgbnVsbHB0cik7CiAg ICAgICAgIEFTU0VSVChoMjY0cGFyc2UpOworICAgICAgICBnX3JldHVybl92YWxfaWZfZmFpbCho MjY0cGFyc2UsIG51bGxwdHIpOwogICAgICAgICByZXR1cm4gR1JlZlB0cjxHc3RFbGVtZW50Piho MjY0cGFyc2UpOwogICAgIH0KIAo=