190392 2018-10-08 21:51:24 -0700 StringTypeAdapter constructor is not properly enforcing String::MaxLength. 2018-10-09 11:16:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 190187 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue darin dbates ews-watchlist fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1467335 0 mark.lam 2018-10-08 21:51:24 -0700 Fix coming. 1467336 1 webkit-bug-importer 2018-10-08 21:51:59 -0700 <rdar://problem/45116210> 1467341 2 351858 mark.lam 2018-10-08 22:26:07 -0700 Created attachment 351858 proposed patch. 1467342 3 351859 mark.lam 2018-10-08 22:31:34 -0700 Created attachment 351859 proposed patch. 1467414 4 351859 saam 2018-10-09 09:08:52 -0700 Comment on attachment 351859 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351859&action=review > Source/WTF/ChangeLog:11 > + length a size_t which removes this issue, and assert that it's within We’re ok with this not working on 32bit? Maybe just use uint64_t directly? 1467415 5 351859 saam 2018-10-09 09:10:17 -0700 Comment on attachment 351859 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351859&action=review >> Source/WTF/ChangeLog:11 >> + length a size_t which removes this issue, and assert that it's within > > We’re ok with this not working on 32bit? Maybe just use uint64_t directly? I guess on 32bit we’re limited by address space. 1467468 6 351859 mark.lam 2018-10-09 10:50:13 -0700 Comment on attachment 351859 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351859&action=review Thanks for the review. >>> Source/WTF/ChangeLog:11 >>> + length a size_t which removes this issue, and assert that it's within >> >> We’re ok with this not working on 32bit? Maybe just use uint64_t directly? > > I guess on 32bit we’re limited by address space. Yes, this works on 32-bit because the string is limited by the address space. This is by design. 1467483 7 351859 commit-queue 2018-10-09 11:16:04 -0700 Comment on attachment 351859 proposed patch. Clearing flags on attachment: 351859 Committed r236969: <https://trac.webkit.org/changeset/236969> 1467484 8 commit-queue 2018-10-09 11:16:06 -0700 All reviewed patches have been landed. Closing bug. 351858 2018-10-08 22:26:07 -0700 2018-10-08 22:28:28 -0700 proposed patch. bug-190392.patch text/plain 2413 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzY5NTgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTA4ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmdUeXBlQWRhcHRlciBjb25zdHJ1Y3RvciBpcyBu b3QgcHJvcGVybHkgZW5mb3JjaW5nIFN0cmluZzo6TWF4TGVuZ3RoLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMzkyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NTExNjIxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQcmV2aW91c2x5LCB0aGUgU3RyaW5nVHlwZUFkYXB0ZXIgY29uc3RydWN0b3Ig Zm9yIGEgVUNoYXIqIHN0cmluZyB3YXMgc3VtbWluZyB0aGUKKyAgICAgICAgdW5zaWduZWQgbGVu Z3RoIG9mIHRoZSBzb3VyY2Ugc3RyaW5nIHdpdGhvdXQgYW4gb3ZlcmZsb3cgY2hlY2suICBXZSBu b3cgbWFrZSB0aGF0CisgICAgICAgIGxlbmd0aCBhIHNpemVfdCB3aGljaCByZW1vdmVzIHRoaXMg aXNzdWUsIGFuZCBhc3NlcnQgdGhhdCBpdCdzIHdpdGhpbgorICAgICAgICBTdHJpbmc6Ok1heExl bmd0aCB0aGVyZWFmdGVyLgorCisgICAgICAgIEFsc28gbWFkZSB0aGUgU3RyaW5nVHlwZUFkYXB0 ZXIgY29uc3RydWN0b3IgZm9yIGEgTENoYXIqIHN0cmluZyBiZWhhdmUgaW4gYW4KKyAgICAgICAg ZXF1aXZhbGVudCBtYW5uZXIgZm9yIGNvbnNpc3RlbmN5LiAgSW4gYm90aCBjYXNlcywgd2UnbGwg Y3Jhc2ggaW4gYSBSRUxFQVNFX0FTU0VSVAorICAgICAgICBpZiB0aGUgc291cmNlIHN0cmluZyBs ZW5ndGggZXhjZWVkcyBTdHJpbmc6Ok1heExlbmd0aC4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0 cmluZ0NvbmNhdGVuYXRlLmg6CisKIDIwMTgtMTAtMDggIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0 aGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgPGlucHV0IHR5cGU9Y29sb3I+IGEgcnVudGlt ZSBlbmFibGVkIChvbi1ieS1kZWZhdWx0KSBmZWF0dXJlCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90 ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdDb25jYXRlbmF0ZS5oCShyZXZpc2lvbiAyMzY5NTcpCisrKyBTb3VyY2UvV1RGL3d0 Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOCw4ICsxMDgs MTAgQEAgY2xhc3MgU3RyaW5nVHlwZUFkYXB0ZXI8Y29uc3QgTENoYXIqLCB2bwogcHVibGljOgog ICAgIFN0cmluZ1R5cGVBZGFwdGVyKGNvbnN0IExDaGFyKiBjaGFyYWN0ZXJzKQogICAgICAgICA6 IG1fY2hhcmFjdGVycyhjaGFyYWN0ZXJzKQotICAgICAgICAsIG1fbGVuZ3RoKHN0cmxlbihyZWlu dGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihjaGFyYWN0ZXJzKSkpCiAgICAgeworICAgICAgICBz aXplX3QgbGVuZ3RoID0gc3RybmxlbihyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihjaGFy YWN0ZXJzKSwgU3RyaW5nOjpNYXhMZW5ndGggKyAxKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQo bGVuZ3RoIDw9IFN0cmluZzo6TWF4TGVuZ3RoKTsKKyAgICAgICAgbV9sZW5ndGggPSBzdGF0aWNf Y2FzdDx1bnNpZ25lZD4obGVuZ3RoKTsKICAgICB9CiAKICAgICB1bnNpZ25lZCBsZW5ndGgoKSBj b25zdCB7IHJldHVybiBtX2xlbmd0aDsgfQpAQCAtMTM4LDEyICsxNDAsMTEgQEAgcHVibGljOgog ICAgIFN0cmluZ1R5cGVBZGFwdGVyKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzKQogICAgICAgICA6 IG1fY2hhcmFjdGVycyhjaGFyYWN0ZXJzKQogICAgIHsKLSAgICAgICAgdW5zaWduZWQgbGVuZ3Ro ID0gMDsKLSAgICAgICAgd2hpbGUgKG1fY2hhcmFjdGVyc1tsZW5ndGhdKQorICAgICAgICBzaXpl X3QgbGVuZ3RoID0gMDsKKyAgICAgICAgd2hpbGUgKGxlbmd0aCA8IFN0cmluZzo6TWF4TGVuZ3Ro ICsgMSAmJiBtX2NoYXJhY3RlcnNbbGVuZ3RoXSkKICAgICAgICAgICAgICsrbGVuZ3RoOwotCiAg ICAgICAgIFJFTEVBU0VfQVNTRVJUKGxlbmd0aCA8PSBTdHJpbmc6Ok1heExlbmd0aCk7Ci0gICAg ICAgIG1fbGVuZ3RoID0gbGVuZ3RoOworICAgICAgICBtX2xlbmd0aCA9IHN0YXRpY19jYXN0PHVu c2lnbmVkPihsZW5ndGgpOwogICAgIH0KIAogICAgIHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0IHsg cmV0dXJuIG1fbGVuZ3RoOyB9Cg== 351859 2018-10-08 22:31:34 -0700 2018-10-09 11:16:04 -0700 proposed patch. bug-190392.patch text/plain 2317 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzY5NTgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTA4ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBTdHJpbmdUeXBlQWRhcHRlciBjb25zdHJ1Y3RvciBpcyBu b3QgcHJvcGVybHkgZW5mb3JjaW5nIFN0cmluZzo6TWF4TGVuZ3RoLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMzkyCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NTExNjIxMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBQcmV2aW91c2x5LCB0aGUgU3RyaW5nVHlwZUFkYXB0ZXIgY29uc3RydWN0b3Ig Zm9yIGEgVUNoYXIqIHN0cmluZyB3YXMgc3VtbWluZyB0aGUKKyAgICAgICAgdW5zaWduZWQgbGVu Z3RoIG9mIHRoZSBzb3VyY2Ugc3RyaW5nIHdpdGhvdXQgYW4gb3ZlcmZsb3cgY2hlY2suICBXZSBu b3cgbWFrZSB0aGF0CisgICAgICAgIGxlbmd0aCBhIHNpemVfdCB3aGljaCByZW1vdmVzIHRoaXMg aXNzdWUsIGFuZCBhc3NlcnQgdGhhdCBpdCdzIHdpdGhpbgorICAgICAgICBTdHJpbmc6Ok1heExl bmd0aCB0aGVyZWFmdGVyLgorCisgICAgICAgIEFsc28gbWFkZSB0aGUgU3RyaW5nVHlwZUFkYXB0 ZXIgY29uc3RydWN0b3IgZm9yIGEgTENoYXIqIHN0cmluZyBiZWhhdmUgaW4gYW4KKyAgICAgICAg ZXF1aXZhbGVudCBtYW5uZXIgZm9yIGNvbnNpc3RlbmN5LiAgSW4gYm90aCBjYXNlcywgd2UnbGwg Y3Jhc2ggaW4gYSBSRUxFQVNFX0FTU0VSVAorICAgICAgICBpZiB0aGUgc291cmNlIHN0cmluZyBs ZW5ndGggZXhjZWVkcyBTdHJpbmc6Ok1heExlbmd0aC4KKworICAgICAgICAqIHd0Zi90ZXh0L1N0 cmluZ0NvbmNhdGVuYXRlLmg6CisKIDIwMTgtMTAtMDggIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0 aGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgPGlucHV0IHR5cGU9Y29sb3I+IGEgcnVudGlt ZSBlbmFibGVkIChvbi1ieS1kZWZhdWx0KSBmZWF0dXJlCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi90 ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvdGV4 dC9TdHJpbmdDb25jYXRlbmF0ZS5oCShyZXZpc2lvbiAyMzY5NTcpCisrKyBTb3VyY2UvV1RGL3d0 Zi90ZXh0L1N0cmluZ0NvbmNhdGVuYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwOCw4ICsxMDgs MTAgQEAgY2xhc3MgU3RyaW5nVHlwZUFkYXB0ZXI8Y29uc3QgTENoYXIqLCB2bwogcHVibGljOgog ICAgIFN0cmluZ1R5cGVBZGFwdGVyKGNvbnN0IExDaGFyKiBjaGFyYWN0ZXJzKQogICAgICAgICA6 IG1fY2hhcmFjdGVycyhjaGFyYWN0ZXJzKQotICAgICAgICAsIG1fbGVuZ3RoKHN0cmxlbihyZWlu dGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPihjaGFyYWN0ZXJzKSkpCiAgICAgeworICAgICAgICBz aXplX3QgbGVuZ3RoID0gc3RybGVuKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KGNoYXJh Y3RlcnMpKTsKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQobGVuZ3RoIDw9IFN0cmluZzo6TWF4TGVu Z3RoKTsKKyAgICAgICAgbV9sZW5ndGggPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4obGVuZ3RoKTsK ICAgICB9CiAKICAgICB1bnNpZ25lZCBsZW5ndGgoKSBjb25zdCB7IHJldHVybiBtX2xlbmd0aDsg fQpAQCAtMTM4LDEyICsxNDAsMTEgQEAgcHVibGljOgogICAgIFN0cmluZ1R5cGVBZGFwdGVyKGNv bnN0IFVDaGFyKiBjaGFyYWN0ZXJzKQogICAgICAgICA6IG1fY2hhcmFjdGVycyhjaGFyYWN0ZXJz KQogICAgIHsKLSAgICAgICAgdW5zaWduZWQgbGVuZ3RoID0gMDsKKyAgICAgICAgc2l6ZV90IGxl bmd0aCA9IDA7CiAgICAgICAgIHdoaWxlIChtX2NoYXJhY3RlcnNbbGVuZ3RoXSkKICAgICAgICAg ICAgICsrbGVuZ3RoOwotCiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGxlbmd0aCA8PSBTdHJpbmc6 Ok1heExlbmd0aCk7Ci0gICAgICAgIG1fbGVuZ3RoID0gbGVuZ3RoOworICAgICAgICBtX2xlbmd0 aCA9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihsZW5ndGgpOwogICAgIH0KIAogICAgIHVuc2lnbmVk IGxlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIG1fbGVuZ3RoOyB9Cg==