190332 2018-10-06 16:53:13 -0700 [JSC] Avoid creating ProgramExecutable in checkSyntax 2018-10-07 02:33:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1466902 0 ysuzuki 2018-10-06 16:53:13 -0700 [JSC] Avoid creating ProgramExecutable in checkSyntax 1466904 1 351734 ysuzuki 2018-10-06 16:57:54 -0700 Created attachment 351734 Patch 1466914 2 351734 mark.lam 2018-10-06 20:07:50 -0700 Comment on attachment 351734 Patch Nice. r=me 1466920 3 351734 ysuzuki 2018-10-07 02:06:40 -0700 Comment on attachment 351734 Patch Thanks! 1466921 4 351734 commit-queue 2018-10-07 02:33:00 -0700 Comment on attachment 351734 Patch Clearing flags on attachment: 351734 Committed r236904: <https://trac.webkit.org/changeset/236904> 1466922 5 commit-queue 2018-10-07 02:33:01 -0700 All reviewed patches have been landed. Closing bug. 1466923 6 webkit-bug-importer 2018-10-07 02:33:31 -0700 <rdar://problem/45072391> 351734 2018-10-06 16:57:54 -0700 2018-10-07 02:33:00 -0700 Patch bug-190332-20181007085753.patch text/plain 5398 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2OTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YTE5Y2IyOTExN2FiMGU1MmI4N2JiN2E4Y2ViMzhlZjQ3ODg4OTE3Li40OTZjMGI1MWUxNDUyMWI0 ZGExZmYyZTZiNWQzNTE4ODA4ZDMxYTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyOCBAQAorMjAxOC0xMC0wNiAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtKU0NdIEF2b2lkIGNyZWF0aW5nIFByb2dyYW1FeGVjdXRh YmxlIGluIGNoZWNrU3ludGF4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xOTAzMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICB1Z2xpZnktanMgaW4gd2ViLXRvb2xpbmctYmVuY2htYXJrIGV4ZWN1dGVzIG1h c3NpdmUgbnVtYmVyIG9mIEZ1bmN0aW9uIGNvbnN0cnVjdG9yIGNhbGxzLgorICAgICAgICBJbiBG dW5jdGlvbiBjb25zdHJ1Y3RvciBjb2RlLCB3ZSBwZXJmb3JtIGNoZWNrU3ludGF4IGZvciBib2R5 IGFuZCBwYXJhbWV0ZXJzLiBTbyBmYXN0IGNoZWNrU3ludGF4CisgICAgICAgIGlzIGltcG9ydGFu dCB3aGVuIHRoZSBwZXJmb3JtYW5jZSBvZiBGdW5jdGlvbiBjb25zdHJ1Y3RvciBtYXR0ZXJzLiBD dXJyZW50IGNoZWNrU3ludGF4IGNvZGUKKyAgICAgICAgdW5uZWNlc3NhcmlseSBhbGxvY2F0ZXMg UHJvZ3JhbUV4ZWN1dGFibGUuIFRoaXMgcGF0Y2ggcmVtb3ZlcyB0aGlzIGFsbG9jYXRpb24gYW5k IGltcHJvdmVzCisgICAgICAgIHRoZSBiZW5jaG1hcmsgc2NvcmUgc2xpZ2h0bHkuCisKKyAgICAg ICAgQmVmb3JlOgorICAgICAgICAgICAgdWdsaWZ5LWpzOiAgMi44NyBydW5zL3MKKyAgICAgICAg QWZ0ZXI6CisgICAgICAgICAgICB1Z2xpZnktanM6ICAyLjk0IHJ1bnMvcworCisgICAgICAgICog cnVudGltZS9Db21wbGV0aW9uLmNwcDoKKyAgICAgICAgKEpTQzo6Y2hlY2tTeW50YXhJbnRlcm5h bCk6CisgICAgICAgIChKU0M6OmNoZWNrU3ludGF4KToKKyAgICAgICAgKiBydW50aW1lL1Byb2dy YW1FeGVjdXRhYmxlLmNwcDoKKyAgICAgICAgKEpTQzo6UHJvZ3JhbUV4ZWN1dGFibGU6OmNoZWNr U3ludGF4KTogRGVsZXRlZC4KKyAgICAgICAgKiBydW50aW1lL1Byb2dyYW1FeGVjdXRhYmxlLmg6 CisKIDIwMTgtMTAtMDUgIFl1c3VrZSBTdXp1a2kgIDx5dXN1a2VzdXp1a2lAc2xvd3N0YXJ0Lm9y Zz4KIAogICAgICAgICBbSlNDXSBVc2UgbmV3IGV4dHJhIG1lbW9yeSByZXBvcnRpbmcgaW4gU3Bh cnNlQXJyYXlNYXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Nv bXBsZXRpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tcGxldGlvbi5j cHAKaW5kZXggZWEzMzliMGIxZmYxZDljZmJlOWQ4ZmZiYjVjMDk3MTdjMmNkNTlmMy4uYjE3NDdj NGQ3YWY2ZDRhMzNmYjgyMzFkYmQ3ZjIyODY2NzA2NDI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tcGxldGlvbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvQ29tcGxldGlvbi5jcHAKQEAgLTQ0LDMwICs0NCwzMyBAQAogCiBuYW1l c3BhY2UgSlNDIHsKIAorc3RhdGljIGlubGluZSBib29sIGNoZWNrU3ludGF4SW50ZXJuYWwoVk0m IHZtLCBjb25zdCBTb3VyY2VDb2RlJiBzb3VyY2UsIFBhcnNlckVycm9yJiBlcnJvcikKK3sKKyAg ICByZXR1cm4gISFwYXJzZTxQcm9ncmFtTm9kZT4oCisgICAgICAgICZ2bSwgc291cmNlLCBJZGVu dGlmaWVyKCksIEpTUGFyc2VyQnVpbHRpbk1vZGU6Ok5vdEJ1aWx0aW4sCisgICAgICAgIEpTUGFy c2VyU3RyaWN0TW9kZTo6Tm90U3RyaWN0LCBKU1BhcnNlclNjcmlwdE1vZGU6OkNsYXNzaWMsIFNv dXJjZVBhcnNlTW9kZTo6UHJvZ3JhbU1vZGUsIFN1cGVyQmluZGluZzo6Tm90TmVlZGVkLCBlcnJv cik7Cit9CisKIGJvb2wgY2hlY2tTeW50YXgoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBTb3VyY2VD b2RlJiBzb3VyY2UsIEpTVmFsdWUqIHJldHVybmVkRXhjZXB0aW9uKQogewogICAgIFZNJiB2bSA9 IGV4ZWMtPnZtKCk7CiAgICAgSlNMb2NrSG9sZGVyIGxvY2sodm0pOwogICAgIFJFTEVBU0VfQVNT RVJUKHZtLmF0b21pY1N0cmluZ1RhYmxlKCkgPT0gVGhyZWFkOjpjdXJyZW50KCkuYXRvbWljU3Ry aW5nVGFibGUoKSk7CiAKLSAgICBQcm9ncmFtRXhlY3V0YWJsZSogcHJvZ3JhbSA9IFByb2dyYW1F eGVjdXRhYmxlOjpjcmVhdGUoZXhlYywgc291cmNlKTsKLSAgICBKU09iamVjdCogZXJyb3IgPSBw cm9ncmFtLT5jaGVja1N5bnRheChleGVjKTsKLSAgICBpZiAoZXJyb3IpIHsKLSAgICAgICAgaWYg KHJldHVybmVkRXhjZXB0aW9uKQotICAgICAgICAgICAgKnJldHVybmVkRXhjZXB0aW9uID0gZXJy b3I7Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci0KLSAgICByZXR1cm4gdHJ1ZTsKKyAg ICBQYXJzZXJFcnJvciBlcnJvcjsKKyAgICBpZiAoY2hlY2tTeW50YXhJbnRlcm5hbCh2bSwgc291 cmNlLCBlcnJvcikpCisgICAgICAgIHJldHVybiB0cnVlOworICAgIEFTU0VSVChlcnJvci5pc1Zh bGlkKCkpOworICAgIGlmIChyZXR1cm5lZEV4Y2VwdGlvbikKKyAgICAgICAgKnJldHVybmVkRXhj ZXB0aW9uID0gZXJyb3IudG9FcnJvck9iamVjdChleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCks IHNvdXJjZSk7CisgICAgcmV0dXJuIGZhbHNlOwogfQotICAgIAorCiBib29sIGNoZWNrU3ludGF4 KFZNJiB2bSwgY29uc3QgU291cmNlQ29kZSYgc291cmNlLCBQYXJzZXJFcnJvciYgZXJyb3IpCiB7 CiAgICAgSlNMb2NrSG9sZGVyIGxvY2sodm0pOwogICAgIFJFTEVBU0VfQVNTRVJUKHZtLmF0b21p Y1N0cmluZ1RhYmxlKCkgPT0gVGhyZWFkOjpjdXJyZW50KCkuYXRvbWljU3RyaW5nVGFibGUoKSk7 Ci0gICAgcmV0dXJuICEhcGFyc2U8UHJvZ3JhbU5vZGU+KAotICAgICAgICAmdm0sIHNvdXJjZSwg SWRlbnRpZmllcigpLCBKU1BhcnNlckJ1aWx0aW5Nb2RlOjpOb3RCdWlsdGluLAotICAgICAgICBK U1BhcnNlclN0cmljdE1vZGU6Ok5vdFN0cmljdCwgSlNQYXJzZXJTY3JpcHRNb2RlOjpDbGFzc2lj LCBTb3VyY2VQYXJzZU1vZGU6OlByb2dyYW1Nb2RlLCBTdXBlckJpbmRpbmc6Ok5vdE5lZWRlZCwg ZXJyb3IpOworICAgIHJldHVybiBjaGVja1N5bnRheEludGVybmFsKHZtLCBzb3VyY2UsIGVycm9y KTsKIH0KIAogYm9vbCBjaGVja01vZHVsZVN5bnRheChFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IFNv dXJjZUNvZGUmIHNvdXJjZSwgUGFyc2VyRXJyb3ImIGVycm9yKQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvZ3JhbUV4ZWN1dGFibGUuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvZ3JhbUV4ZWN1dGFibGUuY3BwCmluZGV4IDM4YmRhZjUx NzU3YTk2MTgxZmVmNDZmYzkwODE2YjEyNjg5Nzg0NTMuLjM5M2IwMDdhY2E4ZGYxYjRiMDFjZjU2 NjI0M2Q2ZGZjNzU5YTljZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1Byb2dyYW1FeGVjdXRhYmxlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Qcm9ncmFtRXhlY3V0YWJsZS5jcHAKQEAgLTU4LDIwICs1OCw2IEBAIHZvaWQgUHJvZ3Jh bUV4ZWN1dGFibGU6OmRlc3Ryb3koSlNDZWxsKiBjZWxsKQogICAgIHN0YXRpY19jYXN0PFByb2dy YW1FeGVjdXRhYmxlKj4oY2VsbCktPlByb2dyYW1FeGVjdXRhYmxlOjp+UHJvZ3JhbUV4ZWN1dGFi bGUoKTsKIH0KIAotSlNPYmplY3QqIFByb2dyYW1FeGVjdXRhYmxlOjpjaGVja1N5bnRheChFeGVj U3RhdGUqIGV4ZWMpCi17Ci0gICAgUGFyc2VyRXJyb3IgZXJyb3I7Ci0gICAgVk0qIHZtID0gJmV4 ZWMtPnZtKCk7Ci0gICAgSlNHbG9iYWxPYmplY3QqIGxleGljYWxHbG9iYWxPYmplY3QgPSBleGVj LT5sZXhpY2FsR2xvYmFsT2JqZWN0KCk7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPFByb2dyYW1Ob2Rl PiBwcm9ncmFtTm9kZSA9IHBhcnNlPFByb2dyYW1Ob2RlPigKLSAgICAgICAgdm0sIG1fc291cmNl LCBJZGVudGlmaWVyKCksIEpTUGFyc2VyQnVpbHRpbk1vZGU6Ok5vdEJ1aWx0aW4sCi0gICAgICAg IEpTUGFyc2VyU3RyaWN0TW9kZTo6Tm90U3RyaWN0LCBKU1BhcnNlclNjcmlwdE1vZGU6OkNsYXNz aWMsIFNvdXJjZVBhcnNlTW9kZTo6UHJvZ3JhbU1vZGUsIFN1cGVyQmluZGluZzo6Tm90TmVlZGVk LCBlcnJvcik7Ci0gICAgaWYgKHByb2dyYW1Ob2RlKQotICAgICAgICByZXR1cm4gMDsKLSAgICBB U1NFUlQoZXJyb3IuaXNWYWxpZCgpKTsKLSAgICByZXR1cm4gZXJyb3IudG9FcnJvck9iamVjdChs ZXhpY2FsR2xvYmFsT2JqZWN0LCBtX3NvdXJjZSk7Ci19Ci0KIC8vIGh0dHA6Ly93d3cuZWNtYS1p bnRlcm5hdGlvbmFsLm9yZy9lY21hLTI2Mi82LjAvaW5kZXguaHRtbCNzZWMtaGFzcmVzdHJpY3Rl ZGdsb2JhbHByb3BlcnR5CiBzdGF0aWMgYm9vbCBoYXNSZXN0cmljdGVkR2xvYmFsUHJvcGVydHko RXhlY1N0YXRlKiBleGVjLCBKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBQcm9wZXJ0eU5h bWUgcHJvcGVydHlOYW1lKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvUHJvZ3JhbUV4ZWN1dGFibGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1Byb2dyYW1FeGVjdXRhYmxlLmgKaW5kZXggMTJiZWJiYThlN2QyMTQ3NzJlZTYyM2M1ZWQyOGQ5 Y2Y1MWFhOWE3OS4uZmY4NGM5ZTcxMjI4NjYzMThhNGFjZjQxNWM4NTZmMjExYzA4OGI3ZiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvZ3JhbUV4ZWN1dGFibGUu aAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Qcm9ncmFtRXhlY3V0YWJsZS5o CkBAIC01OSw4ICs1OSw2IEBAIGNsYXNzIFByb2dyYW1FeGVjdXRhYmxlIGZpbmFsIDogcHVibGlj IFNjcmlwdEV4ZWN1dGFibGUgewogICAgICAgICByZXR1cm4gYml0d2lzZV9jYXN0PFByb2dyYW1D b2RlQmxvY2sqPihFeGVjdXRhYmxlVG9Db2RlQmxvY2tFZGdlOjp1bndyYXAobV9wcm9ncmFtQ29k ZUJsb2NrLmdldCgpKSk7CiAgICAgfQogCi0gICAgSlNPYmplY3QqIGNoZWNrU3ludGF4KEV4ZWNT dGF0ZSopOwotCiAgICAgUmVmPEpJVENvZGU+IGdlbmVyYXRlZEpJVENvZGUoKQogICAgIHsKICAg ICAgICAgcmV0dXJuIGdlbmVyYXRlZEpJVENvZGVGb3JDYWxsKCk7Cg==