190331 2018-10-06 10:50:28 -0700 Adding some temporary asserts to debug a mysterious ASAN bot crash. 2018-10-06 12:11:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1466883 0 mark.lam 2018-10-06 10:50:28 -0700 Patch coming. 1466885 1 351729 mark.lam 2018-10-06 10:54:43 -0700 Created attachment 351729 proposed patch. 1466889 2 351729 commit-queue 2018-10-06 12:10:38 -0700 Comment on attachment 351729 proposed patch. Clearing flags on attachment: 351729 Committed r236899: <https://trac.webkit.org/changeset/236899> 1466890 3 commit-queue 2018-10-06 12:10:40 -0700 All reviewed patches have been landed. Closing bug. 1466891 4 webkit-bug-importer 2018-10-06 12:11:29 -0700 <rdar://problem/45069311> 351729 2018-10-06 10:54:43 -0700 2018-10-06 12:10:38 -0700 proposed patch. bug-190331.patch text/plain 1996 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzY4OTgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTA2ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBBZGRpbmcgc29tZSB0ZW1wb3JhcnkgYXNzZXJ0cyB0byBk ZWJ1ZyBhIG15c3RlcmlvdXMgQVNBTiBib3QgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAzMzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVzZSBhc3NlcnRpb25zIGFyZSBuZWVkZWQgYmVj YXVzZSB3ZSBjYW4ndCByZXByb2R1Y2UgdGhlIGlzc3VlIGxvY2FsbHkuCisgICAgICAgIFdlJ2xs IHJlbW92ZSB0aGVzZSBhc3NlcnRzIGFmdGVyIHRoZSBuZWVkZWQgZGF0YSBoYXMgYmVlbiBjb2xs ZWN0ZWQgZnJvbSB0aGUgYm90LgorCisgICAgICAgICogd3RmL1N0YWNrQm91bmRzLmg6CisgICAg ICAgIChXVEY6OlN0YWNrQm91bmRzOjpjaGVja0NvbnNpc3RlbmN5IGNvbnN0KToKKwogMjAxOC0x MC0wNSAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93c3RhcnQub3JnPgogCiAgICAg ICAgIFtKU0NdW0xpbnV4XSBTdXBwb3J0IFBlcmYgSklURHVtcCBsb2dnaW5nCkluZGV4OiBTb3Vy Y2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1N0 YWNrQm91bmRzLmgJKHJldmlzaW9uIDIzNjg5OCkKKysrIFNvdXJjZS9XVEYvd3RmL1N0YWNrQm91 bmRzLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0Nyw2ICsxNDcsMjYgQEAgcHJpdmF0ZToKICAgICB7 CiAjaWYgIUFTU0VSVF9ESVNBQkxFRAogICAgICAgICB2b2lkKiBjdXJyZW50UG9zaXRpb24gPSAm Y3VycmVudFBvc2l0aW9uOworCisgICAgICAgIC8vIFRoZSBmb2xsb3dpbmcgc2V0IG9mIGFzc2Vy dGlvbnMgYXJlIG9ubHkgbmVlZGVkIGZvciBkZWJ1Z2dpbmcgYQorICAgICAgICAvLyBteXN0ZXJp b3VzIGNyYXNoIG9uIGFuIEFTQU4gYm90IHRoYXQgaXMgbm90IHJlcHJvZHVjaWJsZSBvdGhlcndp c2UuCisgICAgICAgIC8vIFdpbGwgcmVtb3ZlIGFmdGVyIHRoZSBuZWVkZWQgZGF0YSBoYXMgYmVl biBjb2xsZWN0ZWQuCisjaWYgT1MoTElOVVgpCisgICAgICAgIEFTU0VSVChjdXJyZW50UG9zaXRp b24pOworICAgICAgICBBU1NFUlQobV9vcmlnaW4pOworICAgICAgICBBU1NFUlQobV9ib3VuZCk7 CisgICAgICAgIEFTU0VSVChjdXJyZW50UG9zaXRpb24gIT0gbV9vcmlnaW4pOworICAgICAgICBB U1NFUlQoY3VycmVudFBvc2l0aW9uICE9IG1fYm91bmQpOworICAgICAgICBpZiAoaXNHcm93aW5n RG93bndhcmQoKSkgeworICAgICAgICAgICAgQVNTRVJUKGN1cnJlbnRQb3NpdGlvbiA8IG1fb3Jp Z2luKTsKKyAgICAgICAgICAgIEFTU0VSVChjdXJyZW50UG9zaXRpb24gPiBtX2JvdW5kKTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIEFTU0VSVChjdXJyZW50UG9zaXRpb24gPiBtX29y aWdpbik7CisgICAgICAgICAgICBBU1NFUlQoY3VycmVudFBvc2l0aW9uIDwgbV9ib3VuZCk7Cisg ICAgICAgIH0KKyNlbmRpZiAvLyBPUyhMSU5VWCkKKyAgICAgICAgLy8gRW5kIG9mIEFTQU4gYm90 IGRlYnVnZ2luZyBhc3NlcnRpb25zLgorCiAgICAgICAgIEFTU0VSVChtX29yaWdpbiAhPSBtX2Jv dW5kKTsKICAgICAgICAgQVNTRVJUKGlzR3Jvd2luZ0Rvd253YXJkKCkKICAgICAgICAgICAgID8g KGN1cnJlbnRQb3NpdGlvbiA8IG1fb3JpZ2luICYmIGN1cnJlbnRQb3NpdGlvbiA+IG1fYm91bmQp Cg==