190327 2018-10-06 00:40:17 -0700 [Xcode] Never build yasm with ASAN 2020-04-06 10:27:50 -0700 1 1 1 Unclassified WebKit WebRTC Safari Technology Preview Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210057 InRadar P2 Normal --- 1 mitz webkit-unassigned ap commit-queue eric.carlson ews-watchlist ryanhaddad webkit-bug-importer youennf oldest_to_newest 1466847 0 mitz 2018-10-06 00:40:17 -0700 yasm is only used at build time to derive other source files, so there’s no point building it with ASAN. Worse, when targeting the iOS Simulator, yasm is built as a Simulator binary, even though it’s then run on the host. This works, but if ASAN is enabled, it tries to link against the Simulator ASAN dylib, which causes a failure at runtime. Patch forthcoming. 1466848 1 351719 mitz 2018-10-06 00:43:36 -0700 Created attachment 351719 Opt yasm out of ASAN 1466859 2 351719 youennf 2018-10-06 07:23:39 -0700 Comment on attachment 351719 Opt yasm out of ASAN View in context: https://bugs.webkit.org/attachment.cgi?id=351719&action=review > Tools/asan/asan.xcconfig:16 > +CLANG_ADDRESS_SANITIZER_NO = YES; Is it working? Should we set WK_ASAN_ALLOWED = NO in yasm.xcconfig and CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_ALLOWED)); CLANG_ADDRESS_SANITIZER_NO = NO; 1466873 3 351719 mitz 2018-10-06 08:49:52 -0700 Comment on attachment 351719 Opt yasm out of ASAN View in context: https://bugs.webkit.org/attachment.cgi?id=351719&action=review >> Tools/asan/asan.xcconfig:16 >> +CLANG_ADDRESS_SANITIZER_NO = YES; > > Is it working? > Should we set WK_ASAN_ALLOWED = NO in yasm.xcconfig and > CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_ALLOWED)); > CLANG_ADDRESS_SANITIZER_NO = NO; By convention, if a build setting is not specified, it’s equivalent to being set to NO. So if we wanted a build setting that means “ASAN allowed” we’d have to remember to explicitly set it to YES in every project. Since this is such a rare exception, I opted for something we set in the one place where we make the exception. 1466875 4 351719 commit-queue 2018-10-06 09:05:09 -0700 Comment on attachment 351719 Opt yasm out of ASAN Rejecting attachment 351719 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 351719, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=351719&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=190327&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 351719 from bug 190327. Fetching: https://bugs.webkit.org/attachment.cgi?id=351719 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). (Stripping trailing CRs from patch.) patching file Source/ThirdParty/libwebrtc/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. (Stripping trailing CRs from patch.) patching file Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig Hunk #1 FAILED at 19. 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/libwebrtc/Configurations/yasm.xcconfig.rej (Stripping trailing CRs from patch.) patching file Tools/ChangeLog (Stripping trailing CRs from patch.) patching file Tools/asan/asan.xcconfig Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Youenn Fablet']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/9473060 1466876 5 mitz 2018-10-06 09:07:37 -0700 Committed <https://trac.webkit.org/r236898>. 1466877 6 webkit-bug-importer 2018-10-06 09:08:22 -0700 <rdar://problem/45068477> 1466879 7 ap 2018-10-06 10:16:18 -0700 There is some benefit building internal tools with ASan - we want them to behave reliably, so catching random memory corruption is useful. 351719 2018-10-06 00:43:36 -0700 2018-10-06 09:05:09 -0700 Opt yasm out of ASAN file_190327.txt text/plain 2678 mitz SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9DaGFuZ2VMb2cNCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY4 OTQpDQorKysgU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQ0KQEAgLTEsMyArMSwxMiBAQA0KKzIwMTgtMTAtMDYgIERhbiBCZXJuc3RlaW4gIDxtaXR6 QGFwcGxlLmNvbT4NCisNCisgICAgICAgIFtYY29kZV0gTmV2ZXIgYnVpbGQgeWFzbSB3aXRoIEFT QU4NCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAz MjcNCisNCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAg KiBDb25maWd1cmF0aW9ucy95YXNtLnhjY29uZmlnOiBTZXQgV0tfQVNBTl9ESVNBTExPV0VEIHRv IFlFUy4NCisNCiAyMDE4LTEwLTA0ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+DQog DQogICAgICAgICBGaXhlZCBlbmdpbmVlcmluZyBidWlsZHMgdXNpbmcgdGhlIEFwcGxlIGludGVy bmFsIFNESyBhcyB3ZWxsIGFzIGJ1aWxkaW5nIHdpdGggb2xkZXINCkluZGV4OiBTb3VyY2UvVGhp cmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMveWFzbS54Y2NvbmZpZw0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQ0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy95YXNtLnhj Y29uZmlnCShyZXZpc2lvbiAyMzY4OTQpDQorKysgU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L0NvbmZpZ3VyYXRpb25zL3lhc20ueGNjb25maWcJKHdvcmtpbmcgY29weSkNCkBAIC0xOSwzICsx OSw1IEBAIENMQU5HX1dBUk5fREVQUkVDQVRFRF9PQkpDX0lNUExFTUVOVEFUSU8NCiBFWENMVURF RF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9bWFjb3MqXSA9ICpfbmVvbi5jIGFybV9jcHVkZXRlY3Qu YyAqX2FybS5jIHNhZC5jDQogRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2RrPWlwaG9uZXNp bXVsYXRvcipdID0gKl9uZW9uLmMgYXJtX2NwdWRldGVjdC5jICpfYXJtLmMgc2FkLmMNCiBFWENM VURFRF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9aXBob25lb3MqXSA9ICpfc3NlMi5jICpfc3NzZTMu YyAqX3NzZTQuYyAqX2F2eDIuYyAqX2F2eC5jICpfc3NlMi5hc20ubyAqX3NzZTMuYXNtLm8NCisN CitXS19BU0FOX0RJU0FMTE9XRUQgPSBZRVM7DQpJbmRleDogVG9vbHMvQ2hhbmdlTG9nDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzY4OTQpDQorKysgVG9vbHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpDQpAQCAtMSwzICsxLDEzIEBADQorMjAxOC0xMC0wNiAg RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPg0KKw0KKyAgICAgICAgW1hjb2RlXSBOZXZl ciBidWlsZCB5YXNtIHdpdGggQVNBTg0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MDMyNw0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuDQorDQorICAgICAgICAqIGFzYW4vYXNhbi54Y2NvbmZpZzogQWxsb3cgdGFyZ2V0cyB0 byBvcHQgb3V0IG9mIGJ1aWxkaW5nIHdpdGggQVNBTiBieSBzZXR0aW5nDQorICAgICAgICAgIHRo ZSBXS19BU0FOX0RJU0FMTE9XRUQgYnVpbGQgc2V0dGluZyB0byBZRVMgKG9yLCBhY3R1YWxseSwg YW55dGhpbmcgb3RoZXIgdGhhbiBOTyBvciB1bnNldCkuDQorDQogMjAxOC0xMC0wNSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPg0KIA0KICAgICAgICAgUmVncmVzc2lvbihyMjM2ODYy KTogQ3Jhc2ggdW5kZXIgRE9NV2luZG93RXh0ZW5zaW9uOjp3aWxsRGV0YWNoR2xvYmFsT2JqZWN0 RnJvbUZyYW1lKCkNCkluZGV4OiBUb29scy9hc2FuL2FzYW4ueGNjb25maWcNCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0N Ci0tLSBUb29scy9hc2FuL2FzYW4ueGNjb25maWcJKHJldmlzaW9uIDIzNjg5NCkNCisrKyBUb29s cy9hc2FuL2FzYW4ueGNjb25maWcJKHdvcmtpbmcgY29weSkNCkBAIC0xMSw3ICsxMSw5IEBAIEdD Q19PUFRJTUlaQVRJT05fTEVWRUxfRGVidWcgPSAwOw0KIEdDQ19PUFRJTUlaQVRJT05fTEVWRUxf UHJvZHVjdGlvbiA9IDE7DQogR0NDX09QVElNSVpBVElPTl9MRVZFTF9SZWxlYXNlID0gMTsNCiAN Ci1DTEFOR19BRERSRVNTX1NBTklUSVpFUj1ZRVMNCitDTEFOR19BRERSRVNTX1NBTklUSVpFUiA9 ICQoQ0xBTkdfQUREUkVTU19TQU5JVElaRVJfJChXS19BU0FOX0RJU0FMTE9XRUQpKTsNCitDTEFO R19BRERSRVNTX1NBTklUSVpFUl8gPSBZRVM7DQorQ0xBTkdfQUREUkVTU19TQU5JVElaRVJfTk8g PSBZRVM7DQogDQogQVNBTl9PVEhFUl9DRkxBR1MgPSAtZm5vLW9taXQtZnJhbWUtcG9pbnRlciAt ZzsNCiBBU0FOX09USEVSX0NQTFVTUExVU0ZMQUdTID0gJChBU0FOX09USEVSX0NGTEFHUyk7DQo=