190326 2018-10-05 23:33:31 -0700 [Xcode] Don’t install yasm and don’t compile it in iOS device builds 2018-10-06 09:00:21 -0700 1 1 1 Unclassified WebKit WebRTC Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz commit-queue eric.carlson ews-watchlist webkit-bug-importer youennf oldest_to_newest 1466845 0 mitz 2018-10-05 23:33:31 -0700 yasm is used for building vpx for macOS and the iOS Simulator, but it doesn’t need to be installed, and it’s not used when building for iOS devices. Patch forthcoming. 1466846 1 351718 mitz 2018-10-05 23:35:18 -0700 Created attachment 351718 Skip install, and exclude all sources when building for a device 1466858 2 351718 youennf 2018-10-06 07:14:45 -0700 Comment on attachment 351718 Skip install, and exclude all sources when building for a device Thanks! 1466863 3 351718 commit-queue 2018-10-06 07:41:43 -0700 Comment on attachment 351718 Skip install, and exclude all sources when building for a device Clearing flags on attachment: 351718 Committed r236896: <https://trac.webkit.org/changeset/236896> 1466864 4 commit-queue 2018-10-06 07:41:44 -0700 All reviewed patches have been landed. Closing bug. 1466865 5 webkit-bug-importer 2018-10-06 07:42:26 -0700 <rdar://problem/45068117> 1466874 6 mitz 2018-10-06 09:00:21 -0700 (In reply to WebKit Commit Bot from comment #3) > Comment on attachment 351718 [details] > Skip install, and exclude all sources when building for a device > > Clearing flags on attachment: 351718 > > Committed r236896: <https://trac.webkit.org/changeset/236896> Fixed production builds for iOS devices in <https://trac.webkit.org/r236897>. 351718 2018-10-05 23:35:18 -0700 2018-10-06 07:41:43 -0700 Skip install, and exclude all sources when building for a device bug-190326-20181005233518.patch text/plain 1924 mitz SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9DaGFuZ2VMb2cKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2ODk0 KQorKysgU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5 KQpAQCAtMSwzICsxLDEzIEBACisyMDE4LTEwLTA1ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CisKKyAgICAgICAgW1hjb2RlXSBEb27igJl0IGluc3RhbGwgeWFzbSBhbmQgZG9u4oCZ dCBjb21waWxlIGl0IGluIGlPUyBkZXZpY2UgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTAzMjYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL3lhc20ueGNjb25maWc6 IFNldCBTS0lQX0lOU1RBTEwgdG8gWUVTLCBhbmQgZXhjbHVkZWQgYWxsIHNvdXJjZSBmaWxlcyB3 aGVuCisgICAgICAgICAgdGFyZ2V0aW5nIGlPUyBkZXZpY2VzLgorCiAyMDE4LTEwLTA0ICBEYW4g QmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ZWQgZW5naW5lZXJpbmcg YnVpbGRzIHVzaW5nIHRoZSBBcHBsZSBpbnRlcm5hbCBTREsgYXMgd2VsbCBhcyBidWlsZGluZyB3 aXRoIG9sZGVyCkluZGV4OiBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlv bnMveWFzbS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJy dGMvQ29uZmlndXJhdGlvbnMveWFzbS54Y2NvbmZpZwkocmV2aXNpb24gMjM2ODk0KQorKysgU291 cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL3lhc20ueGNjb25maWcJKHdv cmtpbmcgY29weSkKQEAgLTIsNyArMiw3IEBAIFBST0RVQ1RfTkFNRSA9IHlhc207CiAKIEhFQURF Ul9TRUFSQ0hfUEFUSFMgPSBTb3VyY2UvdGhpcmRfcGFydHkveWFzbS0xLjMuMDsKIAotSU5TVEFM TF9QQVRIID0gL3Vzci9sb2NhbC9saWI7CitTS0lQX0lOU1RBTEwgPSBZRVM7CiBQVUJMSUNfSEVB REVSU19GT0xERVJfUEFUSCA9IC91c3IvbG9jYWwvaW5jbHVkZS9saWJ3ZWJydGM7CiBVU0VfSEVB REVSTUFQID0gTk87CiAKQEAgLTE2LDYgKzE2LDYgQEAgQ0xBTkdfV0FSTl9VTlJFQUNIQUJMRV9D T0RFID0gWUVTOwogQ0xBTkdfV0FSTl9SQU5HRV9MT09QX0FOQUxZU0lTID0gWUVTOwogQ0xBTkdf V0FSTl9ERVBSRUNBVEVEX09CSkNfSU1QTEVNRU5UQVRJT05TID0gWUVTOwogCi1FWENMVURFRF9T T1VSQ0VfRklMRV9OQU1FU1tzZGs9bWFjb3MqXSA9ICpfbmVvbi5jIGFybV9jcHVkZXRlY3QuYyAq X2FybS5jIHNhZC5jCi1FWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9aXBob25lc2ltdWxh dG9yKl0gPSAqX25lb24uYyBhcm1fY3B1ZGV0ZWN0LmMgKl9hcm0uYyBzYWQuYwotRVhDTFVERURf U09VUkNFX0ZJTEVfTkFNRVNbc2RrPWlwaG9uZW9zKl0gPSAqX3NzZTIuYyAqX3Nzc2UzLmMgKl9z c2U0LmMgKl9hdngyLmMgKl9hdnguYyAqX3NzZTIuYXNtLm8gKl9zc2UzLmFzbS5vCitFWENMVURF RF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9bWFjb3MqXSA9ICpfbmVvbi5jIGFybV9jcHVkZXRlY3Qu YyAqX2FybS5jIHNhZC5jOworRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNbc2RrPWlwaG9uZXNp bXVsYXRvcipdID0gKl9uZW9uLmMgYXJtX2NwdWRldGVjdC5jICpfYXJtLmMgc2FkLmM7CitFWENM VURFRF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9aXBob25lb3MqXSA9ICo7Cg==