190317 2018-10-05 11:14:51 -0700 performJITMemcpy() should handle the case when the executable allocator is not initialized yet. 2018-10-05 12:15:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset ryanhaddad saam tzagallo webkit-bug-importer oldest_to_newest 1466725 0 mark.lam 2018-10-05 11:14:51 -0700 When SeparatedWXHeaps is in use, jitWriteThunkGenerator() will call performJITMemcpy() to copy memory before the JIT fixed memory pool is initialize. Before r236864, performJITMemcpy() would just do a memcpy in that case. We need to restore the equivalent behavior. <rdar://problem/45039398> 1466726 1 351683 mark.lam 2018-10-05 11:18:38 -0700 Created attachment 351683 proposed patch. 1466728 2 351683 saam 2018-10-05 11:21:56 -0700 Comment on attachment 351683 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351683&action=review > Source/JavaScriptCore/ChangeLog:10 > + to copy memory before the JIT fixed memory pool is initialize. Before r236864, s/initialize/initialized > Source/JavaScriptCore/ChangeLog:11 > + performJITMemcpy() would just do a memcpy in that case. We need to restore the Why not just make it call memcpy? This feels like a roundabout way to solve that issue IMO 1466730 3 mark.lam 2018-10-05 11:24:52 -0700 (In reply to Saam Barati from comment #2) > Comment on attachment 351683 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351683&action=review > > > Source/JavaScriptCore/ChangeLog:10 > > + to copy memory before the JIT fixed memory pool is initialize. Before r236864, > > s/initialize/initialized will fix. > > Source/JavaScriptCore/ChangeLog:11 > > + performJITMemcpy() would just do a memcpy in that case. We need to restore the > > Why not just make it call memcpy? This feels like a roundabout way to solve > that issue IMO Because jitWriteThunkGenerator() does not call performJITMemcpy() directly. The call comes indirectly far below LinkBuffer::linkCode(). 1466736 4 351683 saam 2018-10-05 11:28:47 -0700 Comment on attachment 351683 proposed patch. r=me 1466742 5 mark.lam 2018-10-05 11:34:24 -0700 Thanks for the review. Landed in r236880: <http://trac.webkit.org/r236880>. 1466748 6 mark.lam 2018-10-05 12:15:24 -0700 + build fix landed in r236881: <http://trac.webkit.org/r236881>. 351683 2018-10-05 11:18:38 -0700 2018-10-05 11:28:47 -0700 proposed patch. bug-190317.patch text/plain 3209 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2ODc4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE4LTEwLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBw ZXJmb3JtSklUTWVtY3B5KCkgc2hvdWxkIGhhbmRsZSB0aGUgY2FzZSB3aGVuIHRoZSBleGVjdXRh YmxlIGFsbG9jYXRvciBpcyBub3QgaW5pdGlhbGl6ZWQgeWV0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMzE3CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80NTAzOTM5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGVuIFNlcGFyYXRlZFdYSGVhcHMgaXMgaW4gdXNlLCBqaXRXcml0ZVRodW5rR2Vu ZXJhdG9yKCkgd2lsbCBjYWxsIHBlcmZvcm1KSVRNZW1jcHkoKQorICAgICAgICB0byBjb3B5IG1l bW9yeSBiZWZvcmUgdGhlIEpJVCBmaXhlZCBtZW1vcnkgcG9vbCBpcyBpbml0aWFsaXplLiAgQmVm b3JlIHIyMzY4NjQsCisgICAgICAgIHBlcmZvcm1KSVRNZW1jcHkoKSB3b3VsZCBqdXN0IGRvIGEg bWVtY3B5IGluIHRoYXQgY2FzZS4gIFdlIG5lZWQgdG8gcmVzdG9yZSB0aGUKKyAgICAgICAgZXF1 aXZhbGVudCBiZWhhdmlvci4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNw cDoKKyAgICAgICAgKEpTQzo6aXNKSVRQQyk6CisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3IuaDoKKyAgICAgICAgKEpTQzo6cGVyZm9ybUpJVE1lbWNweSk6CisKIDIwMTgtMTAtMDUg IENhcmxvcyBFZHVhcmRvIFJhbWFsaG8gIDxjYWR1YmVudHplbkBnbWFpbC5jb20+CiAKICAgICAg ICAgW1dQRV1bSlNDXSBVc2UgVW5pZmllZCBTb3VyY2VzIGZvciBQbGF0Zm9ybS1zcGVjaWZpYyBz b3VyY2VzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvci5jcHAJKHJldmlzaW9uIDIzNjg3OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzMSw3ICsz MzEsNyBAQCBwcml2YXRlOgogICAgICAgICAvLyBhc3luY0Rpc2Fzc2VtYmx5IG9wdGlvbiBhcyBv dXIgY2FsbGVyIHdpbGwgc2V0IG91ciBwYWdlcyBleGVjdXRlIG9ubHkuCiAgICAgICAgIHJldHVy biBsaW5rQnVmZmVyLmZpbmFsaXplQ29kZVdpdGhvdXREaXNhc3NlbWJseTxKSVRUaHVua1B0clRh Zz4oKTsKICAgICB9Ci0jZWxzZSAvLyBDUFUoQVJNNjQpICYmIFVTRShFWEVDVVRFX09OTFlfSklU X1dSSVRFX0ZVTkNUSU9OKQorI2Vsc2UgLy8gbm90IENQVShBUk02NCkgJiYgVVNFKEVYRUNVVEVf T05MWV9KSVRfV1JJVEVfRlVOQ1RJT04pCiAgICAgc3RhdGljIHZvaWQgZ2VuZXJpY1dyaXRlVG9K SVRSZWdpb24ob2ZmX3Qgb2Zmc2V0LCBjb25zdCB2b2lkKiBkYXRhLCBzaXplX3QgZGF0YVNpemUp CiAgICAgewogICAgICAgICBtZW1jcHkoKHZvaWQqKShzdGFydE9mRml4ZWRXcml0YWJsZU1lbW9y eVBvb2wgKyBvZmZzZXQpLCBkYXRhLCBkYXRhU2l6ZSk7CkBAIC0zNTAsNyArMzUwLDcgQEAgcHJp dmF0ZToKICAgICAgICAgYXV0byBjb2RlUHRyID0gTWFjcm9Bc3NlbWJsZXJDb2RlUHRyPEpJVFRo dW5rUHRyVGFnPih0YWdDRnVuY3Rpb25QdHI8SklUVGh1bmtQdHJUYWc+KGZ1bmN0aW9uKSk7CiAg ICAgICAgIHJldHVybiBNYWNyb0Fzc2VtYmxlckNvZGVSZWY8SklUVGh1bmtQdHJUYWc+OjpjcmVh dGVTZWxmTWFuYWdlZENvZGVSZWYoY29kZVB0cik7CiAgICAgfQotI2VuZGlmCisjZW5kaWYgLy8g Q1BVKEFSTTY0KSAmJiBVU0UoRVhFQ1VURV9PTkxZX0pJVF9XUklURV9GVU5DVElPTikKIAogI2Vs c2UgLy8gT1MoREFSV0lOKSAmJiBIQVZFKFJFTUFQX0pJVCkKICAgICB2b2lkIGluaXRpYWxpemVT ZXBhcmF0ZWRXWEhlYXBzKHZvaWQqLCBzaXplX3QsIHZvaWQqLCBzaXplX3QpCkBAIC01MDksNyAr NTA5LDcgQEAgdm9pZCogZW5kT2ZGaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sSW1wbAogCiBib29s IGlzSklUUEModm9pZCogcGMpCiB7Ci0gICAgcmV0dXJuIGFsbG9jYXRvci0+aXNKSVRQQyhwYyk7 CisgICAgcmV0dXJuIGFsbG9jYXRvciAmJiBhbGxvY2F0b3ItPmlzSklUUEMocGMpOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBKU0MKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0 YWJsZUFsbG9jYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv RXhlY3V0YWJsZUFsbG9jYXRvci5oCShyZXZpc2lvbiAyMzY4NzgpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtOTMs NyArOTMsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQqIHBlcmZvcm1KSVRNZW1jcHkodm9pCiAgICAg UkVMRUFTRV9BU1NFUlQocm91bmRVcFRvTXVsdGlwbGVPZjxpbnN0cnVjdGlvblNpemU+KGRzdCkg PT0gZHN0KTsKICAgICBSRUxFQVNFX0FTU0VSVChyb3VuZFVwVG9NdWx0aXBsZU9mPGluc3RydWN0 aW9uU2l6ZT4oc3JjKSA9PSBzcmMpOwogI2VuZGlmCi0gICAgaWYgKGRzdCA+PSBzdGFydE9mRml4 ZWRFeGVjdXRhYmxlTWVtb3J5UG9vbCgpICYmIGRzdCA8IGVuZE9mRml4ZWRFeGVjdXRhYmxlTWVt b3J5UG9vbCgpKSB7CisgICAgaWYgKGlzSklUUEMoZHN0KSkgewogICAgICAgICBSRUxFQVNFX0FT U0VSVChyZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPihkc3QpICsgbiA8PSBlbmRPZkZpeGVkRXhl Y3V0YWJsZU1lbW9yeVBvb2woKSk7CiAjaWYgRU5BQkxFKEZBU1RfSklUX1BFUk1JU1NJT05TKQog I2lmICFDUFUoQVJNNjRFKQo=