190283 2018-10-04 11:20:33 -0700 Disable Options::useWebAssemblyFastMemory() on linux if ASAN signal handling is not disabled. 2018-10-04 12:24:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller mcatanzaro msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1466414 0 mark.lam 2018-10-04 11:20:33 -0700 Will also print a warning if we detect this condition. 1466420 1 webkit-bug-importer 2018-10-04 11:28:05 -0700 <rdar://problem/45015752> 1466423 2 351607 mark.lam 2018-10-04 11:30:55 -0700 Created attachment 351607 proposed patch. 1466442 3 351607 keith_miller 2018-10-04 12:14:58 -0700 Comment on attachment 351607 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review r=me with comment. > Source/JavaScriptCore/runtime/Options.cpp:581 > + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); Do we actually need both or does ASAN work with just allow_user_segv_handler=1? 1466447 4 351607 mark.lam 2018-10-04 12:17:40 -0700 Comment on attachment 351607 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >> Source/JavaScriptCore/runtime/Options.cpp:581 >> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); > > Do we actually need both or does ASAN work with just allow_user_segv_handler=1? We're checking for either here. 1466453 5 351607 keith_miller 2018-10-04 12:22:21 -0700 Comment on attachment 351607 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=351607&action=review >>> Source/JavaScriptCore/runtime/Options.cpp:581 >>> + && (strstr(asanOptions, "allow_user_segv_handler=1") || strstr(asanOptions, "handle_segv=0")); >> >> Do we actually need both or does ASAN work with just allow_user_segv_handler=1? > > We're checking for either here. Whoops, read that as &&. carry on! 1466454 6 mark.lam 2018-10-04 12:24:21 -0700 Thanks for the review. Landed in r236839: <http://trac.webkit.org/r236839>. 351607 2018-10-04 11:30:55 -0700 2018-10-04 12:14:58 -0700 proposed patch. bug-190283.patch text/plain 2813 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2ODM3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTEwLTA0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBE aXNhYmxlIE9wdGlvbnM6OnVzZVdlYkFzc2VtYmx5RmFzdE1lbW9yeSgpIG9uIGxpbnV4IGlmIEFT QU4gc2lnbmFsIGhhbmRsaW5nIGlzIG5vdCBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI4MworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNDUwMTU3NTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBydW50aW1lL09wdGlvbnMuY3BwOgorICAgICAgICAoSlNDOjpPcHRpb25zOjppbml0 aWFsaXplKToKKyAgICAgICAgKiB3YXNtL1dhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwOgorICAg ICAgICAoSlNDOjpXYXNtOjplbmFibGVGYXN0TWVtb3J5KToKKwogMjAxOC0xMC0wMyAgUm9zcyBL aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgW0pTQ10gcHJpbnQo KSBjaGFuZ2VzIENSTEYgdG8gQ1JDUkxGIG9uIFdpbmRvd3MKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCShyZXZpc2lvbiAyMzY4MzYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcz LDYgKzU3MywxOCBAQCB2b2lkIE9wdGlvbnM6OmluaXRpYWxpemUoKQogICAgICAgICAgICAgaWYg KE9wdGlvbnM6OnVzZU1hY2hGb3JFeGNlcHRpb25zKCkpCiAgICAgICAgICAgICAgICAgaGFuZGxl U2lnbmFsc1dpdGhNYWNoKCk7CiAjZW5kaWYKKworI2lmIEFTQU5fRU5BQkxFRCAmJiBPUyhMSU5V WCkgJiYgRU5BQkxFKFdFQkFTU0VNQkxZX0ZBU1RfTUVNT1JZKQorICAgICAgICAgICAgaWYgKE9w dGlvbnM6OnVzZVdlYkFzc2VtYmx5RmFzdE1lbW9yeSgpKSB7CisgICAgICAgICAgICAgICAgY29u c3QgY2hhciogYXNhbk9wdGlvbnMgPSBnZXRlbnYoIkFTQU5fT1BUSU9OUyIpOworICAgICAgICAg ICAgICAgIGJvb2wgb2tUb1VzZVdlYkFzc2VtYmx5RmFzdE1lbW9yeSA9IGFzYW5PcHRpb25zCisg ICAgICAgICAgICAgICAgICAgICYmIChzdHJzdHIoYXNhbk9wdGlvbnMsICJhbGxvd191c2VyX3Nl Z3ZfaGFuZGxlcj0xIikgfHwgc3Ryc3RyKGFzYW5PcHRpb25zLCAiaGFuZGxlX3NlZ3Y9MCIpKTsK KyAgICAgICAgICAgICAgICBpZiAoIW9rVG9Vc2VXZWJBc3NlbWJseUZhc3RNZW1vcnkpIHsKKyAg ICAgICAgICAgICAgICAgICAgZGF0YUxvZ0xuKCJXQVJOSU5HOiBBU0FOIGludGVyZmVyZXMgd2l0 aCBKU0Mgc2lnbmFsIGhhbmRsZXJzOyB1c2VXZWJBc3NlbWJseUZhc3RNZW1vcnkgd2lsbCBiZSBk aXNhYmxlZC4iKTsKKyAgICAgICAgICAgICAgICAgICAgT3B0aW9uczo6dXNlV2ViQXNzZW1ibHlG YXN0TWVtb3J5KCkgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9Cisj ZW5kaWYKICAgICAgICAgfSk7CiB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNt L1dhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwCShyZXZpc2lvbiAyMzY4MzYp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRmF1bHRTaWduYWxIYW5kbGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTIzLDIwICsxMjMsMjAgQEAgYm9vbCBmYXN0TWVtb3J5RW5h YmxlZCgpCiAKIHZvaWQgZW5hYmxlRmFzdE1lbW9yeSgpCiB7CisjaWYgRU5BQkxFKFdFQkFTU0VN QkxZX0ZBU1RfTUVNT1JZKQogICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlOwogICAgIHN0 ZDo6Y2FsbF9vbmNlKG9uY2UsIFtdIHsKICAgICAgICAgaWYgKCFPcHRpb25zOjp1c2VXZWJBc3Nl bWJseUZhc3RNZW1vcnkoKSkKICAgICAgICAgICAgIHJldHVybjsKIAotI2lmIEVOQUJMRShXRUJB U1NFTUJMWV9GQVNUX01FTU9SWSkKICAgICAgICAgaW5zdGFsbFNpZ25hbEhhbmRsZXIoU2lnbmFs OjpCYWRBY2Nlc3MsIFtdIChTaWduYWwgc2lnbmFsLCBTaWdJbmZvJiBzaWdJbmZvLCBQbGF0Zm9y bVJlZ2lzdGVycyYgdWNvbnRleHQpIHsKICAgICAgICAgICAgIHJldHVybiB0cmFwSGFuZGxlcihz aWduYWwsIHNpZ0luZm8sIHVjb250ZXh0KTsKICAgICAgICAgfSk7CiAKICAgICAgICAgY29kZUxv Y2F0aW9ucy5jb25zdHJ1Y3QoKTsKICAgICAgICAgZmFzdEhhbmRsZXJJbnN0YWxsZWQgPSB0cnVl OwotI2VuZGlmIC8vIEVOQUJMRShXRUJBU1NFTUJMWV9GQVNUX01FTU9SWSkKICAgICB9KTsKKyNl bmRpZiAvLyBFTkFCTEUoV0VCQVNTRU1CTFlfRkFTVF9NRU1PUlkpCiB9CiAgICAgCiB9IH0gLy8g bmFtZXNwYWNlIEpTQzo6V2FzbQo=