190279 2018-10-04 03:36:52 -0700 XMLHttpRequest should use reportExtraMemoryAllocated/reportExtraMemoryVisited instead of deprecatedReportExtraMemory 2018-10-10 01:50:54 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki cdumez commit-queue darin esprehn+autocc ews-watchlist ggaren keith_miller kondapallykalyan mark.lam msaboff rniwa saam sam webkit-bug-importer oldest_to_newest 1466348 0 ysuzuki 2018-10-04 03:36:52 -0700 XMLHttpRequest should use reportExtraMemoryAllocated/reportExtraMemoryVisited instead of deprecatedReportExtraMemory 1466349 1 351593 ysuzuki 2018-10-04 03:38:54 -0700 Created attachment 351593 Patch 1466894 2 ysuzuki 2018-10-06 12:49:25 -0700 Ping? 1467670 3 351593 ysuzuki 2018-10-10 01:22:18 -0700 Comment on attachment 351593 Patch Thanks! 1467671 4 351593 commit-queue 2018-10-10 01:49:05 -0700 Comment on attachment 351593 Patch Clearing flags on attachment: 351593 Committed r236999: <https://trac.webkit.org/changeset/236999> 1467672 5 commit-queue 2018-10-10 01:49:07 -0700 All reviewed patches have been landed. Closing bug. 1467673 6 webkit-bug-importer 2018-10-10 01:50:54 -0700 <rdar://problem/45154619> 351593 2018-10-04 03:38:54 -0700 2018-10-10 01:49:05 -0700 Patch bug-190279-20181004193853.patch text/plain 7004 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2ODI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIzN2Y1NWIyNGVkZGQ4 ZjQ0NjMyZmZjNTgzOWM2MDI2NTAxYzEzZi4uZDMwMDU5YWRjZjNkMTEyMjg1MjI4OWJjMzU4ZjEw M2Y1MDM5NzQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTEwLTA0ICBZdXN1 a2UgU3V6dWtpICA8eXVzdWtlc3V6dWtpQHNsb3dzdGFydC5vcmc+CisKKyAgICAgICAgWE1MSHR0 cFJlcXVlc3Qgc2hvdWxkIHVzZSByZXBvcnRFeHRyYU1lbW9yeUFsbG9jYXRlZC9yZXBvcnRFeHRy YU1lbW9yeVZpc2l0ZWQgaW5zdGVhZCBvZiBkZXByZWNhdGVkUmVwb3J0RXh0cmFNZW1vcnkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2gg c3dpdGNoZXMgZGVwcmVjYXRlZFJlcG9ydEV4dHJhTWVtb3J5IHRvIHJlcG9ydEV4dHJhTWVtb3J5 QWxsb2NhdGVkL3JlcG9ydEV4dHJhTWVtb3J5VmlzaXRlZAorICAgICAgICBpbiBYTUxIdHRwUmVx dWVzdC4gV2UgcmVwb3J0IGV4dHJhIG1lbW9yeSBhbGxvY2F0aW9uIHdoZW4gdGhlIHJlYWR5U3Rh dGUgYmVjb21lcyBET05FLiBBbmQgbWVtb3J5Q29zdAorICAgICAgICBmdW5jdGlvbiByZXR1cm5z IHRoZSBtZW1vcnkgY29zdCB3aGljaCBpcyBiYXNlZCBvbiB0aGUgcmVhZHlTdGF0ZSBhbmQgbV9y ZXNwb25zZUJ1aWxkZXIuCisgICAgICAgIFdlIGFubm90YXRlIFhNTEh0dHBSZXF1ZXN0IHdpdGgg UmVwb3J0RXh0cmFNZW1vcnlDb3N0IHRvIHVzZSByZXBvcnRFeHRyYU1lbW9yeVZpc2l0ZWQgYXV0 b21hdGljYWxseSB3aXRoCisgICAgICAgIG1lbW9yeUNvc3QoKSBmdW5jdGlvbi4KKworICAgICAg ICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVx dWVzdDo6Y2hhbmdlU3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmFi b3J0KToKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjppbnRlcm5hbEFib3J0KToK KyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpuZXR3b3JrRXJyb3JUaW1lckZpcmVk KToKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjptZW1vcnlDb3N0IGNvbnN0KToK KyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpkaWRGaW5pc2hMb2FkaW5nKToKKyAg ICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpkaWRSZWFjaFRpbWVvdXQpOgorICAgICAg ICAoV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmRyb3BQcm90ZWN0aW9uKTogRGVsZXRlZC4KKyAg ICAgICAgKiB4bWwvWE1MSHR0cFJlcXVlc3QuaDoKKyAgICAgICAgKiB4bWwvWE1MSHR0cFJlcXVl c3QuaWRsOgorCiAyMDE4LTEwLTAzICBKdXN0aW4gTWljaGF1ZCAgPGp1c3Rpbl9taWNoYXVkQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWdpc3RlcmVkIGN1c3RvbSBwcm9wZXJ0aWVzIHNob3VsZCBh bGxvdyBpbmhlcml0YW5jZSB0byBiZSBjb250cm9sbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBS ZXF1ZXN0LmNwcAppbmRleCA5MDBmYTdkZDcxNmMwNzdjMTY0Nzc2OTA0ZDljY2NlZDQzMGM2NTZh Li4xZmM4NzhiMTU0MjNmOTczNjE4Zjg0ZTM5NzhhNjJmOWFjNjQ1NTAyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTI5NSw2ICsyOTUsMTkgQEAgdm9pZCBYTUxIdHRw UmVxdWVzdDo6Y2hhbmdlU3RhdGUoU3RhdGUgbmV3U3RhdGUpCiB7CiAgICAgaWYgKHJlYWR5U3Rh dGUoKSAhPSBuZXdTdGF0ZSkgewogICAgICAgICBtX3JlYWR5U3RhdGUgPSBzdGF0aWNfY2FzdDxT dGF0ZT4obmV3U3RhdGUpOworICAgICAgICBpZiAocmVhZHlTdGF0ZSgpID09IERPTkUpIHsKKyAg ICAgICAgICAgIC8vIFRoZSBYSFIgb2JqZWN0IGl0c2VsZiBob2xkcyBvbiB0byB0aGUgcmVzcG9u c2VUZXh0LCBhbmQKKyAgICAgICAgICAgIC8vIHRodXMgaGFzIGV4dHJhIGNvc3QgZXZlbiBpbmRl cGVuZGVudCBvZiBhbnkKKyAgICAgICAgICAgIC8vIHJlc3BvbnNlVGV4dCBvciByZXNwb25zZVhN TCBvYmplY3RzIGl0IGhhcyBoYW5kZWQKKyAgICAgICAgICAgIC8vIG91dC4gQnV0IGl0IGlzIHBy b3RlY3RlZCBmcm9tIEdDIHdoaWxlIGxvYWRpbmcsIHNvIHRoaXMKKyAgICAgICAgICAgIC8vIGNh bid0IGJlIHJlY291cGVkIHVudGlsIHRoZSBsb2FkIGlzIGRvbmUsIHNvIG9ubHkKKyAgICAgICAg ICAgIC8vIHJlcG9ydCB0aGUgZXh0cmEgY29zdCBhdCB0aGF0IHBvaW50LgorICAgICAgICAgICAg aWYgKGF1dG8qIGNvbnRleHQgPSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpIHsKKyAgICAgICAg ICAgICAgICBKU0M6OlZNJiB2bSA9IGNvbnRleHQtPnZtKCk7CisgICAgICAgICAgICAgICAgSlND OjpKU0xvY2tIb2xkZXIgbG9jayh2bSk7CisgICAgICAgICAgICAgICAgdm0uaGVhcC5yZXBvcnRF eHRyYU1lbW9yeUFsbG9jYXRlZChtZW1vcnlDb3N0KCkpOworICAgICAgICAgICAgfQorICAgICAg ICB9CiAgICAgICAgIGNhbGxSZWFkeVN0YXRlQ2hhbmdlTGlzdGVuZXIoKTsKICAgICB9CiB9CkBA IC02NTYsNyArNjY5LDcgQEAgRXhjZXB0aW9uT3I8dm9pZD4gWE1MSHR0cFJlcXVlc3Q6OmNyZWF0 ZVJlcXVlc3QoKQogCiB2b2lkIFhNTEh0dHBSZXF1ZXN0OjphYm9ydCgpCiB7Ci0gICAgLy8gaW50 ZXJuYWxBYm9ydCgpIGNhbGxzIGRyb3BQcm90ZWN0aW9uKCksIHdoaWNoIG1heSByZWxlYXNlIHRo ZSBsYXN0IHJlZmVyZW5jZS4KKyAgICAvLyBpbnRlcm5hbEFib3J0KCkgY2FsbHMgdW5zZXRQZW5k aW5nQWN0aXZpdHkodGhpcyksIHdoaWNoIG1heSByZWxlYXNlIHRoZSBsYXN0IHJlZmVyZW5jZS4K ICAgICBSZWY8WE1MSHR0cFJlcXVlc3Q+IHByb3RlY3RlZFRoaXMoKnRoaXMpOwogCiAgICAgbV93 YXNBYm9ydGVkQnlDbGllbnQgPSB0cnVlOwpAQCAtNzAyLDcgKzcxNSw3IEBAIGJvb2wgWE1MSHR0 cFJlcXVlc3Q6OmludGVybmFsQWJvcnQoKQogICAgIC8vIFNhdmUgdGhpcyBpbmZvcm1hdGlvbiB0 byBhIGxvY2FsIHZhcmlhYmxlIHNpbmNlIHdlIGFyZSBnb2luZyB0byBkcm9wIHByb3RlY3Rpb24u CiAgICAgYm9vbCBuZXdMb2FkU3RhcnRlZCA9IG1fbG9hZGVyOwogCi0gICAgZHJvcFByb3RlY3Rp b24oKTsKKyAgICB1bnNldFBlbmRpbmdBY3Rpdml0eSh0aGlzKTsKIAogICAgIHJldHVybiAhbmV3 TG9hZFN0YXJ0ZWQ7CiB9CkBAIC03NDksNyArNzYyLDcgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6 bmV0d29ya0Vycm9yKCkKIHZvaWQgWE1MSHR0cFJlcXVlc3Q6Om5ldHdvcmtFcnJvclRpbWVyRmly ZWQoKQogewogICAgIG5ldHdvcmtFcnJvcigpOwotICAgIGRyb3BQcm90ZWN0aW9uKCk7CisgICAg dW5zZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CiB9CiAgICAgCiB2b2lkIFhNTEh0dHBSZXF1ZXN0 OjphYm9ydEVycm9yKCkKQEAgLTc1OSwyMSArNzcyLDExIEBAIHZvaWQgWE1MSHR0cFJlcXVlc3Q6 OmFib3J0RXJyb3IoKQogICAgIGRpc3BhdGNoRXJyb3JFdmVudHMoZXZlbnROYW1lcygpLmFib3J0 RXZlbnQpOwogfQogCi12b2lkIFhNTEh0dHBSZXF1ZXN0Ojpkcm9wUHJvdGVjdGlvbigpCitzaXpl X3QgWE1MSHR0cFJlcXVlc3Q6Om1lbW9yeUNvc3QoKSBjb25zdAogewotICAgIC8vIFRoZSBYSFIg b2JqZWN0IGl0c2VsZiBob2xkcyBvbiB0byB0aGUgcmVzcG9uc2VUZXh0LCBhbmQKLSAgICAvLyB0 aHVzIGhhcyBleHRyYSBjb3N0IGV2ZW4gaW5kZXBlbmRlbnQgb2YgYW55Ci0gICAgLy8gcmVzcG9u c2VUZXh0IG9yIHJlc3BvbnNlWE1MIG9iamVjdHMgaXQgaGFzIGhhbmRlZAotICAgIC8vIG91dC4g QnV0IGl0IGlzIHByb3RlY3RlZCBmcm9tIEdDIHdoaWxlIGxvYWRpbmcsIHNvIHRoaXMKLSAgICAv LyBjYW4ndCBiZSByZWNvdXBlZCB1bnRpbCB0aGUgbG9hZCBpcyBkb25lLCBzbyBvbmx5Ci0gICAg Ly8gcmVwb3J0IHRoZSBleHRyYSBjb3N0IGF0IHRoYXQgcG9pbnQuCi0gICAgSlNDOjpWTSYgdm0g PSBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPnZtKCk7Ci0gICAgSlNDOjpKU0xvY2tIb2xkZXIg bG9jayh2bSk7Ci0gICAgLy8gRklYTUU6IEFkb3B0IHJlcG9ydEV4dHJhTWVtb3J5VmlzaXRlZCwg YW5kIHN3aXRjaCB0byByZXBvcnRFeHRyYU1lbW9yeUFsbG9jYXRlZC4KLSAgICAvLyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyNTk1Ci0gICAgdm0uaGVhcC5kZXBy ZWNhdGVkUmVwb3J0RXh0cmFNZW1vcnkobV9yZXNwb25zZUJ1aWxkZXIubGVuZ3RoKCkgKiAyKTsK LQotICAgIHVuc2V0UGVuZGluZ0FjdGl2aXR5KHRoaXMpOworICAgIGlmIChyZWFkeVN0YXRlKCkg PT0gRE9ORSkKKyAgICAgICAgcmV0dXJuIG1fcmVzcG9uc2VCdWlsZGVyLmxlbmd0aCgpICogMjsK KyAgICByZXR1cm4gMDsKIH0KIAogRXhjZXB0aW9uT3I8dm9pZD4gWE1MSHR0cFJlcXVlc3Q6Om92 ZXJyaWRlTWltZVR5cGUoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKQEAgLTk0Myw3ICs5NDYsNyBA QCB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpkaWRGaW5pc2hMb2FkaW5nKHVuc2lnbmVkIGxvbmcpCiAg ICAgbV90aW1lb3V0VGltZXIuc3RvcCgpOwogCiAgICAgaWYgKGhhZExvYWRlcikKLSAgICAgICAg ZHJvcFByb3RlY3Rpb24oKTsKKyAgICAgICAgdW5zZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7CiB9 CiAKIHZvaWQgWE1MSHR0cFJlcXVlc3Q6OmRpZFNlbmREYXRhKHVuc2lnbmVkIGxvbmcgbG9uZyBi eXRlc1NlbnQsIHVuc2lnbmVkIGxvbmcgbG9uZyB0b3RhbEJ5dGVzVG9CZVNlbnQpCkBAIC0xMDgz LDcgKzEwODYsNyBAQCB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpkaXNwYXRjaEVycm9yRXZlbnRzKGNv bnN0IEF0b21pY1N0cmluZyYgdHlwZSkKIAogdm9pZCBYTUxIdHRwUmVxdWVzdDo6ZGlkUmVhY2hU aW1lb3V0KCkKIHsKLSAgICAvLyBpbnRlcm5hbEFib3J0KCkgY2FsbHMgZHJvcFByb3RlY3Rpb24o KSwgd2hpY2ggbWF5IHJlbGVhc2UgdGhlIGxhc3QgcmVmZXJlbmNlLgorICAgIC8vIGludGVybmFs QWJvcnQoKSBjYWxscyB1bnNldFBlbmRpbmdBY3Rpdml0eSh0aGlzKSwgd2hpY2ggbWF5IHJlbGVh c2UgdGhlIGxhc3QgcmVmZXJlbmNlLgogICAgIFJlZjxYTUxIdHRwUmVxdWVzdD4gcHJvdGVjdGVk VGhpcygqdGhpcyk7CiAgICAgaWYgKCFpbnRlcm5hbEFib3J0KCkpCiAgICAgICAgIHJldHVybjsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oIGIvU291cmNl L1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmgKaW5kZXggNTA1MjBiNmExNDFiMTgzZjA0OGRl NjA5MzI5ZjljYzgxZjI1NDg3MC4uYWVhZDFiYzA4ZDlkNDZjMTJjZDM1Njg0NmQ5NzExMTA3NTAw YTQ4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmgKKysr IGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmgKQEAgLTEyNSw2ICsxMjUsOCBA QCBjbGFzcyBYTUxIdHRwUmVxdWVzdCBmaW5hbCA6IHB1YmxpYyBBY3RpdmVET01PYmplY3QsIHB1 YmxpYyBSZWZDb3VudGVkPFhNTEh0dHBSZQogICAgIHVzaW5nIFJlZkNvdW50ZWQ8WE1MSHR0cFJl cXVlc3Q+OjpyZWY7CiAgICAgdXNpbmcgUmVmQ291bnRlZDxYTUxIdHRwUmVxdWVzdD46OmRlcmVm OwogCisgICAgc2l6ZV90IG1lbW9yeUNvc3QoKSBjb25zdDsKKwogcHJpdmF0ZToKICAgICBleHBs aWNpdCBYTUxIdHRwUmVxdWVzdChTY3JpcHRFeGVjdXRpb25Db250ZXh0Jik7CiAKQEAgLTE2Niw3 ICsxNjgsNiBAQCBjbGFzcyBYTUxIdHRwUmVxdWVzdCBmaW5hbCA6IHB1YmxpYyBBY3RpdmVET01P YmplY3QsIHB1YmxpYyBSZWZDb3VudGVkPFhNTEh0dHBSZQogCiAgICAgdm9pZCBjaGFuZ2VTdGF0 ZShTdGF0ZSk7CiAgICAgdm9pZCBjYWxsUmVhZHlTdGF0ZUNoYW5nZUxpc3RlbmVyKCk7Ci0gICAg dm9pZCBkcm9wUHJvdGVjdGlvbigpOwogCiAgICAgLy8gUmV0dXJucyBmYWxzZSB3aGVuIGNhbmNl bGxpbmcgdGhlIGxvYWRlciB3aXRoaW4gaW50ZXJuYWxBYm9ydCgpIHRyaWdnZXJzIGFuIGV2ZW50 IHdob3NlIGNhbGxiYWNrIGNyZWF0ZXMgYSBuZXcgbG9hZGVyLiAKICAgICAvLyBJbiB0aGF0IGNh c2UsIHRoZSBmdW5jdGlvbiBjYWxsaW5nIGludGVybmFsQWJvcnQgc2hvdWxkIGV4aXQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsIGIvU291cmNlL1dl YkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAppbmRleCAzYjFhNzc2MzkxMjExMmVlNDBiMTg1 NmNiYzViYWJlYmUwNjA4OTQ3Li43MmQ3YWRiYjY2ZDRkMzM3YTNiMjU0ZmJhMjZjMGY4YWQwN2Nl MTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCisr KyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKQEAgLTQ3LDYgKzQ3LDcg QEAgZW51bSBYTUxIdHRwUmVxdWVzdFJlc3BvbnNlVHlwZSB7CiAgICAgSlNDdXN0b21NYXJrRnVu Y3Rpb24sCiAgICAgSlNHZW5lcmF0ZVRvSlNPYmplY3QsCiAgICAgSlNHZW5lcmF0ZVRvTmF0aXZl T2JqZWN0LAorICAgIFJlcG9ydEV4dHJhTWVtb3J5Q29zdCwKIF0gaW50ZXJmYWNlIFhNTEh0dHBS ZXF1ZXN0IDogWE1MSHR0cFJlcXVlc3RFdmVudFRhcmdldCB7CiAgICAgLy8gZXZlbnQgaGFuZGxl cgogICAgIGF0dHJpYnV0ZSBFdmVudEhhbmRsZXIgb25yZWFkeXN0YXRlY2hhbmdlOwo=