190263 2018-10-03 14:53:25 -0700 Suppress unreachable code warning for LLIntAssembly.h code. 2018-10-03 15:03:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1466187 0 mark.lam 2018-10-03 14:53:25 -0700 This is needed because LLIntAssembly.h is template generated from LowLevelInterpreter asm files, and may contain dead code which are harmless, but will trip up the warning. We should suppress the warning so that it doesn't break builds. <rdar://problem/44986532> 1466190 1 351549 mark.lam 2018-10-03 14:58:34 -0700 Created attachment 351549 proposed patch. 1466194 2 mark.lam 2018-10-03 15:03:21 -0700 Thanks for the review. Landed in r236813: <http://trac.webkit.org/r236813>. 351549 2018-10-03 14:58:34 -0700 2018-10-03 14:59:58 -0700 proposed patch. bug-190263.patch text/plain 1608 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM2ODEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE4LTEwLTAzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBT dXBwcmVzcyB1bnJlYWNoYWJsZSBjb2RlIHdhcm5pbmcgZm9yIExMSW50QXNzZW1ibHkuaCBjb2Rl LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjYz CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80NDk4NjUzMj4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG5lZWRlZCBiZWNhdXNlIExMSW50 QXNzZW1ibHkuaCBpcyB0ZW1wbGF0ZSBnZW5lcmF0ZWQgZnJvbSBMb3dMZXZlbEludGVycHJldGVy CisgICAgICAgIGFzbSBmaWxlcywgYW5kIG1heSBjb250YWluIGRlYWQgY29kZSB3aGljaCBhcmUg aGFybWxlc3MsIGJ1dCB3aWxsIHRyaXAgdXAgdGhlIHdhcm5pbmcuCisgICAgICAgIFdlIHNob3Vs ZCBzdXBwcmVzcyB0aGUgd2FybmluZyBzbyB0aGF0IGl0IGRvZXNuJ3QgYnJlYWsgYnVpbGRzLgor CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6 OkNMb29wOjpleGVjdXRlKToKKwogMjAxOC0xMC0wMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBw bGUuY29tPgogCiAgICAgICAgIEphdmFTY3JpcHRDb3JlIHBhcnQgb2YgW1hjb2RlXSBVcGRhdGUg c29tZSBidWlsZCBzZXR0aW5ncyBhcyByZWNvbW1lbmRlZCBieSBYY29kZSAxMApJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmNw cAkocmV2aXNpb24gMjM2ODEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NDYsNyArNDQ2LDkgQEAgSlNW YWx1ZSBDTG9vcDo6ZXhlY3V0ZShPcGNvZGVJRCBlbnRyeU9wYwogICAgICAgICAvLyBieXRlY29k ZSBoYW5kbGVycyBmb3IgdGhlIGludGVycHJldGVyLCBhcyBjb21waWxlZCBmcm9tCiAgICAgICAg IC8vIExvd0xldmVsSW50ZXJwcmV0ZXIuYXNtIGFuZCBpdHMgcGVlcnMuCiAKKyAgICAgICAgSUdO T1JFX0NMQU5HX1dBUk5JTkdTX0JFR0lOKCJ1bnJlYWNoYWJsZS1jb2RlIikKICAgICAgICAgI2lu Y2x1ZGUgIkxMSW50QXNzZW1ibHkuaCIKKyAgICAgICAgSUdOT1JFX0NMQU5HX1dBUk5JTkdTX0VO RAogCiAgICAgICAgIE9GRkxJTkVfQVNNX0dMVUVfTEFCRUwobGxpbnRfcmV0dXJuX3RvX2hvc3Qp CiAgICAgICAgIHsK