190259 2018-10-03 13:23:54 -0700 Web Automation: clear pending callbacks when the session terminates 2018-10-04 14:47:27 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg cgarcia joepeck timothy webkit-bug-importer oldest_to_newest 1466159 0 bburg 2018-10-03 13:23:54 -0700 In some cases, the UIProcess may assert when completion handlers are not called and are instead destructed via WebAutomationSession::~WebAutomationSession. 1466160 1 bburg 2018-10-03 13:24:26 -0700 <rdar://problem/44958352> 1466162 2 351543 bburg 2018-10-03 13:32:11 -0700 Created attachment 351543 Patch 1466475 3 351543 joepeck 2018-10-04 12:58:39 -0700 Comment on attachment 351543 Patch r=me 1466533 4 bburg 2018-10-04 14:47:27 -0700 Committed r236852: <https://trac.webkit.org/changeset/236852> 351543 2018-10-03 13:32:11 -0700 2018-10-04 12:58:39 -0700 Patch bug-190259-20181003133210.patch text/plain 2787 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDgxYWQwNTZhMjJhOTdjYmY5 ZDgyM2NiNGE3ZGQyMTM4YjMzZTczYjIuLjMwY2M2OGE4ODZjMjYyYTA4ZDUwYzQ0NDQ5ZWY2YWU5 ZjE1YWQzNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMTAtMDMgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGNsZWFyIHBl bmRpbmcgY2FsbGJhY2tzIHdoZW4gdGhlIHNlc3Npb24gdGVybWluYXRlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjU5CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS80NDk1ODM1Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6dGVybWluYXRlKCkgY2FuIGJlIGNh bGxlZCBhdCBhbnkgdGltZSB0byBudWtlIHRoZSBzZXNzaW9uLgorICAgICAgICBIb3dldmVyLCBp dCdzIHBvc3NpYmxlIHRoYXQgdGhlIHNlc3Npb24gaXMgaW4gdGhlIG1pZHN0IG9mIHNpbXVsYXRp bmcga2V5Ym9hcmQvbW91c2UKKyAgICAgICAgZXZlbnRzLiBXaGlsZSBpbiB0aGF0IHN0YXRlLCB0 aGVyZSBhcmUgc29tZSBDb21wbGV0aW9uSGFuZGxlciBvYmplY3RzIHdhaXRpbmcKKyAgICAgICAg Zm9yIGtleS9tb3VzZSBldmVudHMgdG8gYmUgZmx1c2hlZC4gV2UgbmVlZCB0byBlbXB0eSBvdXQg Y2FsbGJhY2sgbWFwcyB3aXRoCisgICAgICAgIENvbXBsZXRpb25IYW5kbGVyIGluc3RhbmNlcyBz byB0aGF0IHRoZXkgZG8gbm90IGFzc2VydCBiZWNhdXNlIHRoZXkgd2VyZSBuZXZlciBjYWxsZWQu CisKKyAgICAgICAgSSB3YXMgYWJsZSB0byB0ZXN0IHRoaXMgbWFudWFsbHkgYnkgcnVubmluZyBh IHRlc3QgdGhhdCBlcnJvbmVvdXNseSBoYW5ncworICAgICAgICB3aGlsZSB3YWl0aW5nIGZvciBr ZXlib2FyZCBpbnB1dC4gV2hpbGUgdGhlIHRlc3Qgd2FzIGh1bmcsIEkga2lsbGVkIHRoZSBOZXR3 b3JrUHJvY2VzcworICAgICAgICBtYW51YWxseSB0byB0cmlnZ2VyIFdlYkF1dG9tYXRpb25TZXNz aW9uOjp0ZXJtaW5hdGUoKS4gRnJvbSB0aGVyZSwgSSBzYXcgdGhhdCB0aGUKKyAgICAgICAgUGVy Zm9ybSBBY3Rpb25zIFJFU1QgQVBJIGNhbGwgZ2V0cyBjYW5jZWxsZWQgd2l0aCB0aGUgYXBwcm9w cmlhdGUgZXJyb3IgY29kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1 dG9tYXRpb25TZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Np b246OnRlcm1pbmF0ZSk6CisKIDIwMTgtMTAtMDMgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5j b20+CiAKICAgICAgICAgW0NvY29hXSBSRUdSRVNTSU9OOiB3ZWIgY29udGVudCBwcm9jZXNzIHBh dXNlZCBpbiBkZWJ1Z2dlciBpcyBjb25zaWRlcmVkIHRvIGJlIHVucmVzcG9uc2l2ZSBpZiBXZWJL aXQgY2xpZW50IGlzIHNhbmRib3hlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAppbmRleCBmNjNiYjJi YWZlYjk4ZGU0MzVlZmI1ZjVjZDUzZGU0MGM0NzZjYmUxLi45YmQ3Mzg3NTExZjhjMTg3NDcyMjM4 MTIwOWZlNDYwNDRjMDI0MzdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B dXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcApAQCAtMTM5LDYgKzEz OSwxNiBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpkaXNjb25uZWN0KEluc3BlY3Rvcjo6 RnJvbnRlbmRDaGFubmVsKiBjaGFubmVsKQogCiB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjp0 ZXJtaW5hdGUoKQogeworICAgIGZvciAoYXV0byYgaWRlbnRpZmllciA6IGNvcHlUb1ZlY3Rvciht X3BlbmRpbmdLZXlib2FyZEV2ZW50c0ZsdXNoZWRDYWxsYmFja3NQZXJQYWdlLmtleXMoKSkpIHsK KyAgICAgICAgYXV0byBjYWxsYmFjayA9IG1fcGVuZGluZ0tleWJvYXJkRXZlbnRzRmx1c2hlZENh bGxiYWNrc1BlclBhZ2UudGFrZShpZGVudGlmaWVyKTsKKyAgICAgICAgY2FsbGJhY2soQVVUT01B VElPTl9DT01NQU5EX0VSUk9SX1dJVEhfTkFNRShJbnRlcm5hbEVycm9yKSk7CisgICAgfQorCisg ICAgZm9yIChhdXRvJiBpZGVudGlmaWVyIDogY29weVRvVmVjdG9yKG1fcGVuZGluZ01vdXNlRXZl bnRzRmx1c2hlZENhbGxiYWNrc1BlclBhZ2Uua2V5cygpKSkgeworICAgICAgICBhdXRvIGNhbGxi YWNrID0gbV9wZW5kaW5nTW91c2VFdmVudHNGbHVzaGVkQ2FsbGJhY2tzUGVyUGFnZS50YWtlKGlk ZW50aWZpZXIpOworICAgICAgICBjYWxsYmFjayhBVVRPTUFUSU9OX0NPTU1BTkRfRVJST1JfV0lU SF9OQU1FKEludGVybmFsRXJyb3IpKTsKKyAgICB9CisKICNpZiBFTkFCTEUoUkVNT1RFX0lOU1BF Q1RPUikKICAgICBpZiAoSW5zcGVjdG9yOjpGcm9udGVuZENoYW5uZWwqIGNoYW5uZWwgPSBtX3Jl bW90ZUNoYW5uZWwpIHsKICAgICAgICAgbV9yZW1vdGVDaGFubmVsID0gbnVsbHB0cjsK