190256 2018-10-03 11:49:25 -0700 [Cocoa] REGRESSION: web content process paused in debugger is considered to be unresponsive if WebKit client is sandboxed 2018-10-07 19:59:55 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg ap bburg commit-queue darin joepeck mitz webkit-bug-importer oldest_to_newest 1466141 0 bburg 2018-10-03 11:49:25 -0700 We can do a better job. 1466142 1 bburg 2018-10-03 11:49:41 -0700 <rdar://problem/44957921> 1466144 2 351540 bburg 2018-10-03 12:04:52 -0700 Created attachment 351540 Patch 1466173 3 351540 commit-queue 2018-10-03 14:02:28 -0700 Comment on attachment 351540 Patch Clearing flags on attachment: 351540 Committed r236810: <https://trac.webkit.org/changeset/236810> 1466174 4 commit-queue 2018-10-03 14:02:29 -0700 All reviewed patches have been landed. Closing bug. 1466982 5 351540 darin 2018-10-07 19:59:55 -0700 Comment on attachment 351540 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351540&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm:140 > + // If the UI process is sandboxed and lacks 'process-info-pidinfo', it cannot find out whether other processes are being debugged. > + if (currentProcessIsSandboxed() && !!sandbox_check(getpid(), "process-info-pidinfo", SANDBOX_CHECK_NO_REPORT)) Why do we need the "currentProcessIsSandboxed()" check? Wouldn’t the second call to sandbox_check do the right thing on its own? Separate smaller comment: It doesn’t seem helpful to include the !! in this boolean expression. 351540 2018-10-03 12:04:52 -0700 2018-10-03 14:02:28 -0700 Patch bug-190256-20181003120452.patch text/plain 2262 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Nzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVmOTQ0NzQyMzMyYmM4ODg5 MmU0NzQzMDc2OGEwMDQyOTdmNDYwODIuLjYxNDI3NWY3YzFkOTE4YWE0ZDVjNzFlN2JkOWJlMWVm M2U2OTI1NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMTAtMDMgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBSRUdSRVNTSU9OOiB3ZWIg Y29udGVudCBwcm9jZXNzIHBhdXNlZCBpbiBkZWJ1Z2dlciBpcyBjb25zaWRlcmVkIHRvIGJlIHVu cmVzcG9uc2l2ZSBpZiBXZWJLaXQgY2xpZW50IGlzIHNhbmRib3hlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjU2CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS80NDk1NzkyMT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbnN0ZWFkIG9mIGdpdmluZyB1cCB3aGVuIHRoZSBjbGllbnQgaXMgc2FuZGJv eGVkLCBjaGVjayB3aGV0aGVyIGl0IGhhcyB0aGUKKyAgICAgICAgZXhjZXB0aW9uIHRoYXQncyBu ZWNlc3NhcnkgdG8gZ2V0IHByb2Nlc3MgaW5mb3JtYXRpb24uIElmIGl0IGlzIHBvc3NpYmxlLAor ICAgICAgICBwcm9jZWVkIHRvIGNoZWNrIHdoZXRoZXIgdGhlIHdlYiBjb250ZW50IHByb2Nlc3Mg aGFzIGEgZGVidWdnZXIgYXR0YWNoZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2Vi UHJvY2Vzc1Byb3h5Q29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6 cGxhdGZvcm1Jc0JlaW5nRGVidWdnZWQgY29uc3QpOgorICAgICAgICBDaGVjayAncHJvY2Vzcy1p bmZvLXBpZGluZm8nIHRvIHNlZSBpZiB0aGUgc3lzY3RsIGNhbGwgd291bGQgYmUgYWxsb3dlZC4K KwogMjAxOC0xMC0wMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAg W21hY09TXSBTd2l0Y2hpbmcgdG8gZGlzY3JldGUgR1BVIHNob3VsZCBiZSBkb25lIGluIHRoZSBV SSBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQ cm9jZXNzUHJveHlDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBy b2Nlc3NQcm94eUNvY29hLm1tCmluZGV4IDU4YzQ2YTBkMzcyYTYyMTQ1YmFjYTc0NTcyOWQzZDNk MDFkMzFkYTAuLjMwMzYwMGI5ZWM1NjJmODlhYmIzNTk5NGRhODg0ZjJiZWJlNjVlMGIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQcm94eUNvY29h Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQcm94eUNv Y29hLm1tCkBAIC0zNyw2ICszNyw3IEBACiAjaW1wb3J0ICJXZWJQcm9jZXNzUG9vbC5oIgogI2lt cG9ydCA8c3lzL3N5c2N0bC5oPgogI2ltcG9ydCA8d3RmL05ldmVyRGVzdHJveWVkLmg+CisjaW1w b3J0IDx3dGYvc3BpL2Rhcndpbi9TYW5kYm94U1BJLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewog CkBAIC0xMzUsOCArMTM2LDggQEAgUmVmUHRyPE9iakNPYmplY3RHcmFwaD4gV2ViUHJvY2Vzc1By b3h5Ojp0cmFuc2Zvcm1PYmplY3RzVG9IYW5kbGVzKE9iakNPYmplY3RHcmEKIAogYm9vbCBXZWJQ cm9jZXNzUHJveHk6OnBsYXRmb3JtSXNCZWluZ0RlYnVnZ2VkKCkgY29uc3QKIHsKLSAgICAvLyBJ ZiB0aGUgVUkgcHJvY2VzcyBpcyBzYW5kYm94ZWQsIGl0IGNhbm5vdCBmaW5kIG91dCB3aGV0aGVy IG90aGVyIHByb2Nlc3NlcyBhcmUgYmVpbmcgZGVidWdnZWQuCi0gICAgaWYgKGN1cnJlbnRQcm9j ZXNzSXNTYW5kYm94ZWQoKSkKKyAgICAvLyBJZiB0aGUgVUkgcHJvY2VzcyBpcyBzYW5kYm94ZWQg YW5kIGxhY2tzICdwcm9jZXNzLWluZm8tcGlkaW5mbycsIGl0IGNhbm5vdCBmaW5kIG91dCB3aGV0 aGVyIG90aGVyIHByb2Nlc3NlcyBhcmUgYmVpbmcgZGVidWdnZWQuCisgICAgaWYgKGN1cnJlbnRQ cm9jZXNzSXNTYW5kYm94ZWQoKSAmJiAhIXNhbmRib3hfY2hlY2soZ2V0cGlkKCksICJwcm9jZXNz LWluZm8tcGlkaW5mbyIsIFNBTkRCT1hfQ0hFQ0tfTk9fUkVQT1JUKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogCiAgICAgc3RydWN0IGtpbmZvX3Byb2MgaW5mbzsK