190252 2018-10-03 09:54:30 -0700 Regression(r236779): Crash when changing the input element type from inside an 'input' event listener 2018-10-04 12:40:53 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 190223 1 cdumez cdumez achristensen cdumez commit-queue darin dbates ggaren rniwa webkit-bug-importer oldest_to_newest 1466094 0 cdumez 2018-10-03 09:54:30 -0700 Crash when changing the input element type from inside an 'input' event listener: Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [7691] VM Regions Near 0: --> __TEXT 000000010eb67000-000000010eb69000 [ 8K] r-x/rwx SM=COW /Volumes/VOLUME/*/WebKit.framework/Versions/A/XPCServices/com.apple.WebKit.WebContent.xpc/Contents/MacOS/com.apple.WebKit.WebContent.Development Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000006ca50e32e WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent() + 30 (HTMLTextFormControlElement.cpp:211) 1 com.apple.WebCore 0x00000006ca35c518 WebCore::BaseCheckableInputType::fireInputAndChangeEvents() + 200 (BaseCheckableInputType.cpp:133) 2 com.apple.WebCore 0x00000006ca361bcc WebCore::CheckboxInputType::didDispatchClick(WebCore::Event&, WebCore::InputElementClickState const&) + 252 (CheckboxInputType.cpp:92) 3 com.apple.WebCore 0x00000006ca4281a1 WebCore::HTMLInputElement::didDispatchClickEvent(WebCore::Event&, WebCore::InputElementClickState const&) + 81 (HTMLInputElement.cpp:1128) 4 com.apple.WebCore 0x00000006ca0f2a06 WebCore::EventDispatcher::dispatchEvent(WebCore::Node&, WebCore::Event&) + 614 (EventDispatcher.cpp:165) 5 com.apple.WebCore 0x00000006ca15d2dd WebCore::Node::dispatchEvent(WebCore::Event&) + 29 (Node.cpp:2383) 6 com.apple.WebCore 0x00000006ca1dbfa5 WebCore::simulateMouseEvent(WTF::AtomicString const&, WebCore::Element&, WebCore::Event*, WebCore::SimulatedClickSource) + 149 (SimulatedClick.cpp:79) 7 com.apple.WebCore 0x00000006ca1dbe94 WebCore::simulateClick(WebCore::Element&, WebCore::Event*, WebCore::SimulatedClickMouseEventOptions, WebCore::SimulatedClickVisualOptions, WebCore::SimulatedClickSource) + 436 (SimulatedClick.cpp:101) 8 com.apple.WebCore 0x00000006ca3d8112 WebCore::HTMLElement::click() + 34 (HTMLElement.cpp:695) 9 com.apple.WebCore 0x00000006c8ab80ea WebCore::jsHTMLElementPrototypeFunctionClickBody(JSC::ExecState*, WebCore::JSHTMLElement*, JSC::ThrowScope&) + 42 (JSHTMLElement.cpp:3118) 10 com.apple.WebCore 0x00000006c8a7c906 long long WebCore::IDLOperation<WebCore::JSHTMLElement>::call<&(WebCore::jsHTMLElementPrototypeFunctionClickBody(JSC::ExecState*, WebCore::JSHTMLElement*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) + 742 (JSDOMOperation.h:53) 1466095 1 351529 cdumez 2018-10-03 10:00:06 -0700 Created attachment 351529 Patch 1466132 2 351529 commit-queue 2018-10-03 11:26:39 -0700 Comment on attachment 351529 Patch Clearing flags on attachment: 351529 Committed r236803: <https://trac.webkit.org/changeset/236803> 1466133 3 commit-queue 2018-10-03 11:26:41 -0700 All reviewed patches have been landed. Closing bug. 1466134 4 webkit-bug-importer 2018-10-03 11:27:45 -0700 <rdar://problem/44980354> 1466406 5 cdumez 2018-10-04 10:52:48 -0700 Reverted r236803 for reason: Caused crashes on some bots Committed r236837: <https://trac.webkit.org/changeset/236837> 1466408 6 351602 cdumez 2018-10-04 10:54:07 -0700 Created attachment 351602 Patch 1466409 7 351602 cdumez 2018-10-04 10:54:28 -0700 Comment on attachment 351602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351602&action=review > Source/WebCore/html/BaseCheckableInputType.cpp:130 > + auto protectedThis = makeRef(*this); Previous iteration was missing this protectedThis. 1466449 8 351602 achristensen 2018-10-04 12:19:37 -0700 Comment on attachment 351602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351602&action=review > Source/WebCore/html/BaseCheckableInputType.cpp:134 > + if (auto* element = this->element()) > + element->dispatchFormControlChangeEvent(); It seems like this is a general JavaScript re-entry problem. Maybe this should be done on the next runloop iteration? 1466464 9 cdumez 2018-10-04 12:29:59 -0700 (In reply to Alex Christensen from comment #8) > Comment on attachment 351602 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=351602&action=review > > > Source/WebCore/html/BaseCheckableInputType.cpp:134 > > + if (auto* element = this->element()) > > + element->dispatchFormControlChangeEvent(); > > It seems like this is a general JavaScript re-entry problem. Maybe this > should be done on the next runloop iteration? I do not think this would be Web-compliant as it would be observable. Note that protecting |this| and null-checking element() is how the InputType code is currently dealing with this so my patch is consistent with existing code. 1466465 10 351602 cdumez 2018-10-04 12:31:21 -0700 Comment on attachment 351602 Patch Clearing flags on attachment: 351602 Committed r236841: <https://trac.webkit.org/changeset/236841> 1466466 11 cdumez 2018-10-04 12:31:24 -0700 All reviewed patches have been landed. Closing bug. 1466470 12 351602 ggaren 2018-10-04 12:40:53 -0700 Comment on attachment 351602 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351602&action=review >>> Source/WebCore/html/BaseCheckableInputType.cpp:134 >>> + element->dispatchFormControlChangeEvent(); >> >> It seems like this is a general JavaScript re-entry problem. Maybe this should be done on the next runloop iteration? > > I do not think this would be Web-compliant as it would be observable. > > Note that protecting |this| and null-checking element() is how the InputType code is currently dealing with this so my patch is consistent with existing code. Though some parts of WebCore -- like layout -- forbid JavaScript execution, the default condition in WebCore is that it is generally possible, acceptable, and required to allow JavaScript execution. 351529 2018-10-03 10:00:06 -0700 2018-10-04 10:54:05 -0700 Patch bug-190252-20181003100005.patch text/plain 6244 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY5ZTE1YmJkMDAzZDA5 ZWQ2NDkyN2UzY2ViMTIyODQ4NDhkYzI4Yi4uNjA2OGFjZmY5Nzg4MTNmMjhlNWUwNTUxNWMzYTE5 NTc4NDU0ZDYyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjM2Nzc5 KTogQ3Jhc2ggd2hlbiBjaGFuZ2luZyB0aGUgaW5wdXQgZWxlbWVudCB0eXBlIGZyb20gaW5zaWRl IGFuICdpbnB1dCcgZXZlbnQgbGlzdGVuZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MDI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgZm9yIGVsZW1lbnQoKSBhZnRlciBm aXJpbmcgdGhlICdpbnB1dCcgZXZlbnQgYW5kIGJlZm9yZSBmaXJpbmcgdGhlICdjaGFuZ2UnIGV2 ZW50CisgICAgICAgIGluIGNhc2UgdGhlIGlucHV0IGV2ZW50IGxpc3RlbmVyIGNoYW5nZXMgdGhl IGlucHV0IHR5cGUuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQv Y2hhbmdlLXR5cGUtaW4tY2xpY2stZXZlbnQtbGlzdGVuZXIuaHRtbAorICAgICAgICAgICAgICAg ZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1dC1ldmVudC1saXN0 ZW5lci5odG1sCisKKyAgICAgICAgKiBodG1sL0Jhc2VDaGVja2FibGVJbnB1dFR5cGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QmFzZUNoZWNrYWJsZUlucHV0VHlwZTo6ZmlyZUlucHV0QW5kQ2hh bmdlRXZlbnRzKToKKwogMjAxOC0xMC0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIGlucHV0LmNoZWNrZWQgaXMgaW5jb3JyZWN0IHdoaWxlIHdlJ3JlIHBhcnNp bmcgaXRzIGNoaWxkcmVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaGVj a2FibGVJbnB1dFR5cGUuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9CYXNlQ2hlY2thYmxlSW5w dXRUeXBlLmNwcAppbmRleCA0NDAzZDYwYjQxZWUxMmYzOTQzNzMwYmYzYjViNDBmZWEyM2M0NzQ0 Li43MzUwZTdlZDllNjllMTU3NmRlNDhhZWY0ZTIzMTNmNjdkMzEyYzk5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaGVja2FibGVJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvQmFzZUNoZWNrYWJsZUlucHV0VHlwZS5jcHAKQEAgLTEyOSw3ICsxMjks OCBAQCB2b2lkIEJhc2VDaGVja2FibGVJbnB1dFR5cGU6OmZpcmVJbnB1dEFuZENoYW5nZUV2ZW50 cygpCiAKICAgICBlbGVtZW50KCktPnNldFRleHRBc09mTGFzdEZvcm1Db250cm9sQ2hhbmdlRXZl bnQoU3RyaW5nKCkpOwogICAgIGVsZW1lbnQoKS0+ZGlzcGF0Y2hJbnB1dEV2ZW50KCk7Ci0gICAg ZWxlbWVudCgpLT5kaXNwYXRjaEZvcm1Db250cm9sQ2hhbmdlRXZlbnQoKTsKKyAgICBpZiAoYXV0 byogZWxlbWVudCA9IHRoaXMtPmVsZW1lbnQoKSkKKyAgICAgICAgZWxlbWVudC0+ZGlzcGF0Y2hG b3JtQ29udHJvbENoYW5nZUV2ZW50KCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCAwNGU1ZDRjMDM1ZmE2MWNmZDY1MmMyMjEyZWNmZjgzZTIwYzczMmVjLi41ZDRmZTU0Y2Mw MDFmMDFjZjc4NmM1NjJhYTVkZjVhMDU4ZTA2YjA0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTgtMTAtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdy ZXNzaW9uKHIyMzY3NzkpOiBDcmFzaCB3aGVuIGNoYW5naW5nIHRoZSBpbnB1dCBlbGVtZW50IHR5 cGUgZnJvbSBpbnNpZGUgYW4gJ2lucHV0JyBldmVudCBsaXN0ZW5lcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjUyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVyYWdl LgorCisgICAgICAgICogZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1j bGljay1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv ZG9tL0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4tY2xpY2stZXZlbnQtbGlzdGVuZXIu aHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2Ut dHlwZS1pbi1pbnB1dC1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4taW5wdXQtZXZlbnQt bGlzdGVuZXIuaHRtbDogQWRkZWQuCisKIDIwMTgtMTAtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBIMjY0IHNpbXVsY2FzdApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1j bGljay1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MSW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWNsaWNrLWV2ZW50LWxpc3RlbmVyLWV4cGVj dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi43NGM1ZjhiN2I4NDU4NmRmMTBkMTU5MDI2ODAxYzA3NDlkZGNi Y2IxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxl bWVudC9jaGFuZ2UtdHlwZS1pbi1jbGljay1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwxMCBAQAorTWFrZSBzdXJlIHdlIGRvIG5vdCBjcmFzaCBpZiB0aGUgJ2NsaWNrJyBl dmVudCBsaXN0ZW5lciBjaGFuZ2VzIHRoZSBpbnB1dCB0eXBlLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyBDbGljayBldmVudCB3YXMgZmlyZWQKK1BBU1Mgc3VjY2Vzc2Z1 bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWNsaWNrLWV2ZW50 LWxpc3RlbmVyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2No YW5nZS10eXBlLWluLWNsaWNrLWV2ZW50LWxpc3RlbmVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjI0NTZk ZGQxNjRmOGNiODc3YTA0YTIyNWJkNDY3ZDMyNTQ4NGIwZAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4tY2xpY2st ZXZlbnQtbGlzdGVuZXIuaHRtbApAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk1ha2Ug c3VyZSB3ZSBkbyBub3QgY3Jhc2ggaWYgdGhlICdjbGljaycgZXZlbnQgbGlzdGVuZXIgY2hhbmdl cyB0aGUgaW5wdXQgdHlwZS4iKTsKKworb25sb2FkID0gKCkgPT4geworICAgIHRlc3RJbnB1dC5h ZGRFdmVudExpc3RlbmVyKCJjbGljayIsICgpID0+IHsKKyAgICAgICAgdGVzdFBhc3NlZCgiQ2xp Y2sgZXZlbnQgd2FzIGZpcmVkIik7CisgICAgICAgIHRlc3RJbnB1dC50eXBlID0gInRleHQiOwor ICAgIH0pOworCisgICAgdGVzdElucHV0LmFkZEV2ZW50TGlzdGVuZXIoImlucHV0IiwgKCkgPT4g eworICAgICAgICB0ZXN0RmFpbGVkKCJpbnB1dCBldmVudCBzaG91bGQgbm90IGhhdmUgZmlyZWQi KTsKKyAgICB9KTsKKyAgICB0ZXN0SW5wdXQuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgKCkg PT4geworICAgICAgICB0ZXN0RmFpbGVkKCJjaGFuZ2UgZXZlbnQgc2hvdWxkIG5vdCBoYXZlIGZp cmVkIik7CisgICAgfSk7CisgICAgdGVzdElucHV0LmNsaWNrKCk7CisgICAgc2V0VGltZW91dChm aW5pc2hKU1Rlc3QsIDApOworfTsKKzwvc2NyaXB0PgorPGlucHV0IHR5cGU9ImNoZWNrYm94IiBp ZD0idGVzdElucHV0Ij48L2lucHV0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1dC1l dmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5w dXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWlucHV0LWV2ZW50LWxpc3RlbmVyLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi42MWEzNGJhNjZhZDJjZDNkNDMwNDMyZTg0ZTk0YTQ4OWM0YmNmMTJjCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9j aGFuZ2UtdHlwZS1pbi1pbnB1dC1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwxMCBAQAorTWFrZSBzdXJlIHdlIGRvIG5vdCBjcmFzaCBpZiB0aGUgJ2lucHV0JyBldmVudCBs aXN0ZW5lciBjaGFuZ2VzIHRoZSBpbnB1dCB0eXBlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworUEFTUyBJbnB1dCBldmVudCB3YXMgZmlyZWQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWlucHV0LWV2ZW50LWxpc3Rl bmVyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10 eXBlLWluLWlucHV0LWV2ZW50LWxpc3RlbmVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjA1ZGExZjVkMWUz Zjc0MWUzMWYxYjExNDQ5MWFiYzVmNDRmNDcxNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4taW5wdXQtZXZlbnQt bGlzdGVuZXIuaHRtbApAQCAtMCwwICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk1ha2Ugc3VyZSB3 ZSBkbyBub3QgY3Jhc2ggaWYgdGhlICdpbnB1dCcgZXZlbnQgbGlzdGVuZXIgY2hhbmdlcyB0aGUg aW5wdXQgdHlwZS4iKTsKKworb25sb2FkID0gKCkgPT4geworICAgIHRlc3RJbnB1dC5hZGRFdmVu dExpc3RlbmVyKCJpbnB1dCIsICgpID0+IHsKKyAgICAgICAgdGVzdFBhc3NlZCgiSW5wdXQgZXZl bnQgd2FzIGZpcmVkIik7CisgICAgICAgIHRlc3RJbnB1dC50eXBlID0gInRleHQiOworICAgIH0p OworICAgIHRlc3RJbnB1dC5hZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCAoKSA9PiB7CisgICAg ICAgIHRlc3RGYWlsZWQoImNoYW5nZSBldmVudCBzaG91bGQgbm90IGhhdmUgZmlyZWQiKTsKKyAg ICB9KTsKKyAgICB0ZXN0SW5wdXQuY2xpY2soKTsKKyAgICBzZXRUaW1lb3V0KGZpbmlzaEpTVGVz dCwgMCk7Cit9OworPC9zY3JpcHQ+Cis8aW5wdXQgdHlwZT0iY2hlY2tib3giIGlkPSJ0ZXN0SW5w dXQiPjwvaW5wdXQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg== 351602 2018-10-04 10:54:07 -0700 2018-10-04 12:31:21 -0700 Patch bug-190252-20181004105405.patch text/plain 6340 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGQzODVlNzFlZDhmMjUz OGMyZTU4OWRkMDkzMWEwZmM3MWNmNzgwMC4uMmQ5MDQ1MWQ4N2RiNmIwOTkxZjdmODA3MDVlZTJl YWY5YzVhNzUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTA0ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbihyMjM2Nzc5 KTogQ3Jhc2ggd2hlbiBjaGFuZ2luZyB0aGUgaW5wdXQgZWxlbWVudCB0eXBlIGZyb20gaW5zaWRl IGFuICdpbnB1dCcgZXZlbnQgbGlzdGVuZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5MDI1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBhIG51bGwgY2hlY2sgZm9yIGVsZW1lbnQoKSBhZnRlciBm aXJpbmcgdGhlICdpbnB1dCcgZXZlbnQgYW5kIGJlZm9yZSBmaXJpbmcgdGhlICdjaGFuZ2UnIGV2 ZW50CisgICAgICAgIGluIGNhc2UgdGhlIGlucHV0IGV2ZW50IGxpc3RlbmVyIGNoYW5nZXMgdGhl IGlucHV0IHR5cGUuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQv Y2hhbmdlLXR5cGUtaW4tY2xpY2stZXZlbnQtbGlzdGVuZXIuaHRtbAorICAgICAgICAgICAgICAg ZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1dC1ldmVudC1saXN0 ZW5lci5odG1sCisKKyAgICAgICAgKiBodG1sL0Jhc2VDaGVja2FibGVJbnB1dFR5cGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QmFzZUNoZWNrYWJsZUlucHV0VHlwZTo6ZmlyZUlucHV0QW5kQ2hh bmdlRXZlbnRzKToKKwogMjAxOC0xMC0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzY4MDMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaGVja2FibGVJbnB1dFR5cGUuY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9CYXNlQ2hlY2thYmxlSW5wdXRUeXBlLmNwcAppbmRleCA0NDAzZDYwYjQx ZWUxMmYzOTQzNzMwYmYzYjViNDBmZWEyM2M0NzQ0Li4xNGZhMjQ4ZTYyNTFlOTFjMzhiOWFlMjA5 YTg2N2RiYTc2YTkxZmMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Jhc2VDaGVj a2FibGVJbnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvQmFzZUNoZWNrYWJs ZUlucHV0VHlwZS5jcHAKQEAgLTEyNyw5ICsxMjcsMTEgQEAgdm9pZCBCYXNlQ2hlY2thYmxlSW5w dXRUeXBlOjpmaXJlSW5wdXRBbmRDaGFuZ2VFdmVudHMoKQogICAgIGlmICghc2hvdWxkU2VuZENo YW5nZUV2ZW50QWZ0ZXJDaGVja2VkQ2hhbmdlZCgpKQogICAgICAgICByZXR1cm47CiAKKyAgICBh dXRvIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKTsKICAgICBlbGVtZW50KCktPnNldFRl eHRBc09mTGFzdEZvcm1Db250cm9sQ2hhbmdlRXZlbnQoU3RyaW5nKCkpOwogICAgIGVsZW1lbnQo KS0+ZGlzcGF0Y2hJbnB1dEV2ZW50KCk7Ci0gICAgZWxlbWVudCgpLT5kaXNwYXRjaEZvcm1Db250 cm9sQ2hhbmdlRXZlbnQoKTsKKyAgICBpZiAoYXV0byogZWxlbWVudCA9IHRoaXMtPmVsZW1lbnQo KSkKKyAgICAgICAgZWxlbWVudC0+ZGlzcGF0Y2hGb3JtQ29udHJvbENoYW5nZUV2ZW50KCk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNjllNjYxYTY5ZTY2MjhkNzM1MTk1 MzI0ZDk3Zjk3MTYxOTczYjFjLi4xZjdkYWIzOGQ5ZTNhMDNlYzkwZjI4YmNiZjI1Zjk4YjBmOTBk NGZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMTAtMDQgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyMzY3NzkpOiBDcmFzaCB3aGVu IGNoYW5naW5nIHRoZSBpbnB1dCBlbGVtZW50IHR5cGUgZnJvbSBpbnNpZGUgYW4gJ2lucHV0JyBl dmVudCBsaXN0ZW5lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTkwMjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVyYWdlLgorCisgICAgICAgICogZmFzdC9kb20vSFRN TElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1jbGljay1ldmVudC1saXN0ZW5lci1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdl LXR5cGUtaW4tY2xpY2stZXZlbnQtbGlzdGVuZXIuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1dC1ldmVudC1saXN0ZW5l ci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxJbnB1dEVsZW1l bnQvY2hhbmdlLXR5cGUtaW4taW5wdXQtZXZlbnQtbGlzdGVuZXIuaHRtbDogQWRkZWQuCisKIDIw MTgtMTAtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjM2ODAzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1jbGljay1ldmVudC1saXN0ZW5l ci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2No YW5nZS10eXBlLWluLWNsaWNrLWV2ZW50LWxpc3RlbmVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li43NGM1ZjhiN2I4NDU4NmRmMTBkMTU5MDI2ODAxYzA3NDlkZGNiY2IxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1p bi1jbGljay1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAorTWFr ZSBzdXJlIHdlIGRvIG5vdCBjcmFzaCBpZiB0aGUgJ2NsaWNrJyBldmVudCBsaXN0ZW5lciBjaGFu Z2VzIHRoZSBpbnB1dCB0eXBlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMg b2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFT UyBDbGljayBldmVudCB3YXMgZmlyZWQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK KworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1M SW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWNsaWNrLWV2ZW50LWxpc3RlbmVyLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWNsaWNr LWV2ZW50LWxpc3RlbmVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjI0NTZkZGQxNjRmOGNiODc3YTA0YTIy NWJkNDY3ZDMyNTQ4NGIwZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9t L0hUTUxJbnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4tY2xpY2stZXZlbnQtbGlzdGVuZXIuaHRt bApAQCAtMCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk1ha2Ugc3VyZSB3ZSBkbyBub3QgY3Jh c2ggaWYgdGhlICdjbGljaycgZXZlbnQgbGlzdGVuZXIgY2hhbmdlcyB0aGUgaW5wdXQgdHlwZS4i KTsKKworb25sb2FkID0gKCkgPT4geworICAgIHRlc3RJbnB1dC5hZGRFdmVudExpc3RlbmVyKCJj bGljayIsICgpID0+IHsKKyAgICAgICAgdGVzdFBhc3NlZCgiQ2xpY2sgZXZlbnQgd2FzIGZpcmVk Iik7CisgICAgICAgIHRlc3RJbnB1dC50eXBlID0gInRleHQiOworICAgIH0pOworCisgICAgdGVz dElucHV0LmFkZEV2ZW50TGlzdGVuZXIoImlucHV0IiwgKCkgPT4geworICAgICAgICB0ZXN0RmFp bGVkKCJpbnB1dCBldmVudCBzaG91bGQgbm90IGhhdmUgZmlyZWQiKTsKKyAgICB9KTsKKyAgICB0 ZXN0SW5wdXQuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgKCkgPT4geworICAgICAgICB0ZXN0 RmFpbGVkKCJjaGFuZ2UgZXZlbnQgc2hvdWxkIG5vdCBoYXZlIGZpcmVkIik7CisgICAgfSk7Cisg ICAgdGVzdElucHV0LmNsaWNrKCk7CisgICAgc2V0VGltZW91dChmaW5pc2hKU1Rlc3QsIDApOwor fTsKKzwvc2NyaXB0PgorPGlucHV0IHR5cGU9ImNoZWNrYm94IiBpZD0idGVzdElucHV0Ij48L2lu cHV0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20v SFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1dC1ldmVudC1saXN0ZW5lci1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10 eXBlLWluLWlucHV0LWV2ZW50LWxpc3RlbmVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42MWEz NGJhNjZhZDJjZDNkNDMwNDMyZTg0ZTk0YTQ4OWM0YmNmMTJjCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTElucHV0RWxlbWVudC9jaGFuZ2UtdHlwZS1pbi1pbnB1 dC1ldmVudC1saXN0ZW5lci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAorTWFrZSBzdXJl IHdlIGRvIG5vdCBjcmFzaCBpZiB0aGUgJ2lucHV0JyBldmVudCBsaXN0ZW5lciBjaGFuZ2VzIHRo ZSBpbnB1dCB0eXBlLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBJbnB1 dCBldmVudCB3YXMgZmlyZWQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVT VCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRF bGVtZW50L2NoYW5nZS10eXBlLWluLWlucHV0LWV2ZW50LWxpc3RlbmVyLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MSW5wdXRFbGVtZW50L2NoYW5nZS10eXBlLWluLWlucHV0LWV2ZW50 LWxpc3RlbmVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNjA1ZGExZjVkMWUzZjc0MWUzMWYxYjExNDQ5MWFi YzVmNDRmNDcxNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxJ bnB1dEVsZW1lbnQvY2hhbmdlLXR5cGUtaW4taW5wdXQtZXZlbnQtbGlzdGVuZXIuaHRtbApAQCAt MCwwICsxLDI0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNy Yz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJv ZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIk1ha2Ugc3VyZSB3ZSBkbyBub3QgY3Jhc2ggaWYg dGhlICdpbnB1dCcgZXZlbnQgbGlzdGVuZXIgY2hhbmdlcyB0aGUgaW5wdXQgdHlwZS4iKTsKKwor b25sb2FkID0gKCkgPT4geworICAgIHRlc3RJbnB1dC5hZGRFdmVudExpc3RlbmVyKCJpbnB1dCIs ICgpID0+IHsKKyAgICAgICAgdGVzdFBhc3NlZCgiSW5wdXQgZXZlbnQgd2FzIGZpcmVkIik7Cisg ICAgICAgIHRlc3RJbnB1dC50eXBlID0gInRleHQiOworICAgIH0pOworICAgIHRlc3RJbnB1dC5h ZGRFdmVudExpc3RlbmVyKCJjaGFuZ2UiLCAoKSA9PiB7CisgICAgICAgIHRlc3RGYWlsZWQoImNo YW5nZSBldmVudCBzaG91bGQgbm90IGhhdmUgZmlyZWQiKTsKKyAgICB9KTsKKyAgICB0ZXN0SW5w dXQuY2xpY2soKTsKKyAgICBzZXRUaW1lb3V0KGZpbmlzaEpTVGVzdCwgMCk7Cit9OworPC9zY3Jp cHQ+Cis8aW5wdXQgdHlwZT0iY2hlY2tib3giIGlkPSJ0ZXN0SW5wdXQiPjwvaW5wdXQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==