190251 2018-10-03 09:41:40 -0700 Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener 2018-10-10 09:32:12 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 cdumez cdumez achristensen cdumez commit-queue darin ggaren rniwa webkit-bug-importer youennf oldest_to_newest 1466091 0 cdumez 2018-10-03 09:41:40 -0700 Passing noopener=NOOPENER to window.open() should cause the new window to not have an opener, similarly to noopener=1: - https://html.spec.whatwg.org/#window-open-steps (step 5) It does not matter what the value is, if there is a key named "noopener", then the new window should not have an opener. 1466092 1 351528 cdumez 2018-10-03 09:43:54 -0700 Created attachment 351528 Patch 1466129 2 351528 commit-queue 2018-10-03 11:24:03 -0700 Comment on attachment 351528 Patch Clearing flags on attachment: 351528 Committed r236802: <https://trac.webkit.org/changeset/236802> 1466130 3 commit-queue 2018-10-03 11:24:05 -0700 All reviewed patches have been landed. Closing bug. 1466131 4 webkit-bug-importer 2018-10-03 11:25:29 -0700 <rdar://problem/44980240> 1466981 5 351528 darin 2018-10-07 19:57:03 -0700 Comment on attachment 351528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351528&action=review > Source/WebCore/page/WindowFeatures.cpp:161 > else if (equalLettersIgnoringASCIICase(key, "noopener")) > - features.noopener = numericValue; > + features.noopener = true; So even values like "0" and "no" mean yes? Do we have test coverage for those kinds of values? Also seems that other boolean keys like menubar, toolbar, location, status, fullscreen, and scrollbars might need similar treatment. Would be good to make sure we have tests and make sure those are also right. 1467040 6 351528 cdumez 2018-10-08 08:08:35 -0700 Comment on attachment 351528 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351528&action=review >> Source/WebCore/page/WindowFeatures.cpp:161 >> + features.noopener = true; > > So even values like "0" and "no" mean yes? Do we have test coverage for those kinds of values? > > Also seems that other boolean keys like menubar, toolbar, location, status, fullscreen, and scrollbars might need similar treatment. Would be good to make sure we have tests and make sure those are also right. Yes, even values like "0" and "no" enable no opener as per the special case in the spec: https://html.spec.whatwg.org/#window-open-steps (step 5): Let noopener be true if tokenizedFeatures contains an entry with the key "noopener". imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html contains extensive testing for noopener, including "0" / "false" values. The other keys you mention (like menubar) are currently missing from the spec: - https://github.com/whatwg/html/issues/2464 However, other browsers seem to treat them like regular booleans so I do not think we should align them with noopener. AFAICT, noopener is the exception but I am not quite sure why (will comment on the spec). 1467734 7 cdumez 2018-10-10 09:30:13 -0700 Reverted r236802 for reason: Working on getting the HTML spec updated instead (https://github.com/whatwg/html/pull/4079) Committed r237002: <https://trac.webkit.org/changeset/237002> 351528 2018-10-03 09:43:54 -0700 2018-10-03 11:24:03 -0700 Patch bug-190251-20181003094353.patch text/plain 4902 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY5ZTE1YmJkMDAzZDA5 ZWQ2NDkyN2UzY2ViMTIyODQ4NDhkYzI4Yi4uMDZiZTY2ZWI2MTFiZTMyZDkzZmU0Mzg5NzBlMzQ2 Njg4MDhiYTIwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE4LTEwLTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUGFzc2luZyBub29wZW5lcj1O T09QRU5FUiB0byB3aW5kb3cub3BlbigpIHNob3VsZCBjYXVzZSB0aGUgbmV3IHdpbmRvdyB0byBu b3QgaGF2ZSBhbiBvcGVuZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE5MDI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFBhc3Npbmcgbm9vcGVuZXI9Tk9PUEVORVIgdG8gd2luZG93Lm9wZW4oKSBzaG91 bGQgY2F1c2UgdGhlIG5ldyB3aW5kb3cgdG8gbm90IGhhdmUgYW4gb3BlbmVyLAorICAgICAgICBz aW1pbGFybHkgdG8gbm9vcGVuZXI9MToKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3BlYy53aGF0 d2cub3JnLyN3aW5kb3ctb3Blbi1zdGVwcyAoc3RlcCA1KQorCisgICAgICAgIEl0IGRvZXMgbm90 IG1hdHRlciB3aGF0IHRoZSB2YWx1ZSBpcywgaWYgdGhlcmUgaXMgYSBrZXkgbmFtZWQgIm5vb3Bl bmVyIiwgdGhlbiB0aGUgbmV3IHdpbmRvdworICAgICAgICBzaG91bGQgbm90IGhhdmUgYW4gb3Bl bmVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4K KworICAgICAgICAqIHBhZ2UvV2luZG93RmVhdHVyZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 c2V0V2luZG93RmVhdHVyZSk6CisKIDIwMTgtMTAtMDMgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBpbnB1dC5jaGVja2VkIGlzIGluY29ycmVjdCB3aGlsZSB3ZSdy ZSBwYXJzaW5nIGl0cyBjaGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9X aW5kb3dGZWF0dXJlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dpbmRvd0ZlYXR1cmVzLmNw cAppbmRleCAwNjc2NDVjNzI1MWUyNTcxODAwNGJlYTU4MjAyZjUxNTU0MTM4ZDE1Li5iYmI2NmFh MTU5ZDhiZjEzODQ3NzNlM2Q4MjQ5ZjJhMjg3NjIxZDI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1dpbmRvd0ZlYXR1cmVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1dp bmRvd0ZlYXR1cmVzLmNwcApAQCAtMTU4LDcgKzE1OCw3IEBAIHN0YXRpYyB2b2lkIHNldFdpbmRv d0ZlYXR1cmUoV2luZG93RmVhdHVyZXMmIGZlYXR1cmVzLCBTdHJpbmdWaWV3IGtleSwgU3RyaW5n VmllCiAgICAgZWxzZSBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uoa2V5LCAic2Ny b2xsYmFycyIpKQogICAgICAgICBmZWF0dXJlcy5zY3JvbGxiYXJzVmlzaWJsZSA9IG51bWVyaWNW YWx1ZTsKICAgICBlbHNlIGlmIChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShrZXksICJu b29wZW5lciIpKQotICAgICAgICBmZWF0dXJlcy5ub29wZW5lciA9IG51bWVyaWNWYWx1ZTsKKyAg ICAgICAgZmVhdHVyZXMubm9vcGVuZXIgPSB0cnVlOwogICAgIGVsc2UgaWYgKG51bWVyaWNWYWx1 ZSA9PSAxKQogICAgICAgICBmZWF0dXJlcy5hZGRpdGlvbmFsRmVhdHVyZXMuYXBwZW5kKGtleS50 b1N0cmluZygpKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IGQyMWMwNTMy NGVlNjUyYTViMTU2YzYxMmY1Nzk0YmI5MTY5N2U1YTAuLjYyZDgwMzQwY2QwNDMwMzJhMmE2NjAz YWZjNzJjMjdhYzJjMzNlYmUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE0IEBACisyMDE4LTEwLTAzICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisK KyAgICAgICAgUGFzc2luZyBub29wZW5lcj1OT09QRU5FUiB0byB3aW5kb3cub3BlbigpIHNob3Vs ZCBjYXVzZSB0aGUgbmV3IHdpbmRvdyB0byBub3QgaGF2ZSBhbiBvcGVuZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI1MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUgV1BUIHRlc3Qg bm93IHRoYXQgaXQgaXMgcGFzc2luZy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9o dG1sL2Jyb3dzZXJzL3RoZS13aW5kb3ctb2JqZWN0L2FwaXMtZm9yLWNyZWF0aW5nLWFuZC1uYXZp Z2F0aW5nLWJyb3dzaW5nLWNvbnRleHRzLWJ5LW5hbWUvb3Blbi1mZWF0dXJlcy10b2tlbml6YXRp b24tbm9vcGVuZXItZXhwZWN0ZWQudHh0OgorCiAyMDE4LTEwLTAzICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgaW5wdXQuY2hlY2tlZCBpcyBpbmNvcnJlY3Qgd2hp bGUgd2UncmUgcGFyc2luZyBpdHMgY2hpbGRyZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2lt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9icm93c2Vycy90aGUtd2luZG93LW9i amVjdC9hcGlzLWZvci1jcmVhdGluZy1hbmQtbmF2aWdhdGluZy1icm93c2luZy1jb250ZXh0cy1i eS1uYW1lL29wZW4tZmVhdHVyZXMtdG9rZW5pemF0aW9uLW5vb3BlbmVyLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9icm93c2Vy cy90aGUtd2luZG93LW9iamVjdC9hcGlzLWZvci1jcmVhdGluZy1hbmQtbmF2aWdhdGluZy1icm93 c2luZy1jb250ZXh0cy1ieS1uYW1lL29wZW4tZmVhdHVyZXMtdG9rZW5pemF0aW9uLW5vb3BlbmVy LWV4cGVjdGVkLnR4dAppbmRleCBjN2Y3ZGM3MjQ1NTA3MWFjN2IzZmY2ODFmYThkYzk1ZGE5OTVl YTY0Li5hM2ExNGY2NmJlZjdiNjhmZmZhYTFmMzJkNzEzNjg0MDk0ZjE1NDQyIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvYnJvd3Nl cnMvdGhlLXdpbmRvdy1vYmplY3QvYXBpcy1mb3ItY3JlYXRpbmctYW5kLW5hdmlnYXRpbmctYnJv d3NpbmctY29udGV4dHMtYnktbmFtZS9vcGVuLWZlYXR1cmVzLXRva2VuaXphdGlvbi1ub29wZW5l ci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9odG1sL2Jyb3dzZXJzL3RoZS13aW5kb3ctb2JqZWN0L2FwaXMtZm9yLWNyZWF0aW5n LWFuZC1uYXZpZ2F0aW5nLWJyb3dzaW5nLWNvbnRleHRzLWJ5LW5hbWUvb3Blbi1mZWF0dXJlcy10 b2tlbml6YXRpb24tbm9vcGVuZXItZXhwZWN0ZWQudHh0CkBAIC0xLDEwICsxLDkgQEAKIAogUEFT UyB0b2tlbml6YXRpb24gc2hvdWxkIHNraXAgd2luZG93IGZlYXR1cmVzIHNlcGFyYXRvcnMgYmVm b3JlIGBuYW1lYCAKLUZBSUwgZmVhdHVyZSBgbmFtZWAgc2hvdWxkIGJlIGNvbnZlcnRlZCB0byBB U0NJSSBsb3dlcmNhc2UgYXNzZXJ0X2VxdWFsczogIm5vb3BlbmVyPU5PT1BFTkVSIiBzaG91bGQg YWN0aXZhdGUgZmVhdHVyZSAibm9vcGVuZXIiIGV4cGVjdGVkIG51bGwgYnV0IGdvdCBvYmplY3Qg IltvYmplY3QgV2luZG93XSIKK1BBU1MgZmVhdHVyZSBgbmFtZWAgc2hvdWxkIGJlIGNvbnZlcnRl ZCB0byBBU0NJSSBsb3dlcmNhc2UgCiBQQVNTIGFmdGVyIGBuYW1lYCwgdG9rZW5pemF0aW9uIHNo b3VsZCBza2lwIHdpbmRvdyBmZWF0dXJlcyBzZXBhcmF0b3JzIHRoYXQgYXJlIG5vdCAiPSIgb3Ig IiwiIAotRkFJTCBUb2tlbml6aW5nIHNob3VsZCBpZ25vcmUgd2luZG93IGZlYXR1cmUgc2VwYXJh dG9ycyBleGNlcHQgIiwiIGFmdGVyIGluaXRpYWwgIj0iIGFuZCBiZWZvcmUgdmFsdWUgYXNzZXJ0 X2VxdWFsczogIm5vb3BlbmVyCi09XHIgbm9vcGVuZXIsIiBzaG91bGQgYWN0aXZhdGUgZmVhdHVy ZSAibm9vcGVuZXIiIGV4cGVjdGVkIG51bGwgYnV0IGdvdCBvYmplY3QgIltvYmplY3QgV2luZG93 XSIKLUZBSUwgVG9rZW5pemluZyBzaG91bGQgcmVhZCBjaGFyYWN0ZXJzIHVudGlsIGZpcnN0IHdp bmRvdyBmZWF0dXJlIHNlcGFyYXRvciBhcyBgdmFsdWVgIGFzc2VydF9lcXVhbHM6ICJub29wZW5l cj1ub29wZW5lciIgc2hvdWxkIHNldCAibm9vcGVuZXIiIGV4cGVjdGVkIG51bGwgYnV0IGdvdCBv YmplY3QgIltvYmplY3QgV2luZG93XSIKLUZBSUwgIm5vb3BlbmVyIiBzaG91bGQgYmUgYmFzZWQg b24gbmFtZSAoa2V5KSwgbm90IHZhbHVlIGFzc2VydF9lcXVhbHM6ICJub29wZW5lcj1mYWxzZSIg c2hvdWxkIGFjdGl2YXRlIGZlYXR1cmUgIm5vb3BlbmVyIiBleHBlY3RlZCBudWxsIGJ1dCBnb3Qg b2JqZWN0ICJbb2JqZWN0IFdpbmRvd10iCitQQVNTIFRva2VuaXppbmcgc2hvdWxkIGlnbm9yZSB3 aW5kb3cgZmVhdHVyZSBzZXBhcmF0b3JzIGV4Y2VwdCAiLCIgYWZ0ZXIgaW5pdGlhbCAiPSIgYW5k IGJlZm9yZSB2YWx1ZSAKK1BBU1MgVG9rZW5pemluZyBzaG91bGQgcmVhZCBjaGFyYWN0ZXJzIHVu dGlsIGZpcnN0IHdpbmRvdyBmZWF0dXJlIHNlcGFyYXRvciBhcyBgdmFsdWVgIAorUEFTUyAibm9v cGVuZXIiIHNob3VsZCBiZSBiYXNlZCBvbiBuYW1lIChrZXkpLCBub3QgdmFsdWUgCiBQQVNTIGlu dmFsaWQgZmVhdHVyZSBuYW1lcyBzaG91bGQgbm90IHRva2VuaXplIGFzICJub29wZW5lciIgCiAK