190249 2018-10-03 07:58:42 -0700 [GTK][WPE] Incorrect rendering of layers whose backingStore hasn't changed 2018-10-04 08:34:51 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez aperez bugs-noreply cmarcelo commit-queue ews-watchlist kondapallykalyan luiz mcatanzaro noam zan oldest_to_newest 1466060 0 magomez 2018-10-03 07:58:42 -0700 CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly() sets m_nicosia.performLayerSync to true when the layer properties have changed and the layer needs to be synced. But after that, CoordinatedGraphicsLayer::updateContentBuffers() sets that value to false if the layer has backingStore that doesn't need to me modified. This causes that the layer properties are not synced if the backingStore isn't modified as well. 1466061 1 351519 magomez 2018-10-03 08:03:40 -0700 Created attachment 351519 Patch 1466062 2 351520 magomez 2018-10-03 08:09:50 -0700 Created attachment 351520 Patch 1466077 3 351520 commit-queue 2018-10-03 08:48:01 -0700 Comment on attachment 351520 Patch Clearing flags on attachment: 351520 Committed r236794: <https://trac.webkit.org/changeset/236794> 1466078 4 commit-queue 2018-10-03 08:48:02 -0700 All reviewed patches have been landed. Closing bug. 1466355 5 mcatanzaro 2018-10-04 06:29:51 -0700 Is this the commit that might fix bug #189743? Should this be added to https://trac.webkit.org/wiki/WebKitGTK/2.22.x for backport to 2.22? The Nicosia code has changed dramatically since branching, so I'm not sure without investigation. 1466358 6 aperez 2018-10-04 07:28:20 -0700 (In reply to Michael Catanzaro from comment #5) > Is this the commit that might fix bug #189743? > > Should this be added to https://trac.webkit.org/wiki/WebKitGTK/2.22.x for > backport to 2.22? The Nicosia code has changed dramatically since branching, > so I'm not sure without investigation. Yesterday I was chatting with Žan about this and found it that if we also merge the patch for bug #188693 beforehand, then this will apply cleanly on 2.22.x as well. And in that case we also will want the patch for bug #189224 to avoid hitting a performance regression. Note that I did *NOT* get to the point of trying to run a build with them applied, and only checked what would be the minimum needed to get this merged, in case we wanted. 1466359 7 mcatanzaro 2018-10-04 07:42:28 -0700 Is the bug this fixes present on 2.22? 1466362 8 magomez 2018-10-04 08:23:07 -0700 In which version is the youtube (In reply to Michael Catanzaro from comment #7) > Is the bug this fixes present on 2.22? This fixes a regression that was introduced by the fix to bug #188693, which I think is not in 2.22, so this won't fix anything in that release. 1466364 9 mcatanzaro 2018-10-04 08:34:51 -0700 Thanks Miguel. In that case, we surely don't need to backport this. 351519 2018-10-03 08:03:40 -0700 2018-10-03 08:09:47 -0700 Patch bug-190249-20181003170339.patch text/plain 1864 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjljMGRmZTE2Nzg5ZDZh ZTUzZjZkYzdiYjhkM2IzMTIzNGQyNTk0OS4uZmEzNmE2ZTJmYzQ1MTQwMWNmYjI3OGYxOTZlM2Ex YmVjNWJhODk5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTEwLTAzICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBJbmNv cnJlY3QgcmVuZGVyaW5nIG9mIGxheWVycyB3aG9zZSBiYWNraW5nU3RvcmUgaGFzbid0IGNoYW5n ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvIG5v dCBvdmVyd3JpdGUgbV9uaWNvc2lhLnBlcmZvcm1MYXllclN5bmMgd2hlbiB1cGRhdGluZyB0aGUg Y29udGVudCBidWZmZXJzIG9yIHdlIGxvc2UKKyAgICAgICAgdGhlIHZhbHVlIGNhbGN1bGF0ZWQg ZHVyaW5nIHRoZSBsYXllciBmbHVzaC4gVXNlIGFuIE9SIGluc3RlYWQgdG8ga2VlcCB0aGUgb2xk IHZhbHVlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjp1cGRhdGVDb250ZW50 QnVmZmVycyk6CisKIDIwMTgtMTAtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIEVuYWJsZSBIMjY0IHNpbXVsY2FzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3Jh cGhpY3NMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv Y29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAppbmRleCBmMjVjN2I4YTJi Mzk5YjhkYzczMDdmNzRiYjQzOTQ4NmUwZDgzY2UxLi4wZjZhZDY1NGUyNmYwYjA4YTliNDFiYzU2 NGU4OTNkYTNmZjkwZWUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29v cmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcApAQCAtODYxLDcgKzg2MSw3IEBAIHZvaWQgQ29vcmRp bmF0ZWRHcmFwaGljc0xheWVyOjp1cGRhdGVDb250ZW50QnVmZmVycygpCiAgICAgYXV0byBmaW5p c2hVcGRhdGUgPQogICAgICAgICBbdGhpcywgJmxheWVyU3RhdGVdIHsKICAgICAgICAgICAgIGF1 dG8mIHVwZGF0ZSA9IGxheWVyU3RhdGUudXBkYXRlOwotICAgICAgICAgICAgbV9uaWNvc2lhLnBl cmZvcm1MYXllclN5bmMgPSAhdXBkYXRlLnRpbGVzVG9DcmVhdGUuaXNFbXB0eSgpCisgICAgICAg ICAgICBtX25pY29zaWEucGVyZm9ybUxheWVyU3luYyB8PSAhdXBkYXRlLnRpbGVzVG9DcmVhdGUu aXNFbXB0eSgpCiAgICAgICAgICAgICAgICAgfHwgIXVwZGF0ZS50aWxlc1RvUmVtb3ZlLmlzRW1w dHkoKSB8fCAhdXBkYXRlLnRpbGVzVG9VcGRhdGUuaXNFbXB0eSgpOwogICAgICAgICAgICAgbGF5 ZXJTdGF0ZS5pc0ZsdXNoaW5nID0gZmFsc2U7CiAgICAgICAgIH07Cg== 351520 2018-10-03 08:09:50 -0700 2018-10-03 08:48:01 -0700 Patch bug-190249-20181003170949.patch text/plain 1839 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjljMGRmZTE2Nzg5ZDZh ZTUzZjZkYzdiYjhkM2IzMTIzNGQyNTk0OS4uOWI1MDg3Y2JlYzdlZWVhNmM0OTdlN2JlYTk5NzQw Y2ZlMzM3MTMyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTEwLTAzICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBJbmNv cnJlY3QgcmVuZGVyaW5nIG9mIGxheWVycyB3aG9zZSBiYWNraW5nU3RvcmUgaGFzbid0IGNoYW5n ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI0 OQorCisgICAgICAgIFJldmlld2VkIGJ5IMW9YW4gRG9iZXLFoWVrLgorCisgICAgICAgIERvIG5v dCBvdmVyd3JpdGUgbV9uaWNvc2lhLnBlcmZvcm1MYXllclN5bmMgd2hlbiB1cGRhdGluZyB0aGUg Y29udGVudCBidWZmZXJzIG9yIHdlIGxvc2UKKyAgICAgICAgdGhlIHZhbHVlIGNhbGN1bGF0ZWQg ZHVyaW5nIHRoZSBsYXllciBmbHVzaC4gVXNlIGFuIE9SIGluc3RlYWQgdG8ga2VlcCB0aGUgb2xk IHZhbHVlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVk L0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb29yZGlu YXRlZEdyYXBoaWNzTGF5ZXI6OnVwZGF0ZUNvbnRlbnRCdWZmZXJzKToKKwogMjAxOC0xMC0wMyAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIEgyNjQg c2ltdWxjYXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdy YXBoaWNzTGF5ZXIuY3BwCmluZGV4IGYyNWM3YjhhMmIzOTliOGRjNzMwN2Y3NGJiNDM5NDg2ZTBk ODNjZTEuLjBmNmFkNjU0ZTI2ZjBiMDhhOWI0MWJjNTY0ZTg5M2RhM2ZmOTBlZTEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3Bw CkBAIC04NjEsNyArODYxLDcgQEAgdm9pZCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnVwZGF0 ZUNvbnRlbnRCdWZmZXJzKCkKICAgICBhdXRvIGZpbmlzaFVwZGF0ZSA9CiAgICAgICAgIFt0aGlz LCAmbGF5ZXJTdGF0ZV0gewogICAgICAgICAgICAgYXV0byYgdXBkYXRlID0gbGF5ZXJTdGF0ZS51 cGRhdGU7Ci0gICAgICAgICAgICBtX25pY29zaWEucGVyZm9ybUxheWVyU3luYyA9ICF1cGRhdGUu dGlsZXNUb0NyZWF0ZS5pc0VtcHR5KCkKKyAgICAgICAgICAgIG1fbmljb3NpYS5wZXJmb3JtTGF5 ZXJTeW5jIHw9ICF1cGRhdGUudGlsZXNUb0NyZWF0ZS5pc0VtcHR5KCkKICAgICAgICAgICAgICAg ICB8fCAhdXBkYXRlLnRpbGVzVG9SZW1vdmUuaXNFbXB0eSgpIHx8ICF1cGRhdGUudGlsZXNUb1Vw ZGF0ZS5pc0VtcHR5KCk7CiAgICAgICAgICAgICBsYXllclN0YXRlLmlzRmx1c2hpbmcgPSBmYWxz ZTsKICAgICAgICAgfTsK