190240 2018-10-03 02:01:32 -0700 Clear m_pendingTargets in MutationObserver::takeRecords 2018-10-03 20:55:14 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ajuma cdumez darin dbates esprehn+autocc ews-watchlist ggaren joepeck kangil.han kondapallykalyan sam webkit-bug-importer oldest_to_newest 1465971 0 rniwa 2018-10-03 02:01:32 -0700 https://trac.webkit.org/r236781 delayed the clearing of m_pendingTargets until the end of microtask to avoid a race between JSMutationRecord's wrappers to be created and GC. Cleanup this code so that we don't have to delay the clearing until the end of Microtask. 1465973 1 351496 rniwa 2018-10-03 02:11:29 -0700 Created attachment 351496 Cleanup 1466198 2 351496 ggaren 2018-10-03 15:13:43 -0700 Comment on attachment 351496 Cleanup r=me Can you add a bindings test for this? Here are two alternative names to consider: [ResultField=records] [ResultExtractor=result.records] 1466296 3 webkit-bug-importer 2018-10-03 20:51:01 -0700 <rdar://problem/44997466> 1466297 4 rniwa 2018-10-03 20:52:14 -0700 (In reply to Geoffrey Garen from comment #2) > Comment on attachment 351496 [details] > Cleanup > > r=me > > Can you add a bindings test for this? Will do. > Here are two alternative names to consider: > > [ResultField=records] > [ResultExtractor=result.records] Will use ResultField. 1466299 5 rniwa 2018-10-03 20:55:14 -0700 Committed r236825: <https://trac.webkit.org/changeset/236825> 351496 2018-10-03 02:11:29 -0700 2018-10-03 15:13:43 -0700 Cleanup bug-190240-20181003021128.patch text/plain 5968 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNjc4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDE4LTEwLTAzICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENsZWFyIG1fcGVuZGluZ1Rhcmdl dHMgaW4gTXV0YXRpb25PYnNlcnZlcjo6dGFrZVJlY29yZHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDI0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMzY3ODEsIHdlIGRlbGF5ZWQgdGhlIGNs ZWFyaW5nIG9mIG1fcGVuZGluZ1RhcmdldHMgdW50aWwgdGhlIGVuZCBvZiBtaWNyb3Rhc2sgdG8g YXZvaWQgYSByYWNlIGJldHdlZW4KKyAgICAgICAgbXV0YXRpb24gcmVjb3JkJ3MgSlMgd3JhcHBl cnMgZ2V0dGluZyBjcmVhdGVkIGFuZCBHQyBtYXJraW5nIEpTIHdyYXBwZXJzIG9mIGVsZW1lbnRz IGluIG11dGF0aW9uIHJlY29yZHMuCisKKyAgICAgICAgVGhpcyBwYXRjaCBzaG9ydGVucyB0aGlz IGRlbGF5IHRvIHVudGlsIG11dGF0aW9uIHJlY29yZCdzIEpTIHdyYXBwZXJzIGFyZSBjcmVhdGVk LiBTcGVjaWZpY2FsbHksIHdlIG1ha2UKKyAgICAgICAgTXV0YXRpb25PYnNlcnZlcjo6dGFrZVJl Y29yZHMoKSByZXR1cm4gYSBzdHJ1Y3Qgd2hpY2ggaGFzIGJvdGggcGVuZGluZyB0YXJnZXRzIGhh c2ggc2V0IGFuZCB0aGUgdmVjdG9yIG9mCisgICAgICAgIG11dGF0aW9uIHJlY29yZHMgc28gdGhh dCB0aGUgaGFzaCBzZXQgc3Vydml2ZXMgdGhyb3VnaCB0aGUgY3JlYXRpb24gb2YgSlMgd3JhcHBl cnMgZm9yIG11dGF0aW9uIHJlY29yZHMuCisKKyAgICAgICAgVG8gZG8gdGhpcywgYSBuZXcgSURM IGV4dGVuZGVkIGF0dHJpYnV0ZSAiRXhwbGljaXRSZXN1bHQiIGlzIGludHJvZHVjZWQgdG8gc3Bl Y2lmeSB0aGUgbWVtYmVyIHZhcmlhYmxlIGluCisgICAgICAgIHdoaWNoIHRoZSByZXN1bHQgaXMg c3RvcmVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVW5mb3J0dW5hdGVseSwgdGhpcyByYWNl IGNvbmRpdGlvbiBhcHBlYXJzIHRvIGJlIGltcG9zc2libGUgdG8gY2FwdHVyZSBpbiBhIHJlZ3Jl c3Npb24gdGVzdC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpT LnBtOgorICAgICAgICAoR2VuZXJhdGVPcGVyYXRpb25Cb2R5RGVmaW5pdGlvbik6CisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9JRExBdHRyaWJ1dGVzLmpzb246CisgICAgICAgICogZG9tL011 dGF0aW9uT2JzZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TXV0YXRpb25PYnNlcnZlcjo6 dGFrZVJlY29yZHMpOgorICAgICAgICAoV2ViQ29yZTo6TXV0YXRpb25PYnNlcnZlcjo6ZGVsaXZl cik6CisgICAgICAgICogZG9tL011dGF0aW9uT2JzZXJ2ZXIuaDoKKyAgICAgICAgKiBkb20vTXV0 YXRpb25PYnNlcnZlci5pZGw6CisKIDIwMTgtMTAtMDIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQ29weWluZyBjb250ZW50IHdpdGggc2hhZG93IERPTSBkb2Vz bid0IGNvcHkgYW55IGNvbnRlbnRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JKUy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkocmV2aXNpb24gMjM2Nzg0KQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0JKHdvcmtpbmcg Y29weSkKQEAgLTUxMzYsNyArNTEzNiwxNCBAQCBzdWIgR2VuZXJhdGVPcGVyYXRpb25Cb2R5RGVm aW5pdGlvbgogCiAgICAgICAgIEdlbmVyYXRlQXJndW1lbnRzQ291bnRDaGVjaygkb3V0cHV0QXJy YXksICRvcGVyYXRpb24sICRpbnRlcmZhY2UsICRpbmRlbnQpOwogICAgICAgICBteSAkZnVuY3Rp b25TdHJpbmcgPSBHZW5lcmF0ZVBhcmFtZXRlcnNDaGVjaygkb3V0cHV0QXJyYXksICRvcGVyYXRp b24sICRpbnRlcmZhY2UsICRmdW5jdGlvbkltcGxlbWVudGF0aW9uTmFtZSwgJGluZGVudCk7Ci0g ICAgICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25GdW5jdGlvbkNhbGwoJG91dHB1dEFycmF5LCAk b3BlcmF0aW9uLCAkaW50ZXJmYWNlLCAkZnVuY3Rpb25TdHJpbmcsICRpbmRlbnQpOworCisgICAg ICAgIGlmICgkb3BlcmF0aW9uLT5leHRlbmRlZEF0dHJpYnV0ZXMtPntFeHBsaWNpdFJlc3VsdH0p IHsKKyAgICAgICAgICAgIG15ICRyZXN1bHROYW1lID0gJG9wZXJhdGlvbi0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57RXhwbGljaXRSZXN1bHR9OworICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5 LCAiICAgIGF1dG8gaW1wbFJlc3VsdCA9ICRmdW5jdGlvblN0cmluZztcbiIpOworICAgICAgICAg ICAgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbkZ1bmN0aW9uQ2FsbCgkb3V0cHV0QXJyYXksICRvcGVy YXRpb24sICRpbnRlcmZhY2UsICJXVEZNb3ZlKGltcGxSZXN1bHQuJHJlc3VsdE5hbWUpIiwgJGlu ZGVudCk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBHZW5lcmF0ZUltcGxlbWVudGF0 aW9uRnVuY3Rpb25DYWxsKCRvdXRwdXRBcnJheSwgJG9wZXJhdGlvbiwgJGludGVyZmFjZSwgJGZ1 bmN0aW9uU3RyaW5nLCAkaW5kZW50KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHB1c2goQCRv dXRwdXRBcnJheSwgIn1cblxuIik7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0lETEF0dHJpYnV0ZXMuanNvbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0lETEF0dHJpYnV0ZXMuanNvbgkocmV2aXNpb24gMjM2Nzg0KQorKysgU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExBdHRyaWJ1dGVzLmpzb24JKHdvcmtpbmcg Y29weSkKQEAgLTE5MSw2ICsxOTEsOSBAQAogICAgICAgICAgICAgICAgICJ1cmwiOiAiaHR0cHM6 Ly9oZXljYW0uZ2l0aHViLmlvL3dlYmlkbC8jRW5mb3JjZVJhbmdlIgogICAgICAgICAgICAgfQog ICAgICAgICB9LAorICAgICAgICAiRXhwbGljaXRSZXN1bHQiOiB7CisgICAgICAgICAgICAiY29u dGV4dHNBbGxvd2VkIjogWyJvcGVyYXRpb24iXQorICAgICAgICB9LAogICAgICAgICAiRXhwb3J0 TWFjcm8iOiB7CiAgICAgICAgICAgICAiY29udGV4dHNBbGxvd2VkIjogWyJpbnRlcmZhY2UiLCAi ZGljdGlvbmFyeSIsICJlbnVtIiwgImNhbGxiYWNrLWZ1bmN0aW9uIl0sCiAgICAgICAgICAgICAi dmFsdWVzIjogWyJXRUJDT1JFX0VYUE9SVCIsICJXRUJDT1JFX1RFU1RTVVBQT1JUX0VYUE9SVCJd CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXIuY3BwCShyZXZpc2lvbiAy MzY3ODQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25PYnNlcnZlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTExMCwxMyArMTEwLDkgQEAgRXhjZXB0aW9uT3I8dm9pZD4gTXV0YXRpb25P YnNlcnZlcjo6b2JzZQogICAgIHJldHVybiB7IH07CiB9CiAKLVZlY3RvcjxSZWY8TXV0YXRpb25S ZWNvcmQ+PiBNdXRhdGlvbk9ic2VydmVyOjp0YWtlUmVjb3JkcygpCithdXRvIE11dGF0aW9uT2Jz ZXJ2ZXI6OnRha2VSZWNvcmRzKCkgLT4gVGFrZW5SZWNvcmRzCiB7Ci0gICAgVmVjdG9yPFJlZjxN dXRhdGlvblJlY29yZD4+IHJlY29yZHM7Ci0gICAgcmVjb3Jkcy5zd2FwKG1fcmVjb3Jkcyk7Ci0g ICAgLy8gRG9uJ3QgY2xlYXIgbV9wZW5kaW5nVGFyZ2V0cyBoZXJlIGJlY2F1c2Ugd2UgY2FuIGNv bGxlY3QgSlMgd3JhcHBlcnMKLSAgICAvLyBiZXR3ZWVuIHRoZSB0aW1lIHRha2VSZWNvcmRzIGlz IGNhbGxlZCBhbmQgbm9kZXMgaW4gcmVjb3JkcyBhcmUgYWNjZXNzc2VkLgotICAgIHJldHVybiBy ZWNvcmRzOworICAgIHJldHVybiB7IFdURk1vdmUobV9yZWNvcmRzKSwgV1RGTW92ZShtX3BlbmRp bmdUYXJnZXRzKSB9OwogfQogCiB2b2lkIE11dGF0aW9uT2JzZXJ2ZXI6OmRpc2Nvbm5lY3QoKQpA QCAtMjM5LDggKzIzNSwxMCBAQCB2b2lkIE11dGF0aW9uT2JzZXJ2ZXI6OmRlbGl2ZXIoKQogICAg IGZvciAoYXV0byYgcmVnaXN0cmF0aW9uIDogdHJhbnNpZW50UmVnaXN0cmF0aW9ucykKICAgICAg ICAgbm9kZXNUb0tlZXBBbGl2ZS5hcHBlbmQocmVnaXN0cmF0aW9uLT50YWtlVHJhbnNpZW50UmVn aXN0cmF0aW9ucygpKTsKIAotICAgIGlmIChtX3JlY29yZHMuaXNFbXB0eSgpKQorICAgIGlmICht X3JlY29yZHMuaXNFbXB0eSgpKSB7CisgICAgICAgIEFTU0VSVChtX3BlbmRpbmdUYXJnZXRzLmlz RW1wdHkoKSk7CiAgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBWZWN0b3I8UmVmPE11dGF0 aW9uUmVjb3JkPj4gcmVjb3JkczsKICAgICByZWNvcmRzLnN3YXAobV9yZWNvcmRzKTsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2VydmVyLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXIuaAkocmV2aXNpb24gMjM2Nzg0KQorKysg U291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXIuaAkod29ya2luZyBjb3B5KQpAQCAt ODYsNyArODYsMTIgQEAgcHVibGljOgogICAgIH07CiAKICAgICBFeGNlcHRpb25Pcjx2b2lkPiBv YnNlcnZlKE5vZGUmLCBjb25zdCBJbml0Jik7Ci0gICAgVmVjdG9yPFJlZjxNdXRhdGlvblJlY29y ZD4+IHRha2VSZWNvcmRzKCk7CisgICAgCisgICAgc3RydWN0IFRha2VuUmVjb3JkcyB7CisgICAg ICAgIFZlY3RvcjxSZWY8TXV0YXRpb25SZWNvcmQ+PiByZWNvcmRzOworICAgICAgICBIYXNoU2V0 PEdDUmVhY2hhYmxlUmVmPE5vZGU+PiBwZW5kaW5nVGFyZ2V0czsKKyAgICB9OworICAgIFRha2Vu UmVjb3JkcyB0YWtlUmVjb3JkcygpOwogICAgIHZvaWQgZGlzY29ubmVjdCgpOwogCiAgICAgdm9p ZCBvYnNlcnZhdGlvblN0YXJ0ZWQoTXV0YXRpb25PYnNlcnZlclJlZ2lzdHJhdGlvbiYpOwpJbmRl eDogU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXIuaWRsCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbk9ic2VydmVyLmlkbAkocmV2aXNpb24gMjM2Nzg0 KQorKysgU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uT2JzZXJ2ZXIuaWRsCSh3b3JraW5nIGNv cHkpCkBAIC0zNyw3ICszNyw3IEBACiBdIGludGVyZmFjZSBNdXRhdGlvbk9ic2VydmVyIHsKICAg ICBbTWF5VGhyb3dFeGNlcHRpb25dIHZvaWQgb2JzZXJ2ZShOb2RlIHRhcmdldCwgb3B0aW9uYWwg TXV0YXRpb25PYnNlcnZlckluaXQgb3B0aW9ucyk7CiAgICAgdm9pZCBkaXNjb25uZWN0KCk7Ci0g ICAgc2VxdWVuY2U8TXV0YXRpb25SZWNvcmQ+IHRha2VSZWNvcmRzKCk7CisgICAgW0V4cGxpY2l0 UmVzdWx0PXJlY29yZHNdIHNlcXVlbmNlPE11dGF0aW9uUmVjb3JkPiB0YWtlUmVjb3JkcygpOwog fTsKIAogZGljdGlvbmFyeSBNdXRhdGlvbk9ic2VydmVySW5pdCB7Cg==