190231 2018-10-02 18:38:37 -0700 AudioNode.connect should use [ReturnValue] 2018-10-04 09:21:28 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 darin darin eric.carlson webkit-bug-importer wjahenderson oldest_to_newest 1465863 0 darin 2018-10-02 18:38:37 -0700 AudioNode.connect should use [ReturnValue] 1465865 1 351465 darin 2018-10-02 18:40:25 -0700 Created attachment 351465 Patch 1465886 2 wjahenderson 2018-10-02 19:42:15 -0700 *** Bug 190199 has been marked as a duplicate of this bug. *** 1466373 3 darin 2018-10-04 09:20:29 -0700 Committed r236831: <https://trac.webkit.org/changeset/236831> 1466374 4 webkit-bug-importer 2018-10-04 09:21:28 -0700 <rdar://problem/45010742> 351465 2018-10-02 18:40:25 -0700 2018-10-03 02:37:38 -0700 Patch bug-190231-20181002184024.patch text/plain 5252 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJlNzEwZTg5ZDIyYjRj ZjEwMWRkODUwM2IyOGNhY2EyZmJhZWRmZi4uZmM5YWU5NjE3MjFlNjJjYzViNTNiMGI4YzA4NTc1 OTEzM2MyNGUxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTEwLTAyICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBBdWRpb05vZGUuY29ubmVjdCBz aG91bGQgdXNlIFtSZXR1cm5WYWx1ZV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5MDIzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb0Jhc2ljSW5zcGVjdG9yTm9k ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Jhc2ljSW5zcGVjdG9yTm9kZTo6Y29ubmVj dCk6IFJldHVybiBFeGNlcHRpb25Pcjx2b2lkPi4KKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmg6IERpdHRvLgorICAgICAgICAqIE1vZHVsZXMvd2Vi YXVkaW8vQXVkaW9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvTm9kZTo6Y29ubmVj dCk6IERpdHRvLgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmg6IERpdHRv LgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaWRsOiBVc2UgW1JldHVy blZhbHVlXS4KKwogMjAxOC0xMC0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4K IAogICAgICAgICBHQyBjYW4gY29sbGVjdCBKUyB3cmFwcGVycyBvZiBub2RlcyBpbiB0aGUgbXV0 YXRpb24gcmVjb3JkcyB3YWl0aW5nIHRvIGJlIGRlbGl2ZXJlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0Jhc2ljSW5zcGVjdG9yTm9kZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmNw cAppbmRleCA1MDMzYjdkN2RkODhkMTJhNTRlYzgyMGRmZDU1MGY3OWZmN2QwZTE1Li4yN2U1NmM0 YzZiOTQ3YWViODI0NTllZDEzZjMzYjU4MWEzZDNhMGE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmNw cApAQCAtNDksNyArNDksNyBAQCB2b2lkIEF1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlOjpwdWxsSW5w dXRzKHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpCiAgICAgaW5wdXQoMCktPnB1bGwob3V0cHV0KDAp LT5idXMoKSwgZnJhbWVzVG9Qcm9jZXNzKTsKIH0KIAotRXhjZXB0aW9uT3I8QXVkaW9Ob2RlJj4g QXVkaW9CYXNpY0luc3BlY3Rvck5vZGU6OmNvbm5lY3QoQXVkaW9Ob2RlJiBkZXN0aW5hdGlvbiwg dW5zaWduZWQgb3V0cHV0SW5kZXgsIHVuc2lnbmVkIGlucHV0SW5kZXgpCitFeGNlcHRpb25Pcjx2 b2lkPiBBdWRpb0Jhc2ljSW5zcGVjdG9yTm9kZTo6Y29ubmVjdChBdWRpb05vZGUmIGRlc3RpbmF0 aW9uLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJbmRleCkKIHsKICAgICBB U1NFUlQoaXNNYWluVGhyZWFkKCkpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQmFzaWNJbnNwZWN0b3JOb2RlLmgKaW5kZXggZmFlMjM1OWQ1 MjgxY2M1MmJlNTgzMGJiNGIzNGI1YWE2Y2Q2NDdkMC4uYjg2ZjFhMzg3ZmRkZjhjMmI1ODM0NTgz NWI5YWQ1NTVkZGVmZTEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9BdWRpb0Jhc2ljSW5zcGVjdG9yTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9CYXNpY0luc3BlY3Rvck5vZGUuaApAQCAtMzcsNyArMzcsNyBAQCBw dWJsaWM6CiAKIHByaXZhdGU6CiAgICAgdm9pZCBwdWxsSW5wdXRzKHNpemVfdCBmcmFtZXNUb1By b2Nlc3MpIG92ZXJyaWRlOwotICAgIEV4Y2VwdGlvbk9yPEF1ZGlvTm9kZSY+IGNvbm5lY3QoQXVk aW9Ob2RlJiwgdW5zaWduZWQgb3V0cHV0SW5kZXgsIHVuc2lnbmVkIGlucHV0SW5kZXgpIG92ZXJy aWRlOworICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IGNvbm5lY3QoQXVkaW9Ob2RlJiwgdW5zaWduZWQg b3V0cHV0SW5kZXgsIHVuc2lnbmVkIGlucHV0SW5kZXgpIG92ZXJyaWRlOwogICAgIEV4Y2VwdGlv bk9yPHZvaWQ+IGRpc2Nvbm5lY3QodW5zaWduZWQgb3V0cHV0SW5kZXgpIG92ZXJyaWRlOwogICAg IHZvaWQgY2hlY2tOdW1iZXJPZkNoYW5uZWxzRm9ySW5wdXQoQXVkaW9Ob2RlSW5wdXQqKSBvdmVy cmlkZTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRp b05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3Bw CmluZGV4IDZmM2M2M2M1ZTY1ZjU2NzI0NmMyMzQ5ODUzMzA1NmQ4NmRiZDFkN2UuLmFkMTM1MWY0 NGFlZWYzNDdjM2VkYjBkNWRhNWJlMTcxMTNlNzk3ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5jcHAKQEAgLTEyMiw3ICsxMjIsNyBAQCBBdWRpb05v ZGVPdXRwdXQqIEF1ZGlvTm9kZTo6b3V0cHV0KHVuc2lnbmVkIGkpCiAgICAgcmV0dXJuIG51bGxw dHI7CiB9CiAKLUV4Y2VwdGlvbk9yPEF1ZGlvTm9kZSY+IEF1ZGlvTm9kZTo6Y29ubmVjdChBdWRp b05vZGUmIGRlc3RpbmF0aW9uLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJ bmRleCkKK0V4Y2VwdGlvbk9yPHZvaWQ+IEF1ZGlvTm9kZTo6Y29ubmVjdChBdWRpb05vZGUmIGRl c3RpbmF0aW9uLCB1bnNpZ25lZCBvdXRwdXRJbmRleCwgdW5zaWduZWQgaW5wdXRJbmRleCkKIHsK ICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOyAKICAgICBBdWRpb0NvbnRleHQ6OkF1dG9Mb2Nr ZXIgbG9ja2VyKGNvbnRleHQoKSk7CkBAIC0xNDQsNyArMTQ0LDcgQEAgRXhjZXB0aW9uT3I8QXVk aW9Ob2RlJj4gQXVkaW9Ob2RlOjpjb25uZWN0KEF1ZGlvTm9kZSYgZGVzdGluYXRpb24sIHVuc2ln bmVkIG91dHAKICAgICAvLyBMZXQgY29udGV4dCBrbm93IHRoYXQgYSBjb25uZWN0aW9uIGhhcyBi ZWVuIG1hZGUuCiAgICAgY29udGV4dCgpLmluY3JlbWVudENvbm5lY3Rpb25Db3VudCgpOwogCi0g ICAgcmV0dXJuIGRlc3RpbmF0aW9uOworICAgIHJldHVybiB7IH07CiB9CiAKIEV4Y2VwdGlvbk9y PHZvaWQ+IEF1ZGlvTm9kZTo6Y29ubmVjdChBdWRpb1BhcmFtJiBwYXJhbSwgdW5zaWduZWQgb3V0 cHV0SW5kZXgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1 ZGlvTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaApp bmRleCBjNGY3ODRiNDQwYTZiYjIyOWI2NGM5NDQ1OGJhOWU0NDU1NzE4YTg4Li4zMGE1ZjgxNDQ1 MmI5YTM5ZTg2NTJmN2YyMTRmNTFjMzM4OTljZTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmgKQEAgLTEyMyw3ICsxMjMsNyBAQCBwdWJsaWM6CiAgICAg QXVkaW9Ob2RlT3V0cHV0KiBvdXRwdXQodW5zaWduZWQpOwogCiAgICAgLy8gQ2FsbGVkIGZyb20g bWFpbiB0aHJlYWQgYnkgY29ycmVzcG9uZGluZyBKYXZhU2NyaXB0IG1ldGhvZHMuCi0gICAgdmly dHVhbCBFeGNlcHRpb25PcjxBdWRpb05vZGUmPiBjb25uZWN0KEF1ZGlvTm9kZSYsIHVuc2lnbmVk IG91dHB1dEluZGV4LCB1bnNpZ25lZCBpbnB1dEluZGV4KTsKKyAgICB2aXJ0dWFsIEV4Y2VwdGlv bk9yPHZvaWQ+IGNvbm5lY3QoQXVkaW9Ob2RlJiwgdW5zaWduZWQgb3V0cHV0SW5kZXgsIHVuc2ln bmVkIGlucHV0SW5kZXgpOwogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IGNvbm5lY3QoQXVkaW9QYXJh bSYsIHVuc2lnbmVkIG91dHB1dEluZGV4KTsKICAgICB2aXJ0dWFsIEV4Y2VwdGlvbk9yPHZvaWQ+ IGRpc2Nvbm5lY3QodW5zaWduZWQgb3V0cHV0SW5kZXgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5pZGwKaW5kZXggODAwZjAxZWNmYjdmZWIyMzg5YzM5 MjYyMDk2ODZhMWM4MmNjZmYwOS4uYWM4M2E4YmM5MzQ1ZjQ2YWYyNjRhMzgwYTAzYzEyM2NlNjZl NTQyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05v ZGUuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmlk bApAQCAtMzQsNyArMzQsNyBAQAogICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgY2hhbm5lbENvdW50 TW9kZTsKICAgICBhdHRyaWJ1dGUgRE9NU3RyaW5nIGNoYW5uZWxJbnRlcnByZXRhdGlvbjsKIAot ICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gQXVkaW9Ob2RlIGNvbm5lY3QoQXVkaW9Ob2RlIGRlc3Rp bmF0aW9uLCBvcHRpb25hbCB1bnNpZ25lZCBsb25nIG91dHB1dCA9IDAsIG9wdGlvbmFsIHVuc2ln bmVkIGxvbmcgaW5wdXQgPSAwKTsKKyAgICBbTWF5VGhyb3dFeGNlcHRpb25dIEF1ZGlvTm9kZSBj b25uZWN0KFtSZXR1cm5WYWx1ZV0gQXVkaW9Ob2RlIGRlc3RpbmF0aW9uLCBvcHRpb25hbCB1bnNp Z25lZCBsb25nIG91dHB1dCA9IDAsIG9wdGlvbmFsIHVuc2lnbmVkIGxvbmcgaW5wdXQgPSAwKTsK ICAgICBbTWF5VGhyb3dFeGNlcHRpb25dIHZvaWQgY29ubmVjdChBdWRpb1BhcmFtIGRlc3RpbmF0 aW9uLCBvcHRpb25hbCB1bnNpZ25lZCBsb25nIG91dHB1dCA9IDApOwogICAgIFtNYXlUaHJvd0V4 Y2VwdGlvbl0gdm9pZCBkaXNjb25uZWN0KG9wdGlvbmFsIHVuc2lnbmVkIGxvbmcgb3V0cHV0ID0g MCk7CiB9Owo=