190228 2018-10-02 17:02:03 -0700 [JSC] print() changes CRLF to CRCRLF on Windows 2018-10-03 22:13:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Windows 10 RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1465830 0 ross.kirsling 2018-10-02 17:02:03 -0700 Repro: 1. Create test.js: > print(function foo() { > }); 2. Run it (with WinCairo JSC) and view output with explicit carriage returns: > jsc.exe test.js | cat -v 3. Notice that carriage returns inside the function are doubled: > function fn() {^M^M > }^M --- Notes: - This results in various test failures under the ChakraCore/test directory: Basics/with3.js.default Closures/closure-funcexpr-eval.js.default Function/CallerArgs.js.default Function/funcExpr.js.default Function/moreFuncExpr.js.default Function/stackargs.js.default Function/toString.js.default LetConst/l.js.default strict/05.arguments.js.default - It appears that read/readFile also produce CRCRLF in function bodies; perhaps this is why there aren't even more failures (e.g. stress/jsc-read.js). 1466202 1 351553 ross.kirsling 2018-10-03 15:34:30 -0700 Created attachment 351553 Patch 1466204 2 351553 mark.lam 2018-10-03 15:45:02 -0700 Comment on attachment 351553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351553&action=review > Source/JavaScriptCore/jsc.cpp:2236 > + _setmode(1, _O_BINARY); > + _setmode(2, _O_BINARY); Would it be possible to use _fileno(stdout) and _fileno(stderr) instead? I think that those documents the intent better than 1 and 2. 1466205 3 351555 ross.kirsling 2018-10-03 15:55:02 -0700 Created attachment 351555 Patch 1466206 4 351555 mark.lam 2018-10-03 15:56:19 -0700 Comment on attachment 351555 Patch r=me if the EWS bots are green. 1466319 5 351555 commit-queue 2018-10-03 22:12:27 -0700 Comment on attachment 351555 Patch Clearing flags on attachment: 351555 Committed r236827: <https://trac.webkit.org/changeset/236827> 1466320 6 commit-queue 2018-10-03 22:12:29 -0700 All reviewed patches have been landed. Closing bug. 1466321 7 webkit-bug-importer 2018-10-03 22:13:23 -0700 <rdar://problem/44998734> 351553 2018-10-03 15:34:30 -0700 2018-10-03 15:55:01 -0700 Patch bug-190228-20181003153430.patch text/plain 1501 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2ODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YjNkZWU4OGI1NmNkM2FkYmU4NGQ1ODkxODZlOGVlZjkzN2UxNjFjLi4yODlkZTA1ZDI2NDUyMTI4 M2ExMTg3NzEwYmFmMTk4NWM1ODc1NTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0xMC0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW0pTQ10gcHJpbnQoKSBjaGFuZ2VzIENSTEYgdG8gQ1JDUkxGIG9u IFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MDIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICoganNjLmNwcDoKKyAgICAgICAgKG1haW4pOgorICAgICAgICBVbHRpbWF0ZWx5LCB0aGlzIGlz IGp1c3QgdGhlIG5vcm1hbCBiZWhhdmlvciBvZiBwcmludGYgaW4gdGV4dCBtb2RlIG9uIFdpbmRv d3MuCisgICAgICAgIFNpbmNlIHdlJ3JlIHJlYWRpbmcgaW4gZmlsZXMgYXMgYmluYXJ5LCB3ZSBu ZWVkIHRvIGJlIHByaW50aW5nIG91dCBhcyBiaW5hcnkgdG9vCisgICAgICAgIChqdXN0IGFzIHdl IGRvIGluIER1bXBSZW5kZXJUcmVlIGFuZCBJbWFnZURpZmYuKQorCiAyMDE4LTEwLTAzICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwcmVzcyB1bnJlYWNoYWJs ZSBjb2RlIHdhcm5pbmcgZm9yIExMSW50QXNzZW1ibHkuaCBjb2RlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cAppbmRleCBmNmMxZTgyNTZiYTI2MGJhNTEzNTdjMjZiYzVkMWNmYjkwYzVmOGJhLi4zMjE3YzZm ZjEyNmJiMWUxOWI0M2NhZGM4MGJhOTJjOGI5OGRkZWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcApA QCAtMjIzMiw2ICsyMjMyLDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAg IC8vIGVycm9yIG1vZGUgaGVyZSB0byB3b3JrIGFyb3VuZCBDeWd3aW4ncyBiZWhhdmlvci4gU2Vl IDxodHRwOi8vd2Via2l0Lm9yZy9iLzU1MjIyPi4KICAgICA6OlNldEVycm9yTW9kZSgwKTsKIAor ICAgIF9zZXRtb2RlKDEsIF9PX0JJTkFSWSk7CisgICAgX3NldG1vZGUoMiwgX09fQklOQVJZKTsK KwogI2lmIGRlZmluZWQoX0RFQlVHKQogICAgIF9DcnRTZXRSZXBvcnRGaWxlKF9DUlRfV0FSTiwg X0NSVERCR19GSUxFX1NUREVSUik7CiAgICAgX0NydFNldFJlcG9ydE1vZGUoX0NSVF9XQVJOLCBf Q1JUREJHX01PREVfRklMRSk7Cg== 351555 2018-10-03 15:55:02 -0700 2018-10-03 22:12:27 -0700 Patch bug-190228-20181003155502.patch text/plain 1697 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2ODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YjNkZWU4OGI1NmNkM2FkYmU4NGQ1ODkxODZlOGVlZjkzN2UxNjFjLi4yODlkZTA1ZDI2NDUyMTI4 M2ExMTg3NzEwYmFmMTk4NWM1ODc1NTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0xMC0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29u eS5jb20+CisKKyAgICAgICAgW0pTQ10gcHJpbnQoKSBjaGFuZ2VzIENSTEYgdG8gQ1JDUkxGIG9u IFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE5MDIyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICoganNjLmNwcDoKKyAgICAgICAgKG1haW4pOgorICAgICAgICBVbHRpbWF0ZWx5LCB0aGlzIGlz IGp1c3QgdGhlIG5vcm1hbCBiZWhhdmlvciBvZiBwcmludGYgaW4gdGV4dCBtb2RlIG9uIFdpbmRv d3MuCisgICAgICAgIFNpbmNlIHdlJ3JlIHJlYWRpbmcgaW4gZmlsZXMgYXMgYmluYXJ5LCB3ZSBu ZWVkIHRvIGJlIHByaW50aW5nIG91dCBhcyBiaW5hcnkgdG9vCisgICAgICAgIChqdXN0IGFzIHdl IGRvIGluIER1bXBSZW5kZXJUcmVlIGFuZCBJbWFnZURpZmYuKQorCiAyMDE4LTEwLTAzICBNYXJr IExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwcmVzcyB1bnJlYWNoYWJs ZSBjb2RlIHdhcm5pbmcgZm9yIExMSW50QXNzZW1ibHkuaCBjb2RlLgpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNw cAppbmRleCBmNmMxZTgyNTZiYTI2MGJhNTEzNTdjMjZiYzVkMWNmYjkwYzVmOGJhLi44NTAzYmI1 N2Y0ZWM1YmM5YmI4ZGRiZGM5MTJmNGI1ZTkxYjc4NzJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcApA QCAtOTAsNiArOTAsOCBAQAogCiAjaWYgT1MoV0lORE9XUykKICNpbmNsdWRlIDxkaXJlY3QuaD4K KyNpbmNsdWRlIDxmY250bC5oPgorI2luY2x1ZGUgPGlvLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQv d2luL1dDaGFyU3RyaW5nRXh0cmFzLmg+CiAjZWxzZQogI2luY2x1ZGUgPHVuaXN0ZC5oPgpAQCAt MjIzMiw2ICsyMjM0LDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIqKiBhcmd2KQogICAgIC8v IGVycm9yIG1vZGUgaGVyZSB0byB3b3JrIGFyb3VuZCBDeWd3aW4ncyBiZWhhdmlvci4gU2VlIDxo dHRwOi8vd2Via2l0Lm9yZy9iLzU1MjIyPi4KICAgICA6OlNldEVycm9yTW9kZSgwKTsKIAorICAg IF9zZXRtb2RlKF9maWxlbm8oc3Rkb3V0KSwgX09fQklOQVJZKTsKKyAgICBfc2V0bW9kZShfZmls ZW5vKHN0ZGVyciksIF9PX0JJTkFSWSk7CisKICNpZiBkZWZpbmVkKF9ERUJVRykKICAgICBfQ3J0 U2V0UmVwb3J0RmlsZShfQ1JUX1dBUk4sIF9DUlREQkdfRklMRV9TVERFUlIpOwogICAgIF9DcnRT ZXRSZXBvcnRNb2RlKF9DUlRfV0FSTiwgX0NSVERCR19NT0RFX0ZJTEUpOwo=