<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>190227</bug_id>
          
          <creation_ts>2018-10-02 16:44:57 -0700</creation_ts>
          <short_desc>input.checked is incorrect while we&apos;re parsing its children</short_desc>
          <delta_ts>2018-10-16 16:30:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=50442</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>190651</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>cdumez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>darin</cc>
    
    <cc>ggaren</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1465822</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-02 16:44:57 -0700</bug_when>
    <thetext>input.checked is incorrect while we&apos;re parsing its children.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465826</commentid>
    <comment_count>1</comment_count>
      <attachid>351457</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-02 16:52:50 -0700</bug_when>
    <thetext>Created attachment 351457
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465829</commentid>
    <comment_count>2</comment_count>
      <attachid>351458</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-02 16:58:58 -0700</bug_when>
    <thetext>Created attachment 351458
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1465861</commentid>
    <comment_count>3</comment_count>
      <attachid>351458</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2018-10-02 18:25:48 -0700</bug_when>
    <thetext>Comment on attachment 351458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351458&amp;action=review

&gt; Source/WebCore/ChangeLog:13
&gt; +        In this patch, we update the checked state as soon as the &apos;checked&apos; attribute is set, when we know
&gt; +        that no form state to restore.

What about in the case where there is form state to restore? Do we have a test covering that? Is our behavior already what we would like it to be in that case?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466058</commentid>
    <comment_count>4</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-03 07:40:12 -0700</bug_when>
    <thetext>(In reply to Darin Adler from comment #3)
&gt; Comment on attachment 351458 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=351458&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:13
&gt; &gt; +        In this patch, we update the checked state as soon as the &apos;checked&apos; attribute is set, when we know
&gt; &gt; +        that no form state to restore.
&gt; 
&gt; What about in the case where there is form state to restore? Do we have a
&gt; test covering that? Is our behavior already what we would like it to be in
&gt; that case?

Yes, as I stated in my change log, we have already a test case covering that and it is still passing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466074</commentid>
    <comment_count>5</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-03 08:39:41 -0700</bug_when>
    <thetext>(In reply to Chris Dumez from comment #4)
&gt; (In reply to Darin Adler from comment #3)
&gt; &gt; Comment on attachment 351458 [details]
&gt; &gt; Patch
&gt; &gt; 
&gt; &gt; View in context:
&gt; &gt; https://bugs.webkit.org/attachment.cgi?id=351458&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebCore/ChangeLog:13
&gt; &gt; &gt; +        In this patch, we update the checked state as soon as the &apos;checked&apos; attribute is set, when we know
&gt; &gt; &gt; +        that no form state to restore.
&gt; &gt; 
&gt; &gt; What about in the case where there is form state to restore? Do we have a
&gt; &gt; test covering that? Is our behavior already what we would like it to be in
&gt; &gt; that case?
&gt; 
&gt; Yes, as I stated in my change log, we have already a test case covering that
&gt; and it is still passing.

And to answer your second question: No, I do not think our behavior is what we would like it to be in the less common state restoration case because it is non-standard behavior. That said, making our behavior standard in the state restoration case while not breaking state restoration is going to be more work and I did not have time to look into this part further. Also note that AFAICT, Blink also does not seem to reflect the correct checked state in the state restoration case, which reduces the risk of Web breakage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466081</commentid>
    <comment_count>6</comment_count>
      <attachid>351458</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-03 09:02:42 -0700</bug_when>
    <thetext>Comment on attachment 351458
Patch

Clearing flags on attachment: 351458

Committed r236795: &lt;https://trac.webkit.org/changeset/236795&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466082</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-10-03 09:02:44 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1466084</commentid>
    <comment_count>8</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-10-03 09:03:36 -0700</bug_when>
    <thetext>&lt;rdar://problem/44975225&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1469938</commentid>
    <comment_count>9</comment_count>
      <attachid>351458</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2018-10-16 16:30:15 -0700</bug_when>
    <thetext>Comment on attachment 351458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351458&amp;action=review

&gt; Source/WebCore/html/HTMLInputElement.cpp:-749
&gt; -            m_reflectsCheckedAttribute = true;

I mistakenly dropped this because it looked like a no-op given the if check above. However, the call to setChecked() sets the attribute to false so we do need to reset the flag to true here.
Fixing via https://bugs.webkit.org/show_bug.cgi?id=190651.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351457</attachid>
            <date>2018-10-02 16:52:50 -0700</date>
            <delta_ts>2018-10-02 16:58:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190227-20181002165250.patch</filename>
            <type>text/plain</type>
            <size>5134</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2QwMDE3YjMyOGI0NGI5
OTliZDE3MGRhYjFhMDBhZWZhN2M2NTZhZS4uNWQwNGM0NzdhODdjZmY5ZmNiMjM0MzI1ODg0YmM5
ZGVjNzQ3OWUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTEwLTAyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaW5wdXQuY2hlY2tlZCBpcyBp
bmNvcnJlY3Qgd2hpbGUgd2UncmUgcGFyc2luZyBpdHMgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDIyNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGlucHV0LmNoZWNrZWQgd2FzIGluY29y
cmVjdCB3aGlsZSB3ZSdyZSBwYXJzaW5nIGl0cyBjaGlsZHJlbiBiZWNhdXNlIHdlIHdlcmUgZGVs
YXlpbmcgdXBkYXRpbmcgdGhlCisgICAgICAgIGNoZWNrZWQgc3RhdGUgdW50aWwgSFRNTElucHV0
RWxlbWVudDo6ZmluaXNoUGFyc2luZ0NoaWxkcmVuKCkgaXMgY2FsbGVkLCB0byBhdm9pZCBhIGJh
ZCBpbnRlcmFjdGlvbgorICAgICAgICB3aXRoIGZvcm0gc3RhdGUgcmVzdG9yYXRpb24uCisKKyAg
ICAgICAgSW4gdGhpcyBwYXRjaCwgd2UgdXBkYXRlIHRoZSBjaGVja2VkIHN0YXRlIGFzIHNvb24g
YXMgdGhlICdjaGVja2VkJyBhdHRyaWJ1dGUgaXMgc2V0LCB3aGVuIHdlIGtub3cKKyAgICAgICAg
dGhhdCBubyBmb3JtIHN0YXRlIHRvIHJlc3RvcmUuCisKKyAgICAgICAgZmFzdC9mb3Jtcy9yYWRp
by9zdGF0ZS1yZXN0b3JlLXJhZGlvLWdyb3VwLmh0bWwgY292ZXJzIHRoZSBmb3JtIHJlc3RvcmF0
aW9uIGNhc2UgYW5kIGlzIHN0aWxsCisgICAgICAgIHBhc3NpbmcuCisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogaHRtbC9Gb3Jt
Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb3JtQ29udHJvbGxlcjo6aGFzRm9y
bVN0YXRlVG9SZXN0b3JlIGNvbnN0KToKKyAgICAgICAgKiBodG1sL0Zvcm1Db250cm9sbGVyLmg6
CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKwogMjAxOC0xMC0wMiAgQ2hyaXMg
RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEltYWdlLl9fcHJvdG9fXyBzaG91
bGQgYmUgRnVuY3Rpb24ucHJvdG90eXBlLCBub3QgSFRNTEVsZW1lbnQucHJvdG90eXBlCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Zvcm1Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3BwCmluZGV4IDBmNWI3NzViZDAyYjNkMWNlMDY4
YWUwMzUyNjBhZmYxNTRmNWMyMmMuLjhhODA2OThmMjZjZWMzNDNjYmU1NGNmN2Y0MjAwYjY3MTBk
ZGIwYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3Bw
CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3BwCkBAIC00NzAsNiAr
NDcwLDExIEBAIHZvaWQgRm9ybUNvbnRyb2xsZXI6OnJlc3RvcmVDb250cm9sU3RhdGVJbihIVE1M
Rm9ybUVsZW1lbnQmIGZvcm0pCiAgICAgfQogfQogCitib29sIEZvcm1Db250cm9sbGVyOjpoYXNG
b3JtU3RhdGVUb1Jlc3RvcmUoKSBjb25zdAoreworICAgIHJldHVybiAhbV9zYXZlZEZvcm1TdGF0
ZU1hcC5pc0VtcHR5KCk7Cit9CisKIFZlY3RvcjxTdHJpbmc+IEZvcm1Db250cm9sbGVyOjpyZWZl
cmVuY2VkRmlsZVBhdGhzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzdGF0ZVZlY3RvcikKIHsKICAg
ICBWZWN0b3I8U3RyaW5nPiBwYXRoczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Rm9ybUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuaApp
bmRleCBiZDQ5Nzk5MTkwYWU2OWYzMzkxYWYxMWU5NWNiNWVlMGQ3ZTU4YjJmLi40NWFhNDNkZDE5
NDA3NjUzNTdhODI5YjdkNmY5ZWY1YWEzMWU5Njg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0Zvcm1Db250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29u
dHJvbGxlci5oCkBAIC01NSw2ICs1NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHdpbGxEZWxldGVG
b3JtKEhUTUxGb3JtRWxlbWVudCYpOwogICAgIHZvaWQgcmVzdG9yZUNvbnRyb2xTdGF0ZUZvcihI
VE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlJik7CiAgICAgdm9pZCByZXN0b3JlQ29udHJv
bFN0YXRlSW4oSFRNTEZvcm1FbGVtZW50Jik7CisgICAgYm9vbCBoYXNGb3JtU3RhdGVUb1Jlc3Rv
cmUoKSBjb25zdDsKIAogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBWZWN0b3I8U3RyaW5nPiBy
ZWZlcmVuY2VkRmlsZVBhdGhzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzdGF0ZVZlY3Rvcik7CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGJkMTAyYTU3Yjhm
YzgyOTBiYTg4YzUwMGZkNzc3NWU1Mzc3MTI3OWIuLjAyNjlhODIyMjc2ZDA4N2M5ZWMwYzhiOGEy
NGExN2ViZWFmNjEyZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0
RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw
cApAQCAtNzQ0LDcgKzc0NCw3IEBAIHZvaWQgSFRNTElucHV0RWxlbWVudDo6cGFyc2VBdHRyaWJ1
dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRvbWljU3RyCiAgICAgICAgIC8v
IHJlc3RvcmUuIFdlIHNob3VsZG4ndCBjYWxsIHNldENoZWNrZWQoKSBldmVuIGlmIHRoaXMgaGFz
IHRoZSBjaGVja2VkCiAgICAgICAgIC8vIGF0dHJpYnV0ZS4gU28sIGRlbGF5IHRoZSBzZXRDaGVj
a2VkKCkgY2FsbCB1bnRpbAogICAgICAgICAvLyBmaW5pc2hQYXJzaW5nQ2hpbGRyZW4oKSBpcyBj
YWxsZWQgaWYgcGFyc2luZyBpcyBpbiBwcm9ncmVzcy4KLSAgICAgICAgaWYgKCFtX3BhcnNpbmdJ
blByb2dyZXNzICYmIG1fcmVmbGVjdHNDaGVja2VkQXR0cmlidXRlKSB7CisgICAgICAgIGlmICgo
IW1fcGFyc2luZ0luUHJvZ3Jlc3MgfHwgIWRvY3VtZW50KCkuZm9ybUNvbnRyb2xsZXIoKS5oYXNG
b3JtU3RhdGVUb1Jlc3RvcmUoKSkgJiYgbV9yZWZsZWN0c0NoZWNrZWRBdHRyaWJ1dGUpIHsKICAg
ICAgICAgICAgIHNldENoZWNrZWQoIXZhbHVlLmlzTnVsbCgpKTsKICAgICAgICAgICAgIG1fcmVm
bGVjdHNDaGVja2VkQXR0cmlidXRlID0gdHJ1ZTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz
Yy9DaGFuZ2VMb2cKaW5kZXggNTAxN2IzYjQ2ZmFhY2U4N2IwODA5NmNmZThkYjRmMWY1Y2U2MjJl
Yi4uMDExZjRhYzkwMjhiNjhmZmI5NTVmMTYzNjYwZWFiNTFlNDcxOTZmMSAxMDA2NDQKLS0tIGEv
TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBv
cnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMTAtMDIgIENocmlzIER1
bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBpbnB1dC5jaGVja2VkIGlzIGluY29y
cmVjdCB3aGlsZSB3ZSdyZSBwYXJzaW5nIGl0cyBjaGlsZHJlbgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkwMjI3CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBXUFQgdGVzdCBub3cgdGhh
dCBpdCBpcyBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2Vt
YW50aWNzL2Zvcm1zL3RoZS1pbnB1dC1lbGVtZW50L2NoZWNrZWQtZXhwZWN0ZWQudHh0OgorCiAy
MDE4LTEwLTAyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVm
cmVzaCBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2RvY3Vt
ZW50LW1ldGFkYXRhL3RoZS1tZXRhLWVsZW1lbnQvcHJhZ21hLWRpcmVjdGl2ZXMvYXR0ci1tZXRh
LWh0dHAtZXF1aXYtcmVmcmVzaApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj
L3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9mb3Jtcy90aGUtaW5wdXQtZWxlbWVu
dC9jaGVja2VkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh
dGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvdGhlLWlucHV0LWVsZW1lbnQvY2hlY2tl
ZC1leHBlY3RlZC50eHQKaW5kZXggYzBhNWY4YmNkYTIwYjg0M2I2ZTA3OWU5MWFjZGM0YTM0ZDUz
ODQyZS4uNWI2YTQxZGRkM2M3MjgwYzljZTIzMGViNDEwMDJjZGE1YWViYzZmYSAxMDA2NDQKLS0t
IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFu
dGljcy9mb3Jtcy90aGUtaW5wdXQtZWxlbWVudC9jaGVja2VkLWV4cGVjdGVkLnR4dAorKysgYi9M
YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNz
L2Zvcm1zL3RoZS1pbnB1dC1lbGVtZW50L2NoZWNrZWQtZXhwZWN0ZWQudHh0CkBAIC0xLDMgKzEs
MyBAQAogCi1GQUlMIGlucHV0QGNoZWNrZWQgaXMgaW1tZWRpYXRlbHkgcmVmbGVjdGVkIHRvICdj
aGVja2VkJyBJREwgYXR0cmlidXRlIGFzc2VydF90cnVlOiBFeGFtaW5pbmcgImNoZWNrZWQiIElE
TCBhdHRyaWJ1dGUgdmFsdWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCitQQVNTIGlucHV0QGNo
ZWNrZWQgaXMgaW1tZWRpYXRlbHkgcmVmbGVjdGVkIHRvICdjaGVja2VkJyBJREwgYXR0cmlidXRl
IAogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>351458</attachid>
            <date>2018-10-02 16:58:58 -0700</date>
            <delta_ts>2018-10-03 09:02:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-190227-20181002165857.patch</filename>
            <type>text/plain</type>
            <size>5252</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjM2NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2QwMDE3YjMyOGI0NGI5
OTliZDE3MGRhYjFhMDBhZWZhN2M2NTZhZS4uNWQwNGM0NzdhODdjZmY5ZmNiMjM0MzI1ODg0YmM5
ZGVjNzQ3OWUyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE4LTEwLTAyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaW5wdXQuY2hlY2tlZCBpcyBp
bmNvcnJlY3Qgd2hpbGUgd2UncmUgcGFyc2luZyBpdHMgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDIyNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGlucHV0LmNoZWNrZWQgd2FzIGluY29y
cmVjdCB3aGlsZSB3ZSdyZSBwYXJzaW5nIGl0cyBjaGlsZHJlbiBiZWNhdXNlIHdlIHdlcmUgZGVs
YXlpbmcgdXBkYXRpbmcgdGhlCisgICAgICAgIGNoZWNrZWQgc3RhdGUgdW50aWwgSFRNTElucHV0
RWxlbWVudDo6ZmluaXNoUGFyc2luZ0NoaWxkcmVuKCkgaXMgY2FsbGVkLCB0byBhdm9pZCBhIGJh
ZCBpbnRlcmFjdGlvbgorICAgICAgICB3aXRoIGZvcm0gc3RhdGUgcmVzdG9yYXRpb24uCisKKyAg
ICAgICAgSW4gdGhpcyBwYXRjaCwgd2UgdXBkYXRlIHRoZSBjaGVja2VkIHN0YXRlIGFzIHNvb24g
YXMgdGhlICdjaGVja2VkJyBhdHRyaWJ1dGUgaXMgc2V0LCB3aGVuIHdlIGtub3cKKyAgICAgICAg
dGhhdCBubyBmb3JtIHN0YXRlIHRvIHJlc3RvcmUuCisKKyAgICAgICAgZmFzdC9mb3Jtcy9yYWRp
by9zdGF0ZS1yZXN0b3JlLXJhZGlvLWdyb3VwLmh0bWwgY292ZXJzIHRoZSBmb3JtIHJlc3RvcmF0
aW9uIGNhc2UgYW5kIGlzIHN0aWxsCisgICAgICAgIHBhc3NpbmcuCisKKyAgICAgICAgTm8gbmV3
IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogaHRtbC9Gb3Jt
Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGb3JtQ29udHJvbGxlcjo6aGFzRm9y
bVN0YXRlVG9SZXN0b3JlIGNvbnN0KToKKyAgICAgICAgKiBodG1sL0Zvcm1Db250cm9sbGVyLmg6
CisgICAgICAgICogaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKwogMjAxOC0xMC0wMiAgQ2hyaXMg
RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEltYWdlLl9fcHJvdG9fXyBzaG91
bGQgYmUgRnVuY3Rpb24ucHJvdG90eXBlLCBub3QgSFRNTEVsZW1lbnQucHJvdG90eXBlCmRpZmYg
LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0Zvcm1Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3BwCmluZGV4IDBmNWI3NzViZDAyYjNkMWNlMDY4
YWUwMzUyNjBhZmYxNTRmNWMyMmMuLjhhODA2OThmMjZjZWMzNDNjYmU1NGNmN2Y0MjAwYjY3MTBk
ZGIwYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3Bw
CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuY3BwCkBAIC00NzAsNiAr
NDcwLDExIEBAIHZvaWQgRm9ybUNvbnRyb2xsZXI6OnJlc3RvcmVDb250cm9sU3RhdGVJbihIVE1M
Rm9ybUVsZW1lbnQmIGZvcm0pCiAgICAgfQogfQogCitib29sIEZvcm1Db250cm9sbGVyOjpoYXNG
b3JtU3RhdGVUb1Jlc3RvcmUoKSBjb25zdAoreworICAgIHJldHVybiAhbV9zYXZlZEZvcm1TdGF0
ZU1hcC5pc0VtcHR5KCk7Cit9CisKIFZlY3RvcjxTdHJpbmc+IEZvcm1Db250cm9sbGVyOjpyZWZl
cmVuY2VkRmlsZVBhdGhzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzdGF0ZVZlY3RvcikKIHsKICAg
ICBWZWN0b3I8U3RyaW5nPiBwYXRoczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Rm9ybUNvbnRyb2xsZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRm9ybUNvbnRyb2xsZXIuaApp
bmRleCBiZDQ5Nzk5MTkwYWU2OWYzMzkxYWYxMWU5NWNiNWVlMGQ3ZTU4YjJmLi40NWFhNDNkZDE5
NDA3NjUzNTdhODI5YjdkNmY5ZWY1YWEzMWU5Njg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9odG1sL0Zvcm1Db250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9Gb3JtQ29u
dHJvbGxlci5oCkBAIC01NSw2ICs1NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHdpbGxEZWxldGVG
b3JtKEhUTUxGb3JtRWxlbWVudCYpOwogICAgIHZvaWQgcmVzdG9yZUNvbnRyb2xTdGF0ZUZvcihI
VE1MRm9ybUNvbnRyb2xFbGVtZW50V2l0aFN0YXRlJik7CiAgICAgdm9pZCByZXN0b3JlQ29udHJv
bFN0YXRlSW4oSFRNTEZvcm1FbGVtZW50Jik7CisgICAgYm9vbCBoYXNGb3JtU3RhdGVUb1Jlc3Rv
cmUoKSBjb25zdDsKIAogICAgIFdFQkNPUkVfRVhQT1JUIHN0YXRpYyBWZWN0b3I8U3RyaW5nPiBy
ZWZlcmVuY2VkRmlsZVBhdGhzKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzdGF0ZVZlY3Rvcik7CiAK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9T
b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwCmluZGV4IGJkMTAyYTU3Yjhm
YzgyOTBiYTg4YzUwMGZkNzc3NWU1Mzc3MTI3OWIuLmQxNTNjM2I0NTNiMTdlZWVkOWUyOTlhNTYx
Y2JlNmY1ZmFjMjA2MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0
RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNw
cApAQCAtNzQ0LDEwICs3NDQsOCBAQCB2b2lkIEhUTUxJbnB1dEVsZW1lbnQ6OnBhcnNlQXR0cmli
dXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21pY1N0cgogICAgICAgICAv
LyByZXN0b3JlLiBXZSBzaG91bGRuJ3QgY2FsbCBzZXRDaGVja2VkKCkgZXZlbiBpZiB0aGlzIGhh
cyB0aGUgY2hlY2tlZAogICAgICAgICAvLyBhdHRyaWJ1dGUuIFNvLCBkZWxheSB0aGUgc2V0Q2hl
Y2tlZCgpIGNhbGwgdW50aWwKICAgICAgICAgLy8gZmluaXNoUGFyc2luZ0NoaWxkcmVuKCkgaXMg
Y2FsbGVkIGlmIHBhcnNpbmcgaXMgaW4gcHJvZ3Jlc3MuCi0gICAgICAgIGlmICghbV9wYXJzaW5n
SW5Qcm9ncmVzcyAmJiBtX3JlZmxlY3RzQ2hlY2tlZEF0dHJpYnV0ZSkgeworICAgICAgICBpZiAo
KCFtX3BhcnNpbmdJblByb2dyZXNzIHx8ICFkb2N1bWVudCgpLmZvcm1Db250cm9sbGVyKCkuaGFz
Rm9ybVN0YXRlVG9SZXN0b3JlKCkpICYmIG1fcmVmbGVjdHNDaGVja2VkQXR0cmlidXRlKQogICAg
ICAgICAgICAgc2V0Q2hlY2tlZCghdmFsdWUuaXNOdWxsKCkpOwotICAgICAgICAgICAgbV9yZWZs
ZWN0c0NoZWNrZWRBdHRyaWJ1dGUgPSB0cnVlOwotICAgICAgICB9CiAgICAgfSBlbHNlIGlmIChu
YW1lID09IG1heGxlbmd0aEF0dHIpCiAgICAgICAgIG1heExlbmd0aEF0dHJpYnV0ZUNoYW5nZWQo
dmFsdWUpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0gbWlubGVuZ3RoQXR0cikKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRl
ZC93M2MvQ2hhbmdlTG9nCmluZGV4IDUwMTdiM2I0NmZhYWNlODdiMDgwOTZjZmU4ZGI0ZjFmNWNl
NjIyZWIuLjAxMWY0YWM5MDI4YjY4ZmZiOTU1ZjE2MzY2MGVhYjUxZTQ3MTk2ZjEgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv
aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTEwLTAyICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgaW5wdXQuY2hlY2tlZCBpcyBp
bmNvcnJlY3Qgd2hpbGUgd2UncmUgcGFyc2luZyBpdHMgY2hpbGRyZW4KKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5MDIyNworCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlYmFzZWxpbmUgV1BUIHRlc3Qgbm93
IHRoYXQgaXQgaXMgcGFzc2luZy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9odG1s
L3NlbWFudGljcy9mb3Jtcy90aGUtaW5wdXQtZWxlbWVudC9jaGVja2VkLWV4cGVjdGVkLnR4dDoK
KwogMjAxOC0xMC0wMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg
IFJlZnJlc2ggaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFudGljcy9k
b2N1bWVudC1tZXRhZGF0YS90aGUtbWV0YS1lbGVtZW50L3ByYWdtYS1kaXJlY3RpdmVzL2F0dHIt
bWV0YS1odHRwLWVxdWl2LXJlZnJlc2gKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVk
L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZm9ybXMvdGhlLWlucHV0LWVs
ZW1lbnQvY2hlY2tlZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi
LXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2Zvcm1zL3RoZS1pbnB1dC1lbGVtZW50L2No
ZWNrZWQtZXhwZWN0ZWQudHh0CmluZGV4IGMwYTVmOGJjZGEyMGI4NDNiNmUwNzllOTFhY2RjNGEz
NGQ1Mzg0MmUuLjViNmE0MWRkZDNjNzI4MGM5Y2UyMzBlYjQxMDAyY2RhNWFlYmM2ZmEgMTAwNjQ0
Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9z
ZW1hbnRpY3MvZm9ybXMvdGhlLWlucHV0LWVsZW1lbnQvY2hlY2tlZC1leHBlY3RlZC50eHQKKysr
IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFu
dGljcy9mb3Jtcy90aGUtaW5wdXQtZWxlbWVudC9jaGVja2VkLWV4cGVjdGVkLnR4dApAQCAtMSwz
ICsxLDMgQEAKIAotRkFJTCBpbnB1dEBjaGVja2VkIGlzIGltbWVkaWF0ZWx5IHJlZmxlY3RlZCB0
byAnY2hlY2tlZCcgSURMIGF0dHJpYnV0ZSBhc3NlcnRfdHJ1ZTogRXhhbWluaW5nICJjaGVja2Vk
IiBJREwgYXR0cmlidXRlIHZhbHVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQorUEFTUyBpbnB1
dEBjaGVja2VkIGlzIGltbWVkaWF0ZWx5IHJlZmxlY3RlZCB0byAnY2hlY2tlZCcgSURMIGF0dHJp
YnV0ZSAKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>